158579 2016-06-09 13:52:04 -0700 Web Inspector: Support Command-P for quick open 2016-06-09 19:46:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1200961 0 timothy 2016-06-09 13:52:04 -0700 To match Chrome Dev Tools, we should support Command-P. This is a stupid shortcut, since Command-P is normally Print. But I have seen some users on Twitter not know we supported Quick Open because the shortcut was different. 1200963 1 nvasilyev 2016-06-09 13:54:42 -0700 Command-P also matches Sublime Text and Atom, which is probably why Chrome DevTools chose to use it. 1200964 2 webkit-bug-importer 2016-06-09 13:57:02 -0700 <rdar://problem/26726751> 1200965 3 webkit-bug-importer 2016-06-09 13:57:51 -0700 <rdar://problem/26726702> 1201009 4 280957 nvasilyev 2016-06-09 15:29:04 -0700 Created attachment 280957 Patch 1201010 5 nvasilyev 2016-06-09 15:32:45 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=280957&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:261 > this.openResourceKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Command | WebInspector.KeyboardShortcut.Modifier.Shift, "O", this._showOpenResourceDialog.bind(this)); This property is never used, not even in tests. Why do we use it? Same goes for many other WebInspector._*Shortcut properties. 1201026 6 280957 commit-queue 2016-06-09 15:54:22 -0700 Comment on attachment 280957 Patch Clearing flags on attachment: 280957 Committed r201891: <http://trac.webkit.org/changeset/201891> 1201027 7 commit-queue 2016-06-09 15:54:25 -0700 All reviewed patches have been landed. Closing bug. 1201095 8 280957 darin 2016-06-09 19:33:49 -0700 Comment on attachment 280957 Patch Isn’t command-P usually Print? 1201103 9 bburg 2016-06-09 19:46:53 -0700 (In reply to comment #8) > Comment on attachment 280957 [details] > Patch > > Isn’t command-P usually Print? That is often the case, but not always. Previously it was not bound to anything for the Web Inspector window. Xcode and Instruments do not bind it to anything. I don't think there is anything to print in the inspector window itself. I don't like to use such a prime shortcut that conflicts with Print, but our hands are a bit tied since we don't have our own menu bar / key equivalents that can be targeted by Keyboard pref pane's App Shortcuts. So we have to do what the user is going to expect, which due to Sublime Text's precedent, is command palette or quick open. 280957 2016-06-09 15:29:04 -0700 2016-06-09 15:54:22 -0700 Patch patch.txt text/plain 1999 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc1YjhmZWYuLmJhYjY3YjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA2LTA5ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN1cHBv cnQgQ29tbWFuZC1QIGZvciBxdWljayBvcGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg1NzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NzI2 NzUxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVu dExvYWRlZCk6CisKIDIwMTYtMDYtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBXZWIgSW5zcGVjdG9yOiBTaG91bGQgYmUgYWJs ZSB0byBldmFsdWF0ZSAie2E6MSwgYjoyfSIgaW4gdGhlIGNvbnNvbGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAwZDM4ZmQ2Li41 MmZhNTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzCkBAIC0yNTksNiArMjU5LDcgQEAgV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2FkZWQg PSBmdW5jdGlvbigpCiAgICAgdGhpcy5fc2F2ZUFzS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5N b2RpZmllci5TaGlmdCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNv bW1hbmRPckNvbnRyb2wsICJTIiwgdGhpcy5fc2F2ZUFzLmJpbmQodGhpcykpOwogCiAgICAgdGhp cy5vcGVuUmVzb3VyY2VLZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmQg fCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgIk8iLCB0aGlz Ll9zaG93T3BlblJlc291cmNlRGlhbG9nLmJpbmQodGhpcykpOworICAgIG5ldyBXZWJJbnNwZWN0 b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmll ci5Db21tYW5kLCAiUCIsIHRoaXMuX3Nob3dPcGVuUmVzb3VyY2VEaWFsb2cuYmluZCh0aGlzKSk7 CiAKICAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5N b2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu TW9kaWZpZXIuU2hpZnQsICIwIiwgdGhpcy50b2dnbGVOYXZpZ2F0aW9uU2lkZWJhci5iaW5kKHRo aXMpKTsKICAgICB0aGlzLmRldGFpbHNTaWRlYmFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5N b2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu TW9kaWZpZXIuT3B0aW9uLCAiMCIsIHRoaXMudG9nZ2xlRGV0YWlsc1NpZGViYXIuYmluZCh0aGlz KSk7Cg==