158578 2016-06-09 13:41:20 -0700 Pass through play state and toggle state to the WebPlaybackControlsManager 2016-06-09 14:00:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble bdakin webkit-bug-importer oldest_to_newest 1200952 0 jer.noble 2016-06-09 13:41:20 -0700 Pass through play state and toggle state to the WebPlaybackControlsManager 1200953 1 jer.noble 2016-06-09 13:41:42 -0700 <rdar://problem/25045616> 1200954 2 280940 jer.noble 2016-06-09 13:43:13 -0700 Created attachment 280940 Patch 1200958 3 280940 bdakin 2016-06-09 13:46:08 -0700 Comment on attachment 280940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280940&action=review > Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm:91 > + [controlsManager setPlaying:isPlaying]; Dot syntax?! 1200967 4 jer.noble 2016-06-09 14:00:37 -0700 Committed r201882: <http://trac.webkit.org/changeset/201882> 280940 2016-06-09 13:43:13 -0700 2016-06-09 13:46:08 -0700 Patch bug-158578-20160609134442.patch text/plain 4341 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM2YWRmNThhNjFlNmQ1 M2UxMDEzMjVjZTU5MmQyZmQ4ZjY3ZTJjOC4uMTViYzllNjUyNGY0MWUyZGQzNjFhNjY1OWUwMjg4 ZTUyZDEwNmE0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA2LTA5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFBhc3MgdGhyb3VnaCBwbGF5 IHN0YXRlIGFuZCB0b2dnbGUgc3RhdGUgdG8gdGhlIFdlYlBsYXliYWNrQ29udHJvbHNNYW5hZ2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg1NzgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1MDQ1NjE2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhc3MgdGhyb3VnaCB0aGUgaXNQbGF5aW5nIHBv cnRpb24gb2Ygc2V0UmF0ZSgpIGFuZCBhbGxvdyB0b2dnbGluZyB3aGVuIGEgbW9kZWwgaXMgcHJl c2VudC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xzTWFuYWdl ci5oOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xzTWFuYWdlci5t bToKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6V2ViUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlTWFjOjpz ZXRSYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYlBsYXliYWNrU2Vzc2lvbkludGVyZmFjZU1h Yzo6c2V0UGxheUJhY2tDb250cm9sc01hbmFnZXIpOgorCiAyMDE2LTA2LTA3ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENTUDogQ29udGVudCBTZWN1cml0 eSBQb2xpY3kgZGlyZWN0aXZlLCB1cGdyYWRlLWluc2VjdXJlLXJlcXVlc3RzIChVSVIpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tDb250cm9sc01h bmFnZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xz TWFuYWdlci5oCmluZGV4IDU4ZDY2ZTZlMDYwYWE4NWFlNjhlNmI5YmUxNzczMjI0NjhiZTczMjIu LjQ1NjdjZjlmMzViMTdjMjRhMWYzOThkMjY3OGIwNjhhOTQxOGVjMTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xzTWFuYWdlci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xzTWFuYWdl ci5oCkBAIC00OSw2ICs0OSw4IEBAIFdFQkNPUkVfRVhQT1JUCiAgICAgQk9PTCBfaGFzRW5hYmxl ZEF1ZGlvOwogICAgIEJPT0wgX2hhc0VuYWJsZWRWaWRlbzsKICAgICBmbG9hdCBfcmF0ZTsKKyAg ICBCT09MIF9wbGF5aW5nOworICAgIEJPT0wgX2NhblRvZ2dsZVBsYXliYWNrOwogCiBAcHJpdmF0 ZQogICAgIFdlYkNvcmU6OldlYlBsYXliYWNrU2Vzc2lvbkludGVyZmFjZU1hYyogX3dlYlBsYXli YWNrU2Vzc2lvbkludGVyZmFjZU1hYzsKQEAgLTYxLDYgKzYzLDggQEAgV0VCQ09SRV9FWFBPUlQK IEBwcm9wZXJ0eSAocmVhZHdyaXRlKSBCT09MIGhhc0VuYWJsZWRBdWRpbzsKIEBwcm9wZXJ0eSAo cmVhZHdyaXRlKSBCT09MIGhhc0VuYWJsZWRWaWRlbzsKIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBm bG9hdCByYXRlOworQHByb3BlcnR5IChnZXR0ZXI9aXNQbGF5aW5nKSBCT09MIHBsYXlpbmc7CitA cHJvcGVydHkgQk9PTCBjYW5Ub2dnbGVQbGF5YmFjazsKIAogLSAodm9pZClzZXRBdWRpb01lZGlh U2VsZWN0aW9uT3B0aW9uczooY29uc3QgVmVjdG9yPFdURjo6U3RyaW5nPiYpb3B0aW9ucyB3aXRo U2VsZWN0ZWRJbmRleDooTlNVSW50ZWdlcilzZWxlY3RlZEluZGV4OwogLSAodm9pZClzZXRMZWdp YmxlTWVkaWFTZWxlY3Rpb25PcHRpb25zOihjb25zdCBWZWN0b3I8V1RGOjpTdHJpbmc+JilvcHRp b25zIHdpdGhTZWxlY3RlZEluZGV4OihOU1VJbnRlZ2VyKXNlbGVjdGVkSW5kZXg7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tDb250cm9sc01hbmFn ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tDb250cm9sc01h bmFnZXIubW0KaW5kZXggNjQyNzdiYTRjNzgzZDE4OTQwNWI1MTY4OGY0YmQyMjA1MjQyZDJkOC4u NGVkNjhkMjY4NDFjMDIyNTNhZTk4MzQ4YzkyNDhhYjdlNWM2YmFhZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYlBsYXliYWNrQ29udHJvbHNNYW5hZ2VyLm1tCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xzTWFuYWdl ci5tbQpAQCAtMzgsNiArMzgsOCBAQAogQHN5bnRoZXNpemUgaGFzRW5hYmxlZEF1ZGlvPV9oYXNF bmFibGVkQXVkaW87CiBAc3ludGhlc2l6ZSBoYXNFbmFibGVkVmlkZW89X2hhc0VuYWJsZWRWaWRl bzsKIEBzeW50aGVzaXplIHJhdGU9X3JhdGU7CitAc3ludGhlc2l6ZSBwbGF5aW5nPV9wbGF5aW5n OworQHN5bnRoZXNpemUgY2FuVG9nZ2xlUGxheWJhY2s9X2NhblRvZ2dsZVBsYXliYWNrOwogCiAt IChBVlZhbHVlVGltaW5nICopdGltaW5nCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlTWFjLm1tIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1dlYlBsYXliYWNrU2Vzc2lvbkludGVyZmFjZU1hYy5tbQppbmRl eCAyMDI2Zjk5YTdjZjJjNjJlMjVjNjA4YTgwYzhmODMyMzU0YzIyNDE1Li44MDkwMTQ5OWIyYjJj M2JiNzY5OGRmNjdkMmI2MmQ5ZDVkNTY1Nzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VNYWMubW0K QEAgLTg4LDYgKzg4LDcgQEAgdm9pZCBXZWJQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VNYWM6OnNl dFJhdGUoYm9vbCBpc1BsYXlpbmcsIGZsb2F0IHBsYXliYWNrUmF0ZSkKIHsKICAgICBXZWJQbGF5 YmFja0NvbnRyb2xzTWFuYWdlciogY29udHJvbHNNYW5hZ2VyID0gcGxheUJhY2tDb250cm9sc01h bmFnZXIoKTsKICAgICBbY29udHJvbHNNYW5hZ2VyIHNldFJhdGU6aXNQbGF5aW5nID8gcGxheWJh Y2tSYXRlIDogMC5dOworICAgIFtjb250cm9sc01hbmFnZXIgc2V0UGxheWluZzppc1BsYXlpbmdd OwogCiAgICAgaWYgKG1fY2xpZW50KQogICAgICAgICBtX2NsaWVudC0+cmF0ZUNoYW5nZWQoaXNQ bGF5aW5nLCBwbGF5YmFja1JhdGUpOwpAQCAtMTU3LDYgKzE1OCw4IEBAIHZvaWQgV2ViUGxheWJh Y2tTZXNzaW9uSW50ZXJmYWNlTWFjOjpzZXRQbGF5QmFja0NvbnRyb2xzTWFuYWdlcihXZWJQbGF5 YmFja0NvbnRyCiAgICAgbWFuYWdlci5oYXNFbmFibGVkVmlkZW8gPSBkdXJhdGlvbiA+IDA7CiAg ICAgbWFuYWdlci5yYXRlID0gbV9wbGF5YmFja1Nlc3Npb25Nb2RlbC0+aXNQbGF5aW5nKCkgPyBt X3BsYXliYWNrU2Vzc2lvbk1vZGVsLT5wbGF5YmFja1JhdGUoKSA6IDAuOwogICAgIG1hbmFnZXIu c2Vla2FibGVUaW1lUmFuZ2VzID0gdGltZVJhbmdlc1RvQXJyYXkobV9wbGF5YmFja1Nlc3Npb25N b2RlbC0+c2Vla2FibGVSYW5nZXMoKSkuZ2V0KCk7CisgICAgbWFuYWdlci5jYW5Ub2dnbGVQbGF5 YmFjayA9IFlFUzsKKyAgICBtYW5hZ2VyLnBsYXlpbmcgPSBtX3BsYXliYWNrU2Vzc2lvbk1vZGVs LT5pc1BsYXlpbmcoKTsKICAgICBbbWFuYWdlciBzZXRBdWRpb01lZGlhU2VsZWN0aW9uT3B0aW9u czptX3BsYXliYWNrU2Vzc2lvbk1vZGVsLT5hdWRpb01lZGlhU2VsZWN0aW9uT3B0aW9ucygpIHdp dGhTZWxlY3RlZEluZGV4OnN0YXRpY19jYXN0PE5TVUludGVnZXI+KG1fcGxheWJhY2tTZXNzaW9u TW9kZWwtPmF1ZGlvTWVkaWFTZWxlY3RlZEluZGV4KCkpXTsKICAgICBbbWFuYWdlciBzZXRMZWdp YmxlTWVkaWFTZWxlY3Rpb25PcHRpb25zOm1fcGxheWJhY2tTZXNzaW9uTW9kZWwtPmxlZ2libGVN ZWRpYVNlbGVjdGlvbk9wdGlvbnMoKSB3aXRoU2VsZWN0ZWRJbmRleDpzdGF0aWNfY2FzdDxOU1VJ bnRlZ2VyPihtX3BsYXliYWNrU2Vzc2lvbk1vZGVsLT5sZWdpYmxlTWVkaWFTZWxlY3RlZEluZGV4 KCkpXTsKIH0K