158567 2016-06-09 08:00:05 -0700 Add comments to clarify feature enablement 2016-06-09 13:07:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply commit-queue darin mcatanzaro oldest_to_newest 1200834 0 mcatanzaro 2016-06-09 08:00:05 -0700 Many developers, both experienced and inexperienced, don't understand how we handle feature enablement. Add some comments FeatureList.pm and WebKitFeatures.cmake to clarify the situation. These comments are accurate for all CMake ports; it would be great to add a comment in FeatureList.pm that addresses XCode as well, but it'd be best if someone from Apple would write that. 1200835 1 280919 mcatanzaro 2016-06-09 08:03:38 -0700 Created attachment 280919 Patch 1200937 2 280919 commit-queue 2016-06-09 13:07:51 -0700 Comment on attachment 280919 Patch Clearing flags on attachment: 280919 Committed r201879: <http://trac.webkit.org/changeset/201879> 1200938 3 commit-queue 2016-06-09 13:07:54 -0700 All reviewed patches have been landed. Closing bug. 280919 2016-06-09 08:03:38 -0700 2016-06-09 13:07:51 -0700 Patch bug-158567-20160609100506.patch text/plain 2871 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMTY2MzFmMjRkOWQxODIwMTM0NjRhMWNkMGIxYTIwMjc3OTI4MTc2Mi4uYzYzNDFlMWNmYjMz NjUxYTRjYWJmZGIzMmM2ZDgwODdlNWUyZDZlNSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMSwzICsxLDEzIEBACisjIFRoZSBzZXR0aW5ncyBpbiB0aGlzIGZpbGUgYXJlIHRoZSBX ZWJLaXQgcHJvamVjdCBkZWZhdWx0IHZhbHVlcywgYW5kCisjIGFyZSByZWNvbW1lbmRlZCBmb3Ig bW9zdCBwb3J0cy4gUG9ydHMgY2FuIG92ZXJyaWRlIHRoZXNlIHNldHRpbmdzIGluCisjIE9wdGlv bnMqLmNtYWtlLCBidXQgc2hvdWxkIGRvIHNvIG9ubHkgaWYgdGhlcmUgaXMgc3Ryb25nIHJlYXNv biB0bworIyBkZXZpYXRlIGZyb20gdGhlIGRlZmF1bHRzIG9mIHRoZSBXZWJLaXQgcHJvamVjdCAo ZS5nLiBpZiB0aGUgZmVhdHVyZQorIyByZXF1aXJlcyBwbGF0Zm9ybS1zcGVjaWZpYyBpbXBsZW1l bnRhdGlvbiB0aGF0IGRvZXMgbm90IGV4aXN0KS4KKyMKKyMgTW9zdCBkZWZhdWx0cyBpbiB0aGlz IGZpbGUgYWZmZWN0IGVuZCB1c2VycyBidXQgbm90IGRldmVsb3BlcnMuCisjIERlZmF1bHRzIGZv ciBkZXZlbG9wbWVudCBidWlsZHMgYXJlIHNldCBpbiBGZWF0dXJlTGlzdC5wbS4gTW9zdCBhbGwK KyMgZmVhdHVyZXMgZW5hYmxlZCBoZXJlIHNob3VsZCBhbHNvIGJlIGVuYWJsZWQgaW4gRmVhdHVy ZUxpc3QucG0uCisKIHNldChfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TICIiKQogCiBzZXQoUFVC TElDIFlFUykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCBjNWZiY2I1MDYwNjMyN2M2MzVhM2UwZDc0ZjJlYjllZmRkZTBiMmMxLi41YWJkNGVkOGZl ZjFmYmNkYzljOTBhMTVjY2I4MGEwZjIxZjdmZDE4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMDYtMDkgIE1p Y2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFkZCBj b21tZW50cyB0byBjbGFyaWZ5IGZlYXR1cmUgZW5hYmxlbWVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NTY3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVy ZUxpc3QucG06CisKIDIwMTYtMDYtMDkgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBhbmQgRHVtcFJlbmRlclRyZWUgZG8gbm90 IGhhbmRsZSBkYW5nbGluZyBzdXJyb2dhdGUgY2hhcmFjdGVycwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw ZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IGFhN2NlYjM1YzUxZGU3MDZkZDkyNWZjYWIwMWU0ZTMy ZGYyZGNlYTQuLjdhOTAyOGVmNjhjMzM0NjljZTJjOTNhYTU3MWJlMGRhNmJlOGQyZjAgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTIzLDYgKzIzLDEzIEBACiAj IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCiAKICMgQSBtb2R1bGUgdG8gY29udGFpbiBhbGwgdGhlIGVuYWJsZS9kaXNh YmxlIGZlYXR1cmUgb3B0aW9uIGNvZGUuCisjCisjIEZvciBDTWFrZSBwb3J0cywgdGhpcyBtb2R1 bGUgb25seSBhZmZlY3RzIGRldmVsb3BtZW50IGJ1aWxkcy4gVGhlCisjIHNldHRpbmdzIGluIHRo aXMgZmlsZSBoYXZlIFpFUk8gRUZGRUNUIGZvciBlbmQgdXNlcnMuIFVzZQorIyBXZWJLaXRGZWF0 dXJlcy5jbWFrZSB0byBjaGFuZ2Ugc2V0dGluZ3MgZm9yIHVzZXJzLiBHdWlkZWxpbmVzOgorIwor IyAqIEEgZmVhdHVyZSBlbmFibGVkIGhlcmUgYnV0IG5vdCBXZWJLaXRGZWF0dXJlcy5jbWFrZSBp cyBFWFBFUklNRU5UQUwuCisjICogQSBmZWF0dXJlIGVuYWJsZWQgaW4gV2ViS2l0RmVhdHVyZXMu Y21ha2UgYnV0IG5vdCBoZXJlIGlzIGEgQlVHLgogCiB1c2Ugc3RyaWN0OwogdXNlIHdhcm5pbmdz OwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGVmOTIyNDQ3NGE4OTU2 ODU4OGQ1YzIzNWUzZTA4OWJlMmUxYmEwZjIuLjg5MTMyYzc3NDk0OTNhMTAyZmRkZjg1MTU1N2Qw ODlhMzQzMDE3ODUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNi0wOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgQWRkIGNvbW1lbnRzIHRvIGNsYXJpZnkgZmVhdHVyZSBlbmFi bGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTg1NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAxNi0wNi0wOCAgUGVyIEFy bmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gU2hhZG93IERP TSB0ZXN0cyBhcmUgZmFpbGluZy4K