158560 2016-06-09 03:27:02 -0700 [Threaded Compositor] Many layout tests crash when threaded compositor is enabled 2016-06-09 05:08:03 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 154066 1 cgarcia webkit-unassigned bugs-noreply yoon zan oldest_to_newest 1200799 0 cgarcia 2016-06-09 03:27:02 -0700 Program received signal SIGSEGV, Segmentation fault. 0x00007fb30dca017b in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 (gdb) bt #0 0x00007fb30dca017b in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007fb30dca12f9 in WebCore::CoordinatedGraphicsLayer::didChangeGeometry() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007fb30d951781 in WebCore::RenderLayerCompositor::ensureRootLayer() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007fb30d9518d1 in WebCore::RenderLayerCompositor::enableCompositingMode(bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007fb30d953a76 in WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*) [clone .part.263] [clone .constprop.273] () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007fb30d6458a9 in WebCore::FrameView::layout(bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007fb30d6466e1 in WebCore::FrameView::updateContentsSize() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007fb30d6ea6d8 in WebCore::ScrollView::updateScrollbars(WebCore::IntPoint const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007fb30d6eafc2 in WebCore::ScrollView::setContentsSize(WebCore::IntSize const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007fb30d645176 in WebCore::FrameView::setContentsSize(WebCore::IntSize const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007fb30d6452d1 in WebCore::FrameView::adjustViewSize() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007fb30d646086 in WebCore::FrameView::layout(bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007fb30d646a2d in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007fb30cd92046 in WebKit::DrawingAreaImpl::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #14 0x00007fb30cdefe73 in WebKit::DrawingArea::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #15 0x00007fb30cad8e59 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #16 0x00007fb30cc01216 in WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #17 0x00007fb30cad5246 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #18 0x00007fb30cad5ba3 in IPC::Connection::dispatchOneMessage() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #19 0x00007fb30b6edf32 in WTF::RunLoop::performWork() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #20 0x00007fb30b71d069 in WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #21 0x00007fb306913b8a in g_main_dispatch (context=0x8a2ee0) at gmain.c:3154 #22 g_main_context_dispatch (context=context@entry=0x8a2ee0) at gmain.c:3769 #23 0x00007fb306913f08 in g_main_context_iterate (context=0x8a2ee0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3840 #24 0x00007fb306914222 in g_main_loop_run (loop=0x101f4b0) at gmain.c:4034 #25 0x00007fb30b71d930 in WTF::RunLoop::run() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #26 0x00007fb30cd96ca2 in int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #27 0x00007fb301a355f0 in __libc_start_main (main=0x400af0 <main>, argc=2, argv=0x7ffdc729c8c8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffdc729c8b8) at libc-start.c:291 #28 0x0000000000400b49 in _start () This is because CoordinatedGraphicsLayer::notifyFlushRequired() assumes it has a valid compositor when it's called. But the compositor is only present when GraphicsLayer::create() is called with a GraphicsLayerFactory. When running the layout tests layers are created without a factory because DrawingAreaImpl is not entering the AC mode as expected and the layer tree host is not created, making DrawingAreaImpl::graphicsLayerFactory() always return false. This happens because DrawingAreaImpl is checking acceleratedDrawingEnabled setting to decide whether to always use compositing mode or not and WTR sets that setting to false (changing its default value). The thing is that acceleratedDrawingEnabled setting doesn't have any effect in non-Mac ports, what we really want to check there is whether acceleratedCompositingEnabled is true or false. 1200801 1 280910 cgarcia 2016-06-09 03:30:50 -0700 Created attachment 280910 Patch 1200809 2 cgarcia 2016-06-09 05:08:03 -0700 Committed r201860: <http://trac.webkit.org/changeset/201860> 280910 2016-06-09 03:30:50 -0700 2016-06-09 03:37:19 -0700 Patch wktr-crash-threaded-compositor.diff text/plain 2382 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2MzU5MTlhLi43YjQzYjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTYtMDYtMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtUaHJlYWRlZCBDb21wb3NpdG9yXSBNYW55IGxheW91dCB0ZXN0cyBjcmFz aCB3aGVuIHRocmVhZGVkIGNvbXBvc2l0b3IgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NTYwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIENvb3JkaW5hdGVk R3JhcGhpY3NMYXllcjo6bm90aWZ5Rmx1c2hSZXF1aXJlZCgpIGFzc3VtZXMgaXQgaGFzIGEgdmFs aWQgY29tcG9zaXRvciB3aGVuIGl0J3MKKyAgICAgICAgY2FsbGVkLiBCdXQgdGhlIGNvbXBvc2l0 b3IgaXMgb25seSBwcmVzZW50IHdoZW4gR3JhcGhpY3NMYXllcjo6Y3JlYXRlKCkgaXMgY2FsbGVk IHdpdGggYQorICAgICAgICBHcmFwaGljc0xheWVyRmFjdG9yeS4gV2hlbiBydW5uaW5nIHRoZSBs YXlvdXQgdGVzdHMsIGxheWVycyBhcmUgY3JlYXRlZCB3aXRob3V0IGEgZmFjdG9yeSBiZWNhdXNl IERyYXdpbmdBcmVhSW1wbAorICAgICAgICBpcyBub3QgZW50ZXJpbmcgQUMgbW9kZSBhcyBleHBl Y3RlZCBhbmQgdGhlIGxheWVyIHRyZWUgaG9zdCBpcyBub3QgY3JlYXRlZCwgbWFraW5nCisgICAg ICAgIERyYXdpbmdBcmVhSW1wbDo6Z3JhcGhpY3NMYXllckZhY3RvcnkoKSBhbHdheXMgcmV0dXJu IG51bGxwdHIuIFRoaXMgaGFwcGVucyBiZWNhdXNlIERyYXdpbmdBcmVhSW1wbCBpcyBjaGVja2lu ZworICAgICAgICBhY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkIHNldHRpbmcgdG8gZGVjaWRlIHdo ZXRoZXIgdG8gYWx3YXlzIHVzZSBjb21wb3NpdGluZyBtb2RlIG9yIG5vdCwgYW5kIFdUUiBzZXRz IHRoYXQKKyAgICAgICAgc2V0dGluZyB0byBmYWxzZSAoY2hhbmdpbmcgaXRzIGRlZmF1bHQgdmFs dWUpLiBUaGUgdGhpbmcgaXMgdGhhdCBhY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkIHNldHRpbmcg ZG9lc24ndCBoYXZlCisgICAgICAgIGFueSBlZmZlY3QgaW4gbm9uLU1hYyBwb3J0cywgd2hhdCB3 ZSByZWFsbHkgd2FudCB0byBjaGVjayB0aGVyZSBpcyB3aGV0aGVyIGFjY2VsZXJhdGVkQ29tcG9z aXRpbmdFbmFibGVkIGlzIHRydWUKKyAgICAgICAgb3IgZmFsc2UuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJh d2luZ0FyZWFJbXBsOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisKKzIwMTYtMDYtMDkgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEJyb3dz ZXIgcGx1Z2lucyBjcmFzaCB1bmRlciBXYXlsYW5kCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc2MDUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAppbmRleCBkNDdkZmIzLi41 ODRhZWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWFJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv RHJhd2luZ0FyZWFJbXBsLmNwcApAQCAtMjQ4LDcgKzI0OCw3IEBAIHZvaWQgRHJhd2luZ0FyZWFJ bXBsOjp1cGRhdGVQcmVmZXJlbmNlcyhjb25zdCBXZWJQcmVmZXJlbmNlc1N0b3JlJiBzdG9yZSkK ICAgICBzZXR0aW5ncy5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29udGV4dCh0cnVl KTsKICNlbmRpZgogCi0gICAgbV9hbHdheXNVc2VDb21wb3NpdGluZyA9IHNldHRpbmdzLmFjY2Vs ZXJhdGVkRHJhd2luZ0VuYWJsZWQoKSAmJiBzZXR0aW5ncy5mb3JjZUNvbXBvc2l0aW5nTW9kZSgp OworICAgIG1fYWx3YXlzVXNlQ29tcG9zaXRpbmcgPSBzZXR0aW5ncy5hY2NlbGVyYXRlZENvbXBv c2l0aW5nRW5hYmxlZCgpICYmIHNldHRpbmdzLmZvcmNlQ29tcG9zaXRpbmdNb2RlKCk7CiAgICAg aWYgKG1fYWx3YXlzVXNlQ29tcG9zaXRpbmcgJiYgIW1fbGF5ZXJUcmVlSG9zdCkKICAgICAgICAg ZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZShudWxscHRyKTsKIH0K