158526 2016-06-08 07:40:25 -0700 Increase disk cache capacity when there is lots of free space 2016-06-09 01:40:45 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned ap beidson cdumez webkit-bug-importer oldest_to_newest 1200443 0 koivisto 2016-06-08 07:40:25 -0700 Our maximum disk cache capacity has been 175MB for very long time. Meanwhile the average resource size has grown massively. This is enough for cacheable resources of a few dozen sites at most. By using bigger caches when there is room for it can save battery and speed up page loading. 1200446 1 280804 koivisto 2016-06-08 07:55:43 -0700 Created attachment 280804 patch 1200456 2 280804 cdumez 2016-06-08 08:46:57 -0700 Comment on attachment 280804 patch R=me 1200540 3 webkit-bug-importer 2016-06-08 12:32:58 -0700 <rdar://problem/26703263> 1200575 4 280804 ap 2016-06-08 13:47:35 -0700 Comment on attachment 280804 patch View in context: https://bugs.webkit.org/attachment.cgi?id=280804&action=review > Source/WebKit2/ChangeLog:15 > + >=16GB free: 175MB -> 500MB > + 8-16GB free: 150MB -> 250MB Perhaps the heuristic should take into account the percentage of free space, not just the amount. At some point, it was recommended that no more than 75% of SSD should be used (http://www.anandtech.com/show/6489/playing-with-op). I don't have newer references, but I believe that consumer grade SSDs still work the same way. 1200776 5 koivisto 2016-06-09 01:40:45 -0700 https://trac.webkit.org/r201857 280804 2016-06-08 07:55:43 -0700 2016-06-08 08:46:57 -0700 patch disk-cache-size.patch text/plain 3076 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTgwNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE2LTA2LTA4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNyZWFzZSBkaXNrIGNhY2hl IGNhcGFjaXR5IHdoZW4gdGhlcmUgaXMgbG90cyBvZiBmcmVlIHNwYWNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg1MjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXIgbWF4aW11bSBkaXNrIGNhY2hl IGNhcGFjaXR5IGhhcyBiZWVuIDE3NU1CIGZvciBhIHZlcnkgbG9uZyB0aW1lLiBNZWFud2hpbGUg dGhlIGF2ZXJhZ2UgcmVzb3VyY2Ugc2l6ZSBoYXMgZ3Jvd24KKyAgICAgICAgbWFzc2l2ZWx5LiAx NzVNQiBpcyBub3cgZW5vdWdoIGZvciBjYWNoZWFibGUgcmVzb3VyY2VzIG9mIGEgZmV3IGRvemVu IHNpdGVzIGF0IG1vc3QuIFVzaW5nIGJpZ2dlciBjYWNoZXMgd2hlbiB0aGVyZSBpcworICAgICAg ICByb29tIGZvciBpdCBjYW4gcmVkdWNlIGRpc2sgd3JpdGVzLCBzYXZlIGJhdHRlcnkgYW5kIHNw ZWVkIHVwIHBhZ2UgbG9hZGluZy4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgY2FjaGUg c2l6ZSBmb3IgUHJpbWFyeVdlYkJyb3dzZXIgY2FjaGUgbW9kZWwKKworICAgICAgICA+PTE2R0Ig ZnJlZTogMTc1TUIgLT4gNTAwTUIKKyAgICAgICAgOC0xNkdCIGZyZWU6IDE1ME1CIC0+IDI1ME1C CisKKyAgICAgICAgYW5kIG1vZGVzdGx5IGZvciBEb2N1bWVudEJyb3dzZXIKKworICAgICAgICA+ PTE2R0IgZnJlZTogNTBNQiAtPiA3NU1CCisKKyAgICAgICAgTm90ZSB0aGF0IGlmIHN5c3RlbSBy ZWFsbHkgbmVlZHMgZGlzayBzcGFjZSBpdCB3aWxsIHdpcGUgb3V0IGNhY2hlcyB1c2luZyBDYWNo ZURlbGV0ZSAob24gT1MgWC9pT1MpIHNvIHRoaXMgZG9lc24ndAorICAgICAgICByZWR1Y2UgYXZh aWxhYmxlIGRpc2sgc3BhY2UgaW4gc2NlbmFyaW9zIGxpa2Ugc29mdHdhcmUgaW5zdGFsbGF0aW9u LgorCisgICAgICAgICogU2hhcmVkL0NhY2hlTW9kZWwuY3BwOgorICAgICAgICAoV2ViS2l0Ojpj YWxjdWxhdGVDYWNoZVNpemVzKToKKwogMjAxNi0wNi0wNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0IG1lbW9yeSBjYWNoZSBkb2Vzbid0IHJlc3Bl Y3QgVmFyeSBoZWFkZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9DYWNoZU1vZGVsLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ2FjaGVNb2RlbC5jcHAJKHJl dmlzaW9uIDIwMTgwNCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9DYWNoZU1vZGVsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTUsNyArNTUsNyBAQCB2b2lkIGNhbGN1bGF0ZUNhY2hlU2l6ZXMo Q2FjaGVNb2RlbCBjYWNoCiAgICAgICAgIC8vIEZvdW5kYXRpb24gbWVtb3J5IGNhY2hlIGNhcGFj aXR5IChpbiBieXRlcykKICAgICAgICAgdXJsQ2FjaGVNZW1vcnlDYXBhY2l0eSA9IDA7CiAKLSAg ICAgICAgLy8gRm91bmRhdGlvbiBkaXNrIGNhY2hlIGNhcGFjaXR5IChpbiBieXRlcykKKyAgICAg ICAgLy8gRGlzayBjYWNoZSBjYXBhY2l0eSAoaW4gYnl0ZXMpCiAgICAgICAgIHVybENhY2hlRGlz a0NhcGFjaXR5ID0gMDsKIAogICAgICAgICBicmVhazsKQEAgLTkyLDkgKzkyLDkgQEAgdm9pZCBj YWxjdWxhdGVDYWNoZVNpemVzKENhY2hlTW9kZWwgY2FjaAogICAgICAgICBlbHNlCiAgICAgICAg ICAgICB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5ID0gICAgICA1MTIgKiAxMDI0OyAKIAotICAgICAg ICAvLyBGb3VuZGF0aW9uIGRpc2sgY2FjaGUgY2FwYWNpdHkgKGluIGJ5dGVzKQorICAgICAgICAv LyBEaXNrIGNhY2hlIGNhcGFjaXR5IChpbiBieXRlcykKICAgICAgICAgaWYgKGRpc2tGcmVlU2l6 ZSA+PSAxNjM4NCkKLSAgICAgICAgICAgIHVybENhY2hlRGlza0NhcGFjaXR5ID0gNTAgKiAxMDI0 ICogMTAyNDsKKyAgICAgICAgICAgIHVybENhY2hlRGlza0NhcGFjaXR5ID0gNzUgKiAxMDI0ICog MTAyNDsKICAgICAgICAgZWxzZSBpZiAoZGlza0ZyZWVTaXplID49IDgxOTIpCiAgICAgICAgICAg ICB1cmxDYWNoZURpc2tDYXBhY2l0eSA9IDQwICogMTAyNCAqIDEwMjQ7CiAgICAgICAgIGVsc2Ug aWYgKGRpc2tGcmVlU2l6ZSA+PSA0MDk2KQpAQCAtMTUzLDExICsxNTMsMTEgQEAgdm9pZCBjYWxj dWxhdGVDYWNoZVNpemVzKENhY2hlTW9kZWwgY2FjaAogICAgICAgICAgICAgdXJsQ2FjaGVNZW1v cnlDYXBhY2l0eSA9ICAgICAgNTEyICogMTAyNDsKICNlbmRpZgogCi0gICAgICAgIC8vIEZvdW5k YXRpb24gZGlzayBjYWNoZSBjYXBhY2l0eSAoaW4gYnl0ZXMpCisgICAgICAgIC8vIERpc2sgY2Fj aGUgY2FwYWNpdHkgKGluIGJ5dGVzKQogICAgICAgICBpZiAoZGlza0ZyZWVTaXplID49IDE2Mzg0 KQotICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkgPSAxNzUgKiAxMDI0ICogMTAyNDsK KyAgICAgICAgICAgIHVybENhY2hlRGlza0NhcGFjaXR5ID0gNTAwICogMTAyNCAqIDEwMjQ7CiAg ICAgICAgIGVsc2UgaWYgKGRpc2tGcmVlU2l6ZSA+PSA4MTkyKQotICAgICAgICAgICAgdXJsQ2Fj aGVEaXNrQ2FwYWNpdHkgPSAxNTAgKiAxMDI0ICogMTAyNDsKKyAgICAgICAgICAgIHVybENhY2hl RGlza0NhcGFjaXR5ID0gMjUwICogMTAyNCAqIDEwMjQ7CiAgICAgICAgIGVsc2UgaWYgKGRpc2tG cmVlU2l6ZSA+PSA0MDk2KQogICAgICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkgPSAxMjUg KiAxMDI0ICogMTAyNDsKICAgICAgICAgZWxzZSBpZiAoZGlza0ZyZWVTaXplID49IDIwNDgpCg==