158515 2016-06-07 21:18:07 -0700 [EFL] Build fix related with SharedBuffer::createFromReadingFile in SharedBufferPosix.cpp 2016-06-07 22:02:11 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park webkit-unassigned gyuyoung.kim lucas.de.marchi oldest_to_newest 1200313 0 jh718.park 2016-06-07 21:18:07 -0700 This patch fixes the build error shown as below. ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp: In static member function ‘static WTF::RefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createFromReadingFile(const WTF::String&)’: ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:69:42: error: operands to ?: have different types ‘WTF::Ref<WebCore::SharedBuffer>’ and ‘int’ return totalBytesRead == bytesToRead ? SharedBuffer::adoptVector(buffer) : 0; 1200316 1 jh718.park 2016-06-07 21:26:24 -0700 Committed r201790: <http://trac.webkit.org/changeset/201790> 1200320 2 gyuyoung.kim 2016-06-07 21:57:30 -0700 (In reply to comment #1) > Committed r201790: <http://trac.webkit.org/changeset/201790> Personally I prefer to fix this issue as https://bugs.webkit.org/attachment.cgi?id=280763&action=review 1200322 3 jh718.park 2016-06-07 22:02:11 -0700 (In reply to comment #2) > (In reply to comment #1) > > Committed r201790: <http://trac.webkit.org/changeset/201790> > > Personally I prefer to fix this issue as > https://bugs.webkit.org/attachment.cgi?id=280763&action=review I realized that I missed to change 0s to nullptr when I saw the https://bugs.webkit.org/attachment.cgi?id=280763. That would be more proper one.