158512 2016-06-07 20:01:37 -0700 EFL build break since r201761 2016-06-07 22:41:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue oldest_to_newest 1200299 0 gyuyoung.kim 2016-06-07 20:01:37 -0700 There has been build error since r201761 on EFL port. To resotre EFL bot, I land a fix without review. Source/WebCore/CMakeFiles/WebCore.dir/platform/posix/SharedBufferPOSIX.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/platform/posix/SharedBufferPOSIX.cpp.o -c ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp: In static member function ‘static WTF::RefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createFromReadingFile(const WTF::String&)’: ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:69:42: error: operands to ?: have different types ‘WTF::Ref<WebCore::SharedBuffer>’ and ‘int’ return totalBytesRead == bytesToRead ? SharedBuffer::adoptVector(buffer) : 0; 1200300 1 280763 gyuyoung.kim 2016-06-07 20:06:31 -0700 Created attachment 280763 Patch 1200325 2 280768 gyuyoung.kim 2016-06-07 22:10:03 -0700 Created attachment 280768 Patch 1200333 3 280768 commit-queue 2016-06-07 22:41:19 -0700 Comment on attachment 280768 Patch Clearing flags on attachment: 280768 Committed r201792: <http://trac.webkit.org/changeset/201792> 1200334 4 commit-queue 2016-06-07 22:41:23 -0700 All reviewed patches have been landed. Closing bug. 280763 2016-06-07 20:06:31 -0700 2016-06-07 22:09:57 -0700 Patch bug-158512-20160608120756.patch text/plain 2139 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc1NDcyNGU3ODZlY2Rk MWM4YzcwODE5OTJiMzZlNDA0NGY2MDYzNC4uMWZkZWMwZmMwN2E3MWY4YzlkZTIzMTUzMWUyYjg4 MjEzZmQ4M2ZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA2LTA3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBFRkwgYnVpbGQg aGFzIGJlZW4gYnJva2VuIHNpbmNlIHIyMDE3NjEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODUxMgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4LgorCisgICAgICAgICogcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwOiAK KyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6Y3JlYXRlRnJvbVJlYWRpbmdGaWxlKToK KyAgICAgICAgRG8gbm90IHVzZSA/IG9wZXJhbmQgaW4gcmV0dXJuIGxpbmUuIEFkZGl0aW9uYWxs eSByZXR1cm4gbnVsbHB0ciBpbnN0ZWFkIG9mIDAuCisKIDIwMTYtMDYtMDcgIEtlaXRoIFJvbGxp biAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBhbGwgdXNlcyBvZiBQYXNz UmVmUHRyIGluIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgv U2hhcmVkQnVmZmVyUE9TSVguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hh cmVkQnVmZmVyUE9TSVguY3BwCmluZGV4IDdlOWEwMjY0ZDcxMDFmNzRiMWQ3ODdlMmQ0NjQxMTc3 YzhmNzc4YzkuLmRiZDJjMGY1NGYzMWJmZjJmYzZhY2NmOWFkNGNiZmU3NjlkNGQyZDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5j cHAKQEAgLTM4LDIzICszOCwyMyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBSZWZQdHI8U2hhcmVk QnVmZmVyPiBTaGFyZWRCdWZmZXI6OmNyZWF0ZUZyb21SZWFkaW5nRmlsZShjb25zdCBTdHJpbmcm IGZpbGVQYXRoKQogewogICAgIGlmIChmaWxlUGF0aC5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVy biAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIENTdHJpbmcgZmlsZW5hbWUgPSBm aWxlU3lzdGVtUmVwcmVzZW50YXRpb24oZmlsZVBhdGgpOwogICAgIGludCBmZCA9IG9wZW4oZmls ZW5hbWUuZGF0YSgpLCBPX1JET05MWSk7CiAgICAgaWYgKGZkID09IC0xKQotICAgICAgICByZXR1 cm4gMDsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICBzdHJ1Y3Qgc3RhdCBmaWxlU3Rh dDsKICAgICBpZiAoZnN0YXQoZmQsICZmaWxlU3RhdCkpIHsKICAgICAgICAgY2xvc2UoZmQpOwot ICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogCiAgICAg c2l6ZV90IGJ5dGVzVG9SZWFkOwogICAgIGlmICghV1RGOjpjb252ZXJ0U2FmZWx5KGZpbGVTdGF0 LnN0X3NpemUsIGJ5dGVzVG9SZWFkKSkgewogICAgICAgICBjbG9zZShmZCk7Ci0gICAgICAgIHJl dHVybiAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKICAgICBWZWN0b3I8Y2hh cj4gYnVmZmVyKGJ5dGVzVG9SZWFkKTsKQEAgLTY2LDcgKzY2LDExIEBAIFJlZlB0cjxTaGFyZWRC dWZmZXI+IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlRnJvbVJlYWRpbmdGaWxlKGNvbnN0IFN0cmluZyYg ZmlsZVBhdGgpCiAKICAgICBjbG9zZShmZCk7CiAKLSAgICByZXR1cm4gdG90YWxCeXRlc1JlYWQg PT0gYnl0ZXNUb1JlYWQgPyBTaGFyZWRCdWZmZXI6OmFkb3B0VmVjdG9yKGJ1ZmZlcikgOiAwOwor CisgICAgaWYgKHRvdGFsQnl0ZXNSZWFkICE9IGJ5dGVzVG9SZWFkKQorICAgICAgICByZXR1cm4g bnVsbHB0cjsKKworICAgIHJldHVybiBTaGFyZWRCdWZmZXI6OmFkb3B0VmVjdG9yKGJ1ZmZlcik7 CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 280768 2016-06-07 22:10:03 -0700 2016-06-07 22:41:19 -0700 Patch bug-158512-20160608141129.patch text/plain 2226 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzU2MDFmZGI0OTI0NmZi ZTJlODM2ODVmYzJhODliOTI0ZGI1YzFmMi4uMjUwNzE4NzZmODQ3YWQ5OGNhZWIzNDg3M2EyZjNi N2U2NDJmZDcyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA2LTA3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBFRkwgYnVpbGQg aGFzIGJlZW4gYnJva2VuIHNpbmNlIHIyMDE3NjEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODUxMgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4LgorCisgICAgICAgICogcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwOiAK KyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6Y3JlYXRlRnJvbVJlYWRpbmdGaWxlKToK KyAgICAgICAgRG8gbm90IHVzZSA/IG9wZXJhbmQgaW4gcmV0dXJuIGxpbmUuIEFkZGl0aW9uYWxs eSByZXR1cm4gbnVsbHB0ciBpbnN0ZWFkIG9mIDAuCisKIDIwMTYtMDYtMDcgIEpvb25naHVuIFBh cmsgIDxqaDcxOC5wYXJrQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEJ1aWxkIGZpeCBy ZWxhdGVkIHdpdGggU2hhcmVkQnVmZmVyOjpjcmVhdGVGcm9tUmVhZGluZ0ZpbGUgaW4gU2hhcmVk QnVmZmVyUG9zaXguY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3Np eC9TaGFyZWRCdWZmZXJQT1NJWC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9T aGFyZWRCdWZmZXJQT1NJWC5jcHAKaW5kZXggMDY5ZDQ2YjQyNDcwYjRkMTQyYjYwODBhM2JiYWVi OTE2NmFhZWU4Mi4uNTY5ZjhmMTAwOTU2NmZhZjU4ZWQxMzJmZWYxM2Q5OGMxM2VlNjA2YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVgu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lY LmNwcApAQCAtMzgsMjMgKzM4LDIzIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIFJlZlB0cjxTaGFy ZWRCdWZmZXI+IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlRnJvbVJlYWRpbmdGaWxlKGNvbnN0IFN0cmlu ZyYgZmlsZVBhdGgpCiB7CiAgICAgaWYgKGZpbGVQYXRoLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0 dXJuIDA7CisgICAgICAgIHJldHVybiBudWxscHRyOwogCiAgICAgQ1N0cmluZyBmaWxlbmFtZSA9 IGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihmaWxlUGF0aCk7CiAgICAgaW50IGZkID0gb3Blbihm aWxlbmFtZS5kYXRhKCksIE9fUkRPTkxZKTsKICAgICBpZiAoZmQgPT0gLTEpCi0gICAgICAgIHJl dHVybiAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIHN0cnVjdCBzdGF0IGZpbGVT dGF0OwogICAgIGlmIChmc3RhdChmZCwgJmZpbGVTdGF0KSkgewogICAgICAgICBjbG9zZShmZCk7 Ci0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKICAg ICBzaXplX3QgYnl0ZXNUb1JlYWQ7CiAgICAgaWYgKCFXVEY6OmNvbnZlcnRTYWZlbHkoZmlsZVN0 YXQuc3Rfc2l6ZSwgYnl0ZXNUb1JlYWQpKSB7CiAgICAgICAgIGNsb3NlKGZkKTsKLSAgICAgICAg cmV0dXJuIDA7CisgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KIAogICAgIFZlY3Rvcjxj aGFyPiBidWZmZXIoYnl0ZXNUb1JlYWQpOwpAQCAtNjYsMTAgKzY2LDEwIEBAIFJlZlB0cjxTaGFy ZWRCdWZmZXI+IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlRnJvbVJlYWRpbmdGaWxlKGNvbnN0IFN0cmlu ZyYgZmlsZVBhdGgpCiAKICAgICBjbG9zZShmZCk7CiAKLSAgICBpZiAodG90YWxCeXRlc1JlYWQg PT0gYnl0ZXNUb1JlYWQpCi0gICAgICAgIHJldHVybiBTaGFyZWRCdWZmZXI6OmFkb3B0VmVjdG9y KGJ1ZmZlcik7CisgICAgaWYgKHRvdGFsQnl0ZXNSZWFkICE9IGJ5dGVzVG9SZWFkKQorICAgICAg ICByZXR1cm4gbnVsbHB0cjsKIAotICAgIHJldHVybiBudWxscHRyOworICAgIHJldHVybiBTaGFy ZWRCdWZmZXI6OmFkb3B0VmVjdG9yKGJ1ZmZlcik7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUK