158510 2016-06-07 18:47:54 -0700 Don't try to cleanup non-existing ios Simulators 2016-06-08 11:01:43 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue glenn lforschler oldest_to_newest 1200287 0 aakash_jain 2016-06-07 18:47:54 -0700 When for some reason run-webkit-tests fails before creating the simulators, the cleanup still tries to cleanup the simulators. The “lsregister” command fails with the error message: “error -10814 unregistering /tmp/WebKitTestingSimulators/Simulator0.app” This just creates unnecessary logs and failed attempts. We should not try to cleanup non-existing simulators. 1200290 1 280760 aakash_jain 2016-06-07 19:01:59 -0700 Created attachment 280760 Proposed patch 1200294 2 280761 aakash_jain 2016-06-07 19:10:24 -0700 Created attachment 280761 Proposed patch 1200499 3 280761 commit-queue 2016-06-08 11:01:39 -0700 Comment on attachment 280761 Proposed patch Clearing flags on attachment: 280761 Committed r201812: <http://trac.webkit.org/changeset/201812> 1200500 4 commit-queue 2016-06-08 11:01:43 -0700 All reviewed patches have been landed. Closing bug. 280760 2016-06-07 19:01:59 -0700 2016-06-07 19:10:24 -0700 Proposed patch patch_cleanup text/plain 1275 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMTc4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA2LTA3ICBTYWZhcmkgQnVpbGQgU2xhdmUgIDxhYWthc2hfamFpbkBh cHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgdHJ5IHRvIGNsZWFudXAgbm9uLWV4aXN0aW5nIGlv cyBTaW11bGF0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTg1MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHk6CisgICAgICAgIChJT1NTaW11bGF0 b3JQb3J0LmNsZWFuX3VwX3Rlc3RfcnVuKTogCisgICAgICAgIENoZWNrIGlmIHNpbXVsYXRvciBl eGlzdHMgYmVmb3JlIHRyeWluZyB0byBjbGVhbiBpdCB1cC4KKwogMjAxNi0wNi0wNyAgS2VpdGgg Um9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGFsbCB1c2VzIG9m IFBhc3NSZWZQdHIgaW4gV1RGCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9z LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkJKHJl dmlzaW9uIDIwMTc4NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkJKHdv cmtpbmcgY29weSkKQEAgLTI1NCw2ICsyNTQsOCBAQCBjbGFzcyBJT1NTaW11bGF0b3JQb3J0KFBv cnQpOgogICAgICAgICAgICAgICAgIHBhc3MKIAogICAgICAgICBmb3IgaSBpbiB4cmFuZ2Uoc2Vs Zi5jaGlsZF9wcm9jZXNzZXMoKSk6CisgICAgICAgICAgICBpZiBub3Qgb3MucGF0aC5leGlzdHMo c2VsZi5nZXRfc2ltdWxhdG9yX3BhdGgoaSkpOgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAg ICAgICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgc3VicHJvY2Vzcy5jYWxsKFtzZWxmLkxT UkVHSVNURVJfUEFUSCwgIi12IiwgIi11Iiwgc2VsZi5nZXRfc2ltdWxhdG9yX3BhdGgoaSldKQog ICAgICAgICAgICAgICAgIHNodXRpbC5ybXRyZWUoc2VsZi5nZXRfc2ltdWxhdG9yX3BhdGgoaSks IGlnbm9yZV9lcnJvcnM9VHJ1ZSkK 280761 2016-06-07 19:10:24 -0700 2016-06-08 11:01:39 -0700 Proposed patch patch_cleanup text/plain 1268 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMTc4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA2LTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEb24ndCB0cnkgdG8gY2xlYW51cCBub24tZXhpc3RpbmcgaW9zIFNpbXVs YXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 ODUxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAgICAgICAgKElPU1NpbXVsYXRvclBvcnQu Y2xlYW5fdXBfdGVzdF9ydW4pOiAKKyAgICAgICAgQ2hlY2sgaWYgc2ltdWxhdG9yIGV4aXN0cyBi ZWZvcmUgdHJ5aW5nIHRvIGNsZWFuIGl0IHVwLgorCiAyMDE2LTA2LTA3ICBLZWl0aCBSb2xsaW4g IDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgYWxsIHVzZXMgb2YgUGFzc1Jl ZlB0ciBpbiBXVEYKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQkocmV2aXNpb24g MjAxNzg0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQkod29ya2luZyBj b3B5KQpAQCAtMjU0LDYgKzI1NCw4IEBAIGNsYXNzIElPU1NpbXVsYXRvclBvcnQoUG9ydCk6CiAg ICAgICAgICAgICAgICAgcGFzcwogCiAgICAgICAgIGZvciBpIGluIHhyYW5nZShzZWxmLmNoaWxk X3Byb2Nlc3NlcygpKToKKyAgICAgICAgICAgIGlmIG5vdCBvcy5wYXRoLmV4aXN0cyhzZWxmLmdl dF9zaW11bGF0b3JfcGF0aChpKSk6CisgICAgICAgICAgICAgICAgY29udGludWUKICAgICAgICAg ICAgIHRyeToKICAgICAgICAgICAgICAgICBzdWJwcm9jZXNzLmNhbGwoW3NlbGYuTFNSRUdJU1RF Ul9QQVRILCAiLXYiLCAiLXUiLCBzZWxmLmdldF9zaW11bGF0b3JfcGF0aChpKV0pCiAgICAgICAg ICAgICAgICAgc2h1dGlsLnJtdHJlZShzZWxmLmdldF9zaW11bGF0b3JfcGF0aChpKSwgaWdub3Jl X2Vycm9ycz1UcnVlKQo=