158502 2016-06-07 17:17:52 -0700 Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode() 2016-06-08 16:01:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1200248 0 bburg 2016-06-07 17:17:52 -0700 ------- Auto-generated details: Inspected URL: file:///Users/bburg/repos/webkit/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Main.html Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12) AppleWebKit/602.1.36+ (KHTML, like Gecko) Uncaught exceptions: - ReferenceError: Cannot access uninitialized variable. (at TimelineDataGrid.js:492:23) ------- * STEPS TO REPRODUCE 1. Create a timeline recording with layout data on it 2. Go to Layout & Rendering timeline 3. Sort by duration by clicking on the heading -> Exception! It looks like the code in TimelineDataGrid._updatePopoverForSelectedNode() is pretty messed up. It uses `targetFrame` in a conditional before declaring it a dozen lines later. The conditional itself doesn't look correct either, so this code should be audited when this is looked at. 1200249 1 webkit-bug-importer 2016-06-07 17:18:20 -0700 <rdar://problem/26687038> 1200250 2 webkit-bug-importer 2016-06-07 17:18:56 -0700 <rdar://problem/26687044> 1200631 3 280847 bburg 2016-06-08 15:28:20 -0700 Created attachment 280847 Proposed Fix 1200632 4 280847 joepeck 2016-06-08 15:31:23 -0700 Comment on attachment 280847 Proposed Fix r=me 1200654 5 280847 commit-queue 2016-06-08 16:01:10 -0700 Comment on attachment 280847 Proposed Fix Clearing flags on attachment: 280847 Committed r201839: <http://trac.webkit.org/changeset/201839> 1200655 6 commit-queue 2016-06-08 16:01:14 -0700 All reviewed patches have been landed. Closing bug. 280847 2016-06-08 15:28:20 -0700 2016-06-08 16:01:10 -0700 Proposed Fix bug-158502-20160608152947.patch text/plain 1920 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZTdiNmZjOTRmMjc2ZDk1YzU3MmExMTFiNDE1MjI5Y2U2NDAwOTUxLi5lMDM1YzM4NjA0ZDY0OTJk YzIzZDIwYjVkODQ0ZGJhODcxYzZhOGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNi0wNi0wOCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBVbmNhdWdodCBFeGNlcHRpb24gaW4gVGltZWxpbmVEYXRhR3JpZC5fdXBkYXRlUG9w b3ZlckZvclNlbGVjdGVkTm9kZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTg1MDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2Njg3MDM4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlRpbWVsaW5lRGF0YUdyaWQucHJvdG90eXBlLl91cGRhdGVQb3BvdmVyRm9yU2VsZWN0ZWROb2Rl KToKKyAgICAgICAgSXQgYXBwZWFycyB0aGF0IHRoaXMgZXhwcmVzc2lvbiB3YXMgbW92ZWQgYXJv dW5kIHNpbmNlIGl0IGFjY2Vzc2VzCisgICAgICAgIHRhcmdldEZyYW1lIGJlZm9yZSBpdCdzIGlu aXRpYWxpemVkLiBDaGVjayByZWN0LnNpemUuaGVpZ2h0IGRpcmVjdGx5LgorCisyMDE2LTA2LTA4 ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGFuIGVycm9yIGlzIGVuY291bnRlcmVkIHdoZW4gdHJ5aW5nIHRvIGRlbGV0ZSBub2RlcyB0aGF0 IGhhdmUgY2hpbGRyZW4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1ODU0MQogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY3MDU5MDE+CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURh dGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVEYXRhR3JpZC5qcwppbmRleCA0YjMwOWM0MDYzNzgzNjk5ZDQxMzg3NTBiZDIwZWE5MDMy ZTUxODdiLi4yOWU5ZDhjMGExMWI2ZGE0NWFkOTZkNzJlNDRlNzI0YjY5OTE1ZTUxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURh dGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lRGF0YUdyaWQuanMKQEAgLTQ4OSw3ICs0ODksNyBAQCBXZWJJbnNwZWN0b3IuVGlt ZWxpbmVEYXRhR3JpZCA9IGNsYXNzIFRpbWVsaW5lRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNwZWN0 b3IuRGF0YQogCiAgICAgICAgIC8vIFRoZSBlbGVtZW50IG1pZ2h0IGJlIGhpZGRlbiBpZiBpdCBk b2VzIG5vdCBoYXZlIGEgd2lkdGggYW5kIGhlaWdodC4KICAgICAgICAgbGV0IHJlY3QgPSBXZWJJ bnNwZWN0b3IuUmVjdC5yZWN0RnJvbUNsaWVudFJlY3QodGFyZ2V0UG9wb3ZlckVsZW1lbnQuZ2V0 Qm91bmRpbmdDbGllbnRSZWN0KCkpOwotICAgICAgICBpZiAoIXJlY3Quc2l6ZS53aWR0aCAmJiAh dGFyZ2V0RnJhbWUucmVjdC5oZWlnaHQpCisgICAgICAgIGlmICghcmVjdC5zaXplLndpZHRoICYm ICFyZWN0LnNpemUuaGVpZ2h0KQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmICh0 aGlzLl9oaWRlUG9wb3ZlckNvbnRlbnRDbGVhclRpbWVvdXQpIHsK