158491 2016-06-07 13:36:23 -0700 Web Inspector: reduce timer churn when processing many DOM.attributeModified messages 2016-06-07 17:30:41 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1200182 0 bburg 2016-06-07 13:36:23 -0700 This patch fixes two issues at play in 142466 and 156250. We currently use the Object.debounce/Object.soon proxy to try to coalesce calls to DOMTreeUpdater._attributesModified. Unfortunately, this doesn't coalesce very many calls because .soon is equivalent to using setTimeout(0). So we end up setting and clearing a timer for every attribute modification, and only coalesce calls until the timer fires. This means we also update the DOMTreeOutline multiple times per frame because this work is not done on a requestAnimationFrame, and the timer could fire many times in a frame's time slice. 1200183 1 bburg 2016-06-07 13:36:37 -0700 <rdar://problem/25561452> 1200186 2 280736 bburg 2016-06-07 13:57:22 -0700 Created attachment 280736 Proposed Fix 1200252 3 bburg 2016-06-07 17:30:41 -0700 Committed r201778: <http://trac.webkit.org/changeset/201778> 280736 2016-06-07 13:57:22 -0700 2016-06-07 15:07:43 -0700 Proposed Fix bug-158491-20160607135848.patch text/plain 7322 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 NmE5ODZlMDlmMDYyZjFlYTU5ZWY2NWNlNTVjOWJlNjdhNmVkZjNiLi5lYmU5ZDVkYjA5NTlkMTFi Zjc3NjBlMjMwNjMyYzE5M2U4ZWMxYTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0MyBAQAorMjAxNi0wNi0wNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiByZWR1Y2UgdGltZXIgY2h1cm4gd2hlbiBwcm9jZXNzaW5n IG1hbnkgRE9NLmF0dHJpYnV0ZU1vZGlmaWVkIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg0OTEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI1NTYxNDUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gdGhlIGJhY2tlbmQgc2VuZHMgdGhvdXNhbmRzIG9mIERPTS5hdHRyaWJ1dGVN b2RpZmllZCBldmVudHMgdG8gdGhlIGZyb250ZW5kLCBpdAorICAgICAgICBzbG93cyB0byBhIGNy YXdsLiBUaGlzIGlzIHBhcnRseSBiZWNhdXNlIHJlZHVuZGFudCBtZXNzYWdlcyBhcmUgYmVpbmcg c2VudCwgYW5kCisgICAgICAgIGJlY2F1c2UgdGhlIGZyb250ZW5kIGlzIHRha2luZyB0b28gbG9u ZyB0byByZW5kZXIgYXR0cmlidXRlIHVwZGF0ZXMgaW4gdGhlIGVsZW1lbnRzIHRhYi4KKworICAg ICAgICBUaGlzIHBhdGNoIGlzIGEgZmlyc3Qgc3RlcCB0byBpbXByb3ZlIHBlcmZvcm1hbmNlIGJ5 IHJlZHVjaW5nIHVubmVjZXNzYXJ5IHdvcmsuIEl0CisgICAgICAgIGNvYWxlc2NlcyBhbGwgYXR0 cmlidXRlIHN0YXRlIHVwZGF0ZXMgdG8gb25seSBoYXBwZW4gb25jZSBwZXIgYW5pbWF0aW9uIGZy YW1lLiBUaGlzCisgICAgICAgIHJlZHVjZXMgdGltZXIgY2h1cm4gYmVjYXVzZSB3ZSBwcmV2aW91 c2x5IHVzZWQgYSBkZWJvdW5jaW5nIHRpbWVyIHdpdGggaW50ZXJ2YWwgb2YgMG1zLAorICAgICAg ICBhbmQgdGhhdCBoYWQgdG8gYmUgY2xlYXJlZCBhbmQgcmVzdGFydGVkIG9uIGV2ZXJ5IGNhbGwu IFRoaXMgY2hhbmdlIGFsc28gZWxpbWluYXRlcworICAgICAgICBmb3JjZWQgbGF5b3V0cyB3aGVu IHVwZGF0aW5nIHRoZSBzZWxlY3Rpb24gaGlnaGxpZ2h0cywgc2luY2UgdGhlIERPTSB0cmVlIG91 dGxpbmUgaGFzCisgICAgICAgIGJlZW4gcmVmbG93ZWQgYnkgdGhlIHRpbWUgd2Ugc3RhcnQgdXBk YXRpbmcgc2VsZWN0aW9ucyBpbiBhIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjay4KKwor ICAgICAgICBUaGVyZSBpcyBzdGlsbCBhIGxvdCBvZiBvcHRpbWl6YXRpb24gdG8gYmUgZG9uZSBo ZXJlLCBidXQgdGhpcyByZWR1Y2VzIHRoZSBwcm9ibGVtCisgICAgICAgIGNvbnNpZGVyYWJseSBi eSBrZWVwaW5nIHRoZSBldmVudCBsb29wIGNsZWFyIGFuZCBtYWtpbmcgaXQgb2J2aW91cyB3aGlj aCBzZWxlY3Rpb24KKyAgICAgICAgdXBkYXRlIG9wZXJhdGlvbnMgYXJlIHN0aWxsIHRvbyBleHBl bnNpdmUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzOgorICAg ICAgICBBZGQgYSAnb25OZXh0RnJhbWUnIHByb3h5IHRvIE9iamVjdC4gSXQgd29ya3MgbGlrZSBk ZWJvdW5jZSwgZXhjZXB0IGl0IGNvYWxlc2NlcyBjYWxscworICAgICAgICB1cCB1bnRpbCB0aGUg bmV4dCBhbmltYXRpb24gZnJhbWUgcmF0aGVyIHRoYW4gYSBmaXhlZCB0aW1lb3V0LiBJdCBhbHNv IGRvZXMgbm90IGV4dGVuZAorICAgICAgICB0aGUgdGltZW91dCBpbnRlcnZhbCBmb3IgZWFjaCBj YWxsLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlVXBkYXRlci5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlVXBkYXRlci5wcm90b3R5cGUuX2F0dHJpYnV0 ZXNVcGRhdGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlVXBkYXRlci5wcm90b3R5 cGUuX2NoYXJhY3RlckRhdGFNb2RpZmllZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJl ZVVwZGF0ZXIucHJvdG90eXBlLl9ub2RlSW5zZXJ0ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkRPTVRyZWVVcGRhdGVyLnByb3RvdHlwZS5fbm9kZVJlbW92ZWQpOgorICAgICAgICBVcGRhdGUg b24gdGhlIG5leHQgZnJhbWUgcmF0aGVyIHRoYW4gb24gYSB6ZXJvIGRlbGF5IHRpbWVvdXQuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlRyZWVPdXRsaW5lLldlYkluc3BlY3Rvci5UcmVlRWxlbWVudC5wcm90b3R5 cGUuZGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UcmVlT3V0bGluZS5XZWJJbnNw ZWN0b3IuVHJlZUVsZW1lbnQucHJvdG90eXBlLl9maXJlRGlkQ2hhbmdlKToKKyAgICAgICAgVXBk YXRlIG9uIHRoZSBuZXh0IGZyYW1lIHJhdGhlciB0aGFuIG9uIGEgemVybyBkZWxheSB0aW1lb3V0 LgorCiAyMDE2LTA2LTA1ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMjAxNjg2KTogV2ViIEluc3BlY3RvcjogRml4IHR5cG8gY2F1c2lu ZyBhbiBpbnRlcm5hbCBlcnJvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwppbmRleCBmY2Y1NzUwNjI0NTEwMWQ0NjEzYTll MGI2NjdiZTBhODYxYmI0NmQ3Li43NmI0NzQwNjVhZWQ5MTJlYzgxMmI0MjIxMzdmMWJlNjJjYzJm YTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L1V0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL1V0aWxpdGllcy5qcwpAQCAtMTI3Myw2ICsxMjczLDM4IEBAIE9iamVjdC5kZWZpbmVQcm9w ZXJ0eShBcnJheS5wcm90b3R5cGUsICJiaW5hcnlJbmRleE9mIiwKICAgICAgICAgICAgIHRoaXNb ZGVib3VuY2VUaW1lb3V0U3ltYm9sXSA9IHVuZGVmaW5lZDsKICAgICAgICAgfQogICAgIH0pOwor CisgICAgY29uc3QgcmVxdWVzdEFuaW1hdGlvbkZyYW1lU3ltYm9sID0gU3ltYm9sKCJwZWZvcm0t b24tYW5pbWF0aW9uLWZyYW1lIik7CisgICAgY29uc3QgcmVxdWVzdEFuaW1hdGlvbkZyYW1lUHJv eHlTeW1ib2wgPSBTeW1ib2woInBlcmZvcm0tb24tYW5pbWF0aW9uLWZyYW1lLXByb3h5Iik7CisK KyAgICBPYmplY3QuZGVmaW5lUHJvcGVydHkoT2JqZWN0LnByb3RvdHlwZSwgIm9uTmV4dEZyYW1l IiwKKyAgICB7CisgICAgICAgIGdldDogZnVuY3Rpb24oKQorICAgICAgICB7CisgICAgICAgICAg ICBpZiAoIXRoaXNbcmVxdWVzdEFuaW1hdGlvbkZyYW1lUHJveHlTeW1ib2xdKSB7CisgICAgICAg ICAgICAgICAgdGhpc1tyZXF1ZXN0QW5pbWF0aW9uRnJhbWVQcm94eVN5bWJvbF0gPSBuZXcgUHJv eHkodGhpcywgeworICAgICAgICAgICAgICAgICAgICBnZXQodGFyZ2V0LCBwcm9wZXJ0eSwgcmVj ZWl2ZXIpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAoLi4uYXJncykgPT4gewor ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxldCBvcmlnaW5hbCA9IHRhcmdldFtwcm9wZXJ0 eV07CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc29sZS5hc3NlcnQodHlwZW9mIG9y aWdpbmFsID09PSAiZnVuY3Rpb24iKTsKKworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlm IChvcmlnaW5hbFtyZXF1ZXN0QW5pbWF0aW9uRnJhbWVTeW1ib2xdKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBs ZXQgcGVyZm9ybVdvcmsgPSAoKSA9PiB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IG9yaWdpbmFsW3JlcXVlc3RBbmltYXRpb25GcmFtZVN5bWJvbF0gPSB1bmRlZmluZWQ7CisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9yaWdpbmFsLmFwcGx5KHRhcmdldCwgYXJncyk7 CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKKworICAgICAgICAgICAgICAgICAgICAg ICAgICAgIG9yaWdpbmFsW3JlcXVlc3RBbmltYXRpb25GcmFtZVN5bWJvbF0gPSByZXF1ZXN0QW5p bWF0aW9uRnJhbWUocGVyZm9ybVdvcmspOworICAgICAgICAgICAgICAgICAgICAgICAgfTsKKyAg ICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfQor CisgICAgICAgICAgICByZXR1cm4gdGhpc1tyZXF1ZXN0QW5pbWF0aW9uRnJhbWVQcm94eVN5bWJv bF07CisgICAgICAgIH0KKyAgICB9KTsKIH0pKCk7CiAKIGZ1bmN0aW9uIGFwcGVuZFdlYkluc3Bl Y3RvclNvdXJjZVVSTChzdHJpbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlVXBkYXRlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVVcGRhdGVyLmpzCmluZGV4IDZiNjI2MGUz N2QyYjlmOWRiNDA3ZGY5OGQ0ZDcyNzBiMWI5MGNlMmQuLjY2ZmNiMGZiMThjNTBmZjhjZjgwMmZj YzM5Y2NmMjgxNWNhZDhkYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVVcGRhdGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVVcGRhdGVyLmpzCkBAIC01NywyOCArNTcs MjggQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVVcGRhdGVyLnByb3RvdHlwZSA9IHsKICAgICB7CiAg ICAgICAgIHRoaXMuX3JlY2VudGx5TW9kaWZpZWROb2Rlcy5wdXNoKHtub2RlOiBldmVudC5kYXRh Lm5vZGUsIHVwZGF0ZWQ6IHRydWUsIGF0dHJpYnV0ZTogZXZlbnQuZGF0YS5uYW1lfSk7CiAgICAg ICAgIGlmICh0aGlzLl90cmVlT3V0bGluZS5fdmlzaWJsZSkKLSAgICAgICAgICAgIHRoaXMuc29v bi5fdXBkYXRlTW9kaWZpZWROb2RlcygpOworICAgICAgICAgICAgdGhpcy5vbk5leHRGcmFtZS5f dXBkYXRlTW9kaWZpZWROb2RlcygpOwogICAgIH0sCiAKICAgICBfY2hhcmFjdGVyRGF0YU1vZGlm aWVkOiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAgICAgIHRoaXMuX3JlY2VudGx5TW9kaWZp ZWROb2Rlcy5wdXNoKHtub2RlOiBldmVudC5kYXRhLm5vZGUsIHVwZGF0ZWQ6IHRydWV9KTsKICAg ICAgICAgaWYgKHRoaXMuX3RyZWVPdXRsaW5lLl92aXNpYmxlKQotICAgICAgICAgICAgdGhpcy5z b29uLl91cGRhdGVNb2RpZmllZE5vZGVzKCk7CisgICAgICAgICAgICB0aGlzLm9uTmV4dEZyYW1l Ll91cGRhdGVNb2RpZmllZE5vZGVzKCk7CiAgICAgfSwKIAogICAgIF9ub2RlSW5zZXJ0ZWQ6IGZ1 bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy5fcmVjZW50bHlNb2RpZmllZE5vZGVz LnB1c2goe25vZGU6IGV2ZW50LmRhdGEubm9kZSwgcGFyZW50OiBldmVudC5kYXRhLnBhcmVudCwg aW5zZXJ0ZWQ6IHRydWV9KTsKICAgICAgICAgaWYgKHRoaXMuX3RyZWVPdXRsaW5lLl92aXNpYmxl KQotICAgICAgICAgICAgdGhpcy5zb29uLl91cGRhdGVNb2RpZmllZE5vZGVzKCk7CisgICAgICAg ICAgICB0aGlzLm9uTmV4dEZyYW1lLl91cGRhdGVNb2RpZmllZE5vZGVzKCk7CiAgICAgfSwKIAog ICAgIF9ub2RlUmVtb3ZlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICB0aGlzLl9y ZWNlbnRseU1vZGlmaWVkTm9kZXMucHVzaCh7bm9kZTogZXZlbnQuZGF0YS5ub2RlLCBwYXJlbnQ6 IGV2ZW50LmRhdGEucGFyZW50LCByZW1vdmVkOiB0cnVlfSk7CiAgICAgICAgIGlmICh0aGlzLl90 cmVlT3V0bGluZS5fdmlzaWJsZSkKLSAgICAgICAgICAgIHRoaXMuc29vbi5fdXBkYXRlTW9kaWZp ZWROb2RlcygpOworICAgICAgICAgICAgdGhpcy5vbk5leHRGcmFtZS5fdXBkYXRlTW9kaWZpZWRO b2RlcygpOwogICAgIH0sCiAKICAgICBfY2hpbGROb2RlQ291bnRVcGRhdGVkOiBmdW5jdGlvbihl dmVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVHJlZU91dGxpbmUuanMKaW5kZXggYmY2Y2JhMGYxZGM2Mjc3MzRkNThmNjZiMGY1OGM3 ZTM0ODU0ZGZhMy4uYzMwODkxZTI4NDQ3YjVhMzEzMWQzNTA4YzQxYzYyODBlZDE0OWQzMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91 dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VHJlZU91dGxpbmUuanMKQEAgLTgwMCw4ICs4MDAsNiBAQCBXZWJJbnNwZWN0b3IuVHJlZUVsZW1l bnQgPSBjbGFzcyBUcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKIAogICAg IF9maXJlRGlkQ2hhbmdlKCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2RpZENoYW5nZVRpbWVvdXRJ ZGVudGlmaWVyID0gdW5kZWZpbmVkOwotCiAgICAgICAgIGlmICh0aGlzLnRyZWVPdXRsaW5lKQog ICAgICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5fdHJlZUVsZW1lbnREaWRDaGFuZ2UodGhpcyk7 CiAgICAgfQpAQCAtODExLDkgKzgwOSw3IEBAIFdlYkluc3BlY3Rvci5UcmVlRWxlbWVudCA9IGNs YXNzIFRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICBpZiAo IXRoaXMudHJlZU91dGxpbmUpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgLy8gUHJl dmVudCB0ZWxsaW5nIHRoZSBUcmVlT3V0bGluZSBtdWx0aXBsZSB0aW1lcyBpbiBhIHJvdyBieSBk ZWxheWluZyBpdCB3aXRoIGEgdGltZW91dC4KLSAgICAgICAgaWYgKCF0aGlzLl9kaWRDaGFuZ2VU aW1lb3V0SWRlbnRpZmllcikKLSAgICAgICAgICAgIHRoaXMuX2RpZENoYW5nZVRpbWVvdXRJZGVu dGlmaWVyID0gc2V0VGltZW91dCh0aGlzLl9maXJlRGlkQ2hhbmdlLmJpbmQodGhpcyksIDApOwor ICAgICAgICB0aGlzLm9uTmV4dEZyYW1lLl9maXJlRGlkQ2hhbmdlKCk7CiAgICAgfQogCiAgICAg X3NldExpc3RJdGVtTm9kZUNvbnRlbnQoKQo=