158487 2016-06-07 11:37:19 -0700 AX: iOS: Need to expose whether object is a dialog element 2016-06-07 15:44:30 -0700 1 1 1 Unclassified WebKit Accessibility Other All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1200137 0 cfleizach 2016-06-07 11:37:19 -0700 We need to expose whether an element is a dialog element to higher level code to determine VoiceOver behavior on iOS 1200138 1 cfleizach 2016-06-07 11:37:32 -0700 <rdar://problem/26678218> 1200139 2 280726 cfleizach 2016-06-07 11:39:28 -0700 Created attachment 280726 Patch 1200148 3 jdiggs 2016-06-07 11:56:04 -0700 Layout test? Nit: Re-read your ChangeLog statement (in particular the commas and position of "so" cannot all be what you want) 1200160 4 280732 cfleizach 2016-06-07 12:25:57 -0700 Created attachment 280732 Patch 1200161 5 cfleizach 2016-06-07 12:26:06 -0700 (In reply to comment #3) > Layout test? > > Nit: Re-read your ChangeLog statement (in particular the commas and position > of "so" cannot all be what you want) Updated 1200181 6 jdiggs 2016-06-07 13:28:47 -0700 (In reply to comment #5) > (In reply to comment #3) > > Layout test? > > > > Nit: Re-read your ChangeLog statement (in particular the commas and position > > of "so" cannot all be what you want) > > Updated But still no layout test? 1200184 7 cfleizach 2016-06-07 13:47:12 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > Layout test? > > > > > > Nit: Re-read your ChangeLog statement (in particular the commas and position > > > of "so" cannot all be what you want) > > > > Updated > > But still no layout test? There's nothing to test at this level of WebCore. 1200212 8 280732 jdiggs 2016-06-07 15:16:03 -0700 Comment on attachment 280732 Patch (In reply to comment #7) > There's nothing to test at this level of WebCore. With respect to VoiceOver, sure. I would have thought that the attribute being exposed here to address the VO issue would warrant a test. But ok. 1200215 9 cfleizach 2016-06-07 15:21:24 -0700 (In reply to comment #8) > Comment on attachment 280732 [details] > Patch > > (In reply to comment #7) > > > There's nothing to test at this level of WebCore. > > With respect to VoiceOver, sure. I would have thought that the attribute > being exposed here to address the VO issue would warrant a test. But ok. That logic can't be tested at this level. Needs to be higher up 1200225 10 280732 commit-queue 2016-06-07 15:44:26 -0700 Comment on attachment 280732 Patch Clearing flags on attachment: 280732 Committed r201774: <http://trac.webkit.org/changeset/201774> 1200226 11 commit-queue 2016-06-07 15:44:30 -0700 All reviewed patches have been landed. Closing bug. 280726 2016-06-07 11:39:28 -0700 2016-06-07 12:25:57 -0700 Patch patch text/plain 1555 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTc2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA2LTA3ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGlPUzogTmVlZCB0 byBleHBvc2Ugd2hldGhlciBvYmplY3QgaXMgYSBkaWFsb2cgZWxlbWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NDg3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNjY3ODIxOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFeHBvc2Ugd2hldGhlciBhbiBvYmplY3QgaXMgYSBkaWFsb2cgdHlwZSwg c28gaGlnaGVyIHVwIHRoZSBzdGFjaywgZGVjaXNpb25zIGNhbiBiZSBtYWRlIHdoZXJlIHRvIGZv Y3VzIFZvaWNlT3Zlci4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVySU9TLm1tOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5SXNEaWFsb2ddKToKKwogMjAxNi0wNi0wNiAgU2FtIFdl aW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBleHBlcmltZW50YWwgc3VwcG9y dCBmb3Igc3ByaW5nIGJhc2VkIENTUyBhbmltYXRpb25zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmls aXR5T2JqZWN0V3JhcHBlcklPUy5tbQkocmV2aXNpb24gMjAxNzU1KQorKysgU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0J KHdvcmtpbmcgY29weSkKQEAgLTUwMSw2ICs0OTksMTUgQEAKICAgICByZXR1cm4gbV9vYmplY3Qt Pmxhbmd1YWdlKCk7CiB9CiAKKy0gKEJPT0wpYWNjZXNzaWJpbGl0eUlzRGlhbG9nCit7CisgICAg aWYgKCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIE5P OworCisgICAgQWNjZXNzaWJpbGl0eVJvbGUgcm9sZVZhbHVlID0gbV9vYmplY3QtPnJvbGVWYWx1 ZSgpOworICAgIHJldHVybiByb2xlVmFsdWUgPT0gQXBwbGljYXRpb25EaWFsb2dSb2xlIHx8IHJv bGVWYWx1ZSA9PSBBcHBsaWNhdGlvbkFsZXJ0RGlhbG9nUm9sZTsKK30KKwogLSAoQk9PTClfYWNj ZXNzaWJpbGl0eUlzTGFuZG1hcmtSb2xlOihBY2Nlc3NpYmlsaXR5Um9sZSlyb2xlCiB7CiAgICAg c3dpdGNoIChyb2xlKSB7Cg== 280732 2016-06-07 12:25:57 -0700 2016-06-07 15:44:26 -0700 Patch patch text/plain 1585 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTc2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA2LTA3ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGlPUzogTmVlZCB0 byBleHBvc2Ugd2hldGhlciBvYmplY3QgaXMgYSBkaWFsb2cgZWxlbWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NDg3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNjY3ODIxOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFeHBvc2Ugd2hldGhlciBhbiBvYmplY3QgaXMgYSBkaWFsb2cgdHlwZS4g VGhpcyB3aWxsIGFsbG93IGRlY2lzaW9ucyBoaWdoZXIgdXAgdGhlIHN0YWNrIHRvIGJlIG1hZGUg aW4gcmVnYXJkcyB0byB3aGVyZSB0byBtb3ZlIFZvaWNlT3ZlciBmb2N1cy4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tOgor ICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5SXNE aWFsb2ddKToKKwogMjAxNi0wNi0wNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAg ICAgICAgIEFkZCBleHBlcmltZW50YWwgc3VwcG9ydCBmb3Igc3ByaW5nIGJhc2VkIENTUyBhbmlt YXRpb25zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQkocmV2 aXNpb24gMjAxNzU1KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNj ZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTUwMSw2ICs0 OTksMTUgQEAKICAgICByZXR1cm4gbV9vYmplY3QtPmxhbmd1YWdlKCk7CiB9CiAKKy0gKEJPT0wp YWNjZXNzaWJpbGl0eUlzRGlhbG9nCit7CisgICAgaWYgKCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2li aWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIE5POworCisgICAgQWNjZXNzaWJpbGl0eVJvbGUg cm9sZVZhbHVlID0gbV9vYmplY3QtPnJvbGVWYWx1ZSgpOworICAgIHJldHVybiByb2xlVmFsdWUg PT0gQXBwbGljYXRpb25EaWFsb2dSb2xlIHx8IHJvbGVWYWx1ZSA9PSBBcHBsaWNhdGlvbkFsZXJ0 RGlhbG9nUm9sZTsKK30KKwogLSAoQk9PTClfYWNjZXNzaWJpbGl0eUlzTGFuZG1hcmtSb2xlOihB Y2Nlc3NpYmlsaXR5Um9sZSlyb2xlCiB7CiAgICAgc3dpdGNoIChyb2xlKSB7Cg==