15848 2007-11-05 13:39:34 -0800 REGRESSION: Assertion failure viewing comments page on digg.com 2007-12-03 07:47:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED http://digg.com/ HasReduction, InRadar, Regression P1 Normal --- 1 ddkilzer darin bdakin brkemper david.barto mitz oldest_to_newest 60329 0 ddkilzer 2007-11-05 13:39:34 -0800 * SUMMARY An assertion failure still occurs viewing a comments page on digg.com. * STEPS TO REPRODUCE 1. Launch Safari/WebKit with a debug build of WebKit. 2. Go to URL: http://digg.com/ 3. Sign in. 4. Search for "Leopard Windows bsod". 5. Click on the "Comments" link for the "Remove the Windows BSOD icon in Leopard, make OS X a little less smug" story. 6. Wait. (Feel free to scroll around the page if it helps make the time pass.) * RESULTS WebKit crashes with an assertion failure. * REGRESSION This is a regression from Safari 3 on Leopard. * NOTES Console output: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) (./wtf/HashTable.h:426 Value* WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::lookup(const T&) [with T = unsigned int, HashTranslator = WTF::IdentityHashTranslator<unsigned int, std::pair<unsigned int, int>, WTF::IntHash<unsigned int> >, Key = unsigned int, Value = std::pair<unsigned int, int>, Extractor = WTF::PairFirstExtractor<std::pair<unsigned int, int> >, HashFunctions = WTF::IntHash<unsigned int>, Traits = WTF::PairHashTraits<WTF::HashTraits<unsigned int>, WTF::HashTraits<int32_t> >, KeyTraits = WTF::HashTraits<unsigned int>]) Segmentation fault Stack trace: Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_INVALID_ADDRESS (0x0001) at 0xbbadbeef Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x00639768 std::pair<unsigned, int>* WTF::HashTable<unsigned, std::pair<unsigned, int>, WTF::PairFirstExtractor<std::pair<unsigned, int> >, WTF::IntHash<unsigned>, WTF::PairHashTraits<WTF::HashTraits<unsigned>, WTF::HashTraits<int> >, WTF::HashTraits<unsigned> >::lookup<unsigned, WTF::IdentityHashTranslator<unsigned, std::pair<unsigned, int>, WTF::IntHash<unsigned> > >(unsigned const&) + 184 (HashTable.h:426) 1 com.apple.JavaScriptCore 0x0063ccac WTF::HashTableIterator<unsigned, std::pair<unsigned, int>, WTF::PairFirstExtractor<std::pair<unsigned, int> >, WTF::IntHash<unsigned>, WTF::PairHashTraits<WTF::HashTraits<unsigned>, WTF::HashTraits<int> >, WTF::HashTraits<unsigned> > WTF::HashTable<unsigned, std::pair<unsigned, int>, WTF::PairFirstExtractor<std::pair<unsigned, int> >, WTF::IntHash<unsigned>, WTF::PairHashTraits<WTF::HashTraits<unsigned>, WTF::HashTraits<int> >, WTF::HashTraits<unsigned> >::find<unsigned, WTF::IdentityHashTranslator<unsigned, std::pair<unsigned, int>, WTF::IntHash<unsigned> > >(unsigned const&) + 80 (HashTable.h:729) 2 com.apple.JavaScriptCore 0x0063cd34 WTF::HashTable<unsigned, std::pair<unsigned, int>, WTF::PairFirstExtractor<std::pair<unsigned, int> >, WTF::IntHash<unsigned>, WTF::PairHashTraits<WTF::HashTraits<unsigned>, WTF::HashTraits<int> >, WTF::HashTraits<unsigned> >::find(unsigned const&) + 52 (HashTable.h:314) 3 com.apple.JavaScriptCore 0x0063cd84 WTF::HashMap<unsigned, KJS::JSValue*, WTF::IntHash<unsigned>, WTF::HashTraits<unsigned>, WTF::HashTraits<KJS::JSValue*> >::find(unsigned const&) + 56 (HashMap.h:251) 4 com.apple.JavaScriptCore 0x00664be0 KJS::ArrayInstance::inlineGetOwnPropertySlot(KJS::ExecState*, unsigned, KJS::PropertySlot&) + 328 (array_instance.cpp:154) 5 com.apple.JavaScriptCore 0x0059efbc KJS::ArrayInstance::getOwnPropertySlot(KJS::ExecState*, unsigned, KJS::PropertySlot&) + 56 (array_instance.cpp:180) 6 com.apple.JavaScriptCore 0x00578160 KJS::JSObject::getPropertySlot(KJS::ExecState*, unsigned, KJS::PropertySlot&) + 88 (object.cpp:182) 7 com.apple.JavaScriptCore 0x0059e6f0 KJS::JSObject::get(KJS::ExecState*, unsigned) const + 52 (object.cpp:171) 8 com.apple.JavaScriptCore 0x005b23a0 KJS::BracketAccessorNode::evaluate(KJS::ExecState*) + 328 (nodes.cpp:583) 9 com.apple.JavaScriptCore 0x005b1080 KJS::TypeOfValueNode::evaluate(KJS::ExecState*) + 84 (nodes.cpp:1322) 10 com.apple.JavaScriptCore 0x005af1b0 KJS::EqualNode::evaluate(KJS::ExecState*) + 84 (nodes.cpp:1941) 11 com.apple.JavaScriptCore 0x005ad520 KJS::IfNode::execute(KJS::ExecState*) + 204 (nodes.cpp:2736) 12 com.apple.JavaScriptCore 0x0058a5b8 KJS::statementListExecute(WTF::Vector<WTF::RefPtr<KJS::StatementNode>, (unsigned long)0>&, KJS::ExecState*) + 148 (nodes.cpp:2648) 13 com.apple.JavaScriptCore 0x0058a7c8 KJS::BlockNode::execute(KJS::ExecState*) + 120 (nodes.cpp:2689) 14 com.apple.JavaScriptCore 0x005ad674 KJS::IfNode::execute(KJS::ExecState*) + 544 (nodes.cpp:2749) 15 com.apple.JavaScriptCore 0x0058a5b8 KJS::statementListExecute(WTF::Vector<WTF::RefPtr<KJS::StatementNode>, (unsigned long)0>&, KJS::ExecState*) + 148 (nodes.cpp:2648) 16 com.apple.JavaScriptCore 0x0058a7c8 KJS::BlockNode::execute(KJS::ExecState*) + 120 (nodes.cpp:2689) 17 com.apple.JavaScriptCore 0x005a920c KJS::FunctionBodyNode::execute(KJS::ExecState*) + 68 (nodes.cpp:3607) 18 com.apple.JavaScriptCore 0x00577550 KJS::FunctionImp::execute(KJS::ExecState*) + 96 (function.cpp:252) 19 com.apple.JavaScriptCore 0x005b5df0 KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 464 (function.cpp:93) 20 com.apple.JavaScriptCore 0x005a2178 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 304 (object.cpp:95) 21 com.apple.JavaScriptCore 0x005c2d58 KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 824 (nodes.cpp:762) 22 com.apple.JavaScriptCore 0x005ad77c KJS::ExprStatementNode::execute(KJS::ExecState*) + 204 (nodes.cpp:2713) 23 com.apple.JavaScriptCore 0x0058a5b8 KJS::statementListExecute(WTF::Vector<WTF::RefPtr<KJS::StatementNode>, (unsigned long)0>&, KJS::ExecState*) + 148 (nodes.cpp:2648) 24 com.apple.JavaScriptCore 0x0058a7c8 KJS::BlockNode::execute(KJS::ExecState*) + 120 (nodes.cpp:2689) 25 com.apple.JavaScriptCore 0x005a920c KJS::FunctionBodyNode::execute(KJS::ExecState*) + 68 (nodes.cpp:3607) 26 com.apple.JavaScriptCore 0x005d1dac KJS::Interpreter::evaluate(KJS::UString const&, int, KJS::UChar const*, int, KJS::JSValue*) + 920 (interpreter.cpp:366) 27 com.apple.WebCore 0x015c84e4 WebCore::KJSProxy::evaluate(WebCore::String const&, int, WebCore::String const&) + 280 (kjs_proxy.cpp:87) 28 com.apple.WebCore 0x011a8c00 WebCore::FrameLoader::executeScript(WebCore::String const&, int, WebCore::String const&) + 128 (FrameLoader.cpp:761) 29 com.apple.WebCore 0x011a8cdc WebCore::FrameLoader::executeScript(WebCore::String const&, bool) + 136 (FrameLoader.cpp:749) 30 com.apple.WebCore 0x015ccb28 KJS::ScheduledAction::execute(KJS::Window*) + 1248 (kjs_window.cpp:1520) 31 com.apple.WebCore 0x015ccc24 KJS::Window::timerFired(KJS::DOMWindowTimer*) + 104 (kjs_window.cpp:1638) 32 com.apple.WebCore 0x015cce58 KJS::DOMWindowTimer::fired() + 72 (kjs_window.cpp:1912) 33 com.apple.WebCore 0x01561444 WebCore::TimerBase::fireTimers(double, WTF::Vector<WebCore::TimerBase*, (unsigned long)0> const&) + 244 (Timer.cpp:339) 34 com.apple.WebCore 0x01561524 WebCore::TimerBase::sharedTimerFired() + 132 (Timer.cpp:359) 35 com.apple.WebCore 0x0153ba38 WebCore::timerFired(__CFRunLoopTimer*, void*) + 140 (SharedTimerMac.cpp:85) 36 com.apple.CoreFoundation 0x907f1578 __CFRunLoopDoTimer + 184 37 com.apple.CoreFoundation 0x907ddef8 __CFRunLoopRun + 1680 38 com.apple.CoreFoundation 0x907dd4ac CFRunLoopRunSpecific + 268 39 com.apple.HIToolbox 0x93298b20 RunCurrentEventLoopInMode + 264 40 com.apple.HIToolbox 0x932981b4 ReceiveNextEventCommon + 380 41 com.apple.HIToolbox 0x93298020 BlockUntilNextEventMatchingListInMode + 96 42 com.apple.AppKit 0x9379eae4 _DPSNextEvent + 384 43 com.apple.AppKit 0x9379e7a8 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 116 44 com.apple.Safari 0x00006770 0x1000 + 22384 45 com.apple.AppKit 0x9379acec -[NSApplication run] + 472 46 com.apple.AppKit 0x9388b87c NSApplicationMain + 452 47 com.apple.Safari 0x0000244c 0x1000 + 5196 48 com.apple.Safari 0x0004f1b0 0x1000 + 319920 60332 1 ddkilzer 2007-11-05 13:42:24 -0800 (In reply to comment #0) > 4. Search for "Leopard Windows bsod". > 5. Click on the "Comments" link for the "Remove the Windows BSOD icon in > Leopard, make OS X a little less smug" story. Direct link: http://digg.com/apple/Remove_the_Windows_BSOD_icon_in_Leopard_make_OS_X_a_little_less_smug 60335 2 ddkilzer 2007-11-05 13:52:56 -0800 (In reply to comment #0) > * SUMMARY > An assertion failure still occurs viewing a comments page on digg.com. See Bug 15747 Comment #5. 62649 3 ddkilzer 2007-11-28 22:30:37 -0800 <rdar://problem/5619330> 62991 4 ddkilzer 2007-12-02 10:06:27 -0800 *** Bug 16155 has been marked as a duplicate of this bug. *** 62993 5 ddkilzer 2007-12-02 10:06:52 -0800 *** Bug 16016 has been marked as a duplicate of this bug. *** 62995 6 ddkilzer 2007-12-02 10:07:24 -0800 *** Bug 16031 has been marked as a duplicate of this bug. *** 63065 7 17661 mitz 2007-12-02 20:18:57 -0800 Created attachment 17661 Reduction (will ASSERT) The ASSERT is hit when accessing the 0th element of a sparse array. 0 is the empty value in the sparse array hash map so the assertion fails. 63066 8 mitz 2007-12-02 20:34:11 -0800 The ASSERT was added in <http://trac.webkit.org/projects/webkit/changeset/27196> where a similar problem was fixed for timer IDs. 63067 9 17662 mitz 2007-12-02 20:40:46 -0800 Created attachment 17662 Reduction (will crash) A version that crashes release builds. 63085 10 mitz 2007-12-02 22:23:06 -0800 I noticed another HashMap in JavaScriptCore that might be prone to the same problem: the intIdentifierMap in npruntime.cpp. There might be more in WebCore. 63086 11 17665 darin 2007-12-02 22:30:19 -0800 Created attachment 17665 patch 63089 12 darin 2007-12-02 22:52:04 -0800 (In reply to comment #10) > I noticed another HashMap in JavaScriptCore that might be prone to the same > problem: the intIdentifierMap in npruntime.cpp. There might be more in WebCore. The intIdentifierMap will have a worse problem, because you can't use either a 0 or -1. In the array case, it's just 0 -- there's no issue with -1. We should probably track that issue with a separate bug. 63090 13 17666 mitz 2007-12-02 22:54:13 -0800 Created attachment 17666 Different approach, without an extra branch I started working on this before I saw Darin took the bug. This approach avoids extra work when accessing the array but initializing the empty values to -2 costs more than initializing to 0. 63091 14 darin 2007-12-02 22:56:27 -0800 (In reply to comment #13) > Created an attachment (id=17666) [edit] > Different approach, without an extra branch > > I started working on this before I saw Darin took the bug. This approach avoids > extra work when accessing the array but initializing the empty values to -2 > costs more than initializing to 0. It's the JavaScript language standard that makes FFFFFFFF special, not our implementation. We can't just change maxArrayIndex; FFFFFFFD and FFFFFFFE have to work as array indices, whereas FFFFFFFF can be treated as just another non-array property. So I suspect this won't work. We'd need a test case that sets a property with FFFFFFFE and checks the length of the array to demonstrate what's wrong with it. 63093 15 mitz 2007-12-02 23:02:54 -0800 (In reply to comment #14) > So I suspect this won't work. We'd need a test case that sets a property with > FFFFFFFE and checks the length of the array to demonstrate what's wrong with > it. Yup, to make it work we'd need to add an extra branch somewhere :-) 63094 16 17665 mitz 2007-12-02 23:09:09 -0800 Comment on attachment 17665 patch \ No newline at end of file Please add a newline. r=me 63140 17 darin 2007-12-03 07:47:11 -0800 Committed revision 28346. 17661 2007-12-02 20:18:57 -0800 2007-12-02 20:18:57 -0800 Reduction (will ASSERT) 15848 reduction.html text/html 82 mitz PHNjcmlwdD4KICAgIHZhciBhcnJheSA9IG5ldyBBcnJheTsKICAgIGFycmF5WzUwMDAwXSA9IDA7 CiAgICBhcnJheVswXTsKPC9zY3JpcHQ+Cg== 17662 2007-12-02 20:40:46 -0800 2007-12-02 20:40:46 -0800 Reduction (will crash) 15848 reduction.html text/html 86 mitz PHNjcmlwdD4KICAgIHZhciBhcnJheSA9IG5ldyBBcnJheTsKICAgIGFycmF5WzUwMDAwXSA9IDEw MDsKICAgIGFycmF5WzBdKys7Cjwvc2NyaXB0Pgo= 17665 2007-12-02 22:30:19 -0800 2007-12-02 23:09:09 -0800 patch SparseArrayPatch.txt text/plain 5270 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MzI3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMTItMDIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1ODQ4CisgICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU2MTkzMzA+IFJFR1JFU1NJT046 IEFzc2VydGlvbiBmYWlsdXJlIHZpZXdpbmcgY29tbWVudHMgcGFnZSBvbiBkaWdnLmNvbQorCisg ICAgICAgIFRlc3Q6IGZhc3QvanMvc3BhcnNlLWFycmF5Lmh0bWwKKworICAgICAgICAqIGtqcy9h cnJheV9pbnN0YW5jZS5jcHA6CisgICAgICAgIChLSlM6OkFycmF5SW5zdGFuY2U6OmlubGluZUdl dE93blByb3BlcnR5U2xvdCk6IENoZWNrIHNwYXJzZSBhcnJheSBjdXRvZmYgYmVmb3JlIGxvb2tp bmcKKyAgICAgICAgaW4gaGFzaCBtYXAuIENhbid0IGF2b2lkIHRoZSBicmFuY2ggYmVjYXVzZSB3 ZSBjYW4ndCBsb29rIGZvciAwIGluIHRoZSBoYXNoLgorICAgICAgICAoS0pTOjpBcnJheUluc3Rh bmNlOjpkZWxldGVQcm9wZXJ0eSk6IERpdHRvLgorCiAyMDA3LTEyLTAxICBBbHAgVG9rZXIgIDxh bHBAYXRva2VyLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDog SmF2YVNjcmlwdENvcmUva2pzL2FycmF5X2luc3RhbmNlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh U2NyaXB0Q29yZS9ranMvYXJyYXlfaW5zdGFuY2UuY3BwCShyZXZpc2lvbiAyODMyNikKKysrIEph dmFTY3JpcHRDb3JlL2tqcy9hcnJheV9pbnN0YW5jZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1 MSwxMCArMTUxLDEyIEBAIEFMV0FZU19JTkxJTkUgYm9vbCBBcnJheUluc3RhbmNlOjppbmxpbmUK ICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAgICAgfSBlbHNlIGlmIChTcGFy c2VBcnJheVZhbHVlTWFwKiBtYXAgPSBzdG9yYWdlLT5tX3NwYXJzZVZhbHVlTWFwKSB7Ci0gICAg ICAgIFNwYXJzZUFycmF5VmFsdWVNYXA6Oml0ZXJhdG9yIGl0ID0gbWFwLT5maW5kKGkpOwotICAg ICAgICBpZiAoaXQgIT0gbWFwLT5lbmQoKSkgewotICAgICAgICAgICAgc2xvdC5zZXRWYWx1ZVNs b3QodGhpcywgJml0LT5zZWNvbmQpOwotICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAg IGlmIChpID49IHNwYXJzZUFycmF5Q3V0b2ZmKSB7CisgICAgICAgICAgICBTcGFyc2VBcnJheVZh bHVlTWFwOjppdGVyYXRvciBpdCA9IG1hcC0+ZmluZChpKTsKKyAgICAgICAgICAgIGlmIChpdCAh PSBtYXAtPmVuZCgpKSB7CisgICAgICAgICAgICAgICAgc2xvdC5zZXRWYWx1ZVNsb3QodGhpcywg Jml0LT5zZWNvbmQpOworICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAgICAg fQogICAgICAgICB9CiAgICAgfQogCkBAIC0zMTgsMTAgKzMyMCwxMiBAQCBib29sIEFycmF5SW5z dGFuY2U6OmRlbGV0ZVByb3BlcnR5KEV4ZWNTCiAgICAgfQogCiAgICAgaWYgKFNwYXJzZUFycmF5 VmFsdWVNYXAqIG1hcCA9IHN0b3JhZ2UtPm1fc3BhcnNlVmFsdWVNYXApIHsKLSAgICAgICAgU3Bh cnNlQXJyYXlWYWx1ZU1hcDo6aXRlcmF0b3IgaXQgPSBtYXAtPmZpbmQoaSk7Ci0gICAgICAgIGlm IChpdCAhPSBtYXAtPmVuZCgpKSB7Ci0gICAgICAgICAgICBtYXAtPnJlbW92ZShpdCk7Ci0gICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgaWYgKGkgPj0gc3BhcnNlQXJyYXlDdXRvZmYp IHsKKyAgICAgICAgICAgIFNwYXJzZUFycmF5VmFsdWVNYXA6Oml0ZXJhdG9yIGl0ID0gbWFwLT5m aW5kKGkpOworICAgICAgICAgICAgaWYgKGl0ICE9IG1hcC0+ZW5kKCkpIHsKKyAgICAgICAgICAg ICAgICBtYXAtPnJlbW92ZShpdCk7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg ICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MzI3KQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMDctMTItMDIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NDgKKyAgICAgICAgICA8cmRhcjovL3By b2JsZW0vNTYxOTMzMD4gUkVHUkVTU0lPTjogQXNzZXJ0aW9uIGZhaWx1cmUgdmlld2luZyBjb21t ZW50cyBwYWdlIG9uIGRpZ2cuY29tCisKKyAgICAgICAgKiBmYXN0L2pzL3Jlc291cmNlcy9zcGFy c2UtYXJyYXkuanM6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvc3BhcnNlLWFycmF5LWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9zcGFyc2UtYXJyYXkuaHRtbDogQWRk ZWQuCisKIDIwMDctMTItMDIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE1pdHouCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3NwYXJzZS1h cnJheS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9zcGFy c2UtYXJyYXktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9q cy9zcGFyc2UtYXJyYXktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE4IEBA CitUaGlzIHRlc3RzIHNvbWUgc3BhcnNlIGFycmF5IG9wZXJhdGlvbnMuCisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworCitQQVNTIGFycmF5WzBdIGlzIHVuZGVmaW5lZAorUEFTUyBhcnJh eVs0OTk5OV0gaXMgdW5kZWZpbmVkCitQQVNTIGFycmF5WzUwMDAwXSBpcyAxMDAKK1BBU1MgYXJy YXlbNTAwMDFdIGlzIHVuZGVmaW5lZAorUEFTUyBhcnJheVswXSBpcyBOYU4KK1BBU1MgYXJyYXlb NDk5OTldIGlzIHVuZGVmaW5lZAorUEFTUyBhcnJheVs1MDAwMF0gaXMgMTAwCitQQVNTIGFycmF5 WzUwMDAxXSBpcyB1bmRlZmluZWQKKworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3Qv anMvc3BhcnNlLWFycmF5LWV4cGVjdGVkLnR4dApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjplb2wtc3R5 bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3NwYXJzZS1hcnJheS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc3BhcnNlLWFycmF5Lmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3NwYXJzZS1hcnJheS5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lF VEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSJyZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9InJlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJk ZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0i cmVzb3VyY2VzL3NwYXJzZS1hcnJheS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0 eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2pzL3NwYXJzZS1hcnJheS5odG1sCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvaHRtbApOYW1lOiBzdm46ZW9sLXN0 eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvc3Bh cnNlLWFycmF5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2Vz L3NwYXJzZS1hcnJheS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcmVz b3VyY2VzL3NwYXJzZS1hcnJheS5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMSBAQAorZGVz Y3JpcHRpb24oCisnVGhpcyB0ZXN0cyBzb21lIHNwYXJzZSBhcnJheSBvcGVyYXRpb25zLicKKyk7 CisKK3ZhciBhcnJheSA9IFsgXTsKKworYXJyYXlbNTAwMDBdID0gMTAwOworCitzaG91bGRCZSgn YXJyYXlbMF0nLCAndW5kZWZpbmVkJyk7CitzaG91bGRCZSgnYXJyYXlbNDk5OTldJywgJ3VuZGVm aW5lZCcpOworc2hvdWxkQmUoJ2FycmF5WzUwMDAwXScsICcxMDAnKTsKK3Nob3VsZEJlKCdhcnJh eVs1MDAwMV0nLCAndW5kZWZpbmVkJyk7CithcnJheVswXSsrOworc2hvdWxkQmUoJ2FycmF5WzBd JywgJ05hTicpOworc2hvdWxkQmUoJ2FycmF5WzQ5OTk5XScsICd1bmRlZmluZWQnKTsKK3Nob3Vs ZEJlKCdhcnJheVs1MDAwMF0nLCAnMTAwJyk7CitzaG91bGRCZSgnYXJyYXlbNTAwMDFdJywgJ3Vu ZGVmaW5lZCcpOworCitkZWJ1ZygnJyk7CisKK3N1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Clwg Tm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo= 17666 2007-12-02 22:54:13 -0800 2007-12-02 22:54:13 -0800 Different approach, without an extra branch digg-assert-sparse-array.diff text/plain 1270 mitz SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9hcnJheV9pbnN0YW5jZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSmF2YVNjcmlwdENvcmUva2pzL2FycmF5X2luc3RhbmNlLmNwcAkocmV2aXNpb24gMjgzMjAp CisrKyBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfaW5zdGFuY2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMSw3ICszMSwxMiBAQCB1c2luZyBzdGQ6Om1pbjsKIAogbmFtZXNwYWNlIEtKUyB7CiAK LXR5cGVkZWYgSGFzaE1hcDx1bnNpZ25lZCwgSlNWYWx1ZSo+IFNwYXJzZUFycmF5VmFsdWVNYXA7 CitzdHJ1Y3QgU3BhcnNlQXJyYXlJbmRleEhhc2hUcmFpdHMgOiBIYXNoVHJhaXRzPHVuc2lnbmVk PiB7CisgICAgc3RhdGljIHVuc2lnbmVkIGVtcHR5VmFsdWUoKSB7IHJldHVybiBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4oLTIpOyB9CisgICAgc3RhdGljIGNvbnN0IGJvb2wgZW1wdHlWYWx1ZUlzWmVy byA9IGZhbHNlOworfTsKKwordHlwZWRlZiBIYXNoTWFwPHVuc2lnbmVkLCBKU1ZhbHVlKiwgRGVm YXVsdEhhc2g8dW5zaWduZWQ+OjpIYXNoLCBTcGFyc2VBcnJheUluZGV4SGFzaFRyYWl0cz4gU3Bh cnNlQXJyYXlWYWx1ZU1hcDsKIAogc3RydWN0IEFycmF5U3RvcmFnZSB7CiAgICAgdW5zaWduZWQg bV9udW1WYWx1ZXNJblZlY3RvcjsKQEAgLTM5LDggKzQ0LDkgQEAgc3RydWN0IEFycmF5U3RvcmFn ZSB7CiAgICAgSlNWYWx1ZSogbV92ZWN0b3JbMV07CiB9OwogCi0vLyAweEZGRkZGRkZGIGlzIGEg Yml0IHdlaXJkIC0tIGlzIG5vdCBhbiBhcnJheSBpbmRleCBldmVuIHRob3VnaCBpdCdzIGFuIGlu dGVnZXIKLXN0YXRpYyBjb25zdCB1bnNpZ25lZCBtYXhBcnJheUluZGV4ID0gMHhGRkZGRkZGRVU7 CisvLyAweEZGRkZGRkZFIGFuZCAweEZGRkZGRkZEIGFyZSBub3QgYXJyYXkgaW5kaWNlcyBldmVu IHRob3VnaCB0aGV5IGFyZSBpbnRlZ2VycywgYmVjYXVzZSB0aGV5CisvLyBoYXZlIHNwZWNpYWwg bWVhbmluZ3MgaW4gdGhlIHNwYXJzZSBhcnJheSBpbXBsZW1lbnRhdGlvbi4KK3N0YXRpYyBjb25z dCB1bnNpZ25lZCBtYXhBcnJheUluZGV4ID0gMHhGRkZGRkZGRFU7CiAKIC8vIE91ciBwb2xpY3kg Zm9yIHdoZW4gdG8gdXNlIGEgdmVjdG9yIGFuZCB3aGVuIHRvIHVzZSBhIHNwYXJzZSBtYXAuCiAv LyBGb3IgYWxsIGFycmF5IGluZGljZXMgdW5kZXIgc3BhcnNlQXJyYXlDdXRvZmYsIHdlIGFsd2F5 cyB1c2UgYSB2ZWN0b3IuCg==