158470 2016-06-07 02:47:20 -0700 [GTK] Fail to build on FreeBSD because locale.h is not included 2016-06-07 09:35:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1199981 0 lantw44 2016-06-07 02:47:20 -0700 Here are the error messages: /home/lantw44/webkit/source/WebKit/Source/JavaScriptCore/jsc.cpp:1955:20: error: use of undeclared identifier 'LC_ALL' if (!setlocale(LC_ALL, "")) ^ 1 error generated. Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/build.make:62: recipe for target 'Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o' failed 1199982 1 280685 lantw44 2016-06-07 02:49:11 -0700 Created attachment 280685 Patch 1200056 2 280685 darin 2016-06-07 08:57:36 -0700 Comment on attachment 280685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280685&action=review > Source/JavaScriptCore/jsc.cpp:114 > +#if PLATFORM(GTK) > +#include <locale.h> > +#endif No reason to put that inside an #if. Should just include this header unconditionally. 1200058 3 280685 darin 2016-06-07 08:58:13 -0700 Comment on attachment 280685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280685&action=review >> Source/JavaScriptCore/jsc.cpp:114 >> +#endif > > No reason to put that inside an #if. Should just include this header unconditionally. Sorry, I don’t mean "no reason", but still, lets include it unconditionally. 1200060 4 lantw44 2016-06-07 09:03:01 -0700 (In reply to comment #3) > >> Source/JavaScriptCore/jsc.cpp:114 > >> +#endif > > > > No reason to put that inside an #if. Should just include this header unconditionally. > > Sorry, I don’t mean "no reason", but still, lets include it unconditionally. OK, I did that because setlocale and LC_ALL are only used by PLATFORM(GTK). 1200061 5 280709 lantw44 2016-06-07 09:03:26 -0700 Created attachment 280709 Patch 1200074 6 280709 commit-queue 2016-06-07 09:35:46 -0700 Comment on attachment 280709 Patch Clearing flags on attachment: 280709 Committed r201755: <http://trac.webkit.org/changeset/201755> 1200075 7 commit-queue 2016-06-07 09:35:50 -0700 All reviewed patches have been landed. Closing bug. 280685 2016-06-07 02:49:11 -0700 2016-06-07 09:03:21 -0700 Patch bug-158470-20160607094910.patch text/plain 1029 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NWNlYjhkMzk0YjRiMjE1NTRmYTZkNDA4NDkyYjYxMzJkZjU1NGNhLi5lOWZmMjg2ODhlNTAzZGE1 MTUwZDQxNDAyODdiNWJiZGJiZTIxYjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNi0wNiAgVGluZy1XZWkgTGFuICA8bGFudHc0NEBnbWFpbC5jb20+ CisKKyAgICAgICAgW0dUS10gSW5jbHVkZSBsb2NhbGUuaCBiZWZvcmUgdXNpbmcgTENfQUxMCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg0NzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzYy5jcHA6 CisKIDIwMTYtMDYtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04ocjE5NzU5NSk6IDIlIEpTQmVuY2ggcmVncmVzc2lvbiBvbiBpUGhvbmUg NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2pzYy5jcHAKaW5kZXggNTJjMzdmMjMwYzM3YmVlZDdhYTRmMzE4ZDEzZmYx MTIyY2JhYjc3Ni4uOTVjNTE2MzQ5MmM5NGRmYzQ0MGFjOGI2ODE1YzdmYTQ1NGY0NmJkYyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2pzYy5jcHAKQEAgLTEwOSw2ICsxMDksMTAgQEAKICNpbmNsdWRlIDxFY29yZS5o PgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspCisjaW5jbHVkZSA8bG9jYWxlLmg+CisjZW5k aWYKKwogI2lmICFkZWZpbmVkKFBBVEhfTUFYKQogI2RlZmluZSBQQVRIX01BWCA0MDk2CiAjZW5k aWYK 280709 2016-06-07 09:03:26 -0700 2016-06-07 09:35:46 -0700 Patch bug-158470-20160607160325.patch text/plain 1073 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 OTIyZWJlNWZlNmExNmM3NmQ0NjE5N2JkMDIwNWVmYmJlMjhiMjlhLi4xNGE1NWY1OGU1MjllMmMx N2VkZWI0M2YxOTJjNDE3OGM3YWQwZTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wNi0wNiAgVGluZy1XZWkgTGFuICA8bGFudHc0NEBnbWFpbC5jb20+ CisKKyAgICAgICAgW0dUS10gSW5jbHVkZSBsb2NhbGUuaCBiZWZvcmUgdXNpbmcgTENfQUxMCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg0NzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzYy5jcHA6 CisKIDIwMTYtMDYtMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXggdHlwbyBpbiB0ZXN0IG5hbWUgdHJhaWxpbmctY29tbWEtaW4tZnVuY3Rpb24t cGFyYW10ZXJzLmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCmluZGV4IDUyYzM3ZjIzMGMzN2JlZWQ3YWE0 ZjMxOGQxM2ZmMTEyMmNiYWI3NzYuLjNhYmRlNzAxNTM3ZjEwYjAwNjQ2YzllODBkNGRlMGFmNmEz NTM4NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCkBAIC02MSw2ICs2MSw3IEBACiAjaW5jbHVkZSAi VGVzdFJ1bm5lclV0aWxzLmgiCiAjaW5jbHVkZSAiVHlwZVByb2ZpbGVyTG9nLmgiCiAjaW5jbHVk ZSAiV0FTTU1vZHVsZVBhcnNlci5oIgorI2luY2x1ZGUgPGxvY2FsZS5oPgogI2luY2x1ZGUgPG1h dGguaD4KICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgo=