<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>158418</bug_id>
          
          <creation_ts>2016-06-06 05:59:03 -0700</creation_ts>
          <short_desc>[EFL] Move efl include paths to JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES</short_desc>
          <delta_ts>2016-06-06 07:29:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gyuyoung Kim">gyuyoung.kim</reporter>
          <assigned_to name="Gyuyoung Kim">gyuyoung.kim</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1199544</commentid>
    <comment_count>0</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2016-06-06 05:59:03 -0700</bug_when>
    <thetext>In Source/JavaScriptCore/PlatformEfl.cmake, we don&apos;t use JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES for efl include paths. Let&apos;s use it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1199547</commentid>
    <comment_count>1</comment_count>
      <attachid>280592</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2016-06-06 05:59:56 -0700</bug_when>
    <thetext>Created attachment 280592
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1199548</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-06-06 06:48:14 -0700</bug_when>
    <thetext>Is JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES to avoid 
possible warnings in third party header files?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1199549</commentid>
    <comment_count>3</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2016-06-06 06:54:57 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Is JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES to avoid 
&gt; possible warnings in third party header files?

Yes, right. FYI - https://trac.webkit.org/changeset/185806</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1199550</commentid>
    <comment_count>4</comment_count>
      <attachid>280592</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-06-06 07:06:35 -0700</bug_when>
    <thetext>Comment on attachment 280592
Patch

OK, r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1199551</commentid>
    <comment_count>5</comment_count>
      <attachid>280592</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-06-06 07:29:54 -0700</bug_when>
    <thetext>Comment on attachment 280592
Patch

Clearing flags on attachment: 280592

Committed r201711: &lt;http://trac.webkit.org/changeset/201711&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1199552</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-06-06 07:29:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>280592</attachid>
            <date>2016-06-06 05:59:56 -0700</date>
            <delta_ts>2016-06-06 07:29:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-158418-20160606220119.patch</filename>
            <type>text/plain</type>
            <size>1545</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw
ZWViNWY5NWZiNGE2NjBjZjU5ODA2OTkxZmViMzdhZDJhMTk0MTRhLi5mMmE5NDg0NmVlMDNkZjhj
NjQwZTUwZGRmNTVmNjdmOWVjMzA3ZjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxNi0wNi0wNiAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtp
dC5vcmc+CisKKyAgICAgICAgW0VGTF0gTW92ZSBlZmwgaW5jbHVkZSBwYXRocyB0byBKYXZhU2Ny
aXB0Q29yZV9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklFUworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRm
b3JtRWZsLmNtYWtlLCB3ZSBkb24ndCB1c2UgSmF2YVNjcmlwdENvcmVfU1lTVEVNX0lOQ0xVREVf
RElSRUNUT1JJRVMKKyAgICAgICAgZm9yIGVmbCBpbmNsdWRlIHBhdGhzLgorCisgICAgICAgICog
UGxhdGZvcm1FZmwuY21ha2U6CisKIDIwMTYtMDYtMDUgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5l
LnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgQ2hhbmdlIFByb3h5T2JqZWN0LltbR2V0XV0gbm90
IHRvIHVzZSBjdXN0b20gYWNjZXNzb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUVmbC5j
bWFrZQppbmRleCAyM2JkNjU3NzI5ZmU4MDE2OWZhZmVkZGUxODFkMzI3MDk2NGYxMDRhLi4xYmE1
M2I5NDQ2NTExY2UyZDViOWI2NTRjZDJjNzgxM2MwZWNlYTZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvUGxhdGZvcm1FZmwuY21ha2UKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0xLDEyICsxLDE2IEBACiBsaXN0KEFQUEVORCBKYXZh
U2NyaXB0Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgIiR7V1RGX0RJUn0iCisgICAgIiR7
V1RGX0RJUn0vd3RmL2VmbCIKKykKKworbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfU1lTVEVN
X0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0VDT1JFX0VWQVNfSU5DTFVERV9ESVJTfQogICAg
ICR7RUNPUkVfSU1GX0lOQ0xVREVfRElSU30KICAgICAke0VDT1JFX0lOQ0xVREVfRElSU30KICAg
ICAke0VJTkFfSU5DTFVERV9ESVJTfQogICAgICR7RU9fSU5DTFVERV9ESVJTfQotICAgICIke1dU
Rl9ESVJ9IgotICAgICIke1dURl9ESVJ9L3d0Zi9lZmwiCiApCisKIGFkZF9kZWZpbml0aW9ucygt
RFNUQVRJQ0FMTFlfTElOS0VEX1dJVEhfV1RGKQogCiBpbnN0YWxsKEZJTEVTIEFQSS9KYXZhU2Ny
aXB0LmgK
</data>

          </attachment>
      

    </bug>

</bugzilla>