158410 2016-06-05 20:40:45 -0700 [EFL] Sync EFL features with featureList.pm 2016-06-05 22:08:30 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue lucas.de.marchi tonikitoo oldest_to_newest 1199471 0 gyuyoung.kim 2016-06-05 20:40:45 -0700 In OptionsEfl, some features on/off status are different with featureList.pm definitions. Sync with it. 1199472 1 280575 gyuyoung.kim 2016-06-05 20:41:22 -0700 Created attachment 280575 Patch 1199473 2 280576 gyuyoung.kim 2016-06-05 20:42:33 -0700 Created attachment 280576 Patch 1199488 3 280576 tonikitoo 2016-06-05 20:56:41 -0700 Comment on attachment 280576 Patch r=me. Could you confirm to me if this actually changes the status of these features in regular builds? 1199494 4 gyuyoung.kim 2016-06-05 21:30:43 -0700 (In reply to comment #3) > Comment on attachment 280576 [details] > Patch > > r=me. > > Could you confirm to me if this actually changes the status of these > features in regular builds? As far as I know the feature definitions of OptionEfl.cmake is just being used to add the feature name to *cmakeconfig.h* (Auto-generated cmakeconfig.h actually defines on/off status). Actual on/off status of cmakeconfig.h is done by FeatureList.pm on EFL port. So now I don't know whether we should keep on/off status in OptionEfl.cmake because it work nothing unless we build EFL port using cmake directly, not use *Tools/Scripts/build-webkit* script. If we don't need to keep the on/off status in OptionsEfl.cmake, I will try to remove it. But it seems to me that it would be good to sync with the status between OptionEfl.cmake and FeatureList.pm at the moment. 1199495 5 gyuyoung.kim 2016-06-05 21:31:30 -0700 See also https://bugs.webkit.org/show_bug.cgi?id=143997 1199508 6 280576 commit-queue 2016-06-05 22:08:26 -0700 Comment on attachment 280576 Patch Clearing flags on attachment: 280576 Committed r201707: <http://trac.webkit.org/changeset/201707> 1199509 7 commit-queue 2016-06-05 22:08:30 -0700 All reviewed patches have been landed. Closing bug. 280575 2016-06-05 20:41:22 -0700 2016-06-05 20:42:28 -0700 Patch bug-158410-20160606124245.patch text/plain 2928 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDQwYzA4 OGFiNmNlNGExOTIzNjUxYzlkZGQxOTA4ZGJhNTEyMThlMTAuLmJkNjBkZDdmNmUyNjI5NWVhOWYw NzA1MGRjZTMzMjY4MTU1ZGFlNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xLDUgKzEsNSBA QAogc2V0KFBST0pFQ1RfVkVSU0lPTl9NQUpPUiAxKQotc2V0KFBST0pFQ1RfVkVSU0lPTl9NSU5P UiAxNCkKK3NldChQUk9KRUNUX1ZFUlNJT05fTUlOT1IgMTcpCiBzZXQoUFJPSkVDVF9WRVJTSU9O X01JQ1JPIDApCiBzZXQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4k e1BST0pFQ1RfVkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlDUk99KQogCkBAIC04 Miw3ICs4Miw3IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BVFRB Q0hNRU5UX0VMRU1FTlQgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9CQVRURVJZX1NUQVRVUyBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfQ1NTM19URVhUIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfREVWSUNFX0FEQVBUQVRJT04gUFVCTElDIE9O KQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19HUklEX0xBWU9V VCBQVUJMSUMgT0ZGKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NT U19HUklEX0xBWU9VVCBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfQ1NTX0lNQUdFX1NFVCBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRf UE9SVF9WQUxVRShFTkFCTEVfQ1NTX1JFR0lPTlMgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19TQ1JPTExfU05BUCBQVUJMSUMgT0ZGKQpAQCAt MTA5LDcgKzEwOSw3IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9M SU5LX1BSRUZFVENIIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9NRURJQV9DQVBUVVJFIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQgUFVCTElDIE9OKQogV0VCS0lU X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJDRSBQVUJMSUMgT04p Ci1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBV QkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9T VFJFQU0gUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9NRU1PUllfU0FNUExFUiBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfTUhUTUwgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX01PVVNFX0NVUlNPUl9TQ0FMRSBQVUJMSUMgT04pCkBAIC0xMzQsNyArMTM0 LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1ZJREVPIFBVQkxJ QyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9WSURFT19UUkFD SyBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklF V19NT0RFX0NTU19NRURJQSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfV0VCX0FVRElPIFBVQkxJQyBPTikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9XRUJfUlRDIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJfUlRDIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCX1RJTUlORyBQVUJMSUMgT04pCiBXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCR0wgUFVCTElDIE9OKQogCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYTFjNjA2OTczMzY0YTE0NTY1MWRiODhh YTQyYjc4NzM3NDEzZDFlYy4uN2U0MDM4MmE3MmZiYmFhMzYwNjA1ZjE5NjQ5ZTEzMjczMjA5NTlm MCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTA2LTA1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKwor ICAgICAgICBbRUZMXSBTeW5jIEVGTCBmZWF0dXJlcyB3aXRoIGZlYXR1cmVMaXN0LnBtCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg0MTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBPcHRpb25zRWZs LCBzb21lIGZlYXR1cmVzIG9uL29mZiBzdGF0dXMgYXJlIGRpZmZlcmVudCB3aXRoCisgICAgICAg IGZlYXR1cmVMaXN0LnBtIGRlZmluaXRpb25zLiBTeW5jIHdpdGggaXQuCisKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxNi0wNi0wMyAgUGVyIEFybmUgVm9s bGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gSW5kZXhlZERCIHdvcmtl ciB0ZXN0cyBhcmUgZmFpbGluZy4K 280576 2016-06-05 20:42:33 -0700 2016-06-05 22:08:26 -0700 Patch bug-158410-20160606124356.patch text/plain 2691 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDQwYzA4 OGFiNmNlNGExOTIzNjUxYzlkZGQxOTA4ZGJhNTEyMThlMTAuLjU2ZGI5NmNhZmIxYTZhOWU5Nzkz YTVlOWNjN2NiNzA4MGY5ZWZjM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC04Miw3ICs4Miw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BVFRBQ0hNRU5UX0VM RU1FTlQgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9CQVRURVJZX1NUQVRVUyBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfQ1NTM19URVhUIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9DU1NfREVWSUNFX0FEQVBUQVRJT04gUFVCTElDIE9OKQotV0VCS0lU X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19HUklEX0xBWU9VVCBQVUJMSUMg T0ZGKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19HUklEX0xB WU9VVCBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf Q1NTX0lNQUdFX1NFVCBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfQ1NTX1JFR0lPTlMgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX0NTU19TQ1JPTExfU05BUCBQVUJMSUMgT0ZGKQpAQCAtMTA5LDcgKzEw OSw3IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MSU5LX1BSRUZF VENIIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9N RURJQV9DQVBUVVJFIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJDRSBQVUJMSUMgT04pCi1XRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBVQkxJQyBPTikK K1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9TVFJFQU0gUFVC TElDIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRU1PUllf U0FNUExFUiBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfTUhUTUwgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX01PVVNFX0NVUlNPUl9TQ0FMRSBQVUJMSUMgT04pCkBAIC0xMzQsNyArMTM0LDcgQEAgV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1ZJREVPIFBVQkxJQyBPTikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9WSURFT19UUkFDSyBQVUJMSUMg T04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklFV19NT0RFX0NT U19NRURJQSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfV0VCX0FVRElPIFBVQkxJQyBPTikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9XRUJfUlRDIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9XRUJfUlRDIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfV0VCX1RJTUlORyBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCR0wgUFVCTElDIE9OKQogCmRpZmYgLS1naXQgYS9DaGFu Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYTFjNjA2OTczMzY0YTE0NTY1MWRiODhhYTQyYjc4NzM3 NDEzZDFlYy4uN2U0MDM4MmE3MmZiYmFhMzYwNjA1ZjE5NjQ5ZTEzMjczMjA5NTlmMCAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2 LTA1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBb RUZMXSBTeW5jIEVGTCBmZWF0dXJlcyB3aXRoIGZlYXR1cmVMaXN0LnBtCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg0MTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBPcHRpb25zRWZsLCBzb21lIGZl YXR1cmVzIG9uL29mZiBzdGF0dXMgYXJlIGRpZmZlcmVudCB3aXRoCisgICAgICAgIGZlYXR1cmVM aXN0LnBtIGRlZmluaXRpb25zLiBTeW5jIHdpdGggaXQuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxNi0wNi0wMyAgUGVyIEFybmUgVm9sbGFuICA8cHZv bGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gSW5kZXhlZERCIHdvcmtlciB0ZXN0cyBh cmUgZmFpbGluZy4K