158393 2016-06-04 23:47:24 -0700 getUserMedia() exposed, but not functional 2019-09-24 17:30:42 -0700 1 1 1 Unclassified WebKit Media Safari Technology Preview Mac All RESOLVED FIXED InRadar P2 Major --- 1 info eric.carlson ap commit-queue daniele.tassone eric.carlson nekr.fabula simon.fraser webkit-bug-importer oldest_to_newest 1199346 0 info 2016-06-04 23:47:24 -0700 The getUserMedia() function is exposed, but when you try to use it, it just fails and calls the error callback. This breaks feature detection. navigator.getUserMedia({ video: true, audio: true }, function() { console.log('success', arguments) }, function() { console.log('error', arguments) }) => error – Arguments [ Error: NotAllowedError: DOM Exception 35 ] and: !!navigator.getUserMedia => true This is also a problem for HTML5test.com where Safari currently gets points for supporting getUserMedia, without actually deserving so. I hope this is an unfinished implementation that will be ready for the next release of Safari, but if not, it should not be exposed publicly. Otherwise I'm afraid I have to put this feature on a blacklist so that HTML5test.com won't show an inaccurate result. The same thing applies to the prefixed webkitGetUserMedia function. 1199390 1 eric.carlson 2016-06-05 10:42:49 -0700 (In reply to comment #0) > > This is also a problem for HTML5test.com where Safari currently gets points > for supporting getUserMedia, without actually deserving so. I hope this is > an unfinished implementation that will be ready for the next release of > Safari, but if not, it should not be exposed publicly. Otherwise I'm afraid > I have to put this feature on a blacklist so that HTML5test.com won't show > an inaccurate result. > > The same thing applies to the prefixed webkitGetUserMedia function. Are you testing with a WebKit nightly build, or with Safari Technology Preview? 1199395 2 info 2016-06-05 11:04:31 -0700 Safari Technical Preview 5 (this issue has been present since Preview 1) 1199396 3 info 2016-06-05 11:08:55 -0700 Bug is also visible in WebKit Nightly r201698. 1199397 4 webkit-bug-importer 2016-06-05 11:16:44 -0700 <rdar://problem/26642259> 1206813 5 282457 eric.carlson 2016-06-30 12:38:56 -0700 Created attachment 282457 Proposed patch. 1206816 6 commit-queue 2016-06-30 12:40:53 -0700 Attachment 282457 did not pass style-queue: ERROR: Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:41: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:43: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1206819 7 282457 dino 2016-06-30 12:57:23 -0700 Comment on attachment 282457 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=282457&action=review > Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:72 > #if ENABLE(MEDIA_STREAM) Maybe this should be #if ENABLE(MEDIA_STREAM) && PLATFORM(COCOA) ? 1206820 8 282457 dino 2016-06-30 12:57:57 -0700 Comment on attachment 282457 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=282457&action=review >> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:72 >> #if ENABLE(MEDIA_STREAM) > > Maybe this should be #if ENABLE(MEDIA_STREAM) && PLATFORM(COCOA) ? Oops. I meant !PLATFORM(COCOA) :) 1206833 9 282460 eric.carlson 2016-06-30 13:39:14 -0700 Created attachment 282460 Patch for landing. 1206854 10 282460 commit-queue 2016-06-30 14:20:52 -0700 Comment on attachment 282460 Patch for landing. Clearing flags on attachment: 282460 Committed r202704: <http://trac.webkit.org/changeset/202704> 1213344 11 info 2016-07-21 14:50:38 -0700 navigator.getUserMedia is no longer exposed in Safari Technology Preview 9. Not originally mentioned in this bug, but the new API for getUserMedia was also exposed in earlier versions. The patch that has landed did not fix that. In fact, navigator.mediaDevices.getUserMedia is still exposed in the latest Technology Preview. navigator.mediaDevices.getUserMedia({ audio: true, video: true }).catch(function(e) { console.log(e) }); => Error: NotAllowedError: DOM Exception 35 1573917 12 ap 2019-09-24 17:30:42 -0700 > Committed r202704: <http://trac.webkit.org/changeset/202704> Moving to RESOLVED since this landed. 282457 2016-06-30 12:38:56 -0700 2016-06-30 13:24:02 -0700 Proposed patch. disable_patch_1.txt text/plain 1756 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjY5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA2LTMwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIGdldFVzZXJNZWRpYSgp IGV4cG9zZWQsIGJ1dCBub3QgZnVuY3Rpb25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MzkzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjY0 MjI1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIFNldCBkZWZhdWx0IHZhbHVlIG9mIHRoZSBNZWRpYSBTdHJlYW0gcnVudGltZSBmbGFn IHRvIGZhbHNlIG9uIE1hYyBPUyBYIGFuZCBpT1MgdW50aWwgdGhlCisgICAgICAgIGJyb3dzZXIg c3VwcG9ydCBpcyBpbiBwbGFjZS4KKworICAgICAgICAqIGJpbmRpbmdzL2dlbmVyaWMvUnVudGlt ZUVuYWJsZWRGZWF0dXJlcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZl YXR1cmVzOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzKTogRGlzYWJsZSBtZWRpYSBzdHJlYW0gYnkg ZGVmYXVsdAorICAgICAgICBvbiBNYWMgT1MgWCBhbmQgaU9TLgorCiAyMDE2LTA2LTMwICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0aGUg bWFjT1MgU2llcnJhIFJlbGVhc2UgY29uZmlndXJhdGlvbiBhZnRlciByMjAyNjQyLgpJbmRleDog U291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVF bmFibGVkRmVhdHVyZXMuY3BwCShyZXZpc2lvbiAyMDI1NjkpCisrKyBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNyw2ICszNywxMiBAQAogI2luY2x1ZGUgIldlYlNvY2tldC5oIgogI2luY2x1ZGUgPHd0 Zi9OZXZlckRlc3Ryb3llZC5oPgogCisjaWYgUExBVEZPUk0oQ09DT0EpCisgICAgI2RlZmluZSBN RURJQV9TVFJFQU1fRU5BQkxFRCBmYWxzZQorI2Vsc2UKKyAgICAjZGVmaW5lIE1FRElBX1NUUkVB TV9FTkFCTEVEIHRydWUKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFJ1bnRpbWVF bmFibGVkRmVhdHVyZXM6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMoKQpAQCAtNjQsNyArNzAsNyBA QCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpSdW50aW1lRW5hYmxlZEZlCiAgICAgLCBtX2lzSW5k ZXhlZERCV29ya2Vyc0VuYWJsZWQodHJ1ZSkKICNlbmRpZgogI2lmIEVOQUJMRShNRURJQV9TVFJF QU0pCi0gICAgLCBtX2lzTWVkaWFTdHJlYW1FbmFibGVkKHRydWUpCisgICAgLCBtX2lzTWVkaWFT dHJlYW1FbmFibGVkKE1FRElBX1NUUkVBTV9FTkFCTEVEKQogI2VuZGlmCiAjaWYgRU5BQkxFKFdF Ql9SVEMpCiAgICAgLCBtX2lzUGVlckNvbm5lY3Rpb25FbmFibGVkKHRydWUpCg== 282460 2016-06-30 13:39:14 -0700 2016-06-30 14:20:52 -0700 Patch for landing. disable_patch_2.txt text/plain 2106 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjY5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA2LTMwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIGdldFVzZXJNZWRpYSgp IGV4cG9zZWQsIGJ1dCBub3QgZnVuY3Rpb25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MzkzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjY0 MjI1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBEZWFuIEphY2tzb24uCisgICAgICAgIAorICAg ICAgICBTZXQgZGVmYXVsdCB2YWx1ZSBvZiB0aGUgTWVkaWEgU3RyZWFtIHJ1bnRpbWUgZmxhZyB0 byBmYWxzZSBvbiBNYWMgT1MgWCBhbmQgaU9TIHVudGlsIHRoZQorICAgICAgICBicm93c2VyIHN1 cHBvcnQgaXMgaW4gcGxhY2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVF bmFibGVkRmVhdHVyZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0 dXJlczo6UnVudGltZUVuYWJsZWRGZWF0dXJlcyk6IERpc2FibGUgbWVkaWEgc3RyZWFtIGJ5IGRl ZmF1bHQKKyAgICAgICAgb24gTWFjIE9TIFggYW5kIGlPUy4KKyAgICAgICAgKiBiaW5kaW5ncy9n ZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaDoKKwogMjAxNi0wNi0zMCAgQnJpYW4gQnVy ZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggdGhlIG1hY09T IFNpZXJyYSBSZWxlYXNlIGNvbmZpZ3VyYXRpb24gYWZ0ZXIgcjIwMjY0Mi4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxl ZEZlYXR1cmVzLmNwcAkocmV2aXNpb24gMjAyNTY5KQorKysgU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjMsOCArNjMsOCBAQCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpSdW50aW1lRW5hYmxlZEZlCiAj aWYgRU5BQkxFKElOREVYRURfREFUQUJBU0VfSU5fV09SS0VSUykKICAgICAsIG1faXNJbmRleGVk REJXb3JrZXJzRW5hYmxlZCh0cnVlKQogI2VuZGlmCi0jaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkK LSAgICAsIG1faXNNZWRpYVN0cmVhbUVuYWJsZWQodHJ1ZSkKKyNpZiBFTkFCTEUoTUVESUFfU1RS RUFNKSAmJiBQTEFURk9STShDT0NPQSkKKyAgICAsIG1faXNNZWRpYVN0cmVhbUVuYWJsZWQoZmFs c2UpCiAjZW5kaWYKICNpZiBFTkFCTEUoV0VCX1JUQykKICAgICAsIG1faXNQZWVyQ29ubmVjdGlv bkVuYWJsZWQodHJ1ZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVu dGltZUVuYWJsZWRGZWF0dXJlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCShyZXZpc2lvbiAyMDI1NjkpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMu aAkod29ya2luZyBjb3B5KQpAQCAtMjU2LDcgKzI1Niw3IEBAIHByaXZhdGU6CiAjZW5kaWYKIAog I2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCi0gICAgYm9vbCBtX2lzTWVkaWFTdHJlYW1FbmFibGVk OworICAgIGJvb2wgbV9pc01lZGlhU3RyZWFtRW5hYmxlZCB7IHRydWUgfTsKICNlbmRpZgogI2lm IEVOQUJMRShXRUJfUlRDKQogICAgIGJvb2wgbV9pc1BlZXJDb25uZWN0aW9uRW5hYmxlZDsK