158392 2016-06-04 21:55:38 -0700 REGRESSION (r201686): Web Inspector: Fix typo causing an internal error 2016-06-05 08:21:47 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1199340 0 mattbaker 2016-06-04 21:55:38 -0700 * SUMMARY Web Inspector: Fix typo causing an internal error. "this._heapAllocations"should be "this._heapAllocationsTimeline". * STEPS TO REPRODUCE 1. Open Inspector > Timelines tab 2. Open Inspector² => TypeError:​ undefined is not an object (evaluating 'this._heapAllocations.recordsInTimeRange')​ (at HeapAllocationsTimelineOverviewGraph.js:​60:​51) Broke in https://trac.webkit.org/changeset/201686. 1199341 1 webkit-bug-importer 2016-06-04 21:55:53 -0700 <rdar://problem/26640467> 1199342 2 280543 mattbaker 2016-06-04 22:00:43 -0700 Created attachment 280543 [Patch] Proposed Fix 1199344 3 joepeck 2016-06-04 23:11:10 -0700 You could land something like this without review. 1199371 4 280543 commit-queue 2016-06-05 08:21:41 -0700 Comment on attachment 280543 [Patch] Proposed Fix Clearing flags on attachment: 280543 Committed r201698: <http://trac.webkit.org/changeset/201698> 1199372 5 commit-queue 2016-06-05 08:21:47 -0700 All reviewed patches have been landed. Closing bug. 280543 2016-06-04 22:00:43 -0700 2016-06-05 08:21:41 -0700 [Patch] Proposed Fix bug-158392-20160604220205.patch text/plain 1705 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm YjljZmM0YmYxZTkyMjhmNjhkODY4NGY4ZjI0MGU3ZWU0ZmM0YWM3Li4wNjM3NmY5ZDQ3NjlhMjI4 MTNiMTQyMWM0MDQ3MDk0ODNjZjA3NzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0wNi0wNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIwMTY4Nik6IFdlYiBJbnNwZWN0b3I6IEZpeCB0eXBv IGNhdXNpbmcgYW4gaW50ZXJuYWwgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1ODM5MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY2NDA0 Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5q czoKKyAgICAgICAgRml4ZWQgdHlwby4KKwogMjAxNi0wNi0wNCAgQnJpYW4gQnVyZyAgPGJidXJn QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgYSBrZXlib2FyZCBzaG9y dGN1dCB0byBvcGVuIHRoZSBuZXcgdGFiIHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVPdmVydmll d0dyYXBoLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVh cEFsbG9jYXRpb25zVGltZWxpbmVPdmVydmlld0dyYXBoLmpzCmluZGV4IGJiNWMyZTQyY2ZiZDM0 MzRkMzFlY2MzMjI3ZDVlNzI5MTVlYWM4MWIuLjBhOTcxZGU2NDc3ZWMwMTRiNWVmMDUwMThkY2Ri NTRlZWQ0NWJmNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNU aW1lbGluZU92ZXJ2aWV3R3JhcGguanMKQEAgLTU3LDcgKzU3LDcgQEAgV2ViSW5zcGVjdG9yLkhl YXBBbGxvY2F0aW9uc1RpbWVsaW5lT3ZlcnZpZXdHcmFwaCA9IGNsYXNzIEhlYXBBbGxvY2F0aW9u c1RpbWVsaW4KICAgICAgICAgdGhpcy5fc2VsZWN0ZWRJbWFnZUVsZW1lbnQgPSBudWxsOwogCiAg ICAgICAgIC8vIFRoaXMgbWF5IGRpc3BsYXkgcmVjb3JkcyBwYXN0IHRoZSBjdXJyZW50IHRpbWUg bWFya2VyLgotICAgICAgICBsZXQgdmlzaWJsZVJlY29yZHMgPSB0aGlzLl9oZWFwQWxsb2NhdGlv bnMucmVjb3Jkc0luVGltZVJhbmdlKHRoaXMuc3RhcnRUaW1lLCB0aGlzLmVuZFRpbWUpOworICAg ICAgICBsZXQgdmlzaWJsZVJlY29yZHMgPSB0aGlzLl9oZWFwQWxsb2NhdGlvbnNUaW1lbGluZS5y ZWNvcmRzSW5UaW1lUmFuZ2UodGhpcy5zdGFydFRpbWUsIHRoaXMuZW5kVGltZSk7CiAgICAgICAg IGlmICghdmlzaWJsZVJlY29yZHMubGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuOwogCg==