158380 2016-06-04 10:16:04 -0700 Avoid redundant isUndefined() check for parameters that are both optional and nullable in overloads 2016-06-04 12:09:06 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez cgarcia commit-queue darin oldest_to_newest 1199238 0 cdumez 2016-06-04 10:16:04 -0700 Avoid redundant isUndefined() check for parameters that are both optional and nullable in overloads. 1199239 1 280517 cdumez 2016-06-04 10:16:41 -0700 Created attachment 280517 Patch 1199251 2 280517 commit-queue 2016-06-04 12:09:01 -0700 Comment on attachment 280517 Patch Clearing flags on attachment: 280517 Committed r201681: <http://trac.webkit.org/changeset/201681> 1199252 3 commit-queue 2016-06-04 12:09:06 -0700 All reviewed patches have been landed. Closing bug. 280517 2016-06-04 10:16:41 -0700 2016-06-04 12:09:01 -0700 Patch bug-158380-20160604101811.patch text/plain 3834 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRkMzRmNWYyMGFjN2Zk OTE4OGY5MmZlNTUxN2MxYjk2ODQzM2QxMy4uMmM5N2U0NzM1ZGNlMWM0NGZjNGY2OTBkOWU2MDQ4 MjljZWI1NzdmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgcmVkdW5kYW50IGlz VW5kZWZpbmVkKCkgY2hlY2sgZm9yIHBhcmFtZXRlcnMgdGhhdCBhcmUgYm90aCBvcHRpb25hbCBh bmQgbnVsbGFibGUgaW4gb3ZlcmxvYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTgzODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgor ICAgICAgICAoR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2tFeHByZXNzaW9uKToKKyAgICAgICAgKiBi aW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uT3ZlcmxvYWRlZE1ldGhvZFdpdGhPcHRpb25hbFBh cmFtZXRlcik6CisKIDIwMTYtMDYtMDQgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5j b20+CiAKICAgICAgICAgQ1NQOiBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBkaXJlY3RpdmUsIHVw Z3JhZGUtaW5zZWN1cmUtcmVxdWVzdHMgKFVJUikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggOGZlYzNkZWZiYjcyYjAwYWEy NTVhODcxNzE3NTE0Njc2MGRlZmQwYS4uZjNkYzk1MjQxYTc4OTI4NTQzYjhmNjA5NjM3MzM3Zjc1 MGM4MmE5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9ySlMucG0KQEAgLTE2ODUsMTAgKzE2ODUsMTIgQEAgc3ViIEdlbmVyYXRlUGFyYW1l dGVyc0NoZWNrRXhwcmVzc2lvbgogICAgICAgICAgICAgJHVzZWRBcmd1bWVudHN7JHBhcmFtZXRl ckluZGV4fSA9IDE7CiAgICAgICAgIH0gZWxzaWYgKCRjb2RlR2VuZXJhdG9yLT5HZXRBcnJheU9y U2VxdWVuY2VUeXBlKCR0eXBlKSB8fCAkY29kZUdlbmVyYXRvci0+SXNUeXBlZEFycmF5VHlwZSgk dHlwZSkgfHwgJGNvZGVHZW5lcmF0b3ItPklzV3JhcHBlclR5cGUoJHR5cGUpKSB7CiAgICAgICAg ICAgICBteSAkY29uZGl0aW9uID0gIiI7Ci0gICAgICAgICAgICAkY29uZGl0aW9uIC49ICIke3Zh bHVlfS5pc1VuZGVmaW5lZCgpIHx8ICIgaWYgJHBhcmFtZXRlci0+aXNPcHRpb25hbDsKIAotICAg ICAgICAgICAgIyBodHRwOi8vaGV5Y2FtLmdpdGh1Yi5pby93ZWJpZGwvI2VzLW51bGxhYmxlLXR5 cGUKLSAgICAgICAgICAgICRjb25kaXRpb24gLj0gIiR7dmFsdWV9LmlzVW5kZWZpbmVkT3JOdWxs KCkgfHwgIiBpZiAkcGFyYW1ldGVyLT5pc051bGxhYmxlOworICAgICAgICAgICAgaWYgKCRwYXJh bWV0ZXItPmlzTnVsbGFibGUpIHsKKyAgICAgICAgICAgICAgICAkY29uZGl0aW9uIC49ICIke3Zh bHVlfS5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8ICI7CisgICAgICAgICAgICB9IGVsc2lmICgkcGFy YW1ldGVyLT5pc09wdGlvbmFsKSB7CisgICAgICAgICAgICAgICAgJGNvbmRpdGlvbiAuPSAiJHt2 YWx1ZX0uaXNVbmRlZmluZWQoKSB8fCAiOworICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBp ZiAoJGNvZGVHZW5lcmF0b3ItPkdldEFycmF5T3JTZXF1ZW5jZVR5cGUoJHR5cGUpKSB7CiAgICAg ICAgICAgICAgICAgIyBGSVhNRTogQWRkIHByb3BlciBzdXBwb3J0IGZvciBUW10sIFRbXT8sIHNl cXVlbmNlPFQ+LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0pTL0pTVGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvSlMvSlNUZXN0T2JqLmNwcAppbmRleCAwOTg0YzdjZmMwMjNkYWY3N2QxY2JmNGNlYmFhYjQ4 MjM3ZTM5ODU5Li5hMGJjOWRiMjhhYTU5MWIwZjQ3MDMyOTNiM2I4NWZkNzIyMTE3MzMzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2Jq LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0 T2JqLmNwcApAQCAtNTQ2Nyw3ICs1NDY3LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBqc1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvbk92ZXJsb2FkZWRNZXRob2RXaXRoT3B0aW8KICAg ICBzaXplX3QgYXJnc0NvdW50ID0gc3RkOjptaW48c2l6ZV90PigyLCBzdGF0ZS0+YXJndW1lbnRD b3VudCgpKTsKICAgICBKU1ZhbHVlIGFyZzAoc3RhdGUtPmFyZ3VtZW50KDApKTsKICAgICBKU1Zh bHVlIGFyZzEoc3RhdGUtPmFyZ3VtZW50KDEpKTsKLSAgICBpZiAoKGFyZ3NDb3VudCA9PSAxICYm IChhcmcwLmlzVW5kZWZpbmVkT3JOdWxsKCkgfHwgKGFyZzAuaXNPYmplY3QoKSAmJiBhc09iamVj dChhcmcwKS0+aW5oZXJpdHMoSlNUZXN0T2JqOjppbmZvKCkpKSkpIHx8IChhcmdzQ291bnQgPT0g MiAmJiAoYXJnMC5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8IChhcmcwLmlzT2JqZWN0KCkgJiYgYXNP YmplY3QoYXJnMCktPmluaGVyaXRzKEpTVGVzdE9iajo6aW5mbygpKSkpICYmIChhcmcxLmlzVW5k ZWZpbmVkKCkgfHwgYXJnMS5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8IChhcmcxLmlzT2JqZWN0KCkg JiYgYXNPYmplY3QoYXJnMSktPmluaGVyaXRzKEpTVGVzdE9iajo6aW5mbygpKSkpKSkKKyAgICBp ZiAoKGFyZ3NDb3VudCA9PSAxICYmIChhcmcwLmlzVW5kZWZpbmVkT3JOdWxsKCkgfHwgKGFyZzAu aXNPYmplY3QoKSAmJiBhc09iamVjdChhcmcwKS0+aW5oZXJpdHMoSlNUZXN0T2JqOjppbmZvKCkp KSkpIHx8IChhcmdzQ291bnQgPT0gMiAmJiAoYXJnMC5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8IChh cmcwLmlzT2JqZWN0KCkgJiYgYXNPYmplY3QoYXJnMCktPmluaGVyaXRzKEpTVGVzdE9iajo6aW5m bygpKSkpICYmIChhcmcxLmlzVW5kZWZpbmVkT3JOdWxsKCkgfHwgKGFyZzEuaXNPYmplY3QoKSAm JiBhc09iamVjdChhcmcxKS0+aW5oZXJpdHMoSlNUZXN0T2JqOjppbmZvKCkpKSkpKQogICAgICAg ICByZXR1cm4ganNUZXN0T2JqUHJvdG90eXBlRnVuY3Rpb25PdmVybG9hZGVkTWV0aG9kV2l0aE9w dGlvbmFsUGFyYW1ldGVyMShzdGF0ZSk7CiAgICAgaWYgKChhcmdzQ291bnQgPT0gMSAmJiAoYXJn MC5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8IChhcmcwLmlzT2JqZWN0KCkgJiYgYXNPYmplY3QoYXJn MCktPmluaGVyaXRzKEpTVGVzdE9iajo6aW5mbygpKSkpKSB8fCAoYXJnc0NvdW50ID09IDIgJiYg KGFyZzAuaXNVbmRlZmluZWRPck51bGwoKSB8fCAoYXJnMC5pc09iamVjdCgpICYmIGFzT2JqZWN0 KGFyZzApLT5pbmhlcml0cyhKU1Rlc3RPYmo6OmluZm8oKSkpKSkpCiAgICAgICAgIHJldHVybiBq c1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvbk92ZXJsb2FkZWRNZXRob2RXaXRoT3B0aW9uYWxQYXJh bWV0ZXIyKHN0YXRlKTsK