158377 2016-06-03 20:30:08 -0700 REGRESSION (r201474): Should set overflow: hidden on -webkit-media-controls when placeholder is showing 2016-06-04 17:36:28 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan oldest_to_newest 1199212 0 adachan 2016-06-03 20:30:08 -0700 We added script to specify overflow: hidden on -webkit-media-controls when the placeholder is showing in r201355 but that code needs to update after r201474. After r201474, we defer removing the hidden class from inlinePlaybackPlaceholder until showInlinePlaybackPlaceholderWhenSafe(). We also need to move the code that adds the placeholder-showing class to -webkit-media-controls to that method. <rdar://problem/26633830> 1199219 1 280508 adachan 2016-06-03 21:38:18 -0700 Created attachment 280508 Patch 1199327 2 adachan 2016-06-04 17:36:28 -0700 Committed: http://trac.webkit.org/changeset/201691 280508 2016-06-03 21:38:18 -0700 2016-06-04 13:37:28 -0700 Patch bug-158377-20160603213939.patch text/plain 3320 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU0MGFiNjJkYjlhZjMx ZmNlMjg3NTJhNzBjZmM1ODBhOGU2MmM4Ni4uYWY0YjZhOGY1ZDVkZTBiOTJiZGIwZTI4NDkzNjU3 NGZlMmI1NWU4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA2LTAzICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDE0NzQp OiBTaG91bGQgc2V0IG92ZXJmbG93OiBoaWRkZW4gb24gLXdlYmtpdC1tZWRpYS1jb250cm9scyB3 aGVuIHBsYWNlaG9sZGVyIGlzIHNob3dpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1ODM3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluIHIyMDE0NzQsIHdlIGRlZmVyIHJlbW92aW5nIHRoZSBoaWRk ZW4gY2xhc3MgZnJvbSBpbmxpbmVQbGF5YmFja1BsYWNlaG9sZGVyIHVudGlsCisgICAgICAgIHNo b3dJbmxpbmVQbGF5YmFja1BsYWNlaG9sZGVyV2hlblNhZmUoKS4gV2UgYWxzbyBuZWVkIHRvIG1v dmUgdGhlIGNvZGUgdGhhdCBhZGRzIHRoZQorICAgICAgICBwbGFjZWhvbGRlci1zaG93aW5nIGNs YXNzIHRvIC13ZWJraXQtbWVkaWEtY29udHJvbHMgdG8gdGhhdCBtZXRob2QuCisKKyAgICAgICAg KiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzOgorICAgICAgICAo Q29udHJvbGxlci5wcm90b3R5cGUuc2hvd0lubGluZVBsYXliYWNrUGxhY2Vob2xkZXJXaGVuU2Fm ZSk6CisgICAgICAgIEFkZCB0aGUgInBsYWNlaG9sZGVyLXNob3dpbmciIGNsYXNzIHRvIC13ZWJr aXQtbWVkaWEtY29udHJvbHMgd2hlbiB3ZSBzaG93IHRoZSBwbGFjZWhvbGRlci4KKyAgICAgICAg KENvbnRyb2xsZXIucHJvdG90eXBlLmhhbmRsZVByZXNlbnRhdGlvbk1vZGVDaGFuZ2UpOgorICAg ICAgICBSZW1vdmUgdGhlICJwbGFjZWhvbGRlci1zaG93aW5nIiBjbGFzcyBmcm9tIC13ZWJraXQt bWVkaWEtY29udHJvbHMgd2hlbiB3ZSBoaWRlIHRoZQorICAgICAgICBwbGFjZWhvbGRlci4gUmVt b3ZlIHRoZSBvbGQgY29kZSB0aGF0IGFkZHMgYW5kIHJlbW92ZXMgdGhhdCBjbGFzcy4KKwogMjAx Ni0wNi0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDcmFz aCB1bmRlciBWaXNpYmxlU2VsZWN0aW9uOjpmaXJzdFJhbmdlKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpz CmluZGV4IDA2MWFhOTU0MmU2NTRjNjY4NjQyZjNmOTNmZWFlZjc0MDBlNTBjNDMuLjZjYzRjZGI1 NWRjNWEwMzAwY2EwNTdmZDdjY2ZhNjJmM2ZjZjM4ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwpA QCAtODQyLDkgKzg0MiwxMCBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYg KHRoaXMucHJlc2VudGF0aW9uTW9kZSgpICE9ICdwaWN0dXJlLWluLXBpY3R1cmUnKQogICAgICAg ICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmICghdGhpcy5ob3N0LmlzVmlkZW9MYXllcklubGlu ZSkKKyAgICAgICAgaWYgKCF0aGlzLmhvc3QuaXNWaWRlb0xheWVySW5saW5lKSB7CiAgICAgICAg ICAgICB0aGlzLmNvbnRyb2xzLmlubGluZVBsYXliYWNrUGxhY2Vob2xkZXIuY2xhc3NMaXN0LnJl bW92ZSh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsKLSAgICAgICAgZWxzZQorICAgICAgICAgICAg dGhpcy5iYXNlLmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05hbWVzLnBsYWNlaG9sZGVyU2hvd2lu Zyk7CisgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgc2V0VGltZW91dCh0aGlzLnNob3dJbmxp bmVQbGF5YmFja1BsYWNlaG9sZGVyV2hlblNhZmUuYmluZCh0aGlzKSwgdGhpcy5QbGFjZWhvbGRl clBvbGxpbmdEZWxheSk7CiAgICAgfSwKIApAQCAtODU5LDYgKzg2MCw3IEBAIENvbnRyb2xsZXIu cHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMuaW5saW5lUGxheWJh Y2tQbGFjZWhvbGRlci5jbGFzc0xpc3QucmVtb3ZlKHRoaXMuQ2xhc3NOYW1lcy5waWN0dXJlSW5Q aWN0dXJlKTsKICAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLmlubGluZVBsYXliYWNrUGxh Y2Vob2xkZXJUZXh0VG9wLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLnBpY3R1cmVJ blBpY3R1cmUpOwogICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMuaW5saW5lUGxheWJhY2tQ bGFjZWhvbGRlclRleHRCb3R0b20uY2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFtZXMucGlj dHVyZUluUGljdHVyZSk7CisgICAgICAgICAgICAgICAgdGhpcy5iYXNlLmNsYXNzTGlzdC5yZW1v dmUodGhpcy5DbGFzc05hbWVzLnBsYWNlaG9sZGVyU2hvd2luZyk7CiAKICAgICAgICAgICAgICAg ICB0aGlzLmNvbnRyb2xzLnBpY3R1cmVJblBpY3R1cmVCdXR0b24uY2xhc3NMaXN0LnJlbW92ZSh0 aGlzLkNsYXNzTmFtZXMucmV0dXJuRnJvbVBpY3R1cmVJblBpY3R1cmUpOwogICAgICAgICAgICAg ICAgIGJyZWFrOwpAQCAtODg0LDExICs4ODYsNiBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCi0gICAgICAgIGlmICh0aGlzLmNv bnRyb2xzLmlubGluZVBsYXliYWNrUGxhY2Vob2xkZXIuY2xhc3NMaXN0LmNvbnRhaW5zKHRoaXMu Q2xhc3NOYW1lcy5oaWRkZW4pKQotICAgICAgICAgICAgdGhpcy5iYXNlLmNsYXNzTGlzdC5yZW1v dmUodGhpcy5DbGFzc05hbWVzLnBsYWNlaG9sZGVyU2hvd2luZyk7Ci0gICAgICAgIGVsc2UKLSAg ICAgICAgICAgIHRoaXMuYmFzZS5jbGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5wbGFjZWhv bGRlclNob3dpbmcpOwotCiAgICAgICAgIHRoaXMudXBkYXRlQ29udHJvbHMoKTsKICAgICAgICAg dGhpcy51cGRhdGVDYXB0aW9uQ29udGFpbmVyKCk7CiAgICAgICAgIHRoaXMucmVzZXRIaWRlQ29u dHJvbHNUaW1lcigpOwo=