158356 2016-06-03 14:15:20 -0700 Give RuleFeatures::classesMatchingAncestors some inline capacity. 2016-06-05 08:18:46 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue koivisto oldest_to_newest 1199027 0 kling 2016-06-03 14:15:20 -0700 There are about 362K Vector<AtomicStringImpl*> backing stores getting allocated and freed on a run of PLUM, in the RuleFeatures::classesMatchingAncestors vector. Since RuleFeatures is only ever stack-allocated, we can avoid most/all of this by giving it some inline capacity. 1199028 1 280463 kling 2016-06-03 14:15:54 -0700 Created attachment 280463 Patch 1199369 2 280463 commit-queue 2016-06-05 08:18:42 -0700 Comment on attachment 280463 Patch Clearing flags on attachment: 280463 Committed r201697: <http://trac.webkit.org/changeset/201697> 1199370 3 commit-queue 2016-06-05 08:18:46 -0700 All reviewed patches have been landed. Closing bug. 280463 2016-06-03 14:15:54 -0700 2016-06-05 08:18:42 -0700 Patch bug-158356.diff text/plain 1410 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MDU3Yzg5Li40N2Y1OTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTYtMDYtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEdpdmUgUnVsZUZlYXR1cmVzOjpjbGFzc2VzTWF0Y2hpbmdBbmNlc3RvcnMgc29tZSBpbmxp bmUgY2FwYWNpdHkuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTgzNTY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgMzYyJzAw MCBoZWFwIGFsbG9jYXRpb25zIG9uIFBMVU0gKDEuMyUgb2YgYWxsIHRyYW5zaWVudCBmYXN0TWFs bG9jcykgYnkgZ2l2aW5nCisgICAgICAgIFJ1bGVGZWF0dXJlczo6Y2xhc3Nlc01hdGNoaW5nQW5j ZXN0b3JzIHNvbWUgaW5saW5lIGNhcGFjaXR5ICgzMikuCisgICAgICAgIFRoaXMgY2xhc3MgaXMg b25seSBldmVyIGFsbG9jYXRlZCBvbiB0aGUgc3RhY2sgYW55d2F5LgorCisgICAgICAgICogY3Nz L1J1bGVGZWF0dXJlLmg6CisKIDIwMTYtMDYtMDMgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWZsZWN0aW9uIG9mIGVsZW1lbnQgZG9lcyBub3QgcmVzcGVj dCBiYWNrZHJvcC1maWx0ZXIgcHJvcGVydHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9SdWxlRmVhdHVyZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVGZWF0dXJlLmgKaW5kZXgg MTFiZDgxNC4uOTA2ZWY1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVGZWF0 dXJlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVGZWF0dXJlLmgKQEAgLTc0LDcgKzc0 LDcgQEAgc3RydWN0IFJ1bGVGZWF0dXJlU2V0IHsKIHByaXZhdGU6CiAgICAgc3RydWN0IFNlbGVj dG9yRmVhdHVyZXMgewogICAgICAgICBib29sIGhhc1NpYmxpbmdTZWxlY3RvciB7IGZhbHNlIH07 Ci0gICAgICAgIFZlY3RvcjxBdG9taWNTdHJpbmdJbXBsKj4gY2xhc3Nlc01hdGNoaW5nQW5jZXN0 b3JzOworICAgICAgICBWZWN0b3I8QXRvbWljU3RyaW5nSW1wbCosIDMyPiBjbGFzc2VzTWF0Y2hp bmdBbmNlc3RvcnM7CiAgICAgICAgIFZlY3Rvcjxjb25zdCBDU1NTZWxlY3Rvcio+IGF0dHJpYnV0 ZVNlbGVjdG9yc01hdGNoaW5nQW5jZXN0b3JzOwogICAgIH07CiAgICAgdm9pZCByZWN1cnNpdmVs eUNvbGxlY3RGZWF0dXJlc0Zyb21TZWxlY3RvcihTZWxlY3RvckZlYXR1cmVzJiwgY29uc3QgQ1NT U2VsZWN0b3ImLCBib29sIG1hdGNoZXNBbmNlc3RvciA9IGZhbHNlKTsK