158349 2016-06-03 11:02:17 -0700 ARMv7 vstm and vldm instructions can only operate on a maximum of 16 registers. 2016-06-03 11:41:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1198967 0 mark.lam 2016-06-03 11:02:17 -0700 According to the ARM Assembler Reference, the vstm and vldm instructions can only operate on a maximum of 16 registers. See http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0002a/ch01s03s02.html and http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0002a/ch01s03s02.html. The ARMv7 probe code was wrongly using these instructions to store and load all 32 'd' registers. 1198988 1 280448 mark.lam 2016-06-03 11:35:36 -0700 Created attachment 280448 proposed patch. 1198990 2 mark.lam 2016-06-03 11:41:28 -0700 Thanks for the review. Landed in r201651: <http://trac.webkit.org/r201651>. 280448 2016-06-03 11:35:36 -0700 2016-06-03 11:37:06 -0700 proposed patch. bug-158349.patch text/plain 2206 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxNjQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTA2LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB Uk12NyB2c3RtIGFuZCB2bGRtIGluc3RydWN0aW9ucyBjYW4gb25seSBvcGVyYXRlIG9uIGEgbWF4 aW11bSBvZiAxNiByZWdpc3RlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTgzNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBY2NvcmRpbmcgdG8gdGhlIEFSTSBBc3NlbWJsZXIgUmVmZXJlbmNlLCB0 aGUgdnN0bSBhbmQgdmxkbSBpbnN0cnVjdGlvbnMgY2FuIG9ubHkKKyAgICAgICAgb3BlcmF0ZSBv biBhIG1heGltdW0gb2YgMTYgcmVnaXN0ZXJzLiAgU2VlCisgICAgICAgIGh0dHA6Ly9pbmZvY2Vu dGVyLmFybS5jb20vaGVscC9pbmRleC5qc3A/dG9waWM9L2NvbS5hcm0uZG9jLmRodDAwMDJhL2No MDFzMDNzMDIuaHRtbAorICAgICAgICBhbmQgaHR0cDovL2luZm9jZW50ZXIuYXJtLmNvbS9oZWxw L2luZGV4LmpzcD90b3BpYz0vY29tLmFybS5kb2MuZGh0MDAwMmEvY2gwMXMwM3MwMi5odG1sLgor CisgICAgICAgIFRoZSBBUk12NyBwcm9iZSBjb2RlIHdhcyB3cm9uZ2x5IHVzaW5nIHRoZXNlIGlu c3RydWN0aW9ucyB0byBzdG9yZSBhbmQgbG9hZCBhbGwKKyAgICAgICAgMzIgJ2QnIHJlZ2lzdGVy cy4gIFRoaXMgaXMgbm93IGZpeGVkLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNdjcuY3BwOgorCiAyMDE2LTA2LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBHYXJkZW5pbmc6IENMT09QIGJ1aWxkIGZpeCAobmVlZHMgYSAjaW5jbHVk ZSkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNdjcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk12Ny5jcHAJKHJldmlzaW9uIDIwMTY0NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIyNCw3ICsyMjQsOCBAQCBhc20gKAogICAgICJsZHIgICAgICAgbHIsIFtzcCwgIyIg U1RSSU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9QQ19PRkZTRVQpICJdIiAiXG4iCiAKICAgICAi YWRkICAgICAgIGlwLCBzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9EMF9PRkZT RVQpICJcbiIKLSAgICAidnN0bWlhLjY0IGlwLCB7IGQwLWQzMSB9IiAiXG4iCisgICAgInZzdG1p YS42NCBpcCEsIHsgZDAtZDE1IH0iICJcbiIKKyAgICAidnN0bWlhLjY0IGlwISwgeyBkMTYtZDMx IH0iICJcbiIKIAogICAgICJtb3YgICAgICAgZnAsIHNwIiAiXG4iIC8vIFNhdmUgdGhlIFByb2Jl Q29udGV4dCouCiAKQEAgLTIzOCw3ICsyMzksOSBAQCBhc20gKAogICAgIC8vIG91dCBvZiB0aGUg UHJvYmVDb250ZXh0IGJlZm9yZSByZXR1cm5pbmcuCiAKICAgICAiYWRkICAgICAgIGlwLCBzcCwg IyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBST0JFX0NQVV9EMzFfT0ZGU0VUICsgRlBSRUdfU0laRSkg IlxuIgotICAgICJ2bGRtZGIuNjQgaXAhLCB7IGQwLWQzMSB9IiAiXG4iCisgICAgInZsZG1kYi42 NCBpcCEsIHsgZDE2LWQzMSB9IiAiXG4iCisgICAgInZsZG1kYi42NCBpcCEsIHsgZDAtZDE1IH0i ICJcbiIKKwogICAgICJhZGQgICAgICAgaXAsIHNwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJP QkVfQ1BVX1IxMV9PRkZTRVQgKyBHUFJFR19TSVpFKSAiXG4iCiAgICAgImxkbWRiICAgICBpcCwg eyByMC1yMTEgfSIgIlxuIgogICAgICJsZHIgICAgICAgaXAsIFtzcCwgIyIgU1RSSU5HSVpFX1ZB TFVFX09GKFBST0JFX0NQVV9GUFNDUl9PRkZTRVQpICJdIiAiXG4iCg==