158347 2016-06-03 08:00:05 -0700 Fix the !ENABLE(SHADOW_DOM) && !ENABLE(DETAILS_ELEMENT) build 2016-06-06 13:18:15 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned cdumez commit-queue esprehn+autocc kangil.han ossy oldest_to_newest 1198925 0 ossy 2016-06-03 08:00:05 -0700 build log: In file included from /usr/include/c++/5/ratio:38:0, from /usr/include/c++/5/chrono:38, from ../../Source/WTF/wtf/StdLibExtras.h:30, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/dom/ContainerNode.cpp:23: /usr/include/c++/5/type_traits: In instantiation of 'struct std::is_base_of<WebCore::Node, WebCore::HTMLSlotElement>': ../../Source/WTF/wtf/TypeCasts.h:59:79: required from 'bool WTF::is(ArgType&) [with ExpectedType = WebCore::HTMLSlotElement; ArgType = WebCore::Node]' ../../Source/WebCore/dom/ContainerNode.cpp:103:91: required from here /usr/include/c++/5/type_traits:1459:12: error: invalid use of incomplete type 'class WebCore::HTMLSlotElement' In file included from ../../Source/WebCore/dom/ContainerNode.h:29:0, from ../../Source/WebCore/dom/ContainerNode.cpp:24: ../../Source/WebCore/dom/Node.h:49:7: note: forward declaration of 'class WebCore::HTMLSlotElement' In file included from ../../Source/WTF/wtf/Ref.h:33:0, from ../../Source/WTF/wtf/PassRefPtr.h:25, from ../../Source/WTF/wtf/RefPtr.h:30, from ../../Source/WebCore/dom/RegisteredEventListener.h:28, from ../../Source/WebCore/dom/EventListenerMap.h:36, from ../../Source/WebCore/dom/EventTarget.h:34, from ../../Source/WebCore/dom/Node.h:28, from ../../Source/WebCore/dom/ContainerNode.h:29, from ../../Source/WebCore/dom/ContainerNode.cpp:24: ../../Source/WTF/wtf/TypeCasts.h: In instantiation of 'bool WTF::is(ArgType&) [with ExpectedType = WebCore::HTMLSlotElement; ArgType = WebCore::Node]': ../../Source/WebCore/dom/ContainerNode.cpp:103:91: required from here ../../Source/WTF/wtf/TypeCasts.h:59:79: error: 'value' is not a member of 'std::is_base_of<WebCore::Node, WebCore::HTMLSlotElement>' HTMLSlotElement has ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT) guards, we should guard all of its uses. 1198927 1 280443 ossy 2016-06-03 08:02:26 -0700 Created attachment 280443 Patch 1198937 2 280443 cdumez 2016-06-03 08:52:31 -0700 Comment on attachment 280443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280443&action=review > Source/WebCore/dom/ContainerNode.cpp:107 > + if (!child.renderer() && !child.isNamedFlowContentNode() && !childIsHTMLSlotElement) I would prefer dropping the && !is<HTMLSlotElement>(child) from this if. > Source/WebCore/dom/ContainerNode.cpp:109 > if (is<Element>(child)) And add a new if() here: #if ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT) if (!is<HTMLSlotElement>(child)) return; #endif 1199600 3 ossy 2016-06-06 10:09:55 -0700 I don't know anything about this code base, so I didn't want to change any logic. It's not obvious for me that the change you suggested won't change the behaviour. I don't have time to learn this code base and don't want to land or propose a change I don't understand. If anybody has time and expertise, feel free to fix it. 1199683 4 280443 commit-queue 2016-06-06 13:18:10 -0700 Comment on attachment 280443 Patch Clearing flags on attachment: 280443 Committed r201723: <http://trac.webkit.org/changeset/201723> 1199684 5 commit-queue 2016-06-06 13:18:15 -0700 All reviewed patches have been landed. Closing bug. 280443 2016-06-03 08:02:26 -0700 2016-06-06 13:18:10 -0700 Patch bug-158347-20160603080345.patch text/plain 1592 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg0MzBkNWY4NDJhYzcy OGU1YzU1MDE2ZGM2NjRlNGM1YjNlMmNiNy4uMTNiYWUyMTU1MDgxZjU1Yjk5MGYwNWJlZjAxNGU3 Yzk0NTgxZTkyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA2LTAzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFNIQURPV19ET00pICYmICFFTkFCTEUoREVUQUlMU19FTEVNRU5UKSBidWlsZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MzQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vQ29udGFpbmVy Tm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkZXN0cm95UmVuZGVyVHJlZUlmTmVlZGVkKToK KwogMjAxNi0wNi0wMyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT046IFdlYkdMIGRvZXNuJ3Qgc2hvdyB1cCBpbiBDU1MgcmVmbGVjdGlvbnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAppbmRleCA3NzE2MzgzYWZkNjg4OGUzNmM2 MmE4OGQwNWNhY2Q4NzAxYTk0NDRiLi44N2ZkZWMyZGI4ZmM1NmU0ZjM5NDBhYzZiMzVkODllZWZi ODEwYmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCkBAIC05OSw4ICs5OSwx MiBAQCB2b2lkIENvbnRhaW5lck5vZGU6OnJlbW92ZURldGFjaGVkQ2hpbGRyZW4oKQogCiBzdGF0 aWMgaW5saW5lIHZvaWQgZGVzdHJveVJlbmRlclRyZWVJZk5lZWRlZChOb2RlJiBjaGlsZCkKIHsK KyAgICBib29sIGNoaWxkSXNIVE1MU2xvdEVsZW1lbnQgPSBmYWxzZTsKKyNpZiBFTkFCTEUoU0hB RE9XX0RPTSkgfHwgRU5BQkxFKERFVEFJTFNfRUxFTUVOVCkKKyAgICBjaGlsZElzSFRNTFNsb3RF bGVtZW50ID0gaXM8SFRNTFNsb3RFbGVtZW50PihjaGlsZCk7CisjZW5kaWYKICAgICAvLyBGSVhN RTogR2V0IHJpZCBvZiB0aGUgbmFtZWQgZmxvdyB0ZXN0LgotICAgIGlmICghY2hpbGQucmVuZGVy ZXIoKSAmJiAhY2hpbGQuaXNOYW1lZEZsb3dDb250ZW50Tm9kZSgpICYmICFpczxIVE1MU2xvdEVs ZW1lbnQ+KGNoaWxkKSkKKyAgICBpZiAoIWNoaWxkLnJlbmRlcmVyKCkgJiYgIWNoaWxkLmlzTmFt ZWRGbG93Q29udGVudE5vZGUoKSAmJiAhY2hpbGRJc0hUTUxTbG90RWxlbWVudCkKICAgICAgICAg cmV0dXJuOwogICAgIGlmIChpczxFbGVtZW50PihjaGlsZCkpCiAgICAgICAgIFJlbmRlclRyZWVV cGRhdGVyOjp0ZWFyRG93blJlbmRlcmVycyhkb3duY2FzdDxFbGVtZW50PihjaGlsZCkpOwo=