158346 2016-06-03 07:43:39 -0700 Fix the !ENABLE(INDEXED_DATABASE) build after r201575 2016-06-03 09:12:08 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 158265 1 ossy ossy beidson cdumez commit-queue oldest_to_newest 1198922 0 ossy 2016-06-03 07:43:39 -0700 http://trac.webkit.org/changeset/201575 broke the !ENABLE(INDEXED_DATABASE) build: ../../Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp: In member function 'void WebKit::DatabaseProcess::fetchWebsiteData(WebCore::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, uint64_t)': ../../Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:197:10: error: variable 'completionHandler' set but not used [-Werror=unused-but-set-variable] ../../Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp: In member function 'void WebKit::DatabaseProcess::deleteWebsiteData(WebCore::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, std::chrono::_V2::system_clock::time_point, uint64_t)': ../../Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:219:10: error: variable 'completionHandler' set but not used [-Werror=unused-but-set-variable] ../../Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp: In member function 'void WebKit::DatabaseProcess::deleteWebsiteDataForOrigins(WebCore::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, const WTF::Vector<WebCore::SecurityOriginData>&, uint64_t)': ../../Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:231:10: error: variable 'completionHandler' set but not used [-Werror=unused-but-set-variable] 1198923 1 280442 ossy 2016-06-03 07:47:00 -0700 Created attachment 280442 Patch 1198939 2 280442 commit-queue 2016-06-03 09:12:04 -0700 Comment on attachment 280442 Patch Clearing flags on attachment: 280442 Committed r201643: <http://trac.webkit.org/changeset/201643> 1198940 3 commit-queue 2016-06-03 09:12:08 -0700 All reviewed patches have been landed. Closing bug. 280442 2016-06-03 07:47:00 -0700 2016-06-03 09:12:04 -0700 Patch bug-158346-20160603074820.patch text/plain 3330 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmMwOTRjYTFlYWNmMzgz ODFjM2EyMjBmOTVkMWM1YmEyYjA4YmJhMi4uZTVhZjRhNmY0MzYzOTBiZWI3NTdjYWMzNzJhMDYy NGFkMmI3MmE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTAzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKElOREVYRURfREFUQUJBU0UpIGJ1aWxkIGFmdGVyIHIyMDE1NzUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODM0NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRGF0YWJhc2VQcm9jZXNzL0RhdGFi YXNlUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRhdGFiYXNlUHJvY2Vzczo6ZmV0Y2hX ZWJzaXRlRGF0YSk6CisgICAgICAgIChXZWJLaXQ6OkRhdGFiYXNlUHJvY2Vzczo6ZGVsZXRlV2Vi c2l0ZURhdGEpOgorICAgICAgICAoV2ViS2l0OjpEYXRhYmFzZVByb2Nlc3M6OmRlbGV0ZVdlYnNp dGVEYXRhRm9yT3JpZ2lucyk6CisKIDIwMTYtMDYtMDIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBXZWJQcm9jZXNzOjpyZWdpc3RlcldpdGhT dGF0ZUR1bXBlcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3Mv RGF0YWJhc2VQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9EYXRh YmFzZVByb2Nlc3MuY3BwCmluZGV4IGM4YzI2ZmM2MjY4MzM5M2JkMjFhM2Q4MDhiMTdlODk5MTc2 ZTBiMjcuLmFmODZhZDhiZjMzNDM3MWI3OTY3NzFjZDIwYTAxM2Q4ZDY5NjFiM2QgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9EYXRhYmFzZVByb2Nlc3MuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9EYXRhYmFzZVByb2Nlc3MuY3BwCkBA IC0xOTQsMTEgKzE5NCwxMSBAQCB2b2lkIERhdGFiYXNlUHJvY2Vzczo6Y3JlYXRlRGF0YWJhc2VU b1dlYlByb2Nlc3NDb25uZWN0aW9uKCkKIAogdm9pZCBEYXRhYmFzZVByb2Nlc3M6OmZldGNoV2Vi c2l0ZURhdGEoU2Vzc2lvbklELCBPcHRpb25TZXQ8V2Vic2l0ZURhdGFUeXBlPiB3ZWJzaXRlRGF0 YVR5cGVzLCB1aW50NjRfdCBjYWxsYmFja0lEKQogeworI2lmIEVOQUJMRShJTkRFWEVEX0RBVEFC QVNFKQogICAgIGF1dG8gY29tcGxldGlvbkhhbmRsZXIgPSBbdGhpcywgY2FsbGJhY2tJRF0oY29u c3QgV2Vic2l0ZURhdGEmIHdlYnNpdGVEYXRhKSB7CiAgICAgICAgIHBhcmVudFByb2Nlc3NDb25u ZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6OkRhdGFiYXNlUHJvY2Vzc1Byb3h5OjpEaWRGZXRjaFdl YnNpdGVEYXRhKGNhbGxiYWNrSUQsIHdlYnNpdGVEYXRhKSwgMCk7CiAgICAgfTsKIAotI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIGlmICh3ZWJzaXRlRGF0YVR5cGVzLmNvbnRhaW5z KFdlYnNpdGVEYXRhVHlwZTo6SW5kZXhlZERCRGF0YWJhc2VzKSkgewogICAgICAgICAvLyBGSVhN RTogUGljayB0aGUgcmlnaHQgZGF0YWJhc2Ugc3RvcmUgYmFzZWQgb24gdGhlIHNlc3Npb24gSUQu CiAgICAgICAgIHBvc3REYXRhYmFzZVRhc2soQ3Jvc3NUaHJlYWRUYXNrKFt0aGlzLCB3ZWJzaXRl RGF0YVR5cGVzLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIp XSgpIG11dGFibGUgewpAQCAtMjE2LDExICsyMTYsMTEgQEAgdm9pZCBEYXRhYmFzZVByb2Nlc3M6 OmZldGNoV2Vic2l0ZURhdGEoU2Vzc2lvbklELCBPcHRpb25TZXQ8V2Vic2l0ZURhdGFUeXBlPiB3 ZWIKIAogdm9pZCBEYXRhYmFzZVByb2Nlc3M6OmRlbGV0ZVdlYnNpdGVEYXRhKFdlYkNvcmU6OlNl c3Npb25JRCwgT3B0aW9uU2V0PFdlYnNpdGVEYXRhVHlwZT4gd2Vic2l0ZURhdGFUeXBlcywgc3Rk OjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBtb2RpZmllZFNpbmNlLCB1aW50NjRf dCBjYWxsYmFja0lEKQogeworI2lmIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIGF1dG8g Y29tcGxldGlvbkhhbmRsZXIgPSBbdGhpcywgY2FsbGJhY2tJRF0oKSB7CiAgICAgICAgIHBhcmVu dFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6OkRhdGFiYXNlUHJvY2Vzc1Byb3h5 OjpEaWREZWxldGVXZWJzaXRlRGF0YShjYWxsYmFja0lEKSwgMCk7CiAgICAgfTsKIAotI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIGlmICh3ZWJzaXRlRGF0YVR5cGVzLmNvbnRhaW5z KFdlYnNpdGVEYXRhVHlwZTo6SW5kZXhlZERCRGF0YWJhc2VzKSkKICAgICAgICAgaWRiU2VydmVy KCkuY2xvc2VBbmREZWxldGVEYXRhYmFzZXNNb2RpZmllZFNpbmNlKG1vZGlmaWVkU2luY2UsIFdU Rk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICNlbmRpZgpAQCAtMjI4LDExICsyMjgsMTEgQEAg dm9pZCBEYXRhYmFzZVByb2Nlc3M6OmRlbGV0ZVdlYnNpdGVEYXRhKFdlYkNvcmU6OlNlc3Npb25J RCwgT3B0aW9uU2V0PFdlYnNpdGVEYXQKIAogdm9pZCBEYXRhYmFzZVByb2Nlc3M6OmRlbGV0ZVdl YnNpdGVEYXRhRm9yT3JpZ2lucyhXZWJDb3JlOjpTZXNzaW9uSUQsIE9wdGlvblNldDxXZWJzaXRl RGF0YVR5cGU+IHdlYnNpdGVEYXRhVHlwZXMsIGNvbnN0IFZlY3RvcjxTZWN1cml0eU9yaWdpbkRh dGE+JiBzZWN1cml0eU9yaWdpbkRhdGFzLCB1aW50NjRfdCBjYWxsYmFja0lEKQogeworI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIGF1dG8gY29tcGxldGlvbkhhbmRsZXIgPSBbdGhp cywgY2FsbGJhY2tJRF0oKSB7CiAgICAgICAgIHBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNl bmQoTWVzc2FnZXM6OkRhdGFiYXNlUHJvY2Vzc1Byb3h5OjpEaWREZWxldGVXZWJzaXRlRGF0YUZv ck9yaWdpbnMoY2FsbGJhY2tJRCksIDApOwogICAgIH07CiAKLSNpZiBFTkFCTEUoSU5ERVhFRF9E QVRBQkFTRSkKICAgICBpZiAod2Vic2l0ZURhdGFUeXBlcy5jb250YWlucyhXZWJzaXRlRGF0YVR5 cGU6OkluZGV4ZWREQkRhdGFiYXNlcykpCiAgICAgICAgIGlkYlNlcnZlcigpLmNsb3NlQW5kRGVs ZXRlRGF0YWJhc2VzRm9yT3JpZ2lucyhzZWN1cml0eU9yaWdpbkRhdGFzLCBXVEZNb3ZlKGNvbXBs ZXRpb25IYW5kbGVyKSk7CiAjZW5kaWYK