158323 2016-06-02 15:50:06 -0700 Fix typo in -[WebDefaultUIKitDelegate deleteFromInputwithFlags:] 2016-06-02 20:46:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157689 https://bugs.webkit.org/show_bug.cgi?id=141216 InRadar P2 Normal --- 1 ddkilzer ddkilzer aestes benjamin commit-queue enrica pgomez_81 sam thorton oldest_to_newest 1198716 0 ddkilzer 2016-06-02 15:50:06 -0700 In Source/WebKit/ios/DefaultDelegates/WebDefaultUIKitDelegate.m, this method is defined as: - (void)deleteFromInputwithFlags:(NSUInteger)flags { } However, in Source/WebKit/ios/WebView/WebUIKitDelegate.h, it's defined in a category (not a protocol) as: - (void)deleteFromInputWithFlags:(NSUInteger)flags; This causes problems in Source/WebKit/mac/WebView/WebHTMLView.mm in -_handleEditingKeyEvent: where we use -_UIKitDelegateForwarder to forward the method: switch ([s characterAtIndex:0]) { case kWebBackspaceKey: case kWebDeleteKey: [[webView _UIKitDelegateForwarder] deleteFromInputWithFlags:event.keyboardFlags]; return YES; This was recently changed for Bug 157689 in r200979 from this: switch ([s characterAtIndex:0]) { case kWebBackspaceKey: case kWebDeleteKey: // FIXME: remove the call to deleteFromInput when UIKit implements deleteFromInputWithFlags. if ([webView respondsToSelector:@selector(deleteFromInputWithFlags:)]) [[webView _UIKitDelegateForwarder] deleteFromInputWithFlags:event.keyboardFlags]; else [[webView _UIKitDelegateForwarder] deleteFromInput]; return YES; Finally, since the _UIKitDelegateForwarded always uses the WebDefaultUIKitDelegate to check whether the method exists, -[_WebSafeForwarder methodSignatureForSelector:] in Source/WebKit/mac/WebView/WebView.mm would return NO, which results in the NSException being thrown, leading to the crash: - (NSMethodSignature *)methodSignatureForSelector:(SEL)aSelector { return [defaultTarget methodSignatureForSelector:aSelector]; } The fix is trivial--fix the typo in WebDefaultUIKitDelegate.m. 1198718 1 ddkilzer 2016-06-02 15:50:44 -0700 <rdar://problem/26549165> 1198727 2 280378 ddkilzer 2016-06-02 16:01:53 -0700 Created attachment 280378 Patch v1 1198776 3 280378 commit-queue 2016-06-02 18:32:58 -0700 Comment on attachment 280378 Patch v1 Clearing flags on attachment: 280378 Committed r201631: <http://trac.webkit.org/changeset/201631> 1198777 4 commit-queue 2016-06-02 18:33:02 -0700 All reviewed patches have been landed. Closing bug. 280378 2016-06-02 16:01:53 -0700 2016-06-02 18:32:58 -0700 Patch v1 bug-158323-20160602160313.patch text/plain 1367 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2lv cy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2lvcy9DaGFuZ2VMb2cKaW5kZXggYzJiZmZhMzY1 NGY3OTM1MzNlMDkzOTBhNjNlMjlmMjVjOTQwMzZmZS4uYjlkZmViOTgxODIxYzE0ZmMwYjM0NGQ1 M2Y4ZTBmY2RjNzI1NjQ0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9pb3MvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2 LTA2LTAyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IHR5cG8gaW4gLVtXZWJEZWZhdWx0VUlLaXREZWxlZ2F0ZSBkZWxldGVGcm9tSW5wdXR3aXRoRmxh Z3M6XQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTU4MzIzPgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMjY1NDkxNjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBEZWZhdWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRVSUtpdERlbGVnYXRl Lm06CisgICAgICAgICgtW1dlYkRlZmF1bHRVSUtpdERlbGVnYXRlIGRlbGV0ZUZyb21JbnB1dHdp dGhGbGFnczpdKTogUmVuYW1lLi4uCisgICAgICAgICgtW1dlYkRlZmF1bHRVSUtpdERlbGVnYXRl IGRlbGV0ZUZyb21JbnB1dFdpdGhGbGFnczpdKTogLi4udG8gdGhpcy4KKwogMjAxNi0wNS0xNSAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9yZSBDVFRFIGFuZCBv dGhlciBjbGVhbnVwcyBmb3IgSFRNTCBlZGl0aW5nIGhlYWRlcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9pb3MvRGVmYXVsdERlbGVnYXRlcy9XZWJEZWZhdWx0VUlLaXREZWxlZ2F0ZS5tIGIv U291cmNlL1dlYktpdC9pb3MvRGVmYXVsdERlbGVnYXRlcy9XZWJEZWZhdWx0VUlLaXREZWxlZ2F0 ZS5tCmluZGV4IDkwNDQyNDNkNmRjNjA2N2I2YTA2ZjJhMGZlNmI1ZDY0YjA3OTM4OWMuLjExZDFm ZmE3MzcyNWEwMTE4ZjIyYWQzNzdjMzE4OGNkZmY0NDM3NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvaW9zL0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFVJS2l0RGVsZWdhdGUubQorKysg Yi9Tb3VyY2UvV2ViS2l0L2lvcy9EZWZhdWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRVSUtpdERlbGVn YXRlLm0KQEAgLTE3MCw3ICsxNzAsNyBAQCAtICh2b2lkKWRlbGV0ZUZyb21JbnB1dAogewogfQog Ci0tICh2b2lkKWRlbGV0ZUZyb21JbnB1dHdpdGhGbGFnczooTlNVSW50ZWdlcilmbGFncworLSAo dm9pZClkZWxldGVGcm9tSW5wdXRXaXRoRmxhZ3M6KE5TVUludGVnZXIpZmxhZ3MKIHsKIH0KIAo=