158317 2016-06-02 14:37:40 -0700 [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled 2016-06-02 14:56:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build iPhone / iPad All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam oldest_to_newest 1198693 0 msaboff 2016-06-02 14:37:40 -0700 Some of the stress tests need so much code alive that they run out of executable memory when the LLInt is disabled. There were similar issues with the JS LayoutTests. For these tests, we should not run the "noLLInt" variant. The tests in question are ARM - stress/arrowfunction-lexical-bind-superproperty.js ARM & ARM64 - stress/proxy-revoke.js <rdar://problem/26605951> <rdar://problem/26605961> 1198697 1 280370 msaboff 2016-06-02 14:46:59 -0700 Created attachment 280370 Patch 1198698 2 280370 saam 2016-06-02 14:49:38 -0700 Comment on attachment 280370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280370&action=review > Tools/Scripts/run-jsc-stress-tests:937 > + if $quickMode > + defaultQuickRun > + else > + runDefault > + runAlwaysTriggerCopyPhase > + if $jitTests > + runNoCJITValidatePhases > + runDFGEager > + runDFGEagerNoCJITValidate > + runDefaultFTL > + runFTLNoCJITValidate > + runFTLNoCJITNoPutStackValidate > + runFTLNoCJITNoInlineValidate > + runFTLEager > + runFTLEagerNoCJITValidate > + runFTLNoCJITSmallPool > + runDFGMaximalFlushPhase > + end > + end > +end I wish we had a way to just set some extra flags on every run so we don't have to copy defaultRun here. Maybe we could add something like EXTRA_OPTIONS = []; And here, you can set those options, and then set them back to empty after the run. And each run() can add EXTRA_OPTIONS 1198699 3 msaboff 2016-06-02 14:52:34 -0700 Committed r201618: <http://trac.webkit.org/changeset/201618> 1198701 4 msaboff 2016-06-02 14:56:54 -0700 (In reply to comment #2) > Comment on attachment 280370 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280370&action=review > > > Tools/Scripts/run-jsc-stress-tests:937 > > + if $quickMode > > + defaultQuickRun > > + else > > + runDefault > > + runAlwaysTriggerCopyPhase > > + if $jitTests > > + runNoCJITValidatePhases > > + runDFGEager > > + runDFGEagerNoCJITValidate > > + runDefaultFTL > > + runFTLNoCJITValidate > > + runFTLNoCJITNoPutStackValidate > > + runFTLNoCJITNoInlineValidate > > + runFTLEager > > + runFTLEagerNoCJITValidate > > + runFTLNoCJITSmallPool > > + runDFGMaximalFlushPhase > > + end > > + end > > +end > > I wish we had a way to just set some extra flags on every run so we don't > have to copy defaultRun here. > Maybe we could add something like EXTRA_OPTIONS = []; > And here, you can set those options, and then set them back to empty after > the run. > And each run() can add EXTRA_OPTIONS I was thinking we could make a more general additive process. defaultRun would run everything, but it would be composed of subgroups. For cases like this, be just run the selected subgroups. 280370 2016-06-02 14:46:59 -0700 2016-06-02 14:48:39 -0700 Patch 158317.patch text/plain 3611 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxNTg5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTA2LTAyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdOiBTb21lIEpTQyBzdHJlc3MgdGVzdHMgZmFpbCBydW5uaW5nIG91dCBvZiBleGVj dXRhYmxlIG1lbW9yeSB3aGVuIHRoZSBMTEludCBpcyBkaXNhYmxlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MzE3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0aGVzZSB0ZXN0IHRvIG5v dCBydW4gdGhlICJuby1sbGludCIgdmFyaWFudCB3aGVuIHJ1bm5pbmcgb24gQVJNIG1hY2hpbmVz LgorCisgICAgICAgICogdGVzdHMvc3RyZXNzL2Fycm93ZnVuY3Rpb24tbGV4aWNhbC1iaW5kLXN1 cGVycHJvcGVydHkuanM6IFNraXAgbm8tbGxpbnQgZm9yIEFSTQorICAgICAgICAodGVzdENhc2Up OgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9wcm94eS1yZXZva2UuanM6IFNraXBwIG5vLWxpbnQg Zm9yIEFSTSBhbmQgQVJNNjQKKyAgICAgICAgKGFzc2VydCk6CisKIDIwMTYtMDYtMDEgIE1pY2hh ZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUnVuYXdheSBXZWJDb250 ZW50IHByb2Nlc3MgQ1BVICYgbWVtb3J5IEAgZm94bmV3cy5jb20KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvYXJyb3dmdW5jdGlvbi1sZXhpY2FsLWJpbmQtc3VwZXJw cm9wZXJ0eS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3Ry ZXNzL2Fycm93ZnVuY3Rpb24tbGV4aWNhbC1iaW5kLXN1cGVycHJvcGVydHkuanMJKHJldmlzaW9u IDIwMTU4OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvYXJyb3dmdW5j dGlvbi1sZXhpY2FsLWJpbmQtc3VwZXJwcm9wZXJ0eS5qcwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDUgQEAKKy8vQCBkZWZhdWx0Tm9Ob0xMSW50UnVuIGlmICRhcmNoaXRlY3R1cmUgPT0gImFy bSIKKwogdmFyIHRlc3RDYXNlID0gZnVuY3Rpb24gKGFjdHVhbCwgZXhwZWN0ZWQsIG1lc3NhZ2Up IHsKICAgICBpZiAoYWN0dWFsICE9PSBleHBlY3RlZCkgewogICAgICAgICB0aHJvdyBtZXNzYWdl ICsgIi4gRXhwZWN0ZWQgJyIgKyBleHBlY3RlZCArICInLCBidXQgd2FzICciICsgYWN0dWFsICsg IiciOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9wcm94eS1yZXZv a2UuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9w cm94eS1yZXZva2UuanMJKHJldmlzaW9uIDIwMTU4OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS90ZXN0cy9zdHJlc3MvcHJveHktcmV2b2tlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs NSBAQAorLy9AIGRlZmF1bHROb05vTExJbnRSdW4gaWYgJGFyY2hpdGVjdHVyZSA9PSAiYXJtNjQi IG9yICRhcmNoaXRlY3R1cmUgPT0gImFybSIKKwogZnVuY3Rpb24gYXNzZXJ0KGIpIHsKICAgICBp ZiAoIWIpCiAgICAgICAgIHRocm93IG5ldyBFcnJvcigiYmFkIGFzc2VydGlvbiIpOwpJbmRleDog VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24g MjAxNjE3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDYtMDIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAg ICAgICAgW2lPU106IFNvbWUgSlNDIHN0cmVzcyB0ZXN0cyBmYWlsIHJ1bm5pbmcgb3V0IG9mIGV4 ZWN1dGFibGUgbWVtb3J5IHdoZW4gdGhlIExMSW50IGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgzMTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBkZWZhdWx0Tm9Ob0xMSW50 UnVuIHZhcmlhbnQgdG8gcnVuIHRoZSBkZWZhdWx0IHRlc3RzIHdpdGggdGhlIGV4Y2VwdGlvbiBv ZiB0aGUgbm8tbGxpbnQKKyAgICAgICAgdmFyaWFudC4KKworICAgICAgICAqIFNjcmlwdHMvcnVu LWpzYy1zdHJlc3MtdGVzdHM6CisKIDIwMTYtMDYtMDIgIEFha2FzaCBKYWluICA8YWFrYXNoX2ph aW5AYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dFRlc3RzIHRpbWUgb3V0IGludGVybWl0dGVu dGx5IGR1ZSB0byBhbGVydCBhYm91dCByZW9wZW5pbmcgU2ltdWxhdG9yIGFmdGVyIGl0IHVuZXhw ZWN0ZWRseSBxdWl0CkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMJKHJldmlzaW9u IDIwMTU4OCkKKysrIFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMJKHdvcmtpbmcg Y29weSkKQEAgLTkxNCw2ICs5MTQsMjggQEAgZGVmIGRlZmF1bHRSdW4KICAgICBlbmQKIGVuZAog CitkZWYgZGVmYXVsdE5vTm9MTEludFJ1bgorICAgIGlmICRxdWlja01vZGUKKyAgICAgICAgZGVm YXVsdFF1aWNrUnVuCisgICAgZWxzZQorICAgICAgICBydW5EZWZhdWx0CisgICAgICAgIHJ1bkFs d2F5c1RyaWdnZXJDb3B5UGhhc2UKKyAgICAgICAgaWYgJGppdFRlc3RzCisgICAgICAgICAgICBy dW5Ob0NKSVRWYWxpZGF0ZVBoYXNlcworICAgICAgICAgICAgcnVuREZHRWFnZXIKKyAgICAgICAg ICAgIHJ1bkRGR0VhZ2VyTm9DSklUVmFsaWRhdGUKKyAgICAgICAgICAgIHJ1bkRlZmF1bHRGVEwK KyAgICAgICAgICAgIHJ1bkZUTE5vQ0pJVFZhbGlkYXRlCisgICAgICAgICAgICBydW5GVExOb0NK SVROb1B1dFN0YWNrVmFsaWRhdGUKKyAgICAgICAgICAgIHJ1bkZUTE5vQ0pJVE5vSW5saW5lVmFs aWRhdGUKKyAgICAgICAgICAgIHJ1bkZUTEVhZ2VyCisgICAgICAgICAgICBydW5GVExFYWdlck5v Q0pJVFZhbGlkYXRlCisgICAgICAgICAgICBydW5GVExOb0NKSVRTbWFsbFBvb2wKKyAgICAgICAg ICAgIHJ1bkRGR01heGltYWxGbHVzaFBoYXNlCisgICAgICAgIGVuZAorICAgIGVuZAorZW5kCisK IGRlZiBkZWZhdWx0UXVpY2tSdW4KICAgICBpZiAkZW5hYmxlRlRMIGFuZCAkaml0VGVzdHMKICAg ICAgICAgcnVuRGVmYXVsdEZUTAo=