158310 2016-06-02 12:20:33 -0700 Crash under CachedResource::addClientToSet() 2016-06-02 13:36:03 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1198609 0 cdumez 2016-06-02 12:20:33 -0700 Crash under CachedResource::addClientToSet(): Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed ↩: 0 WebCore 0x0000000198f95154 WebCore::CachedResource::addClientToSet(WebCore::CachedResourceClient*) + 36 (CachedResource.cpp:450) 1 WebCore 0x0000000198f95104 WebCore::CachedResource::addClient(WebCore::CachedResourceClient*) + 24 (CachedResource.cpp:433) 2 WebCore 0x0000000198f95104 WebCore::CachedResource::addClient(WebCore::CachedResourceClient*) + 24 (CachedResource.cpp:433) 3 WebCore 0x0000000199f01338 WebCore::WebCoreAVFResourceLoader::startLoading() + 280 (WebCoreAVFResourceLoader.mm:77) 4 WebCore 0x0000000199a87b08 WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource(AVAssetResourceLoadingRequest*) + 216 (MediaPlayerPrivateAVFoundationObjC.mm:1803) 5 JavaScriptCore 0x00000001983f7d54 WTF::dispatchFunctionsFromMainThread() + 540 (functional:1817) 6 Foundation 0x0000000194f8c8bc __NSThreadPerformPerform + 340 (NSThread.m:1228) 7 CoreFoundation 0x00000001944d3b88 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24 (CFRunLoop.c:1943) 8 CoreFoundation 0x00000001944d34d0 __CFRunLoopDoSources0 + 524 (CFRunLoop.c:1989) 9 CoreFoundation 0x00000001944d10d0 __CFRunLoopRun + 804 (CFRunLoop.c:2821) 10 CoreFoundation 0x00000001944024b4 CFRunLoopRunSpecific + 292 (CFRunLoop.c:3103) 11 Foundation 0x0000000194e926fc -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 304 (NSRunLoop.m:367) 12 Foundation 0x0000000194ee6dec -[NSRunLoop(NSRunLoop) run] + 88 (NSRunLoop.m:389) 13 libxpc.dylib 0x00000001941b8f08 _xpc_objc_main + 660 (main.m:186) 14 libxpc.dylib 0x00000001941bac00 xpc_main + 200 (init.c:1438) 15 com.apple.WebKit.WebContent 0x00000001000ab5e4 main + 376 (XPCServiceMain.mm:114) 16 libdyld.dylib 0x0000000193fa3600 start + 4 1198611 1 cdumez 2016-06-02 12:20:57 -0700 <rdar://problem/23643359> 1198616 2 280348 cdumez 2016-06-02 12:29:00 -0700 Created attachment 280348 Patch 1198654 3 280348 eric.carlson 2016-06-02 13:34:49 -0700 Comment on attachment 280348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280348&action=review > Source/WebCore/ChangeLog:10 > + by CachedResourceLoader::requestMedia() only if the resource is Nit: "only" not needed on this line. 1198655 4 cdumez 2016-06-02 13:36:03 -0700 Committed r201615: <http://trac.webkit.org/changeset/201615> 280348 2016-06-02 12:29:00 -0700 2016-06-02 13:34:49 -0700 Patch bug-158310-20160602123020.patch text/plain 2782 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE1YTFlMDRlMjYyNGVk YmYxYWY5MGYxZjY4MzhkYjQwZjU4OWVjNC4uOTQ5NzBlM2M5NTU0MGZiZjU0NDJhN2NmNzI3MWIx YmY3NWQwZmMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA2LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdW5kZXIgQ2FjaGVk UmVzb3VyY2U6OmFkZENsaWVudFRvU2V0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1ODMxMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjM2NDMz NTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25s eSBjYWxsIENhY2hlZFJlc291cmNlOjphZGRDbGllbnQoKSBvbiB0aGUgcmVzb3VyY2UgcmV0dXJu ZWQKKyAgICAgICAgYnkgQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OnJlcXVlc3RNZWRpYSgpIG9ubHkg aWYgdGhlIHJlc291cmNlIGlzCisgICAgICAgIG5vbi1udWxsLiBDYWNoZWRSZXNvdXJjZUxvYWRl cjo6cmVxdWVzdE1lZGlhKCkgY2FuIHJldHVybiBudWxsCisgICAgICAgIGluIHNvbWUgY2FzZXMg c28gd2UgbmVlZCB0byBoYW5kbGUgdGhpcyBwcm9wZXJseS4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGtub3duIHJlcHJvZHVjdGlvbiBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvV2ViQ29yZUFWRlJlc291cmNlTG9hZGVyLm1tOgorICAg ICAgICAoV2ViQ29yZTo6V2ViQ29yZUFWRlJlc291cmNlTG9hZGVyOjpzdGFydExvYWRpbmcpOgor CiAyMDE2LTA2LTAyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+ CiAKICAgICAgICAgVXNlIG1vcmUgcmVmZXJlbmNlcyBpbiBSZXNvdXJjZUxvYWRlciByZWxhdGVk IGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL1dlYkNvcmVBVkZSZXNvdXJjZUxvYWRlci5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1dlYkNvcmVBVkZSZXNvdXJjZUxv YWRlci5tbQppbmRleCBiNzU3MTg5NmIzMjdiOGQ5MTQ4ZTk0M2E0MzZmMmU3NjNiYTEwNGEyLi43 ODJmYzFmZjViZTQ4MTM1N2ViOGNlNzI3MGFlZDVjMDA5MTM3MWUwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9XZWJDb3JlQVZG UmVzb3VyY2VMb2FkZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvV2ViQ29yZUFWRlJlc291cmNlTG9hZGVyLm1tCkBAIC03MCwxMyAr NzAsMTMgQEAgdm9pZCBXZWJDb3JlQVZGUmVzb3VyY2VMb2FkZXI6OnN0YXJ0TG9hZGluZygpCiAg ICAgLy8gRklYTUU6IFNraXAgQ29udGVudCBTZWN1cml0eSBQb2xpY3kgY2hlY2sgaWYgdGhlIGVs ZW1lbnQgdGhhdCBpbml0aXRhdGVkIHRoaXMgcmVxdWVzdAogICAgIC8vIGlzIGluIGEgdXNlci1h Z2VudCBzaGFkb3cgdHJlZS4gU2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU1NTA1Pi4KICAgICBDYWNoZWRSZXNvdXJjZVJlcXVlc3QgcmVxdWVzdChuc1JlcXVl c3QsIFJlc291cmNlTG9hZGVyT3B0aW9ucyhTZW5kQ2FsbGJhY2tzLCBEb05vdFNuaWZmQ29udGVu dCwgQnVmZmVyRGF0YSwgRG9Ob3RBbGxvd1N0b3JlZENyZWRlbnRpYWxzLCBEb05vdEFza0NsaWVu dEZvckNyb3NzT3JpZ2luQ3JlZGVudGlhbHMsIENsaWVudERpZE5vdFJlcXVlc3RDcmVkZW50aWFs cywgRG9TZWN1cml0eUNoZWNrLCBVc2VEZWZhdWx0T3JpZ2luUmVzdHJpY3Rpb25zRm9yVHlwZSwg RG9Ob3RJbmNsdWRlQ2VydGlmaWNhdGVJbmZvLCBDb250ZW50U2VjdXJpdHlQb2xpY3lJbXBvc2l0 aW9uOjpEb1BvbGljeUNoZWNrLCBEZWZlcnNMb2FkaW5nUG9saWN5OjpBbGxvd0RlZmVyc0xvYWRp bmcsIENhY2hpbmdQb2xpY3k6OkRpc2FsbG93Q2FjaGluZykpOwotCiAgICAgcmVxdWVzdC5tdXRh YmxlUmVzb3VyY2VSZXF1ZXN0KCkuc2V0UHJpb3JpdHkoUmVzb3VyY2VMb2FkUHJpb3JpdHk6Okxv dyk7Ci0gICAgaWYgKENhY2hlZFJlc291cmNlTG9hZGVyKiBsb2FkZXIgPSBtX3BhcmVudC0+cGxh eWVyKCktPmNhY2hlZFJlc291cmNlTG9hZGVyKCkpIHsKKyAgICBpZiAoYXV0byogbG9hZGVyID0g bV9wYXJlbnQtPnBsYXllcigpLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpKQogICAgICAgICBtX3Jl c291cmNlID0gbG9hZGVyLT5yZXF1ZXN0TWVkaWEocmVxdWVzdCk7CisKKyAgICBpZiAobV9yZXNv dXJjZSkKICAgICAgICAgbV9yZXNvdXJjZS0+YWRkQ2xpZW50KHRoaXMpOwotICAgIH0gZWxzZSB7 Ci0gICAgICAgIG1fcmVzb3VyY2UgPSBudWxscHRyOworICAgIGVsc2UgewogICAgICAgICBMT0df RVJST1IoIkZhaWxlZCB0byBzdGFydCBsb2FkIGZvciBtZWRpYSBhdCB1cmwgJXMiLCBbW1tuc1Jl cXVlc3QgVVJMXSBhYnNvbHV0ZVN0cmluZ10gVVRGOFN0cmluZ10pOwogICAgICAgICBbbV9hdlJl cXVlc3QuZ2V0KCkgZmluaXNoTG9hZGluZ1dpdGhFcnJvcjowXTsKICAgICB9Cg==