158290 2016-06-01 17:58:22 -0700 Runaway WebContent process CPU & memory @ foxnews.com 2016-06-03 07:33:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam ossy saam oldest_to_newest 1198368 0 msaboff 2016-06-01 17:58:22 -0700 Some foxnews.com pages with embedded videos have this code: start : function() { if (this.started === true) { return; } try { this.plugin.Media.open(this.getMediaName(), this.media.getDuration(), this.getPlayerName()); // <== Exception here this.started = true; } catch (error) { this.error(error); } this.play(); // recursively call play() } play : function() { if (this.started !== true) { this.start(); // <== call here return; } try { this.plugin.Media.play(this.getMediaName(), this.getPlaybackCore().getCurrentTime() || 0); } catch (error) { this.error(error); } } This can end up being a mutual recursive call chain that will eventually exceed the stack space. This happens when this.plugin.Media.open() in start() throws an exception. That exception is caught in the catch block, but start() then calls play(). At the top of play(), it will recursively call start() and we end up in a recursive loop. While the stack grows, the amount of memory used goes up dramatically. The memory use is due to the error objects that are created for each throw. The catch will be handled in baseline JIT'ed code as the higher tiers will ORS exit at the start of their catch blocks. The baseline JIT'ed code will allocate a local for the thrown value and the conservative scan of the stack during GC will include the thrown value. This means that the error objects for all start() frames further up the stack will not be collected. 1198369 1 msaboff 2016-06-01 17:58:57 -0700 <rdar://problem/24756019> 1198370 2 280288 msaboff 2016-06-01 18:06:10 -0700 Created attachment 280288 Patch 1198379 3 280288 mark.lam 2016-06-01 19:01:40 -0700 Comment on attachment 280288 Patch r=me 1198427 4 msaboff 2016-06-01 21:05:54 -0700 Committed r201589: <http://trac.webkit.org/changeset/201589> 1198921 5 ossy 2016-06-03 07:33:28 -0700 (In reply to comment #4) > Committed r201589: <http://trac.webkit.org/changeset/201589> stress/recursive-try-catch.js.ftl-no-cjit-validate-sampling-profiler times out on Apple Mac 32 bit debug bot: https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/2545 280288 2016-06-01 18:06:10 -0700 2016-06-01 19:01:40 -0700 Patch 158290.patch text/plain 6510 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxNTc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTA2LTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJ1bmF3YXkgV2ViQ29udGVudCBwcm9jZXNzIENQVSAmIG1lbW9yeSBAIGZveG5ld3MuY29t CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgyOTAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhciB0 aGUgdGhyb3duIHZhbHVlIGF0IHRoZSBlbmQgb2YgdGhlIGNhdGNoIGJsb2NrIHNvIHRoYXQgdGhl IHN0YWNrIHNjYW5uZXIgd29uJ3QKKyAgICAgICAgZmluZCB0aGUgdmFsdWUgZHVyaW5nIEdDLgor CisgICAgICAgIEFkZGVkIGEgbmV3IHN0cmVzcyB0ZXN0LgorCisgICAgICAgICogYnl0ZWNvbXBp bGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OlRyeU5vZGU6OmVtaXRCeXRlY29k ZSk6CisgICAgICAgICogdGVzdHMvc3RyZXNzL3JlY3Vyc2l2ZS10cnktY2F0Y2guanM6IEFkZGVk LgorICAgICAgICAobG9nRXJyb3IpOgorICAgICAgICAodHJ5Q2FsbGluZ0JhZEZ1bmN0aW9uKToK KyAgICAgICAgKHJlY3Vyc2UpOgorICAgICAgICAodGVzdCk6CisKIDIwMTYtMDYtMDEgIEdlb2Zm cmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIGluIHIyMDE0MzYuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVy L05vZGVzQ29kZWdlbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCShyZXZpc2lvbiAyMDE1NTUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMxMjcsNiArMzEyNyw3IEBAIHZvaWQgVHJ5Tm9kZTo6ZW1pdEJ5dGVjb2RlKEJ5dGVj b2RlR2VuZXIKICAgICAgICAgICAgIGdlbmVyYXRvci5lbWl0Tm9kZShkc3QsIG1fY2F0Y2hCbG9j ayk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGdlbmVyYXRvci5lbWl0Tm9kZUluVGFpbFBv c2l0aW9uKGRzdCwgbV9jYXRjaEJsb2NrKTsKKyAgICAgICAgZ2VuZXJhdG9yLmVtaXRMb2FkKHRo cm93blZhbHVlUmVnaXN0ZXIuZ2V0KCksIGpzVW5kZWZpbmVkKCkpOwogICAgICAgICBnZW5lcmF0 b3IuZW1pdFBvcENhdGNoU2NvcGUobV9sZXhpY2FsVmFyaWFibGVzKTsKICAgICAgICAgZ2VuZXJh dG9yLmVtaXRMYWJlbChjYXRjaEVuZExhYmVsLmdldCgpKTsKICAgICB9CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3JlY3Vyc2l2ZS10cnktY2F0Y2guanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9yZWN1cnNpdmUtdHJ5 LWNhdGNoLmpzCShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy9yZWN1cnNpdmUtdHJ5LWNhdGNoLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsODgg QEAKKy8vIFRoaXMgdGVzdCBzaG91bGQgcnVuIHRvIGNvbXBsZXRpb24gd2l0aG91dCBleGNlc3Np dmUgbWVtb3J5IHVzYWdlCisKK2xldCBtYXhIZWFwQWxsb3dlZCA9IDEwICogMTAyNCAqIDEwMjQ7 IC8vIFRoaXMgdGVzdCBzaG91bGQgcnVuIHVzaW5nIG11Y2ggbGVzcyB0aGFuIDEwTUIuCitsZXQg YmFkRnVuY3Rpb24gPSB1bmRlZmluZWQ7CitsZXQgbG9nZ2VkRXJyb3IgPSB1bmRlZmluZWQ7CisK K2Z1bmN0aW9uIGxvZ0Vycm9yKGVycm9yKQoreworICAgIGxvZ2dlZEVycm9yID0gZXJyb3I7Cit9 CisKK2Z1bmN0aW9uIHRyeUNhbGxpbmdCYWRGdW5jdGlvbigpCit7CisgICAgdHJ5IHsKKyAgICAg ICAgYmFkRnVuY3Rpb24oNDIpOworICAgIH0gY2F0Y2goZXJyb3IpIHsKKyAgICAgICAgbG9nRXJy b3IoZXJyb3IpOworICAgIH0KKworICAgIHJlY3Vyc2UoKTsKK30KKworZnVuY3Rpb24gcmVjdXJz ZSgpCit7CisgICAgLy8gTWFrZSB0aGUgZnJhbWUgYmlnIHRvIHJ1biBvdXQgb2Ygc3RhY2sgd2l0 aCBmZXdlciByZWN1cnNpdmUgY2FsbHMuCisgICAgbGV0IHZhbDEsIHZhbDIsIHZhbDMsIHZhbDQs IHZhbDUsIHZhbDYsIHZhbDcsIHZhbDgsIHZhbDksIHZhbDEwOworICAgIGxldCB2YWwxMSwgdmFs MTIsIHZhbDEzLCB2YWwxNCwgdmFsMTUsIHZhbDE2LCB2YWwxNywgdmFsMTgsIHZhbDE5LCB2YWwy MDsKKyAgICBsZXQgdmFsMjEsIHZhbDIyLCB2YWwyMywgdmFsMjQsIHZhbDI1LCB2YWwyNiwgdmFs MjcsIHZhbDI4LCB2YWwyOSwgdmFsMzA7CisgICAgbGV0IHZhbDMxLCB2YWwzMiwgdmFsMzMsIHZh bDM0LCB2YWwzNSwgdmFsMzYsIHZhbDM3LCB2YWwzOCwgdmFsMzksIHZhbDQwOworICAgIGxldCB2 YWw0MSwgdmFsNDIsIHZhbDQzLCB2YWw0NCwgdmFsNDUsIHZhbDQ2LCB2YWw0NywgdmFsNDgsIHZh bDQ5LCB2YWw1MDsKKyAgICBsZXQgdmFsNTEsIHZhbDUyLCB2YWw1MywgdmFsNTQsIHZhbDU1LCB2 YWw1NiwgdmFsNTcsIHZhbDU4LCB2YWw1OSwgdmFsNjA7CisgICAgbGV0IHZhbDYxLCB2YWw2Miwg dmFsNjMsIHZhbDY0LCB2YWw2NSwgdmFsNjYsIHZhbDY3LCB2YWw2OCwgdmFsNjksIHZhbDcwOwor ICAgIGxldCB2YWw3MSwgdmFsNzIsIHZhbDczLCB2YWw3NCwgdmFsNzUsIHZhbDc2LCB2YWw3Nywg dmFsNzgsIHZhbDc5LCB2YWw4MDsKKyAgICBsZXQgdmFsODEsIHZhbDgyLCB2YWw4MywgdmFsODQs IHZhbDg1LCB2YWw4NiwgdmFsODcsIHZhbDg4LCB2YWw4OSwgdmFsOTA7CisgICAgbGV0IHZhbDkx LCB2YWw5MiwgdmFsOTMsIHZhbDk0LCB2YWw5NSwgdmFsOTYsIHZhbDk3LCB2YWw5OCwgdmFsOTks IHZhbDEwMDsKKyAgICBsZXQgdmFsMTAxLCB2YWwxMDIsIHZhbDEwMywgdmFsMTA0LCB2YWwxMDUs IHZhbDEwNiwgdmFsMTA3LCB2YWwxMDgsIHZhbDEwOSwgdmFsMTEwOworICAgIGxldCB2YWwxMTEs IHZhbDExMiwgdmFsMTEzLCB2YWwxMTQsIHZhbDExNSwgdmFsMTE2LCB2YWwxMTcsIHZhbDExOCwg dmFsMTE5LCB2YWwxMjA7CisgICAgbGV0IHZhbDEyMSwgdmFsMTIyLCB2YWwxMjMsIHZhbDEyNCwg dmFsMTI1LCB2YWwxMjYsIHZhbDEyNywgdmFsMTI4LCB2YWwxMjksIHZhbDEzMDsKKyAgICBsZXQg dmFsMTMxLCB2YWwxMzIsIHZhbDEzMywgdmFsMTM0LCB2YWwxMzUsIHZhbDEzNiwgdmFsMTM3LCB2 YWwxMzgsIHZhbDEzOSwgdmFsMTQwOworICAgIGxldCB2YWwxNDEsIHZhbDE0MiwgdmFsMTQzLCB2 YWwxNDQsIHZhbDE0NSwgdmFsMTQ2LCB2YWwxNDcsIHZhbDE0OCwgdmFsMTQ5LCB2YWwxNTA7Cisg ICAgbGV0IHZhbDE1MSwgdmFsMTUyLCB2YWwxNTMsIHZhbDE1NCwgdmFsMTU1LCB2YWwxNTYsIHZh bDE1NywgdmFsMTU4LCB2YWwxNTksIHZhbDE2MDsKKyAgICBsZXQgdmFsMTYxLCB2YWwxNjIsIHZh bDE2MywgdmFsMTY0LCB2YWwxNjUsIHZhbDE2NiwgdmFsMTY3LCB2YWwxNjgsIHZhbDE2OSwgdmFs MTcwOworICAgIGxldCB2YWwxNzEsIHZhbDE3MiwgdmFsMTczLCB2YWwxNzQsIHZhbDE3NSwgdmFs MTc2LCB2YWwxNzcsIHZhbDE3OCwgdmFsMTc5LCB2YWwxODA7CisgICAgbGV0IHZhbDE4MSwgdmFs MTgyLCB2YWwxODMsIHZhbDE4NCwgdmFsMTg1LCB2YWwxODYsIHZhbDE4NywgdmFsMTg4LCB2YWwx ODksIHZhbDE5MDsKKyAgICBsZXQgdmFsMTkxLCB2YWwxOTIsIHZhbDE5MywgdmFsMTk0LCB2YWwx OTUsIHZhbDE5NiwgdmFsMTk3LCB2YWwxOTgsIHZhbDE5OSwgdmFsMjAwOworICAgIGxldCB2YWwy MDEsIHZhbDIwMiwgdmFsMjAzLCB2YWwyMDQsIHZhbDIwNSwgdmFsMjA2LCB2YWwyMDcsIHZhbDIw OCwgdmFsMjA5LCB2YWwyMTA7CisgICAgbGV0IHZhbDIxMSwgdmFsMjEyLCB2YWwyMTMsIHZhbDIx NCwgdmFsMjE1LCB2YWwyMTYsIHZhbDIxNywgdmFsMjE4LCB2YWwyMTksIHZhbDIyMDsKKyAgICBs ZXQgdmFsMjIxLCB2YWwyMjIsIHZhbDIyMywgdmFsMjI0LCB2YWwyMjUsIHZhbDIyNiwgdmFsMjI3 LCB2YWwyMjgsIHZhbDIyOSwgdmFsMjMwOworICAgIGxldCB2YWwyMzEsIHZhbDIzMiwgdmFsMjMz LCB2YWwyMzQsIHZhbDIzNSwgdmFsMjM2LCB2YWwyMzcsIHZhbDIzOCwgdmFsMjM5LCB2YWwyNDA7 CisgICAgbGV0IHZhbDI0MSwgdmFsMjQyLCB2YWwyNDMsIHZhbDI0NCwgdmFsMjQ1LCB2YWwyNDYs IHZhbDI0NywgdmFsMjQ4LCB2YWwyNDksIHZhbDI1MDsKKyAgICBsZXQgdmFsMjUxLCB2YWwyNTIs IHZhbDI1MywgdmFsMjU0LCB2YWwyNTUsIHZhbDI1NiwgdmFsMjU3LCB2YWwyNTgsIHZhbDI1OSwg dmFsMjYwOworICAgIGxldCB2YWwyNjEsIHZhbDI2MiwgdmFsMjYzLCB2YWwyNjQsIHZhbDI2NSwg dmFsMjY2LCB2YWwyNjcsIHZhbDI2OCwgdmFsMjY5LCB2YWwyNzA7CisgICAgbGV0IHZhbDI3MSwg dmFsMjcyLCB2YWwyNzMsIHZhbDI3NCwgdmFsMjc1LCB2YWwyNzYsIHZhbDI3NywgdmFsMjc4LCB2 YWwyNzksIHZhbDI4MDsKKyAgICBsZXQgdmFsMjgxLCB2YWwyODIsIHZhbDI4MywgdmFsMjg0LCB2 YWwyODUsIHZhbDI4NiwgdmFsMjg3LCB2YWwyODgsIHZhbDI4OSwgdmFsMjkwOworICAgIGxldCB2 YWwyOTEsIHZhbDI5MiwgdmFsMjkzLCB2YWwyOTQsIHZhbDI5NSwgdmFsMjk2LCB2YWwyOTcsIHZh bDI5OCwgdmFsMjk5LCB2YWwzMDA7CisgICAgbGV0IHZhbDMwMSwgdmFsMzAyLCB2YWwzMDMsIHZh bDMwNCwgdmFsMzA1LCB2YWwzMDYsIHZhbDMwNywgdmFsMzA4LCB2YWwzMDksIHZhbDMxMDsKKyAg ICBsZXQgdmFsMzExLCB2YWwzMTIsIHZhbDMxMywgdmFsMzE0LCB2YWwzMTUsIHZhbDMxNiwgdmFs MzE3LCB2YWwzMTgsIHZhbDMxOSwgdmFsMzIwOworICAgIGxldCB2YWwzMjEsIHZhbDMyMiwgdmFs MzIzLCB2YWwzMjQsIHZhbDMyNSwgdmFsMzI2LCB2YWwzMjcsIHZhbDMyOCwgdmFsMzI5LCB2YWwz MzA7CisgICAgbGV0IHZhbDMzMSwgdmFsMzMyLCB2YWwzMzMsIHZhbDMzNCwgdmFsMzM1LCB2YWwz MzYsIHZhbDMzNywgdmFsMzM4LCB2YWwzMzksIHZhbDM0MDsKKyAgICBsZXQgdmFsMzQxLCB2YWwz NDIsIHZhbDM0MywgdmFsMzQ0LCB2YWwzNDUsIHZhbDM0NiwgdmFsMzQ3LCB2YWwzNDgsIHZhbDM0 OSwgdmFsMzUwOworICAgIGxldCB2YWwzNTEsIHZhbDM1MiwgdmFsMzUzLCB2YWwzNTQsIHZhbDM1 NSwgdmFsMzU2LCB2YWwzNTcsIHZhbDM1OCwgdmFsMzU5LCB2YWwzNjA7CisgICAgbGV0IHZhbDM2 MSwgdmFsMzYyLCB2YWwzNjMsIHZhbDM2NCwgdmFsMzY1LCB2YWwzNjYsIHZhbDM2NywgdmFsMzY4 LCB2YWwzNjksIHZhbDM3MDsKKyAgICBsZXQgdmFsMzcxLCB2YWwzNzIsIHZhbDM3MywgdmFsMzc0 LCB2YWwzNzUsIHZhbDM3NiwgdmFsMzc3LCB2YWwzNzgsIHZhbDM3OSwgdmFsMzgwOworICAgIGxl dCB2YWwzODEsIHZhbDM4MiwgdmFsMzgzLCB2YWwzODQsIHZhbDM4NSwgdmFsMzg2LCB2YWwzODcs IHZhbDM4OCwgdmFsMzg5LCB2YWwzOTA7CisgICAgbGV0IHZhbDM5MSwgdmFsMzkyLCB2YWwzOTMs IHZhbDM5NCwgdmFsMzk1LCB2YWwzOTYsIHZhbDM5NywgdmFsMzk4LCB2YWwzOTksIHZhbDQwMDsK KworICAgIHRyeUNhbGxpbmdCYWRGdW5jdGlvbigpOworfQorCitmdW5jdGlvbiB0ZXN0KCkKK3sK KyAgICB0cnkgeworICAgICAgICByZWN1cnNlKCk7CisgICAgfSBjYXRjaChlcnJvcikgeworICAg ICAgICBpZiAoZXJyb3IgIT0gIlJhbmdlRXJyb3I6IE1heGltdW0gY2FsbCBzdGFjayBzaXplIGV4 Y2VlZGVkLiIpCisgICAgICAgICAgICB0aHJvdyAiRXhwZWN0ZWQ6IFwiUmFuZ2VFcnJvcjogTWF4 aW11bSBjYWxsIHN0YWNrIHNpemUgZXhjZWVkZWQuXCIsIGJ1dCBnb3Q6ICIgKyBlcnJvcjsKKwor ICAgICAgICBsZXQgaGVhcFVzZWQgPSBnY0hlYXBTaXplKCk7CisgICAgICAgIGlmIChoZWFwVXNl ZCA+IG1heEhlYXBBbGxvd2VkKQorICAgICAgICAgICAgdGhyb3cgIlVzZWQgdG9vIG11Y2ggaGVh cC4gIExpbWl0IHdhcyAiICsgbWF4SGVhcEFsbG93ZWQgKyAiIGJ5dGVzLCBidXQgd2UgdXNlZCAi ICsgaGVhcFVzZWQgKyAiIGJ5dGVzLiI7CisgICAgfQorCisgICAgaWYgKGxvZ2dlZEVycm9yLm5h bWUgIT0gIlR5cGVFcnJvciIpCisgICAgICAgIHRocm93ICJFeHBlY3RlZCBsb2dnZWQgZXJyb3Ig dG8gYmU6IFwiVHlwZUVycm9yXCIsIGJ1dCBnb3Q6ICIgKyBsb2dnZWRFcnJvci5uYW1lOworfQor Cit0ZXN0KCk7CisK