158253 2016-06-01 00:14:06 -0700 Close wptserve response file handles explicitly 2016-06-01 09:20:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 158137 1 youennf youennf ap commit-queue lforschler oldest_to_newest 1198088 0 youennf 2016-06-01 00:14:06 -0700 wptserve is not closing file-served response file handles explicitly. This may explain https://bugs.webkit.org/show_bug.cgi?id=158137. 1198089 1 280219 youennf 2016-06-01 00:20:04 -0700 Created attachment 280219 Patch 1198157 2 280219 ap 2016-06-01 08:58:09 -0700 Comment on attachment 280219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280219&action=review > LayoutTests/imported/w3c/resources/web-platform-tests-modules.json:91 > - "url": "https://github.com/youennf/wptserve/archive/9c84ebd90130bef40d440981e0f55947418678b3.tar.gz", > - "url_subpath": "wptserve-9c84ebd90130bef40d440981e0f55947418678b3" > + "url": "https://github.com/youennf/wptserve/archive/fc902e97a21b8470dcdaab8c70691aea1fecbc12.tar.gz", > + "url_subpath": "wptserve-fc902e97a21b8470dcdaab8c70691aea1fecbc12" I don't think that this is the right development model for WebKit. 1198170 3 280219 commit-queue 2016-06-01 09:20:42 -0700 Comment on attachment 280219 Patch Clearing flags on attachment: 280219 Committed r201555: <http://trac.webkit.org/changeset/201555> 1198171 4 commit-queue 2016-06-01 09:20:46 -0700 All reviewed patches have been landed. Closing bug. 280219 2016-06-01 00:20:04 -0700 2016-06-01 09:20:42 -0700 Patch bug-158253-20160601092120.patch text/plain 1722 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNTQ0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp bmRleCBjZGQ3ZDA5ZWUyYWMxYTU1NjljYTEyODZiZmJhOWI5OGNmZTc4YWMzLi5iMmQzZTdiMDA4 ZjU5YjdhOGU2NDAyNjlhN2QxMmVlMzJlMjMwMDg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0wNi0wMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCisgICAgICAgIENsb3NlIHdwdHNlcnZlIHJlc3BvbnNl IGZpbGUgaGFuZGxlcyBleHBsaWNpdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTgyNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTZWUgaHR0cHM6Ly9naXRodWIuY29tL3lvdWVubmYvd3B0c2VydmUv Y29tbWl0L2ZjOTAyZTk3YTIxYjg0NzBkY2RhYWI4YzcwNjkxYWVhMWZlY2JjMTIKKworICAgICAg ICAqIHJlc291cmNlcy93ZWItcGxhdGZvcm0tdGVzdHMtbW9kdWxlcy5qc29uOiBVcGRhdGluZyB3 cHRzZXJ2ZSBtb2R1bGUgdG8gY2xvc2UgcmVzcG9uc2UgZmlsZSBoYW5kbGVzIG9uY2Ugd3JpdHRl bi4KKwogMjAxNi0wNS0yOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9u LmZyPgogCiAgICAgICAgIEFkZGluZyB3cHRzZXJ2ZSBsb2dnaW5nIGZvciA0MDQgZmlsZS1zZXJ2 aW5nIHJlc3BvbnNlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3Jlc291 cmNlcy93ZWItcGxhdGZvcm0tdGVzdHMtbW9kdWxlcy5qc29uIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3Jlc291cmNlcy93ZWItcGxhdGZvcm0tdGVzdHMtbW9kdWxlcy5qc29uCmluZGV4IDgw ZDllMGFkNjVkOTJmYzU4MDk2MTZiYzQ0ZGUwYWFmZTU4YTJkYjguLjRiNDhhYzZjYzYyNDNkY2I3 ZTgxODIzYzBmYmM1YTIyNWFlYmM1NjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy9yZXNvdXJjZXMvd2ViLXBsYXRmb3JtLXRlc3RzLW1vZHVsZXMuanNvbgorKysgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2MvcmVzb3VyY2VzL3dlYi1wbGF0Zm9ybS10ZXN0cy1tb2R1bGVz Lmpzb24KQEAgLTg3LDcgKzg3LDcgQEAKICAgICAgICAgICAgICJ0b29scyIsIAogICAgICAgICAg ICAgIndwdHNlcnZlIgogICAgICAgICBdLCAKLSAgICAgICAgInVybCI6ICJodHRwczovL2dpdGh1 Yi5jb20veW91ZW5uZi93cHRzZXJ2ZS9hcmNoaXZlLzljODRlYmQ5MDEzMGJlZjQwZDQ0MDk4MWUw ZjU1OTQ3NDE4Njc4YjMudGFyLmd6IiwKLSAgICAgICAgInVybF9zdWJwYXRoIjogIndwdHNlcnZl LTljODRlYmQ5MDEzMGJlZjQwZDQ0MDk4MWUwZjU1OTQ3NDE4Njc4YjMiCisgICAgICAgICJ1cmwi OiAiaHR0cHM6Ly9naXRodWIuY29tL3lvdWVubmYvd3B0c2VydmUvYXJjaGl2ZS9mYzkwMmU5N2Ey MWI4NDcwZGNkYWFiOGM3MDY5MWFlYTFmZWNiYzEyLnRhci5neiIsCisgICAgICAgICJ1cmxfc3Vi cGF0aCI6ICJ3cHRzZXJ2ZS1mYzkwMmU5N2EyMWI4NDcwZGNkYWFiOGM3MDY5MWFlYTFmZWNiYzEy IgogICAgIH0KIF0K