158239 2016-05-31 15:15:34 -0700 Notify client immediately if network session doesn't exist for a synchronous XHR load. 2016-06-01 22:38:39 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca beidson commit-queue mitz sam thorton oldest_to_newest 1197976 0 yongjun_zhang 2016-05-31 15:15:34 -0700 For a synchronous XHR load, if the network session doesn't exist, we should notify NetworkLoadClient immediately. Otherwise the Web process could hang when waiting for the synchronous load to finish. 1197977 1 yongjun_zhang 2016-05-31 15:16:14 -0700 <rdar://problem/26344251> 1197980 2 280188 yongjun_zhang 2016-05-31 15:28:11 -0700 Created attachment 280188 Notify the client immediately when the network session doesn't exist for a sync XHR request. 1198017 3 280188 beidson 2016-05-31 16:59:14 -0700 Comment on attachment 280188 Notify the client immediately when the network session doesn't exist for a sync XHR request. Why is this only an issue for sync loads? It seems like it's an issue for async loads, too. Sync loads cause a larger issue because the WebProcess is purposefully hanging for them, but isn't it also bad for the WebProcess to think an async load is happening.... forever...? Even though it will never happen? 1198022 4 yongjun_zhang 2016-05-31 17:24:27 -0700 (In reply to comment #3) > Comment on attachment 280188 [details] > Notify the client immediately when the network session doesn't exist for a > sync XHR request. > > Why is this only an issue for sync loads? It seems like it's an issue for > async loads, too. > > Sync loads cause a larger issue because the WebProcess is purposefully > hanging for them, but isn't it also bad for the WebProcess to think an async > load is happening.... forever...? Even though it will never happen? I wasn't able to reproduce with async load. We could hit the point where the network session is removed for an async load. However, since this only happens when we closing a web page, Web Process will cancel the load immediately and we won't have a long waiting WebProcess. 1198034 5 beidson 2016-05-31 18:30:51 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 280188 [details] > > Notify the client immediately when the network session doesn't exist for a > > sync XHR request. > > > > Why is this only an issue for sync loads? It seems like it's an issue for > > async loads, too. > > > > Sync loads cause a larger issue because the WebProcess is purposefully > > hanging for them, but isn't it also bad for the WebProcess to think an async > > load is happening.... forever...? Even though it will never happen? > > I wasn't able to reproduce with async load. We could hit the point where the > network session is removed for an async load. However, since this only > happens when we closing a web page, Web Process will cancel the load > immediately and we won't have a long waiting WebProcess. That's *currently* the only time a Session can be removed, but I foresee that could change in the future. I don't see any downside to immediately signaling the error for all loads. You've looked at the code more recently - Do you foresee any downside? 1198057 6 yongjun_zhang 2016-05-31 21:20:05 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Comment on attachment 280188 [details] > > > Notify the client immediately when the network session doesn't exist for a > > > sync XHR request. > > > > > > Why is this only an issue for sync loads? It seems like it's an issue for > > > async loads, too. > > > > > > Sync loads cause a larger issue because the WebProcess is purposefully > > > hanging for them, but isn't it also bad for the WebProcess to think an async > > > load is happening.... forever...? Even though it will never happen? > > > > I wasn't able to reproduce with async load. We could hit the point where the > > network session is removed for an async load. However, since this only > > happens when we closing a web page, Web Process will cancel the load > > immediately and we won't have a long waiting WebProcess. > > That's *currently* the only time a Session can be removed, but I foresee > that could change in the future. > > I don't see any downside to immediately signaling the error for all loads. > > You've looked at the code more recently - Do you foresee any downside? I don't see any downside either, and I agree signaling the error for all loads sounds more future-proof. I will submit another path. Thanks! 1198209 7 280250 yongjun_zhang 2016-06-01 11:27:51 -0700 Created attachment 280250 Signal the error for all loads. 1198236 8 andersca 2016-06-01 12:37:38 -0700 Should the callback be made asynchronously, with RunLoop::dispatch or equivalent? 1198260 9 beidson 2016-06-01 13:31:50 -0700 (In reply to comment #8) > Should the callback be made asynchronously, with RunLoop::dispatch or > equivalent? This was going to be my review feedback. It should be asynchronous. 1198261 10 280250 beidson 2016-06-01 13:32:59 -0700 Comment on attachment 280250 Signal the error for all loads. View in context: https://bugs.webkit.org/attachment.cgi?id=280250&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:62 > + m_client.didFailLoading(internalError(m_currentRequest.url())); Synchronously calling back to the client - especially in the constructor - is probably inviting trouble. We should spin the runloop. 1198296 11 280269 yongjun_zhang 2016-06-01 15:00:52 -0700 Created attachment 280269 V3: notify the client asynchronously. 1198343 12 280269 beidson 2016-06-01 17:11:20 -0700 Comment on attachment 280269 V3: notify the client asynchronously. View in context: https://bugs.webkit.org/attachment.cgi?id=280269&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:64 > + RunLoop::main().dispatch([this, url = parameters.request.url()] { > + didCompleteWithError(internalError(url)); > + }); This is a super nit pick, and the first time I've ever suggested it... But we've been looking at all of our lambda usage lately, and going over things like "RunLoop::dispatch" and "callOnMainThread" with a fine toothed comb. We've found a number of thread safety issues. At a glance, this looks like a potential thread safety issue, because it's unsafe to send a URL across threads without making an isolatedCopy() of it first. Of course this isn't *actually* a thread safety issue because it's not cross thread - RunLoop::main() happens to also be the current RunLoop. If the dispatch was instead "RunLoop::current().dispatch(...)", then I wouldn't even have considered it a potential thread safety issue. If you'd like to make that change, that'd be nice. I haven't thought about it a lot yet, but I think that's what we should do going forward and will likely be discussing with a larger audience soon. r+ either way. 1198446 13 yongjun_zhang 2016-06-01 21:53:08 -0700 (In reply to comment #12) > Comment on attachment 280269 [details] > V3: notify the client asynchronously. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280269&action=review > > > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:64 > > + RunLoop::main().dispatch([this, url = parameters.request.url()] { > > + didCompleteWithError(internalError(url)); > > + }); > > This is a super nit pick, and the first time I've ever suggested it... > > But we've been looking at all of our lambda usage lately, and going over > things like "RunLoop::dispatch" and "callOnMainThread" with a fine toothed > comb. We've found a number of thread safety issues. > > At a glance, this looks like a potential thread safety issue, because it's > unsafe to send a URL across threads without making an isolatedCopy() of it > first. Yes, I had the same concern at first, but I convinced myself it won't be an issue - it looks like we expected NetworkLoad to always work on main thread (e.g., we assert this in couple of places). > > Of course this isn't *actually* a thread safety issue because it's not cross > thread - RunLoop::main() happens to also be the current RunLoop. > > If the dispatch was instead "RunLoop::current().dispatch(...)", then I > wouldn't even have considered it a potential thread safety issue. > > If you'd like to make that change, that'd be nice. I haven't thought about > it a lot yet, but I think that's what we should do going forward and will > likely be discussing with a larger audience soon. Sure thing! I will make this change before landing. > > r+ either way. Thank you for the review! 1198451 14 280307 yongjun_zhang 2016-06-01 22:07:55 -0700 Created attachment 280307 Address review comments before landing. 1198456 15 280307 commit-queue 2016-06-01 22:38:34 -0700 Comment on attachment 280307 Address review comments before landing. Clearing flags on attachment: 280307 Committed r201593: <http://trac.webkit.org/changeset/201593> 1198457 16 commit-queue 2016-06-01 22:38:39 -0700 All reviewed patches have been landed. Closing bug. 280188 2016-05-31 15:28:11 -0700 2016-06-01 11:27:51 -0700 Notify the client immediately when the network session doesn't exist for a sync XHR request. svc_unresponsive_web_process.patch text/plain 2597 yongjun_zhang Y29tbWl0IDAzYjM2YzQ4ZjAyNzFhODI3ZjMyMGMzYjUyNDliY2RiNTczYjg5NDcKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgTWF5IDMx IDE0OjIwOjUwIDIwMTYgLTA3MDAKCiAgICBOb3RpZnkgY2xpZW50IGltbWVkaWF0ZWx5IGlmIG5l dHdvcmsgc2Vzc2lvbiBkb2Vzbid0IGV4aXN0IGZvciBhIHN5bmNocm9ub3VzIFhIUiBsb2FkLgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODIzOQogICAgPHJk YXI6Ly9wcm9ibGVtLzI2MzQ0MjUxPgogICAgCiAgICBGb3IgYSBzeW5jaHJvbm91cyBYSFIgbG9h ZCwgaWYgdGhlIG5ldHdvcmsgc2Vzc2lvbiBkb2Vzbid0IGV4aXN0LCB3ZSBzaG91bGQgbm90aWZ5 IE5ldHdvcmtMb2FkQ2xpZW50CiAgICBpbW1lZGlhdGVseS4gT3RoZXJ3aXNlIHRoZSBXZWIgcHJv Y2VzcyBjb3VsZCBoYW5nIHdoZW4gd2FpdGluZyBmb3IgdGhlIHN5bmNocm9ub3VzIGxvYWQgdG8g ZmluaXNoLgogICAgCiAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcDoKICAgIChX ZWJLaXQ6Ok5ldHdvcmtMb2FkOjpOZXR3b3JrTG9hZCk6CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGEyYjQ1ZWIu LjgxYzY1OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNi0wNS0zMSAgWW9uZ2p1 biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgorCisgICAgICAgIE5vdGlmeSBjbGll bnQgaW1tZWRpYXRlbHkgaWYgbmV0d29yayBzZXNzaW9uIGRvZXNuJ3QgZXhpc3QgZm9yIGEgc3lu Y2hyb25vdXMgWEhSIGxvYWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTgyMzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2MzQ0MjUxPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBhIHN5bmNo cm9ub3VzIFhIUiBsb2FkLCBpZiB0aGUgbmV0d29yayBzZXNzaW9uIGRvZXNuJ3QgZXhpc3QsIHdl IHNob3VsZCBub3RpZnkgTmV0d29ya0xvYWRDbGllbnQKKyAgICAgICAgaW1tZWRpYXRlbHkuIE90 aGVyd2lzZSB0aGUgV2ViIHByb2Nlc3MgY291bGQgaGFuZyB3aGVuIHdhaXRpbmcgZm9yIHRoZSBz eW5jaHJvbm91cyBsb2FkIHRvIGZpbmlzaC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05l dHdvcmtMb2FkLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2Fk KToKKwogMjAxNi0wNS0zMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIEJldHRlciBkZWFsIHdpdGggV2ViUHJvY2VzcyBzdXNwZW5zaW9uIGR1ZSB0byBz Y3JlZW4gbG9ja2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya0xvYWQuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xv YWQuY3BwCmluZGV4IDU2MDg5YmYuLmJhNzkwMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAKQEAgLTU3LDggKzU3LDExIEBAIE5ldHdvcmtMb2Fk OjpOZXR3b3JrTG9hZChOZXR3b3JrTG9hZENsaWVudCYgY2xpZW50LCBjb25zdCBOZXR3b3JrTG9h ZFBhcmFtZXRlcnMmCiAgICAgICAgIG1fdGFzayA9IE5ldHdvcmtEYXRhVGFzazo6Y3JlYXRlKCpu ZXR3b3JrU2Vzc2lvbiwgKnRoaXMsIHBhcmFtZXRlcnMucmVxdWVzdCwgcGFyYW1ldGVycy5hbGxv d1N0b3JlZENyZWRlbnRpYWxzLCBwYXJhbWV0ZXJzLmNvbnRlbnRTbmlmZmluZ1BvbGljeSwgcGFy YW1ldGVycy5zaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0KTsKICAgICAg ICAgaWYgKCFwYXJhbWV0ZXJzLmRlZmVyc0xvYWRpbmcpCiAgICAgICAgICAgICBtX3Rhc2stPnJl c3VtZSgpOwotICAgIH0gZWxzZQorICAgIH0gZWxzZSB7CiAgICAgICAgIFdURkxvZ0Fsd2F5cygi QXR0ZW1wdGVkIHRvIGNyZWF0ZSBhIE5ldHdvcmtMb2FkIHdpdGggYSBzZXNzaW9uIChpZD0lIiBQ Ukl1NjQgIikgdGhhdCBkb2VzIG5vdCBleGlzdC4iLCBwYXJhbWV0ZXJzLnNlc3Npb25JRC5zZXNz aW9uSUQoKSk7CisgICAgICAgIGlmIChtX2NsaWVudC5pc1N5bmNocm9ub3VzKCkpCisgICAgICAg ICAgICBtX2NsaWVudC5kaWRGYWlsTG9hZGluZyhpbnRlcm5hbEVycm9yKG1fY3VycmVudFJlcXVl c3QudXJsKCkpKTsKKyAgICB9CiAjZWxzZQogICAgIG1faGFuZGxlID0gUmVzb3VyY2VIYW5kbGU6 OmNyZWF0ZShtX25ldHdvcmtpbmdDb250ZXh0LmdldCgpLCBwYXJhbWV0ZXJzLnJlcXVlc3QsIHRo aXMsIHBhcmFtZXRlcnMuZGVmZXJzTG9hZGluZywgcGFyYW1ldGVycy5jb250ZW50U25pZmZpbmdQ b2xpY3kgPT0gU25pZmZDb250ZW50KTsKICNlbmRpZgo= 280250 2016-06-01 11:27:51 -0700 2016-06-01 15:00:52 -0700 Signal the error for all loads. webprocess_unresponsive.patch text/plain 2571 yongjun_zhang Y29tbWl0IGRhZTY2MzdhOWFiMGQ5NGI2Y2Q3NTI5MDhmYTVhZjk3YzgxMmY0MzYKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgTWF5IDMx IDE0OjIwOjUwIDIwMTYgLTA3MDAKCiAgICBOb3RpZnkgY2xpZW50IGltbWVkaWF0ZWx5IGlmIG5l dHdvcmsgc2Vzc2lvbiBkb2Vzbid0IGV4aXN0IGZvciBhIHN5bmNocm9ub3VzIFhIUiBsb2FkLgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODIzOQogICAgPHJk YXI6Ly9wcm9ibGVtLzI2MzQ0MjUxPgogICAgCiAgICBXaGVuIHN0YXJ0aW5nIGEgbmV0d29yayBs b2FkLCBpZiB0aGUgbmV0d29yayBzZXNzaW9uIGRvZXNuJ3QgZXhpc3QsIHdlIHNob3VsZCBub3Rp ZnkgTmV0d29ya0xvYWRDbGllbnQKICAgIGltbWVkaWF0ZWx5LiBPdGhlcndpc2UgdGhlIFdlYiBw cm9jZXNzIGNvdWxkIGhhbmcgd2hlbiB3YWl0aW5nIGZvciB0aGUgc3luY2hyb25vdXMgbG9hZCB0 byBmaW5pc2guCiAgICAKICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgogICAg KFdlYktpdDo6TmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2FkKToKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjhmNmQ0 ZS4uZDk1ZmU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA1LTMxICBZb25n anVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTm90aWZ5IGNs aWVudCBpbW1lZGlhdGVseSBpZiBuZXR3b3JrIHNlc3Npb24gZG9lc24ndCBleGlzdCBmb3IgYSBz eW5jaHJvbm91cyBYSFIgbG9hZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1ODIzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYzNDQyNTE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIGEgc3lu Y2hyb25vdXMgWEhSIGxvYWQsIGlmIHRoZSBuZXR3b3JrIHNlc3Npb24gZG9lc24ndCBleGlzdCwg d2Ugc2hvdWxkIG5vdGlmeSBOZXR3b3JrTG9hZENsaWVudAorICAgICAgICBpbW1lZGlhdGVseS4g T3RoZXJ3aXNlIHRoZSBXZWIgcHJvY2VzcyBjb3VsZCBoYW5nIHdoZW4gd2FpdGluZyBmb3IgdGhl IHN5bmNocm9ub3VzIGxvYWQgdG8gZmluaXNoLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv TmV0d29ya0xvYWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6TmV0d29ya0xv YWQpOgorCiAyMDE2LTA1LTMxICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGwgb3V0IHIyMDE0ODEsIHIyMDE1MjM6IDAuMyUg cmVncmVzc2lvbiBpbiBPY3RhbmUgY29kZS1sb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAKaW5kZXggNTYwODliZi4uMDU5N2YwZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcApAQCAtNTcsOCArNTcs MTAgQEAgTmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2FkKE5ldHdvcmtMb2FkQ2xpZW50JiBjbGllbnQs IGNvbnN0IE5ldHdvcmtMb2FkUGFyYW1ldGVycyYKICAgICAgICAgbV90YXNrID0gTmV0d29ya0Rh dGFUYXNrOjpjcmVhdGUoKm5ldHdvcmtTZXNzaW9uLCAqdGhpcywgcGFyYW1ldGVycy5yZXF1ZXN0 LCBwYXJhbWV0ZXJzLmFsbG93U3RvcmVkQ3JlZGVudGlhbHMsIHBhcmFtZXRlcnMuY29udGVudFNu aWZmaW5nUG9saWN5LCBwYXJhbWV0ZXJzLnNob3VsZENsZWFyUmVmZXJyZXJPbkhUVFBTVG9IVFRQ UmVkaXJlY3QpOwogICAgICAgICBpZiAoIXBhcmFtZXRlcnMuZGVmZXJzTG9hZGluZykKICAgICAg ICAgICAgIG1fdGFzay0+cmVzdW1lKCk7Ci0gICAgfSBlbHNlCisgICAgfSBlbHNlIHsKICAgICAg ICAgV1RGTG9nQWx3YXlzKCJBdHRlbXB0ZWQgdG8gY3JlYXRlIGEgTmV0d29ya0xvYWQgd2l0aCBh IHNlc3Npb24gKGlkPSUiIFBSSXU2NCAiKSB0aGF0IGRvZXMgbm90IGV4aXN0LiIsIHBhcmFtZXRl cnMuc2Vzc2lvbklELnNlc3Npb25JRCgpKTsKKyAgICAgICAgbV9jbGllbnQuZGlkRmFpbExvYWRp bmcoaW50ZXJuYWxFcnJvcihtX2N1cnJlbnRSZXF1ZXN0LnVybCgpKSk7CisgICAgfQogI2Vsc2UK ICAgICBtX2hhbmRsZSA9IFJlc291cmNlSGFuZGxlOjpjcmVhdGUobV9uZXR3b3JraW5nQ29udGV4 dC5nZXQoKSwgcGFyYW1ldGVycy5yZXF1ZXN0LCB0aGlzLCBwYXJhbWV0ZXJzLmRlZmVyc0xvYWRp bmcsIHBhcmFtZXRlcnMuY29udGVudFNuaWZmaW5nUG9saWN5ID09IFNuaWZmQ29udGVudCk7CiAj ZW5kaWYK 280269 2016-06-01 15:00:52 -0700 2016-06-01 22:08:50 -0700 V3: notify the client asynchronously. webprocess_unresponsive.patch text/plain 2641 yongjun_zhang Y29tbWl0IDdlMTY5ODYxNjA4ZTlkZDUxYTU0ZmQxZjc2MDQ4ODgwZTA4ZGQ1MzMKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgTWF5IDMx IDE0OjIwOjUwIDIwMTYgLTA3MDAKCiAgICBOb3RpZnkgY2xpZW50IGltbWVkaWF0ZWx5IGlmIG5l dHdvcmsgc2Vzc2lvbiBkb2Vzbid0IGV4aXN0IGZvciBhIHN5bmNocm9ub3VzIFhIUiBsb2FkLgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODIzOQogICAgPHJk YXI6Ly9wcm9ibGVtLzI2MzQ0MjUxPgogICAgCiAgICBXaGVuIHN0YXJ0aW5nIGEgbmV0d29yayBs b2FkLCBpZiB0aGUgbmV0d29yayBzZXNzaW9uIGRvZXNuJ3QgZXhpc3QsIHdlIHNob3VsZCBub3Rp ZnkgTmV0d29ya0xvYWRDbGllbnQKICAgIGltbWVkaWF0ZWx5LiBPdGhlcndpc2UgdGhlIFdlYiBw cm9jZXNzIGNvdWxkIGhhbmcgd2hlbiB3YWl0aW5nIGZvciB0aGUgc3luY2hyb25vdXMgbG9hZCB0 byBmaW5pc2guCiAgICAKICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgogICAg KFdlYktpdDo6TmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2FkKToKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjhmNmQ0 ZS4uZDk1ZmU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA1LTMxICBZb25n anVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTm90aWZ5IGNs aWVudCBpbW1lZGlhdGVseSBpZiBuZXR3b3JrIHNlc3Npb24gZG9lc24ndCBleGlzdCBmb3IgYSBz eW5jaHJvbm91cyBYSFIgbG9hZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1ODIzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYzNDQyNTE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIGEgc3lu Y2hyb25vdXMgWEhSIGxvYWQsIGlmIHRoZSBuZXR3b3JrIHNlc3Npb24gZG9lc24ndCBleGlzdCwg d2Ugc2hvdWxkIG5vdGlmeSBOZXR3b3JrTG9hZENsaWVudAorICAgICAgICBpbW1lZGlhdGVseS4g T3RoZXJ3aXNlIHRoZSBXZWIgcHJvY2VzcyBjb3VsZCBoYW5nIHdoZW4gd2FpdGluZyBmb3IgdGhl IHN5bmNocm9ub3VzIGxvYWQgdG8gZmluaXNoLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv TmV0d29ya0xvYWQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6TmV0d29ya0xv YWQpOgorCiAyMDE2LTA1LTMxICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGwgb3V0IHIyMDE0ODEsIHIyMDE1MjM6IDAuMyUg cmVncmVzc2lvbiBpbiBPY3RhbmUgY29kZS1sb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAKaW5kZXggNTYwODliZi4uZTAyNTdhZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcApAQCAtNTcsOCArNTcs MTIgQEAgTmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2FkKE5ldHdvcmtMb2FkQ2xpZW50JiBjbGllbnQs IGNvbnN0IE5ldHdvcmtMb2FkUGFyYW1ldGVycyYKICAgICAgICAgbV90YXNrID0gTmV0d29ya0Rh dGFUYXNrOjpjcmVhdGUoKm5ldHdvcmtTZXNzaW9uLCAqdGhpcywgcGFyYW1ldGVycy5yZXF1ZXN0 LCBwYXJhbWV0ZXJzLmFsbG93U3RvcmVkQ3JlZGVudGlhbHMsIHBhcmFtZXRlcnMuY29udGVudFNu aWZmaW5nUG9saWN5LCBwYXJhbWV0ZXJzLnNob3VsZENsZWFyUmVmZXJyZXJPbkhUVFBTVG9IVFRQ UmVkaXJlY3QpOwogICAgICAgICBpZiAoIXBhcmFtZXRlcnMuZGVmZXJzTG9hZGluZykKICAgICAg ICAgICAgIG1fdGFzay0+cmVzdW1lKCk7Ci0gICAgfSBlbHNlCisgICAgfSBlbHNlIHsKICAgICAg ICAgV1RGTG9nQWx3YXlzKCJBdHRlbXB0ZWQgdG8gY3JlYXRlIGEgTmV0d29ya0xvYWQgd2l0aCBh IHNlc3Npb24gKGlkPSUiIFBSSXU2NCAiKSB0aGF0IGRvZXMgbm90IGV4aXN0LiIsIHBhcmFtZXRl cnMuc2Vzc2lvbklELnNlc3Npb25JRCgpKTsKKyAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3Bh dGNoKFt0aGlzLCB1cmwgPSBwYXJhbWV0ZXJzLnJlcXVlc3QudXJsKCldIHsKKyAgICAgICAgICAg IGRpZENvbXBsZXRlV2l0aEVycm9yKGludGVybmFsRXJyb3IodXJsKSk7CisgICAgICAgIH0pOwor ICAgIH0KICNlbHNlCiAgICAgbV9oYW5kbGUgPSBSZXNvdXJjZUhhbmRsZTo6Y3JlYXRlKG1fbmV0 d29ya2luZ0NvbnRleHQuZ2V0KCksIHBhcmFtZXRlcnMucmVxdWVzdCwgdGhpcywgcGFyYW1ldGVy cy5kZWZlcnNMb2FkaW5nLCBwYXJhbWV0ZXJzLmNvbnRlbnRTbmlmZmluZ1BvbGljeSA9PSBTbmlm ZkNvbnRlbnQpOwogI2VuZGlmCg== 280307 2016-06-01 22:07:55 -0700 2016-06-01 22:38:34 -0700 Address review comments before landing. svc_unresponsive_web.patch text/plain 2630 yongjun_zhang Y29tbWl0IGI1NzU5NDViOGMxMDY4YmFkNTUyMmQwZWJjYWMzMjVmMjc0MzA0ZDYKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgTWF5IDMx IDE0OjIwOjUwIDIwMTYgLTA3MDAKCiAgICBOb3RpZnkgY2xpZW50IGltbWVkaWF0ZWx5IGlmIG5l dHdvcmsgc2Vzc2lvbiBkb2Vzbid0IGV4aXN0IGZvciBhIHN5bmNocm9ub3VzIFhIUiBsb2FkLgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODIzOQogICAgPHJk YXI6Ly9wcm9ibGVtLzI2MzQ0MjUxPgogICAgCiAgICBXaGVuIHN0YXJ0aW5nIGEgbmV0d29yayBs b2FkLCBpZiB0aGUgbmV0d29yayBzZXNzaW9uIGRvZXNuJ3QgZXhpc3QsIHdlIHNob3VsZCBub3Rp ZnkgTmV0d29ya0xvYWRDbGllbnQKICAgIGltbWVkaWF0ZWx5LiBPdGhlcndpc2UgdGhlIFdlYiBw cm9jZXNzIGNvdWxkIGhhbmcgd2hlbiB3YWl0aW5nIGZvciB0aGUgc3luY2hyb25vdXMgbG9hZCB0 byBmaW5pc2guCiAgICAKICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgogICAg KFdlYktpdDo6TmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2FkKToKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjhmNmQ0 ZS4uYWY5NzNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA1LTMxICBZb25n anVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTm90aWZ5IGNs aWVudCBpbW1lZGlhdGVseSBpZiBuZXR3b3JrIHNlc3Npb24gZG9lc24ndCBleGlzdCBmb3IgYSBz eW5jaHJvbm91cyBYSFIgbG9hZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1ODIzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYzNDQyNTE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlkc29uLgorCisgICAgICAgIEZvciBhIHN5bmNo cm9ub3VzIFhIUiBsb2FkLCBpZiB0aGUgbmV0d29yayBzZXNzaW9uIGRvZXNuJ3QgZXhpc3QsIHdl IHNob3VsZCBub3RpZnkgTmV0d29ya0xvYWRDbGllbnQuCisgICAgICAgIE90aGVyd2lzZSB0aGUg V2ViIHByb2Nlc3MgY291bGQgaGFuZyB3aGVuIHdhaXRpbmcgZm9yIHRoZSBzeW5jaHJvbm91cyBs b2FkIHRvIGZpbmlzaC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNw cDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0xvYWQ6Ok5ldHdvcmtMb2FkKToKKwogMjAxNi0w NS0zMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsIG91dCByMjAxNDgxLCByMjAxNTIzOiAwLjMlIHJlZ3Jlc3Npb24gaW4g T2N0YW5lIGNvZGUtbG9hZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya0xvYWQuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29y a0xvYWQuY3BwCmluZGV4IDU2MDg5YmYuLmI5YmYxZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAKQEAgLTU3LDggKzU3LDEyIEBAIE5ldHdvcmtM b2FkOjpOZXR3b3JrTG9hZChOZXR3b3JrTG9hZENsaWVudCYgY2xpZW50LCBjb25zdCBOZXR3b3Jr TG9hZFBhcmFtZXRlcnMmCiAgICAgICAgIG1fdGFzayA9IE5ldHdvcmtEYXRhVGFzazo6Y3JlYXRl KCpuZXR3b3JrU2Vzc2lvbiwgKnRoaXMsIHBhcmFtZXRlcnMucmVxdWVzdCwgcGFyYW1ldGVycy5h bGxvd1N0b3JlZENyZWRlbnRpYWxzLCBwYXJhbWV0ZXJzLmNvbnRlbnRTbmlmZmluZ1BvbGljeSwg cGFyYW1ldGVycy5zaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0KTsKICAg ICAgICAgaWYgKCFwYXJhbWV0ZXJzLmRlZmVyc0xvYWRpbmcpCiAgICAgICAgICAgICBtX3Rhc2st PnJlc3VtZSgpOwotICAgIH0gZWxzZQorICAgIH0gZWxzZSB7CiAgICAgICAgIFdURkxvZ0Fsd2F5 cygiQXR0ZW1wdGVkIHRvIGNyZWF0ZSBhIE5ldHdvcmtMb2FkIHdpdGggYSBzZXNzaW9uIChpZD0l IiBQUkl1NjQgIikgdGhhdCBkb2VzIG5vdCBleGlzdC4iLCBwYXJhbWV0ZXJzLnNlc3Npb25JRC5z ZXNzaW9uSUQoKSk7CisgICAgICAgIFJ1bkxvb3A6OmN1cnJlbnQoKS5kaXNwYXRjaChbdGhpcywg dXJsID0gcGFyYW1ldGVycy5yZXF1ZXN0LnVybCgpXSB7CisgICAgICAgICAgICBkaWRDb21wbGV0 ZVdpdGhFcnJvcihpbnRlcm5hbEVycm9yKHVybCkpOworICAgICAgICB9KTsKKyAgICB9CiAjZWxz ZQogICAgIG1faGFuZGxlID0gUmVzb3VyY2VIYW5kbGU6OmNyZWF0ZShtX25ldHdvcmtpbmdDb250 ZXh0LmdldCgpLCBwYXJhbWV0ZXJzLnJlcXVlc3QsIHRoaXMsIHBhcmFtZXRlcnMuZGVmZXJzTG9h ZGluZywgcGFyYW1ldGVycy5jb250ZW50U25pZmZpbmdQb2xpY3kgPT0gU25pZmZDb250ZW50KTsK ICNlbmRpZgo=