158225 2016-05-31 05:23:39 -0700 [Win] Potential null pointer crash when setting cursor. 2016-06-01 02:15:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham oldest_to_newest 1197764 0 pvollan 2016-05-31 05:23:39 -0700 Code inspection shows that the call cursor.platformCursor() can return null. void WebChromeClient::setCursor(const Cursor& cursor) { HCURSOR platformCursor = cursor.platformCursor()->nativeCursor(); ... 1197765 1 280139 pvollan 2016-05-31 05:32:42 -0700 Created attachment 280139 Patch 1197806 2 280139 achristensen 2016-05-31 09:52:35 -0700 Comment on attachment 280139 Patch Sure 1198108 3 pvollan 2016-06-01 02:13:50 -0700 (In reply to comment #2) > Comment on attachment 280139 [details] > Patch > > Sure Thanks for reviewing :) 1198109 4 pvollan 2016-06-01 02:15:08 -0700 Committed r201546: <https://trac.webkit.org/changeset/201546> 280139 2016-05-31 05:32:42 -0700 2016-05-31 09:52:35 -0700 Patch bug-158225-20160531053337.patch text/plain 1242 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTUwOSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTMx ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBQ b3RlbnRpYWwgbnVsbCBwb2ludGVyIGNyYXNoIHdoZW4gc2V0dGluZyBjdXJzb3IuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgyMjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayByZXR1cm4gdmFs dWUgb2YgQ3Vyc29yOjpwbGF0Zm9ybUN1cnNvcigpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvV2ViQ2hyb21lQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYkNocm9tZUNsaWVudDo6c2V0Q3Vy c29yKToKKwogMjAxNi0wNS0yNyAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtKU0NdIGltcGxlbWVudCBhc3luYyBmdW5jdGlvbnMgcHJvcG9zYWwKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xp ZW50LmNwcAkocmV2aXNpb24gMjAxNTA1KQorKysgU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1 cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjg3LDYgKzY4Nyw5 IEBAIHZvaWQgV2ViQ2hyb21lQ2xpZW50Ojpsb2FkSWNvbkZvckZpbGVzKGMKIAogdm9pZCBXZWJD aHJvbWVDbGllbnQ6OnNldEN1cnNvcihjb25zdCBDdXJzb3ImIGN1cnNvcikKIHsKKyAgICBpZiAo IWN1cnNvci5wbGF0Zm9ybUN1cnNvcigpKQorICAgICAgICByZXR1cm47CisKICAgICBIQ1VSU09S IHBsYXRmb3JtQ3Vyc29yID0gY3Vyc29yLnBsYXRmb3JtQ3Vyc29yKCktPm5hdGl2ZUN1cnNvcigp OwogICAgIGlmICghcGxhdGZvcm1DdXJzb3IpCiAgICAgICAgIHJldHVybjsK