158213 2016-05-30 13:12:43 -0700 Web Inspector: Filter Records not applying to new records 2016-06-13 15:42:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 saam mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1197668 0 saam 2016-05-30 13:12:43 -0700 Repro steps: 1. Start recording this page: http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 2. Stop recording 3. Click on Javascript & events 4. Filter records by the string "Garbage Collection" 5. Notice you only see Garbage Collection events 6. Continue the recording 7. stop the recording 8. We now have records that aren't just "Garbage Collection" records 1197669 1 webkit-bug-importer 2016-05-30 13:12:59 -0700 <rdar://problem/26543912> 1197670 2 bburg 2016-05-30 13:16:51 -0700 The filter is also not re-applied when switching between timelines. 1200612 3 mattbaker 2016-06-08 14:54:56 -0700 I can only reproduce this when the the second part of the recording falls outside the ruler selection end time. This makes sense, because TimelineView won't call _timesDidChange (which causes filters to update) when the current time marker falls outside the ruler selection. 1201664 4 281114 mattbaker 2016-06-11 16:52:05 -0700 Created attachment 281114 [Patch] Proposed Fix 1201991 5 281114 commit-queue 2016-06-13 15:42:50 -0700 Comment on attachment 281114 [Patch] Proposed Fix Clearing flags on attachment: 281114 Committed r202011: <http://trac.webkit.org/changeset/202011> 1201992 6 commit-queue 2016-06-13 15:42:53 -0700 All reviewed patches have been landed. Closing bug. 281114 2016-06-11 16:52:05 -0700 2016-06-13 15:42:50 -0700 [Patch] Proposed Fix bug-158213-20160611165336.patch text/plain 7371 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw OTQ2NTE4NDAyYTY5MzlhNDJmMDdlNDEwZGRiY2U3YjE3NTEyOGYwLi5kNWFjZWJlZmFhMDA2NDM3 YzMxOTBlOGIyNDU5ZjRjMzYxMjJjZTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw1MCBAQAorMjAxNi0wNi0xMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRmlsdGVyIFJlY29yZHMgbm90IGFwcGx5aW5nIHRv IG5ldyByZWNvcmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTgyMTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NTQzOTEyPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMg dGhlIGZvbGxvd2luZyBpbXByb3ZlbWVudHMgdG8gdGltZWxpbmUgZ3JpZCBmaWx0ZXJpbmc6CisK KyAgICAgICAgICAgIC0gUmVjb3JkcyBhcmUgZmlsdGVyZWQgYXMgdGhleSBhcmUgYWRkZWQgdG8g dGhlIGdyaWQuCisgICAgICAgICAgICAtIFRpbWVsaW5lIHZpZXcgbm8gbG9uZ2VyIHRyaWdnZXJz IGEgZmlsdGVyIHJlZnJlc2ggd2hpbGUgdGhlCisgICAgICAgICAgICAgIGN1cnJlbnQgdGltZSBj aGFuZ2VzIHdoaWxlIHJlY29yZGluZy4KKyAgICAgICAgICAgIC0gRmlsdGVycyBhcmUgcmVmcmVz aGVkIHdoZW5ldmVyIHRoZSBjdXJyZW50IHRpbWVsaW5lIHZpZXcgY2hhbmdlcy4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRGF0YUdyaWQucHJvdG90eXBlLmhhc0ZpbHRlcnMpOgorICAgICAgICBIZWxwZXIgZnVuY3Rp b24gdG8gY2hlY2sgZm9yIGN1c3RvbSBhbmQgdGV4dCBmaWx0ZXJzLgorCisgICAgICAgIChXZWJJ bnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLl9hcHBseUZpbHRlcnNUb05vZGVBbmREaXNwYXRj aEV2ZW50KToKKyAgICAgICAgRW5jYXBzdWxhdGUgbm9kZSBzdGF0ZSBjaGFuZ2UgYW5kIGV2ZW50 IGRpc3BhdGNoLCB3aGljaCB3YXMgcHJldmlvdXNseQorICAgICAgICBkb25lIGluIG11bHRpcGxl IHBsYWNlcy4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5pbnNl cnRDaGlsZCk6CisgICAgICAgIEZpbHRlciBpbmNvbWluZyBub2RlIGlmIG5lZWRlZC4KKworICAg ICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5fdXBkYXRlRmlsdGVyLmNyZWF0 ZUl0ZXJhdG9yRm9yTm9kZXNUb0JlRmlsdGVyZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRh dGFHcmlkLnByb3RvdHlwZS5fdXBkYXRlRmlsdGVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5E YXRhR3JpZC5wcm90b3R5cGUueWllbGRhYmxlVGFza1dpbGxQcm9jZXNzSXRlbSk6CisgICAgICAg IFVzZSBuZXcgY29udmVuaWVuY2UgZnVuY3Rpb25zLgorCisgICAgICAgIChXZWJJbnNwZWN0b3Iu RGF0YUdyaWQucHJvdG90eXBlLmhhc0N1c3RvbUZpbHRlcnMpOiBEZWxldGVkLgorICAgICAgICBS ZW5hbWVkIGBoYXNGaWx0ZXJzYC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1l bGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fY3VycmVudENvbnRlbnRWaWV3RGlk Q2hhbmdlKToKKyAgICAgICAgUmVmcmVzaCBncmlkIGZpbHRlcnMgb24gdmlldyBjaGFuZ2UuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UaW1lbGluZVZpZXcucHJvdG90eXBlLnNldCBzdGFydFRpbWUpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmlldy5wcm90b3R5cGUuc2V0IGVuZFRpbWUpOgor ICAgICAgICBTY2hlZHVsZSBmaWx0ZXIgY2hhbmdlIG5vdGlmaWNhdGlvbiB3aGVuIHNlbGVjdGlv biBib3VuZHMgY2hhbmdlcy4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmlldy5w cm90b3R5cGUuX3RpbWVzRGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGlu ZVZpZXcucHJvdG90eXBlLl9zY2hlZHVsZUZpbHRlckRpZENoYW5nZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVWaWV3KToKKwogMjAxNi0wNi0xMCAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IDx0ZW1wbGF0ZT4g Y29udGVudCBzaG91bGQgbm90IGJlIGhpZGRlbiBhcyBTaGFkb3cgQ29udGVudApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwpp bmRleCBmNjMzMmRkYzdlZWI1MTFmZTU3YTU1N2QxY2IyNDljN2E3N2FkYmJkLi40Y2Q3ZmM2YTVj NTY4YjUxYzQ4MGU0N2UyZDY3MzdlYjRjODRlZjdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwpAQCAtMzM4LDkgKzMz OCw5IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV2Vi SW5zcGVjdG9yLlZpZXcKICAgICAgICAgdGhpcy5fc2NoZWR1bGVkRmlsdGVyVXBkYXRlSWRlbnRp ZmllciA9IHJlcXVlc3RBbmltYXRpb25GcmFtZSh0aGlzLl91cGRhdGVGaWx0ZXIuYmluZCh0aGlz KSk7CiAgICAgfQogCi0gICAgaGFzQ3VzdG9tRmlsdGVycygpCisgICAgaGFzRmlsdGVycygpCiAg ICAgewotICAgICAgICByZXR1cm4gdGhpcy5faGFzRmlsdGVyRGVsZWdhdGUoKTsKKyAgICAgICAg cmV0dXJuIHRoaXMuX3RleHRGaWx0ZXJSZWdleCB8fCB0aGlzLl9oYXNGaWx0ZXJEZWxlZ2F0ZSgp OwogICAgIH0KIAogICAgIG1hdGNoTm9kZUFnYWluc3RDdXN0b21GaWx0ZXJzKG5vZGUpCkBAIC0z NjEsOSArMzYxLDE5IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAgICAgICAgfQogICAgIH0KIAorICAgIF9hcHBseUZp bHRlcnNUb05vZGVBbmREaXNwYXRjaEV2ZW50KG5vZGUpCisgICAgeworICAgICAgICBjb25zdCBu b2RlV2FzSGlkZGVuID0gbm9kZS5oaWRkZW47CisgICAgICAgIHRoaXMuX2FwcGx5RmlsdGVyc1Rv Tm9kZShub2RlKTsKKyAgICAgICAgaWYgKG5vZGVXYXNIaWRkZW4gIT09IG5vZGUuaGlkZGVuKQor ICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRh dGFHcmlkLkV2ZW50Lk5vZGVXYXNGaWx0ZXJlZCwge25vZGV9KTsKKworICAgICAgICByZXR1cm4g bm9kZVdhc0hpZGRlbiAhPT0gbm9kZS5oaWRkZW47CisgICAgfQorCiAgICAgX2FwcGx5RmlsdGVy c1RvTm9kZShub2RlKQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLl90ZXh0RmlsdGVyUmVnZXgg JiYgIXRoaXMuaGFzQ3VzdG9tRmlsdGVycygpKSB7CisgICAgICAgIGlmICghdGhpcy5oYXNGaWx0 ZXJzKCkpIHsKICAgICAgICAgICAgIC8vIE5vIGZpbHRlcnMsIHNvIG1ha2UgZXZlcnl0aGluZyB2 aXNpYmxlLgogICAgICAgICAgICAgbm9kZS5oaWRkZW4gPSBmYWxzZTsKIApAQCAtMTE2MSw2ICsx MTcxLDExIEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMg V2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAgICBpZiAodGhpcy5leHBhbmRlZCkKICAgICAgICAg ICAgIGNoaWxkLl9hdHRhY2goKTsKKworICAgICAgICBpZiAoIXRoaXMuZGF0YUdyaWQuaGFzRmls dGVycygpKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMuZGF0YUdyaWQuX2Fw cGx5RmlsdGVyc1RvTm9kZUFuZERpc3BhdGNoRXZlbnQoY2hpbGQpOwogICAgIH0KIAogICAgIHJl bW92ZUNoaWxkKGNoaWxkKQpAQCAtMTc4NCw3ICsxNzk5LDcgQEAgV2ViSW5zcGVjdG9yLkRhdGFH cmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICB7 CiAgICAgICAgICAgICAvLyBEb24ndCBwb3B1bGF0ZSBpZiB3ZSBkb24ndCBoYXZlIGFueSBhY3Rp dmUgZmlsdGVycy4KICAgICAgICAgICAgIC8vIFdlIG9ubHkgbmVlZCB0byBwb3B1bGF0ZSB3aGVu IGEgZmlsdGVyIG5lZWRzIHRvIHJldmVhbC4KLSAgICAgICAgICAgIGxldCBkb250UG9wdWxhdGUg PSAhdGhpcy5fdGV4dEZpbHRlclJlZ2V4ICYmICF0aGlzLmhhc0N1c3RvbUZpbHRlcnMoKTsKKyAg ICAgICAgICAgIGxldCBkb250UG9wdWxhdGUgPSAhdGhpcy5oYXNGaWx0ZXJzKCk7CiAKICAgICAg ICAgICAgIGxldCBjdXJyZW50Tm9kZSA9IHRoaXMuX3Jvd3NbMF07CiAgICAgICAgICAgICB3aGls ZSAoY3VycmVudE5vZGUgJiYgIWN1cnJlbnROb2RlLnJvb3QpIHsKQEAgLTE4MDUsMTMgKzE4MjAs OSBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdlYklu c3BlY3Rvci5WaWV3CiAKICAgICB5aWVsZGFibGVUYXNrV2lsbFByb2Nlc3NJdGVtKHRhc2ssIG5v ZGUpCiAgICAgewotICAgICAgICBjb25zdCBub2RlV2FzSGlkZGVuID0gbm9kZS5oaWRkZW47Ci0g ICAgICAgIHRoaXMuX2FwcGx5RmlsdGVyc1RvTm9kZShub2RlKTsKLSAgICAgICAgaWYgKG5vZGVX YXNIaWRkZW4gPT09IG5vZGUuaGlkZGVuKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5FdmVu dC5Ob2RlV2FzRmlsdGVyZWQsIHtub2RlfSk7Ci0gICAgICAgIHRoaXMuX2ZpbHRlckRpZE1vZGlm eU5vZGVXaGlsZVByb2Nlc3NpbmdJdGVtcyA9IHRydWU7CisgICAgICAgIGxldCBub2RlV2FzTW9k aWZpZWQgPSB0aGlzLl9hcHBseUZpbHRlcnNUb05vZGVBbmREaXNwYXRjaEV2ZW50KG5vZGUpOwor ICAgICAgICBpZiAobm9kZVdhc01vZGlmaWVkKQorICAgICAgICAgICAgdGhpcy5fZmlsdGVyRGlk TW9kaWZ5Tm9kZVdoaWxlUHJvY2Vzc2luZ0l0ZW1zID0gdHJ1ZTsKICAgICB9CiAKICAgICB5aWVs ZGFibGVUYXNrRGlkWWllbGQodGFzaywgcHJvY2Vzc2VkSXRlbXMsIGVsYXBzZWRUaW1lKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggMDIwYmJl ZjcwZjYwNWI0NTE4ZDk3OGYwZGQ5ZmJkYWQwODdiZjIyYS4uYzM3YjljMWU1YjEzZjI3NThkYzI3 ZTE1ZGNlMDg3M2VkMWM1ZmFjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3LmpzCkBAIC0yODIsNiArMjgyLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5l UmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3 IGUKIAogICAgICAgICBpZiAodGltZWxpbmVWaWV3KSB7CiAgICAgICAgICAgICB0aGlzLl91cGRh dGVUaW1lbGluZVZpZXdUaW1lcyh0aW1lbGluZVZpZXcpOworICAgICAgICAgICAgdGhpcy5fZmls dGVyRGlkQ2hhbmdlKCk7CiAKICAgICAgICAgICAgIGxldCB0aW1lbGluZSA9IG51bGw7CiAgICAg ICAgICAgICBpZiAodGltZWxpbmVWaWV3LnJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVWaWV3LmpzCmluZGV4IDU3ZjQ5OTRmNWFjYWRi NmM4NGJjYWYzYzM2YTRlMDM2YTA0ZjllMjIuLjYzMDM1YTFmNWMxZTI5NmQ0YjE2MjZmODQwMThl NjZjMzdiZTNjNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVZpZXcuanMKQEAgLTEwNSw2ICsxMDUsNyBAQCBXZWJJ bnNwZWN0b3IuVGltZWxpbmVWaWV3ID0gY2xhc3MgVGltZWxpbmVWaWV3IGV4dGVuZHMgV2ViSW5z cGVjdG9yLkNvbnRlbnRWaWV3CiAgICAgICAgIHRoaXMuX3N0YXJ0VGltZSA9IHg7CiAKICAgICAg ICAgdGhpcy5fdGltZXNEaWRDaGFuZ2UoKTsKKyAgICAgICAgdGhpcy5fc2NoZWR1bGVGaWx0ZXJE aWRDaGFuZ2UoKTsKICAgICB9CiAKICAgICBnZXQgZW5kVGltZSgpCkBAIC0xMjIsNiArMTIzLDcg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmlldyA9IGNsYXNzIFRpbWVsaW5lVmlldyBleHRlbmRz IFdlYkluc3BlY3Rvci5Db250ZW50VmlldwogICAgICAgICB0aGlzLl9lbmRUaW1lID0geDsKIAog ICAgICAgICB0aGlzLl90aW1lc0RpZENoYW5nZSgpOworICAgICAgICB0aGlzLl9zY2hlZHVsZUZp bHRlckRpZENoYW5nZSgpOwogICAgIH0KIAogICAgIGdldCBjdXJyZW50VGltZSgpCkBAIC0zMjMs NyArMzI1LDEwIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVZpZXcgPSBjbGFzcyBUaW1lbGluZVZp ZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcKICAgICB7CiAgICAgICAgIGlmICgh V2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5pc0NhcHR1cmluZygpIHx8IHRoaXMuc2hvd3NM aXZlUmVjb3JkaW5nRGF0YSkKICAgICAgICAgICAgIHRoaXMubmVlZHNMYXlvdXQoKTsKKyAgICB9 CiAKKyAgICBfc2NoZWR1bGVGaWx0ZXJEaWRDaGFuZ2UoKQorICAgIHsKICAgICAgICAgaWYgKCF0 aGlzLl90aW1lbGluZURhdGFHcmlkIHx8IHRoaXMuX3VwZGF0ZUZpbHRlclRpbWVvdXQpCiAgICAg ICAgICAgICByZXR1cm47CiAK