158206 2016-05-30 08:18:55 -0700 [jsc][mips] implement absDouble() 2016-06-06 11:07:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 guijemont webkit-unassigned annulen commit-queue guijemont jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1197622 0 guijemont 2016-05-30 08:18:55 -0700 The absDouble() method is not implemented in MacroAssemblerMIPS. It is now used in Math.pow() since r200208, so we need it. 1197623 1 guijemont 2016-05-30 08:24:45 -0700 I have a patch that seems to work and will upload it after running some tests. 1197638 2 guijemont 2016-05-30 10:18:02 -0700 (In reply to comment #1) > I have a patch that seems to work and will upload it after running some > tests. Can't do that yet as after rebasing my patch I hit #158209. 1198356 3 280284 guijemont 2016-06-01 17:33:57 -0700 Created attachment 280284 Patch Patch fixing the issue. 1198517 4 jbriance 2016-06-02 05:45:54 -0700 It is not complete, please refer to my commit in QtWebKit: http://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=b6ddb5fe5d3f2223d524e45bf5cdbdde0e5b241f Also, please put absd() implementation between sqrtd and movd in MacroAssemblerMIPS.h to keep the opcodes ordered. 1198562 5 guijemont 2016-06-02 10:41:23 -0700 (In reply to comment #4) > It is not complete, please refer to my commit in QtWebKit: > http://code.qt.io/cgit/qt/qtwebkit.git/commit/ > ?id=b6ddb5fe5d3f2223d524e45bf5cdbdde0e5b241f Indeed, I did not catch that supportsFloatingPointAbs(), or see that you had made that change in qtwebkit. I think we need to check for WTF_MIPS_ISA_AT_LEAST(2) as well, since abs.d is only available from mips 2 on. > > Also, please put absd() implementation between sqrtd and movd in > MacroAssemblerMIPS.h to keep the opcodes ordered. It looks overall not very well ordered and I tried to put it in alphabetical order, but I'm fine with doing that. 1198563 6 280338 guijemont 2016-06-02 10:47:24 -0700 Created attachment 280338 Patch New version addressing Julien's comments. It seems to pass regress and stress tests if combined with patch from #158209 1198695 7 jbriance 2016-06-02 14:40:24 -0700 (In reply to comment #5) > Indeed, I did not catch that supportsFloatingPointAbs(), or see that you had > made that change in qtwebkit. I think we need to check for > WTF_MIPS_ISA_AT_LEAST(2) as well, since abs.d is only available from mips 2 > on. Great, thanks. > It looks overall not very well ordered and I tried to put it in alphabetical > order, but I'm fine with doing that. Thanks, it's just to limit conflicts in case of cherry-pick. Looks good to me. 1199612 8 guijemont 2016-06-06 10:39:04 -0700 ping reviewers 1199627 9 280338 commit-queue 2016-06-06 11:07:54 -0700 Comment on attachment 280338 Patch Clearing flags on attachment: 280338 Committed r201716: <http://trac.webkit.org/changeset/201716> 1199628 10 commit-queue 2016-06-06 11:07:59 -0700 All reviewed patches have been landed. Closing bug. 280284 2016-06-01 17:33:57 -0700 2016-06-02 10:47:18 -0700 Patch bug-158206-20160601193515.patch text/plain 2314 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm Mzc2NzRiOGVmMTA5M2UxN2ZjZDIzY2YzZDhmMzUwMzVjNDlmMDc5Li44YTcwMmQ5ZTY4NTBhMjFk YWYyZjY0NWZkZWU4OTc5M2NmZTg0MGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wNi0wMSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW2pzY11bbWlwc10gSW1wbGVtZW50IGFic0RvdWJsZSgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgyMDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgYWJz RG91YmxlKCkgZm9yIE1JUFMuIFRoaXMgaXMgbmVlZGVkIGJlY2F1c2UgTWF0aC5wb3coKSB1c2Vz CisgICAgICAgIGl0IHNpbmNlIHIyMDAyMDguCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTUlQU0Fz c2VtYmxlci5oOgorICAgICAgICAoSlNDOjpNSVBTQXNzZW1ibGVyOjphYnNkKToKKyAgICAgICAg KiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNz ZW1ibGVyTUlQUzo6YWJzRG91YmxlKToKKwogMjAxNi0wNS0zMSAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBEcm9wICJyZXBsYWNlIiBmcm9t IEpTQ19DT01NT05fUFJJVkFURV9JREVOVElGSUVSU19FQUNIX1dFTExfS05PV05fU1lNQk9MX05P VF9JTVBMRU1FTlRFRF9ZRVQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTUlQU0Fzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N SVBTQXNzZW1ibGVyLmgKaW5kZXggZGM1MTg0MzNlYmU2YjI3M2ViZjZmOGVjZjE4YmY0NmRlZTc5 ODEwMS4uMjEwZWQyNjhlZDU5Y2E3MjJjMDA3YjdhNGMyNTMxNWUwMTQ4Y2Q0YyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgKQEAgLTQ4Myw2 ICs0ODMsMTEgQEAgcHVibGljOgogICAgICAgICBtX2p1bXBzLmFwcGVuZChtX2J1ZmZlci5sYWJl bCgpKTsKICAgICB9CiAKKyAgICB2b2lkIGFic2QoRlBSZWdpc3RlcklEIGZkLCBGUFJlZ2lzdGVy SUQgZnMpCisgICAgeworICAgICAgICBlbWl0SW5zdCgweDQ2MjAwMDA1IHwgKGZkIDw8IE9QX1NI X0ZEKSB8IChmcyA8PCBPUF9TSF9GUykpOworICAgIH0KKwogICAgIHZvaWQgYWRkZChGUFJlZ2lz dGVySUQgZmQsIEZQUmVnaXN0ZXJJRCBmcywgRlBSZWdpc3RlcklEIGZ0KQogICAgIHsKICAgICAg ICAgZW1pdEluc3QoMHg0NjIwMDAwMCB8IChmZCA8PCBPUF9TSF9GRCkgfCAoZnMgPDwgT1BfU0hf RlMpIHwgKGZ0IDw8IE9QX1NIX0ZUKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAppbmRleCAxNGFjMGQwM2IwMGI1Y2YxOWQ0 OTY3YWZiZDU5YmQ1MzZiYjgxMzcxLi41OTkxNjQ0MzUxOTljOWNlYmU1OWE0ZmQxYjE0NjVlOGQ5 ZDJkY2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyTUlQUy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJNSVBTLmgKQEAgLTY0MSwxMCArNjQxLDEwIEBAIHB1YmxpYzoKICAgICB7CiAg ICAgICAgIG1fYXNzZW1ibGVyLnNxcnRkKGRzdCwgc3JjKTsKICAgICB9Ci0gICAgCi0gICAgdm9p ZCBhYnNEb3VibGUoRlBSZWdpc3RlcklELCBGUFJlZ2lzdGVySUQpCisKKyAgICB2b2lkIGFic0Rv dWJsZShGUFJlZ2lzdGVySUQgc3JjLCBGUFJlZ2lzdGVySUQgZHN0KQogICAgIHsKLSAgICAgICAg UkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgbV9hc3NlbWJsZXIuYWJzZChk c3QsIHNyYyk7CiAgICAgfQogCiAgICAgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIGNlaWxE b3VibGUoRlBSZWdpc3RlcklELCBGUFJlZ2lzdGVySUQpCg== 280338 2016-06-02 10:47:24 -0700 2016-06-06 11:07:54 -0700 Patch bug-158206-20160602124843.patch text/plain 2720 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm Mzc2NzRiOGVmMTA5M2UxN2ZjZDIzY2YzZDhmMzUwMzVjNDlmMDc5Li44YTcwMmQ5ZTY4NTBhMjFk YWYyZjY0NWZkZWU4OTc5M2NmZTg0MGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wNi0wMSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW2pzY11bbWlwc10gSW1wbGVtZW50IGFic0RvdWJsZSgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgyMDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgYWJz RG91YmxlKCkgZm9yIE1JUFMuIFRoaXMgaXMgbmVlZGVkIGJlY2F1c2UgTWF0aC5wb3coKSB1c2Vz CisgICAgICAgIGl0IHNpbmNlIHIyMDAyMDguCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTUlQU0Fz c2VtYmxlci5oOgorICAgICAgICAoSlNDOjpNSVBTQXNzZW1ibGVyOjphYnNkKToKKyAgICAgICAg KiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNz ZW1ibGVyTUlQUzo6YWJzRG91YmxlKToKKwogMjAxNi0wNS0zMSAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBEcm9wICJyZXBsYWNlIiBmcm9t IEpTQ19DT01NT05fUFJJVkFURV9JREVOVElGSUVSU19FQUNIX1dFTExfS05PV05fU1lNQk9MX05P VF9JTVBMRU1FTlRFRF9ZRVQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTUlQU0Fzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N SVBTQXNzZW1ibGVyLmgKaW5kZXggZGM1MTg0MzNlYmU2YjI3M2ViZjZmOGVjZjE4YmY0NmRlZTc5 ODEwMS4uNjM2NzNlMmVhYTViMDM4ZTI1ZDdkOTI0OTBkYmNhYmE1NWY2YmJkNCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgKQEAgLTU0Nyw2 ICs1NDcsMTEgQEAgcHVibGljOgogICAgICAgICBlbWl0SW5zdCgweDQ2MjAwMDA0IHwgKGZkIDw8 IE9QX1NIX0ZEKSB8IChmcyA8PCBPUF9TSF9GUykpOwogICAgIH0KIAorICAgIHZvaWQgYWJzZChG UFJlZ2lzdGVySUQgZmQsIEZQUmVnaXN0ZXJJRCBmcykKKyAgICB7CisgICAgICAgIGVtaXRJbnN0 KDB4NDYyMDAwMDUgfCAoZmQgPDwgT1BfU0hfRkQpIHwgKGZzIDw8IE9QX1NIX0ZTKSk7CisgICAg fQorCiAgICAgdm9pZCBtb3ZkKEZQUmVnaXN0ZXJJRCBmZCwgRlBSZWdpc3RlcklEIGZzKQogICAg IHsKICAgICAgICAgZW1pdEluc3QoMHg0NjIwMDAwNiB8IChmZCA8PCBPUF9TSF9GRCkgfCAoZnMg PDwgT1BfU0hfRlMpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyTUlQUy5oCmluZGV4IDE0YWMwZDAzYjAwYjVjZjE5ZDQ5NjdhZmJkNTli ZDUzNmJiODEzNzEuLjZhYmU0YjZiMGYwMGRmOTliZTE1NjdmODBhODUwZDZjMmQzYzYzZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJN SVBTLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ck1JUFMuaApAQCAtNjQxLDEwICs2NDEsMTAgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgbV9h c3NlbWJsZXIuc3FydGQoZHN0LCBzcmMpOwogICAgIH0KLSAgICAKLSAgICB2b2lkIGFic0RvdWJs ZShGUFJlZ2lzdGVySUQsIEZQUmVnaXN0ZXJJRCkKKworICAgIHZvaWQgYWJzRG91YmxlKEZQUmVn aXN0ZXJJRCBzcmMsIEZQUmVnaXN0ZXJJRCBkc3QpCiAgICAgewotICAgICAgICBSRUxFQVNFX0FT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBtX2Fzc2VtYmxlci5hYnNkKGRzdCwgc3JjKTsK ICAgICB9CiAKICAgICBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgY2VpbERvdWJsZShGUFJl Z2lzdGVySUQsIEZQUmVnaXN0ZXJJRCkKQEAgLTEyNzUsNyArMTI3NSwxNiBAQCBwdWJsaWM6CiAg ICAgICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogICAgIH0KLSAgICBzdGF0aWMgYm9vbCBzdXBw b3J0c0Zsb2F0aW5nUG9pbnRBYnMoKSB7IHJldHVybiBmYWxzZTsgfQorCisgICAgc3RhdGljIGJv b2wgc3VwcG9ydHNGbG9hdGluZ1BvaW50QWJzKCkKKyAgICB7CisjaWYgV1RGX01JUFNfRE9VQkxF X0ZMT0FUICYmIFdURl9NSVBTX0lTQV9BVF9MRUFTVCgyKQorICAgICAgICByZXR1cm4gdHJ1ZTsK KyNlbHNlCisgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorICAgIH0KKwogICAgIHN0YXRp YyBib29sIHN1cHBvcnRzRmxvYXRpbmdQb2ludFJvdW5kaW5nKCkgeyByZXR1cm4gZmFsc2U7IH0K IAogICAgIC8vIFN0YWNrIG1hbmlwdWxhdGlvbiBvcGVyYXRpb25zOgo=