158186 2016-05-28 18:56:41 -0700 JSGlobalLexicalEnvironment leaks SegmentedVector due to lack of destructor. 2016-05-28 21:46:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1197438 0 kling 2016-05-28 18:56:41 -0700 We're leaking all of the SegmentedVector backing stores from JSGlobalLexicalEnvironment since it doesn't get a destructor call. 1197439 1 280053 kling 2016-05-28 18:57:33 -0700 Created attachment 280053 Proposed patch 1197440 2 280053 saam 2016-05-28 20:23:36 -0700 Comment on attachment 280053 Proposed patch r=me Nice catch 1197456 3 280053 commit-queue 2016-05-28 21:46:27 -0700 Comment on attachment 280053 Proposed patch Clearing flags on attachment: 280053 Committed r201494: <http://trac.webkit.org/changeset/201494> 1197457 4 commit-queue 2016-05-28 21:46:31 -0700 All reviewed patches have been landed. Closing bug. 280053 2016-05-28 18:57:33 -0700 2016-05-28 21:46:27 -0700 Proposed patch bug-158186.diff text/plain 3140 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDEzMDQ4ZTIuLjhiYTllYjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA1LTI4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBKU0dsb2JhbExleGljYWxFbnZpcm9ubWVu dCBsZWFrcyBTZWdtZW50ZWRWZWN0b3IgZHVlIHRvIGxhY2sgb2YgZGVzdHJ1Y3Rvci4KKyAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE1ODE4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHaXZlIEpTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50 IGEgZGVzdHJveSgpIGFuZCBzZXQgdXAgYSBmaW5hbGl6ZXIgZm9yIGl0CisgICAgICAgIGxpa2Ug d2UgZG8gd2l0aCBKU0dsb2JhbE9iamVjdC4gKFRoaXMgaXMgbmVlZGVkIGJlY2F1c2UgdGhleSBk b24ndCBpbmhlcml0CisgICAgICAgIGZyb20gSlNEZXN0cnVjdGlibGVPYmplY3RzIGFuZCB0aHVz IGNhbid0IHVzZSBKU0NlbGw6Om5lZWRzRGVzdHJ1Y3Rpb24gdG8KKyAgICAgICAgYXNrIGZvciBh bGxvY2F0aW9uIGluIGRlc3RydWN0b3Igc3BhY2UuKQorCisgICAgICAgIFRoaXMgc3RvcHMgdXMg ZnJvbSBsZWFraW5nIGFsbCB0aGUgU2VnbWVudGVkVmVjdG9yIGJhY2tpbmcgc3RvcmVzLgorCisg ICAgICAgICogcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudC5jcHA6CisgICAgICAg IChKU0M6OkpTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50OjpkZXN0cm95KToKKyAgICAgICAgKiBy dW50aW1lL0pTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50Lmg6CisgICAgICAgIChKU0M6OkpTR2xv YmFsTGV4aWNhbEVudmlyb25tZW50OjpjcmVhdGUpOgorCiAyMDE2LTA1LTI2ICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogSlNCZW5jaCBz cGVuZHMgYSBsb3Qgb2YgdGltZSB0cmFuc2l0aW9uaW5nIHRvL2Zyb20gZGljdGlvbmFyeQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxMZXhpY2FsRW52 aXJvbm1lbnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxMZXhp Y2FsRW52aXJvbm1lbnQuY3BwCmluZGV4IGRhNTkwNzIuLjU3Nzk1ZDggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50LmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZp cm9ubWVudC5jcHAKQEAgLTMyLDYgKzMyLDExIEBAIG5hbWVzcGFjZSBKU0MgewogCiBjb25zdCBD bGFzc0luZm8gSlNHbG9iYWxMZXhpY2FsRW52aXJvbm1lbnQ6OnNfaW5mbyA9IHsgIkpTR2xvYmFs TGV4aWNhbEVudmlyb25tZW50IiwgJkJhc2U6OnNfaW5mbywgMCwgQ1JFQVRFX01FVEhPRF9UQUJM RShKU0dsb2JhbExleGljYWxFbnZpcm9ubWVudCkgfTsKIAordm9pZCBKU0dsb2JhbExleGljYWxF bnZpcm9ubWVudDo6ZGVzdHJveShKU0NlbGwqIGNlbGwpCit7CisgICAgc3RhdGljX2Nhc3Q8SlNH bG9iYWxMZXhpY2FsRW52aXJvbm1lbnQqPihjZWxsKS0+SlNHbG9iYWxMZXhpY2FsRW52aXJvbm1l bnQ6On5KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudCgpOworfQorCiBib29sIEpTR2xvYmFsTGV4 aWNhbEVudmlyb25tZW50OjpnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPYmplY3QqIG9iamVjdCwgRXhl Y1N0YXRlKiwgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90JiBzbG90KQog ewogICAgIEpTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50KiB0aGlzT2JqZWN0ID0ganNDYXN0PEpT R2xvYmFsTGV4aWNhbEVudmlyb25tZW50Kj4ob2JqZWN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50LmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbExleGljYWxFbnZpcm9ubWVudC5oCmlu ZGV4IDMxYTA5NzIuLjU3MzdkZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsTGV4aWNhbEVudmlyb25tZW50LmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxMZXhpY2FsRW52aXJvbm1lbnQuaApAQCAtNDMsMTIgKzQz LDE3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIG5ldyAoTm90TnVsbCwgYWxsb2NhdGVDZWxsPEpT R2xvYmFsTGV4aWNhbEVudmlyb25tZW50Pih2bS5oZWFwKSkgSlNHbG9iYWxMZXhpY2FsRW52aXJv bm1lbnQodm0sIHN0cnVjdHVyZSwgcGFyZW50U2NvcGUpOwogICAgICAgICByZXN1bHQtPmZpbmlz aENyZWF0aW9uKHZtKTsKICAgICAgICAgcmVzdWx0LT5zeW1ib2xUYWJsZSgpLT5zZXRTY29wZVR5 cGUoU3ltYm9sVGFibGU6OlNjb3BlVHlwZTo6R2xvYmFsTGV4aWNhbFNjb3BlKTsKKyAgICAgICAg dm0uaGVhcC5hZGRGaW5hbGl6ZXIocmVzdWx0LCBkZXN0cm95KTsKICAgICAgICAgcmV0dXJuIHJl c3VsdDsKICAgICB9CiAKICAgICBzdGF0aWMgYm9vbCBnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPYmpl Y3QqLCBFeGVjU3RhdGUqLCBQcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYpOwogICAgIHN0YXRp YyBib29sIHB1dChKU0NlbGwqLCBFeGVjU3RhdGUqLCBQcm9wZXJ0eU5hbWUsIEpTVmFsdWUsIFB1 dFByb3BlcnR5U2xvdCYpOwogCisgICAgc3RhdGljIHZvaWQgZGVzdHJveShKU0NlbGwqKTsKKyAg ICAvLyBXZSBkb24ndCBuZWVkIGEgZGVzdHJ1Y3RvciBiZWNhdXNlIHdlIHVzZSBhIGZpbmFsaXpl ciBpbnN0ZWFkLgorICAgIHN0YXRpYyBjb25zdCBib29sIG5lZWRzRGVzdHJ1Y3Rpb24gPSBmYWxz ZTsKKwogICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuICFzeW1ib2xUYWJsZSgpLT5z aXplKCk7IH0KICAgICBib29sIGlzQ29uc3RWYXJpYWJsZShVbmlxdWVkU3RyaW5nSW1wbCopOwog ICAgIAo=