158176 2016-05-27 20:40:48 -0700 Improve lambda capture in NetworkCache::Storage::synchronize() 2016-05-27 21:48:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 158111 1 cdumez cdumez andersca beidson cgarcia commit-queue darin koivisto oldest_to_newest 1197306 0 cdumez 2016-05-27 20:40:48 -0700 Improve lambda capture in NetworkCache::Storage::synchronize() by leveraging C++14's capture with initializer. 1197308 1 280018 cdumez 2016-05-27 20:43:32 -0700 Created attachment 280018 Patch 1197312 2 280018 beidson 2016-05-27 21:42:50 -0700 Comment on attachment 280018 Patch Is capturing a protectedThis not necessary? I'm not sure, as I didn't look, but please confirm by yourself :) 1197314 3 280018 cdumez 2016-05-27 21:47:39 -0700 Comment on attachment 280018 Patch Clearing flags on attachment: 280018 Committed r201480: <http://trac.webkit.org/changeset/201480> 1197315 4 cdumez 2016-05-27 21:47:47 -0700 All reviewed patches have been landed. Closing bug. 1197316 5 cdumez 2016-05-27 21:48:19 -0700 (In reply to comment #2) > Comment on attachment 280018 [details] > Patch > > Is capturing a protectedThis not necessary? > > I'm not sure, as I didn't look, but please confirm by yourself :) No need, NetworkCacheStorage is owned by the NetworkCache, which is a singleton. 280018 2016-05-27 20:43:32 -0700 2016-05-27 21:47:39 -0700 Patch bug-158176-20160527204443.patch text/plain 2247 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGMwYzM3NThhN2IyOGU1 YWM4Zjk1OWIyM2VhZWMzMGNhNGQyODYxNi4uNDljODkwZDVmNjQ1NzNiN2JlMTdhOTk3MmI4MjBh MDQ4ZDMyNDI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wcm92ZSBsYW1iZGEgY2Fw dHVyZSBpbiBOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OnN5bmNocm9uaXplKCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODE3NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgbGFtYmRhIGNhcHR1 cmUgaW4gTmV0d29ya0NhY2hlOjpTdG9yYWdlOjpzeW5jaHJvbml6ZSgpLiBXZSBjYW4KKyAgICAg ICAgbm93IGNhcHR1cmUgdGhlIHN0ZDo6dW5pcXVlX3B0cjw+IHZhcmlhYmxlcyBkaXJlY3RseSB0 aGFua3MgdG86CisgICAgICAgIDEuIEMrKzE0J3Mgc3VwcG9ydCBmb3IgaW5pdGlhbGl6ZXIncyBp biBsYW1iZGEgY2FwdHVyZXMKKyAgICAgICAgMi4gUnVuTG9vcDo6ZGlzcGF0Y2goKSBub3cgdGFr ZXMgYSBOb25jb3B5YWJsZUZ1bmN0aW9uIGluIGluc3RlYWQgb2YKKyAgICAgICAgICAgYSBzdGQ6 OmZ1bmN0aW9uLCBhbGxvd2luZyB1cyB0byBjYXB0dXJlIG5vbi1jb3B5YWJsZSB2YXJpYWJsZXMu CisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNw cDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpTdG9yYWdlOjpzeW5jaHJvbml6ZSk6 CisKIDIwMTYtMDUtMjcgIEplcmVteSBKb25lcyAgPGplcmVteWpAYXBwbGUuY29tPgogCiAgICAg ICAgIERlY3JlYXNlIGZsaWNrZXIgd2hlbiBjaGFuZ2luZyB2aWRlbyBwcmVzZW50YXRpb24gbW9k ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZVN0b3JhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlU3RvcmFnZS5jcHAKaW5kZXggZDkxZTYxNjAyOWJjNzFlY2RkZWE4MDYzN2Qy MTI0NmI5NzdmMzAwMS4uMGI5OGQ5OTVmMmU1MDgxYzk5MmNmOTM2Zjc5Y2E0NjY3ZmFiZTgxZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3RvcmFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlU3RvcmFnZS5jcHAKQEAgLTI3OCwxMiArMjc4LDcgQEAgdm9pZCBTdG9yYWdl OjpzeW5jaHJvbml6ZSgpCiAgICAgICAgICAgICArK2NvdW50OwogICAgICAgICB9KTsKIAotICAg ICAgICBhdXRvKiByZWNvcmRGaWx0ZXJQdHIgPSByZWNvcmRGaWx0ZXIucmVsZWFzZSgpOwotICAg ICAgICBhdXRvKiBibG9iRmlsdGVyUHRyID0gYmxvYkZpbHRlci5yZWxlYXNlKCk7Ci0gICAgICAg IFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywgcmVjb3JkRmlsdGVyUHRyLCBibG9iRmls dGVyUHRyLCByZWNvcmRzU2l6ZV0gewotICAgICAgICAgICAgYXV0byByZWNvcmRGaWx0ZXIgPSBz dGQ6OnVuaXF1ZV9wdHI8Q29udGVudHNGaWx0ZXI+KHJlY29yZEZpbHRlclB0cik7Ci0gICAgICAg ICAgICBhdXRvIGJsb2JGaWx0ZXIgPSBzdGQ6OnVuaXF1ZV9wdHI8Q29udGVudHNGaWx0ZXI+KGJs b2JGaWx0ZXJQdHIpOwotCisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhpcywg cmVjb3JkRmlsdGVyID0gV1RGTW92ZShyZWNvcmRGaWx0ZXIpLCBibG9iRmlsdGVyID0gV1RGTW92 ZShibG9iRmlsdGVyKSwgcmVjb3Jkc1NpemVdKCkgbXV0YWJsZSB7CiAgICAgICAgICAgICBmb3Ig KGF1dG8mIHJlY29yZEZpbHRlcktleSA6IG1fcmVjb3JkRmlsdGVySGFzaGVzQWRkZWREdXJpbmdT eW5jaHJvbml6YXRpb24pCiAgICAgICAgICAgICAgICAgcmVjb3JkRmlsdGVyLT5hZGQocmVjb3Jk RmlsdGVyS2V5KTsKICAgICAgICAgICAgIG1fcmVjb3JkRmlsdGVySGFzaGVzQWRkZWREdXJpbmdT eW5jaHJvbml6YXRpb24uY2xlYXIoKTsK