158174 2016-05-27 17:08:48 -0700 Web Inspector: Not all transitively dominated nodes display their retained size 2016-05-27 17:43:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1197284 0 joepeck 2016-05-27 17:08:48 -0700 * SUMMARY Not all transitively dominated nodes display their retained size. * TEST <script> class Person { constructor(name) { this.name = name; } } class Group { constructor(...members) { this.members = members; } } let shared = new Person("Parent"); let p1 = new Person("Alpha"); let p2 = new Person("Beta"); let p3 = new Person("Gamma"); p1.parent = p2.parent = p3.parent = shared; shared = null; console.takeHeapSnapshot("before"); window.group = new Group(p1, p2, p3); setTimeout(() => { console.takeHeapSnapshot("after"); }); </script> * STEPS TO REPRODUCE 1. Inspect test page 2. Show timeline tab 3. Show JavaScript allocations Timeline 4. Reload 5. Show snapshot diff of before + after 6. Expand Objects => The Group object should transitively retain the shared "Parent" object, but it doesn't appear to. 1197285 1 webkit-bug-importer 2016-05-27 17:09:57 -0700 <rdar://problem/26528515> 1197288 2 280013 joepeck 2016-05-27 17:11:33 -0700 Created attachment 280013 [PATCH] Proposed Fix Oops... I remember experimenting with different depths, but unintentionally it seems a fixed depth of 1-2 is what landed. We should go down as far as possible for the transitive cases. 1197290 3 280013 commit-queue 2016-05-27 17:43:01 -0700 Comment on attachment 280013 [PATCH] Proposed Fix Clearing flags on attachment: 280013 Committed r201477: <http://trac.webkit.org/changeset/201477> 1197291 4 commit-queue 2016-05-27 17:43:05 -0700 All reviewed patches have been landed. Closing bug. 280013 2016-05-27 17:11:33 -0700 2016-05-27 17:43:01 -0700 [PATCH] Proposed Fix oops-1.patch text/plain 1670 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJjOWM0ZjIuLmFhYjMxMmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA1LTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTm90IGFs bCB0cmFuc2l0aXZlbHkgZG9taW5hdGVkIG5vZGVzIGRpc3BsYXkgdGhlaXIgcmV0YWluZWQgc2l6 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MTc0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0hlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyaWROb2RlLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyaWROb2RlLnByb3Rv dHlwZS5faXNEb21pbmF0ZWRCeU5vbkJhc2VQYXJlbnQpOgorICAgICAgICBVc2UgdGhlIHBhcmVu dCByZWZlcmVuY2UgY2hhbmdpbmcgaW4gdGhlIGxvb3AgaW5zdGVhZCBvZiBhbHdheXMgdXNpbmcg dGhlIHNhbWUgcGFyZW50LgorCiAyMDE2LTA1LTIwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjAwNzQwKTogV2ViIEluc3BlY3Rv cjogVGltZWxpbmVSZWNvcmRCYXIgY2xhc3MgbGlzdHMgbm90IHByb3Blcmx5IGNsZWFyZWQsIGJs ZWVkaW5nIGNvbG9ycyB3aGVuIHpvb21pbmcgaW4gYW5kIG91dApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcFNuYXBzaG90SW5zdGFuY2VE YXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9IZWFwU25hcHNob3RJbnN0YW5jZURhdGFHcmlkTm9kZS5qcwppbmRleCA5YjZjODlhLi44NzFj ZDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9IZWFwU25hcHNob3RJbnN0YW5jZURhdGFHcmlkTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwU25hcHNob3RJbnN0YW5jZURhdGFHcmlk Tm9kZS5qcwpAQCAtMTk3LDcgKzE5Nyw3IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RJbnN0 YW5jZURhdGFHcmlkTm9kZSA9IGNsYXNzIEhlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyCiAgICAg ICAgIGZvciAobGV0IHAgPSB0aGlzLnBhcmVudDsgcDsgcCA9IHAucGFyZW50KSB7CiAgICAgICAg ICAgICBpZiAocCA9PT0gdGhpcy5fYmFzZSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 Ci0gICAgICAgICAgICBpZiAodGhpcy5fbm9kZS5kb21pbmF0b3JOb2RlSWRlbnRpZmllciA9PT0g dGhpcy5wYXJlbnQubm9kZS5pZCkKKyAgICAgICAgICAgIGlmICh0aGlzLl9ub2RlLmRvbWluYXRv ck5vZGVJZGVudGlmaWVyID09PSBwLm5vZGUuaWQpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgICAgIH0KIAo=