158169 2016-05-27 14:58:18 -0700 Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround 2016-05-28 09:55:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned achristensen darin peavo oldest_to_newest 1197228 0 annulen 2016-05-27 14:58:18 -0700 Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround. 1197231 1 279999 annulen 2016-05-27 15:04:40 -0700 Created attachment 279999 Patch 1197257 2 279999 darin 2016-05-27 16:02:31 -0700 Comment on attachment 279999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279999&action=review > Source/WebCore/platform/PlatformMouseEvent.h:152 > + bool operator==(unsigned short a, MouseButton b) > + { > + return a == static_cast<unsigned short>(b); > + } > + > + bool operator!=(unsigned short a, MouseButton b) > + { > + return a != static_cast<unsigned short>(b); > + } These will need to be marked inline or we can get linker errors. 1197260 3 280008 annulen 2016-05-27 16:04:15 -0700 Created attachment 280008 Patch 1197381 4 280008 darin 2016-05-28 09:37:55 -0700 Comment on attachment 280008 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280008&action=review > Source/WebCore/platform/PlatformMouseEvent.h:142 > // These methods are necessary to work around the fact that MSVC will not find a most-specific I would have said "functions", not "methods". 1197386 5 annulen 2016-05-28 09:55:20 -0700 Manually committed https://trac.webkit.org/r201485, addressing your comment. 279999 2016-05-27 15:04:40 -0700 2016-05-27 16:04:06 -0700 Patch bug-158169-20160528010551.patch text/plain 2532 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQ1ZGRkZGVhYzk0MmE2 YTBkZDY5ODBjZDY0ODI5OTRhYmUyNDIxMy4uNGU0M2ZiMDc5ODM5YWFhZjAwZjk3NzE0MGJhMmZl ZjM4NDhiNDEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTI3ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBVc2UgQ09NUElM RVIoTVNWQykgaW5zdGVhZCBvZiBQTEFURk9STShXSU4pIGZvciBNU1ZDLXNwZWNpZmljIHdvcmth cm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 ODE2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9QbGF0Zm9ybU1vdXNlRXZl bnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vUGxhdGZvcm1Nb3VzZUV2ZW50V2luLmNwcDog TW92ZWQgb3BlcmF0b3JzJworICAgICAgICBpbXBsZW1lbnRhdGlvbnMgdG8gUGxhdGZvcm1Nb3Vz ZUV2ZW50LmgKKwogMjAxNi0wNS0yNyAgQWRhbSBCZXJna3Zpc3QgIDxhZGFtLmJlcmdrdmlzdEBl cmljc3Nvbi5jb20+CiAKICAgICAgICAgV2ViUlRDOiBVcGRhdGUgUlRDUGVlckNvbm5lY3Rpb24g b3ZlcmxvYWRlZCBsZWdhY3kgb3BlcmF0aW9ucyB0byByZXR1cm4gYSBQcm9taXNlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybU1vdXNlRXZlbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oCmluZGV4IDNmOWQ5N2ZhZmU4 NGUwYmQ5ZmM5NmRlNGFmYmI5ZDc4YmI3NDA0MzAuLjFkZWQ3YzU5YmNjMWIyNjVlMmRkYTE0ZjQ2 NDliM2I3NmNkNDZlYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRm b3JtTW91c2VFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91 c2VFdmVudC5oCkBAIC0xMzgsMTEgKzEzOCwxOCBAQCBjb25zdCBkb3VibGUgRm9yY2VBdEZvcmNl Q2xpY2sgPSAyOwogI2VuZGlmCiAgICAgfTsKIAotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBDT01Q SUxFUihNU1ZDKQogICAgIC8vIFRoZXNlIG1ldGhvZHMgYXJlIG5lY2Vzc2FyeSB0byB3b3JrIGFy b3VuZCB0aGUgZmFjdCB0aGF0IE1TVkMgd2lsbCBub3QgZmluZCBhIG1vc3Qtc3BlY2lmaWMKICAg ICAvLyBvcGVyYXRvcj09IHRvIHVzZSBhZnRlciBpbXBsaWNpdGx5IGNvbnZlcnRpbmcgTW91c2VC dXR0b24gdG8gYW4gdW5zaWduZWQgc2hvcnQuCi0gICAgYm9vbCBvcGVyYXRvcj09KHVuc2lnbmVk IHNob3J0IGEsIE1vdXNlQnV0dG9uIGIpOwotICAgIGJvb2wgb3BlcmF0b3IhPSh1bnNpZ25lZCBz aG9ydCBhLCBNb3VzZUJ1dHRvbiBiKTsKKyAgICBib29sIG9wZXJhdG9yPT0odW5zaWduZWQgc2hv cnQgYSwgTW91c2VCdXR0b24gYikKKyAgICB7CisgICAgICAgIHJldHVybiBhID09IHN0YXRpY19j YXN0PHVuc2lnbmVkIHNob3J0PihiKTsKKyAgICB9CisKKyAgICBib29sIG9wZXJhdG9yIT0odW5z aWduZWQgc2hvcnQgYSwgTW91c2VCdXR0b24gYikKKyAgICB7CisgICAgICAgIHJldHVybiBhICE9 IHN0YXRpY19jYXN0PHVuc2lnbmVkIHNob3J0PihiKTsKKyAgICB9CiAjZW5kaWYKIAogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2lu L1BsYXRmb3JtTW91c2VFdmVudFdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4v UGxhdGZvcm1Nb3VzZUV2ZW50V2luLmNwcAppbmRleCBiNjBiYzU2MmJhNjBhYjYxNzUzOWUzZjNm OGMzZTdlYzIyNDBjOTU5Li5jNTJlZDMwNzBjYWNhZTU4YTlkMmViZjZjNjRkOTM3YjIzNGIxZTc1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1Nb3VzZUV2 ZW50V2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1Nb3Vz ZUV2ZW50V2luLmNwcApAQCAtMTIyLDE0ICsxMjIsNCBAQCBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBs YXRmb3JtTW91c2VFdmVudChIV05EIGhXbmQsIFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwg TAogICAgIH0KIH0KIAotYm9vbCBvcGVyYXRvcj09KHVuc2lnbmVkIHNob3J0IGEsIE1vdXNlQnV0 dG9uIGIpCi17Ci0gICAgcmV0dXJuIGEgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgc2hvcnQ+KGIp OwotfQotCi1ib29sIG9wZXJhdG9yIT0odW5zaWduZWQgc2hvcnQgYSwgTW91c2VCdXR0b24gYikK LXsKLSAgICByZXR1cm4gYSAhPSBzdGF0aWNfY2FzdDx1bnNpZ25lZCBzaG9ydD4oYik7Ci19Ci0K IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 280008 2016-05-27 16:04:15 -0700 2016-05-28 09:37:38 -0700 Patch bug-158169-20160528020525.patch text/plain 2546 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQ1ZGRkZGVhYzk0MmE2 YTBkZDY5ODBjZDY0ODI5OTRhYmUyNDIxMy4uNGU0M2ZiMDc5ODM5YWFhZjAwZjk3NzE0MGJhMmZl ZjM4NDhiNDEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTI3ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBVc2UgQ09NUElM RVIoTVNWQykgaW5zdGVhZCBvZiBQTEFURk9STShXSU4pIGZvciBNU1ZDLXNwZWNpZmljIHdvcmth cm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 ODE2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9QbGF0Zm9ybU1vdXNlRXZl bnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vUGxhdGZvcm1Nb3VzZUV2ZW50V2luLmNwcDog TW92ZWQgb3BlcmF0b3JzJworICAgICAgICBpbXBsZW1lbnRhdGlvbnMgdG8gUGxhdGZvcm1Nb3Vz ZUV2ZW50LmgKKwogMjAxNi0wNS0yNyAgQWRhbSBCZXJna3Zpc3QgIDxhZGFtLmJlcmdrdmlzdEBl cmljc3Nvbi5jb20+CiAKICAgICAgICAgV2ViUlRDOiBVcGRhdGUgUlRDUGVlckNvbm5lY3Rpb24g b3ZlcmxvYWRlZCBsZWdhY3kgb3BlcmF0aW9ucyB0byByZXR1cm4gYSBQcm9taXNlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybU1vdXNlRXZlbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oCmluZGV4IDNmOWQ5N2ZhZmU4 NGUwYmQ5ZmM5NmRlNGFmYmI5ZDc4YmI3NDA0MzAuLmIyMTU4ZjYzNGFmNDQwZTkyZjE0Y2I1MzQ4 OTdmOTRhNWVkY2I5ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRm b3JtTW91c2VFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91 c2VFdmVudC5oCkBAIC0xMzgsMTEgKzEzOCwxOCBAQCBjb25zdCBkb3VibGUgRm9yY2VBdEZvcmNl Q2xpY2sgPSAyOwogI2VuZGlmCiAgICAgfTsKIAotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBDT01Q SUxFUihNU1ZDKQogICAgIC8vIFRoZXNlIG1ldGhvZHMgYXJlIG5lY2Vzc2FyeSB0byB3b3JrIGFy b3VuZCB0aGUgZmFjdCB0aGF0IE1TVkMgd2lsbCBub3QgZmluZCBhIG1vc3Qtc3BlY2lmaWMKICAg ICAvLyBvcGVyYXRvcj09IHRvIHVzZSBhZnRlciBpbXBsaWNpdGx5IGNvbnZlcnRpbmcgTW91c2VC dXR0b24gdG8gYW4gdW5zaWduZWQgc2hvcnQuCi0gICAgYm9vbCBvcGVyYXRvcj09KHVuc2lnbmVk IHNob3J0IGEsIE1vdXNlQnV0dG9uIGIpOwotICAgIGJvb2wgb3BlcmF0b3IhPSh1bnNpZ25lZCBz aG9ydCBhLCBNb3VzZUJ1dHRvbiBiKTsKKyAgICBpbmxpbmUgYm9vbCBvcGVyYXRvcj09KHVuc2ln bmVkIHNob3J0IGEsIE1vdXNlQnV0dG9uIGIpCisgICAgeworICAgICAgICByZXR1cm4gYSA9PSBz dGF0aWNfY2FzdDx1bnNpZ25lZCBzaG9ydD4oYik7CisgICAgfQorCisgICAgaW5saW5lIGJvb2wg b3BlcmF0b3IhPSh1bnNpZ25lZCBzaG9ydCBhLCBNb3VzZUJ1dHRvbiBiKQorICAgIHsKKyAgICAg ICAgcmV0dXJuIGEgIT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgc2hvcnQ+KGIpOworICAgIH0KICNl bmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1Nb3VzZUV2ZW50V2luLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3dpbi9QbGF0Zm9ybU1vdXNlRXZlbnRXaW4uY3BwCmluZGV4IGI2MGJjNTYyYmE2 MGFiNjE3NTM5ZTNmM2Y4YzNlN2VjMjI0MGM5NTkuLmM1MmVkMzA3MGNhY2FlNThhOWQyZWJmNmM2 NGQ5MzdiMjM0YjFlNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Q bGF0Zm9ybU1vdXNlRXZlbnRXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dp bi9QbGF0Zm9ybU1vdXNlRXZlbnRXaW4uY3BwCkBAIC0xMjIsMTQgKzEyMiw0IEBAIFBsYXRmb3Jt TW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KEhXTkQgaFduZCwgVUlOVCBtZXNzYWdlLCBX UEFSQU0gd1BhcmFtLCBMCiAgICAgfQogfQogCi1ib29sIG9wZXJhdG9yPT0odW5zaWduZWQgc2hv cnQgYSwgTW91c2VCdXR0b24gYikKLXsKLSAgICByZXR1cm4gYSA9PSBzdGF0aWNfY2FzdDx1bnNp Z25lZCBzaG9ydD4oYik7Ci19Ci0KLWJvb2wgb3BlcmF0b3IhPSh1bnNpZ25lZCBzaG9ydCBhLCBN b3VzZUJ1dHRvbiBiKQotewotICAgIHJldHVybiBhICE9IHN0YXRpY19jYXN0PHVuc2lnbmVkIHNo b3J0PihiKTsKLX0KLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=