158162 2016-05-27 13:09:11 -0700 Web Inspector: Timelines: "-0.000ms" in Self Time 2016-05-30 20:24:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1197184 0 nvasilyev 2016-05-27 13:09:11 -0700 Via https://bugs.webkit.org/show_bug.cgi?id=158117#c8 We should never show "-0.000ms". It should be "0ms". 1197185 1 webkit-bug-importer 2016-05-27 13:10:13 -0700 <rdar://problem/26523350> 1197497 2 bburg 2016-05-29 09:14:11 -0700 Do we have steps to reproduce this? A reduction? 1197675 3 bburg 2016-05-30 13:39:52 -0700 I found several of these frames when profiling http://discuss.emberjs.com/. STEPS TO REPRODUCE 1. Start timeline recording on the page 2. Reload the page 3. Go to "Events" view in JavaScript timeline view 4. Expand the subtree for the DOMContentLoaded event Several of the nodes seem to have -0.000 or -0.00001 self time. 1197679 4 280111 bburg 2016-05-30 14:05:40 -0700 Created attachment 280111 Proposed Fix 1197690 5 280111 darin 2016-05-30 16:48:18 -0700 Comment on attachment 280111 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=280111&action=review > Source/WebInspectorUI/UserInterface/Models/ProfileNode.js:164 > + if (this._selfTime < 0.0001) > + this._selfTime = 0.0; This is OK, but what about normal rounding to a certain number of decimal places? Once we start doing that we might not need this any more. 1197707 6 280111 darin 2016-05-30 20:03:30 -0700 Comment on attachment 280111 Proposed Fix I’m going to say review+ even though I would prefer code that rounds instead of code that adds a special case just for close-to-zero and negative. 1197709 7 280111 commit-queue 2016-05-30 20:24:24 -0700 Comment on attachment 280111 Proposed Fix Clearing flags on attachment: 280111 Committed r201503: <http://trac.webkit.org/changeset/201503> 1197710 8 commit-queue 2016-05-30 20:24:28 -0700 All reviewed patches have been landed. Closing bug. 280111 2016-05-30 14:05:40 -0700 2016-05-30 20:24:24 -0700 Proposed Fix bug-158162-20160530140655.patch text/plain 2099 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw Yzg5YTExNmUxZjczOWQwYzhmM2YxNGJlOTMyMDAwYjZkZDdkZTIwLi5iNjliNjU4N2IxMzBiNjRm OTIxZTcwZGJiOTI3YjVjMzM2MWY2MzdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wNS0zMCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBUaW1lbGluZXM6ICItMC4wMDBtcyIgaW4gU2VsZiBUaW1l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgxNjIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NTIzMzUwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZhbHVlcyBzdWNoIGFzIC0wLjAwMDAgYW5kICsw LjAwMDAxIHNlZW0gdG8gaW5kaWNhdGUgdGhlcmUgaXMKKyAgICAgICAgc29tZSBmbG9hdGluZyBw b2ludCBlcnJvciBhY2N1bXVsYXRpbmcgaW4gcHJvZmlsZSBub2RlIGRhdGEuCisgICAgICAgIFNp bmNlIHRoZSBzYW1wbGluZyBwcm9maWxlciBpc24ndCBhY2N1cmF0ZSB0byB0aGF0IHByZWNpc2lv biwKKyAgICAgICAgbGV0J3MgY2xlYW4gdXAgdGhlIGRhdGEgc28gbmVhci16ZXJvIG51bWJlcnMg YXJlIHNpbXBseSB6ZXJvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvUHJvZmls ZU5vZGUuanM6CisgICAgICAgIFJvdW5kIHNlbGZUaW1lIGRvd24gdG8gemVybyBpZiBpdCdzIGxl c3MgdGhhbiB0aGUKKyAgICAgICAgc21hbGxlc3QgdmFsdWUgd2Ugd291bGQgc2hvdyBpbiB0aGUg dXNlciBpbnRlcmZhY2UuCisKIDIwMTYtMDUtMjkgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQgZXhjZXB0aW9uIHBhZ2Ugc2hv dWxkIHByZS1wb3B1bGF0ZSB0aGUgYnVnJ3MgVVJMIHdpdGggdGhlIGluc3BlY3RlZCBwYWdlIFVS TApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L1Byb2ZpbGVOb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL1Byb2ZpbGVOb2RlLmpzCmluZGV4IDRmMWMzZDA2MmRlZjNkNzUxMTgxZTg0ODU5ZDFiZDgy MzhkYWM2ZDMuLmZhNzBjNmQ4MTZjOTE0ZDM5YzFhNTY3MDY2ODM3ZjBhMzNmZmFiZTQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Qcm9maWxl Tm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv UHJvZmlsZU5vZGUuanMKQEAgLTE1OCw2ICsxNTgsMTAgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVO b2RlID0gY2xhc3MgUHJvZmlsZU5vZGUgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAg ICAgICAgICAgICAgZm9yICh2YXIgY2hpbGROb2RlIG9mIHRoaXMuX2NoaWxkTm9kZXMpCiAgICAg ICAgICAgICAgICAgICAgIGNoaWxkTm9kZXNUb3RhbFRpbWUgKz0gY2hpbGROb2RlLnRvdGFsVGlt ZTsKICAgICAgICAgICAgICAgICB0aGlzLl9zZWxmVGltZSA9IHRoaXMuX3RvdGFsVGltZSAtIGNo aWxkTm9kZXNUb3RhbFRpbWU7CisgICAgICAgICAgICAgICAgLy8gc2VsZlRpbWUgY2FuIG5lZ2F0 aXZlIG9yIHZlcnkgY2xvc2UgdG8gemVybyBkdWUgdG8gZmxvYXRpbmcgcG9pbnQgZXJyb3IuCisg ICAgICAgICAgICAgICAgLy8gU2luY2Ugd2Ugc2hvdyBhdCBtb3N0IGZvdXIgZGVjaW1hbCBwbGFj ZXMsIHRyZWF0IGFueXRoaW5nIGxlc3MgYXMgemVyby4KKyAgICAgICAgICAgICAgICBpZiAodGhp cy5fc2VsZlRpbWUgPCAwLjAwMDEpCisgICAgICAgICAgICAgICAgICAgIHRoaXMuX3NlbGZUaW1l ID0gMC4wOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICByZXR1cm4gewo=