158155 2016-05-27 09:46:45 -0700 Regression(r200972): Webcore::Range::collectSelectionsRects() asserts in startContainer() while selecting text. 2016-05-27 10:08:06 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 157681 1 zalan zalan cdumez darin enrica oldest_to_newest 1197089 0 zalan 2016-05-27 09:46:45 -0700 1. Load j-archive.com 2. Start selecting text. -> assert() 1197090 1 zalan 2016-05-27 09:47:53 -0700 rdar://problem/26502712 1197091 2 279966 zalan 2016-05-27 09:56:46 -0700 Created attachment 279966 Patch 1197092 3 279966 cdumez 2016-05-27 09:59:49 -0700 Comment on attachment 279966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279966&action=review r=me > Source/WebKit2/ChangeLog:3 > + Webcore::Range::collectSelectionsRects() asserts in startContainer() while selecting text. I think we should indicate which revision regressed it in the title (since we know and it is recent). > Source/WebKit2/ChangeLog:10 > + * WebProcess/WebPage/ios/WebPageIOS.mm: I understand we need to land this quickly but we really need to land a test case in a follow-up. 1197097 4 zalan 2016-05-27 10:08:06 -0700 Committed r201453: <http://trac.webkit.org/changeset/201453> 279966 2016-05-27 09:56:46 -0700 2016-05-27 09:59:49 -0700 Patch bug-158155-20160527095757.patch text/plain 2190 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGI3NTZlM2Y5NWU3YzJj NjBhZTZlYjI3ZTFiODQzMzMxZDgwMjQwYi4uNzZkYWY5ZjZmMjk5NzRhMjc4YjcwOGIxMmNkYzRk MzE0MzBhYWEzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTI3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViY29yZTo6UmFuZ2U6OmNv bGxlY3RTZWxlY3Rpb25zUmVjdHMoKSBhc3NlcnRzIGluIHN0YXJ0Q29udGFpbmVyKCkgd2hpbGUg c2VsZWN0aW5nIHRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTgxNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGVuc3VyZXMgdGhhdCB3ZSBzdGlsbCBoYXZlIGEgdmFsaWQgcGFy YWdyYXBoUmFuZ2UgYWZ0ZXIgcmV0dXJuaW5nIGZyb20gZW5jbG9zaW5nVGV4dFVuaXRPZkdyYW51 bGFyaXR5KCkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu bW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNlbGVjdFRleHRXaXRoR3JhbnVsYXJpdHlB dFBvaW50KToKKwogMjAxNi0wNS0yNiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQ2VydGFpbiBOZXR3b3JrUmVzb3VyY2VMb2FkZXIgY2FsbGJhY2tzIGNhbiBk ZXJlZiBhIG51bGwgbV9uZXR3b3JrTG9hZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCA5ZTgwZGIwODk5YTg4NzY1ZTMy ZDAwZDdjZDYzZWIxNmUxM2MxM2JhLi4zMjEwNzNlZjM4YWZiNDc5NDAzOGFlNDA3YzExN2Q1NTc5 NDI3ZjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9z L1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lv cy9XZWJQYWdlSU9TLm1tCkBAIC0xODc5LDkgKzE4NzksOSBAQCB2b2lkIFdlYlBhZ2U6OnNlbGVj dFRleHRXaXRoR3JhbnVsYXJpdHlBdFBvaW50KGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwb2lu dCwgdQogICAgICAgICBpZiAocmVuZGVyZXItPnN0eWxlKCkucHJlc2VydmVOZXdsaW5lKCkpCiAg ICAgICAgICAgICBtX2Jsb2NrUmVjdEZvclRleHRTZWxlY3Rpb24gPSByZW5kZXJlci0+YWJzb2x1 dGVCb3VuZGluZ0JveFJlY3QodHJ1ZSk7CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgYXV0 byogcGFyYWdyYXBoUmFuZ2UgPSBlbmNsb3NpbmdUZXh0VW5pdE9mR3JhbnVsYXJpdHkodmlzaWJs ZVBvc2l0aW9uSW5Gb2N1c2VkTm9kZUZvclBvaW50KGZyYW1lLCBwb2ludCwgaXNJbnRlcmFjdGlu Z1dpdGhBc3Npc3RlZE5vZGUpLCBQYXJhZ3JhcGhHcmFudWxhcml0eSwgRGlyZWN0aW9uRm9yd2Fy ZCkuZ2V0KCk7CisgICAgICAgICAgICBhdXRvIHBhcmFncmFwaFJhbmdlID0gZW5jbG9zaW5nVGV4 dFVuaXRPZkdyYW51bGFyaXR5KHZpc2libGVQb3NpdGlvbkluRm9jdXNlZE5vZGVGb3JQb2ludChm cmFtZSwgcG9pbnQsIGlzSW50ZXJhY3RpbmdXaXRoQXNzaXN0ZWROb2RlKSwgUGFyYWdyYXBoR3Jh bnVsYXJpdHksIERpcmVjdGlvbkZvcndhcmQpOwogICAgICAgICAgICAgaWYgKHBhcmFncmFwaFJh bmdlICYmICFwYXJhZ3JhcGhSYW5nZS0+Y29sbGFwc2VkKCkpCi0gICAgICAgICAgICAgICAgbV9i bG9ja1JlY3RGb3JUZXh0U2VsZWN0aW9uID0gc2VsZWN0aW9uQm94Rm9yUmFuZ2UocGFyYWdyYXBo UmFuZ2UpOworICAgICAgICAgICAgICAgIG1fYmxvY2tSZWN0Rm9yVGV4dFNlbGVjdGlvbiA9IHNl bGVjdGlvbkJveEZvclJhbmdlKHBhcmFncmFwaFJhbmdlLmdldCgpKTsKICAgICAgICAgfQogICAg ICAgICAKICAgICAgICAgaWYgKHJlY3RJc1Rvb0JpZ0ZvclNlbGVjdGlvbihtX2Jsb2NrUmVjdEZv clRleHRTZWxlY3Rpb24sIGZyYW1lKSkK