158152 2016-05-27 05:02:29 -0700 AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416 2016-05-27 12:07:25 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig mario samuel_white webkit-bug-importer oldest_to_newest 1197033 0 jdiggs 2016-05-27 05:02:29 -0700 Looking at the "failure," it may actually be a "fix" because from a quick glance only one child is being added; not two. I should have some time today to verify this and update the expectations (or debug the failure). Deliberately not skipping the test for now. 1197034 1 webkit-bug-importer 2016-05-27 05:03:03 -0700 <rdar://problem/26515630> 1197102 2 279969 jdiggs 2016-05-27 10:20:15 -0700 Created attachment 279969 Patch 1197104 3 jdiggs 2016-05-27 10:23:49 -0700 Chris: Should be a super-quick review. Rather than just rebaseline the test, I started including the child being added/removed in the data sent to the listener so we can verify we're getting what we assume we're getting. Thanks! 1197144 4 279969 commit-queue 2016-05-27 12:07:20 -0700 Comment on attachment 279969 Patch Clearing flags on attachment: 279969 Committed r201458: <http://trac.webkit.org/changeset/201458> 1197145 5 commit-queue 2016-05-27 12:07:25 -0700 All reviewed patches have been landed. Closing bug. 279969 2016-05-27 10:20:15 -0700 2016-05-27 12:07:20 -0700 Patch bug-158152-20160527132125.patch text/plain 5525 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmJhZDNjYzhjMjQ2OWE5NzQyZGIxZTkxMzYxNDZiYjI4 OTlkMzBjZS4uZmNkYjdlYjk0ODEzNDMzYjJkMTM4MWIzZWM4MDUzMmRiY2Q4MTRkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE2LTA1LTI3ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKwor ICAgICAgICBBWDogW0FUS10gYWNjZXNzaWJpbGl0eS9ndGsvbm8tbm90aWZpY2F0aW9uLWZvci11 bnJlbmRlcmVkLWlmcmFtZS1jaGlsZHJlbi5odG1sIGJlZ2FuIGZhaWxpbmcgYWZ0ZXIgcjIwMTQx NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MTUy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZh aWx1cmUgaXMgYWN0dWFsbHkgYSBidWcgZml4IGJlY2F1c2Ugb25seSBvbmUgY2hpbGQgaXMgYmVp bmcgYWRkZWQsIGJ1dCB0d28KKyAgICAgICAgbm90aWZpY2F0aW9ucyB3ZXJlIGJlaW5nIGVtaXR0 ZWQuIE5vdyB0aGVyZSBpcyBvbmx5IG9uZSBub3RpZmljYXRpb24uIFRvIHZlcmlmeQorICAgICAg ICB0aGlzIHdhcyB0aGUgY2FzZSwgd2UgcmVhbGx5IHNob3VsZCBleGFtaW5lIHRoZSBjaGlsZCBy ZXBvcnRlZGx5IGJlaW5nIGFkZGVkLiBUaGF0CisgICAgICAgIGNoaWxkIGlzIHRoZSBBVEsgZXZl bnQncyBhbnlfZGF0YSwgc28gcGFzcyBhbG9uZyB0aGF0IGNoaWxkIHRvIHRoZSBsaXN0ZW5lci4K KworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2li aWxpdHlOb3RpZmljYXRpb25IYW5kbGVyQXRrLmNwcDoKKwogMjAxNi0wNS0yNyAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgTmV3IGludGwtbnVt YmVyZm9ybWF0LmpzIHRlc3QgZmFpbHMgb24gbWFueSBMaW51eCBwbGF0Zm9ybXMKZGlmZiAtLWdp dCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxp dHlOb3RpZmljYXRpb25IYW5kbGVyQXRrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlOb3RpZmljYXRpb25IYW5kbGVyQXRrLmNwcApp bmRleCAxMTk4OGJhOTg3Mjk4Y2JlN2VkNjAwMjAxN2RlZWQ4NWIwNDk3MzhkLi5iYjIyODA4Nzcx MzljZTdlOWQ3Y2I0ZGI0YWU2MGQzYThiNjhlM2I5IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9uSGFu ZGxlckF0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9h dGsvQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbkhhbmRsZXJBdGsuY3BwCkBAIC04MSw2ICs4MSw5 IEBAIGdib29sZWFuIGF4T2JqZWN0RXZlbnRMaXN0ZW5lcihHU2lnbmFsSW52b2NhdGlvbkhpbnQq IHNpZ25hbEhpbnQsIHVuc2lnbmVkIG51bVBhCiAgICAgfSBlbHNlIGlmICghZ19zdHJjbXAwKHNp Z25hbFF1ZXJ5LnNpZ25hbF9uYW1lLCAiY2hpbGRyZW4tY2hhbmdlZCIpKSB7CiAgICAgICAgIGNv bnN0IGdjaGFyKiBjaGlsZHJlbkNoYW5nZWREZXRhaWwgPSBnX3F1YXJrX3RvX3N0cmluZyhzaWdu YWxIaW50LT5kZXRhaWwpOwogICAgICAgICBub3RpZmljYXRpb25OYW1lID0gIWdfc3RyY21wMChj aGlsZHJlbkNoYW5nZWREZXRhaWwsICJhZGQiKSA/ICJBWENoaWxkcmVuQWRkZWQiIDogIkFYQ2hp bGRyZW5SZW1vdmVkIjsKKyAgICAgICAgZ3BvaW50ZXIgY2hpbGQgPSBnX3ZhbHVlX2dldF9wb2lu dGVyKCZwYXJhbVZhbHVlc1syXSk7CisgICAgICAgIGlmIChBVEtfSVNfT0JKRUNUKGNoaWxkKSkK KyAgICAgICAgICAgIGV4dHJhQXJncy5hcHBlbmQodG9KUyhqc0NvbnRleHQsIFdURjo6Z2V0UHRy KFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6Y3JlYXRlKEFUS19PQkpFQ1QoY2hpbGQpKSkp KTsKICAgICB9IGVsc2UgaWYgKCFnX3N0cmNtcDAoc2lnbmFsUXVlcnkuc2lnbmFsX25hbWUsICJw cm9wZXJ0eS1jaGFuZ2UiKSkgewogICAgICAgICBpZiAoIWdfc3RyY21wMChnX3F1YXJrX3RvX3N0 cmluZyhzaWduYWxIaW50LT5kZXRhaWwpLCAiYWNjZXNzaWJsZS12YWx1ZSIpKQogICAgICAgICAg ICAgbm90aWZpY2F0aW9uTmFtZSA9ICJBWFZhbHVlQ2hhbmdlZCI7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDc3NTJhMDEz ZDdmM2I1MzQ5MzM0MTExZGE1MWIwMDgyODI3MjQ0Zi4uNjY0MWYxNTNmOWJiOGEyMzYwZDI1MmJm MDlkYTlkNTZhYzgwNDM4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA1LTI3ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW0FUS10gYWNj ZXNzaWJpbGl0eS9ndGsvbm8tbm90aWZpY2F0aW9uLWZvci11bnJlbmRlcmVkLWlmcmFtZS1jaGls ZHJlbi5odG1sIGJlZ2FuIGZhaWxpbmcgYWZ0ZXIgcjIwMTQxNgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MTUyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZhaWx1cmUgaXMgYWN0dWFsbHkgYSBi dWcgZml4IGJlY2F1c2Ugb25seSBvbmUgY2hpbGQgaXMgYmVpbmcgYWRkZWQsIGJ1dCB0d28KKyAg ICAgICAgbm90aWZpY2F0aW9ucyB3ZXJlIGJlaW5nIGVtaXR0ZWQuIE5vdyB0aGVyZSBpcyBvbmx5 IG9uZSBub3RpZmljYXRpb24uIFRvIHZlcmlmeQorICAgICAgICB0aGlzIHdhcyB0aGUgY2FzZSwg d2UgcmVhbGx5IHNob3VsZCBleGFtaW5lIHRoZSBjaGlsZCByZXBvcnRlZGx5IGJlaW5nIGFkZGVk LiBUaGF0CisgICAgICAgIGNoaWxkIGlzIHRoZSBBVEsgZXZlbnQncyBhbnlfZGF0YSwgc28gcGFz cyBhbG9uZyB0aGF0IGNoaWxkIHRvIHRoZSBsaXN0ZW5lci4KKworICAgICAgICBUaGUgZmFpbGlu ZyB0ZXN0IGFuZCBhc3NvY2lhdGVkIGV4cGVjdGF0aW9ucyB3ZXJlIG1vZGlmaWVkIHRvIHJlbW92 ZSB0aGUgZHVwbGljYXRlCisgICAgICAgIG5vdGlmaWNhdGlvbiBhbmQgaW5jbHVkZSB0aGUgdGl0 bGUgb2YgdGhlIGFkZGVkIGNoaWxkIGZvciB0aGUgbm90aWZpY2F0aW9uIHdlIGdldC4KKworICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL25vLW5vdGlmaWNhdGlvbi1mb3ItdW5yZW5kZXJlZC1p ZnJhbWUtY2hpbGRyZW4uaHRtbDogVXBkYXRlZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0 ay9uby1ub3RpZmljYXRpb24tZm9yLXVucmVuZGVyZWQtaWZyYW1lLWNoaWxkcmVuLWV4cGVjdGVk LnR4dDogVXBkYXRlZC4KKwogMjAxNi0wNS0yNiAgWW9hdiBXZWlzcyAgPHlvYXZAeW9hdi53cz4K IAogICAgICAgICBQcmVsb2FkIHNpbmdsZSBkb3dubG9hZCB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL25vLW5vdGlmaWNhdGlvbi1mb3ItdW5yZW5kZXJl ZC1pZnJhbWUtY2hpbGRyZW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0 eS9ndGsvbm8tbm90aWZpY2F0aW9uLWZvci11bnJlbmRlcmVkLWlmcmFtZS1jaGlsZHJlbi1leHBl Y3RlZC50eHQKaW5kZXggZjQ3MDczNDY2N2E1NDUyNjA1NmNiZTBjYjkwNjZlNjE4NzRhZDdiNC4u NDBkNTdhYTRjZGVhYTBjNzJiNGRiNGMyNWY4MjE4OGM3ZTcwOWE1YiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsvbm8tbm90aWZpY2F0aW9uLWZvci11bnJlbmRlcmVk LWlmcmFtZS1jaGlsZHJlbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9ndGsvbm8tbm90aWZpY2F0aW9uLWZvci11bnJlbmRlcmVkLWlmcmFtZS1jaGlsZHJlbi1l eHBlY3RlZC50eHQKQEAgLTQsOCArNCw3IEBAIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFCiAKIAog Ci1BWENoaWxkcmVuQWRkZWQgb24gQVhUaXRsZTogaW5uZXIgYm9keQotQVhDaGlsZHJlbkFkZGVk IG9uIEFYVGl0bGU6IGlubmVyIGJvZHkKK0FYQ2hpbGRyZW5BZGRlZCBvbiBBWFRpdGxlOiBpbm5l ciBib2R5IChBWFRpdGxlOiBpbm5lciBpZnJhbWUpCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvZ3RrL25vLW5vdGlmaWNhdGlvbi1mb3ItdW5yZW5kZXJlZC1pZnJhbWUtY2hpbGRyZW4u aHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL25vLW5vdGlmaWNhdGlvbi1mb3It dW5yZW5kZXJlZC1pZnJhbWUtY2hpbGRyZW4uaHRtbAppbmRleCAxMTdlZDI3Y2Q0YzQ5YzVhMjk2 Mjk5NWM2MzlmNTYwZWY4MTJhMDkxLi5hYWI0YmRiMmQ3Y2FhYzdlMTFiNWI4ZmIzNjhiYzY5NDA0 ZDc0YTdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2d0ay9uby1ub3Rp ZmljYXRpb24tZm9yLXVucmVuZGVyZWQtaWZyYW1lLWNoaWxkcmVuLmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsvbm8tbm90aWZpY2F0aW9uLWZvci11bnJlbmRlcmVkLWlm cmFtZS1jaGlsZHJlbi5odG1sCkBAIC0xOSw5ICsxOSw5IEBAIGZ1bmN0aW9uIHJ1blRlc3QoKSB7 CiAgICAgICAgIC8vIEdlbmVyYXRlIHRoZSBoaWVyYXJjaHkgYmVmb3JlIHJlZ2lzdGVyaW5nIGEg bGlzdGVuZXIgc28gdGhhdCB3ZSBvbmx5IHNlZSBuZXcgbm90aWZpY2F0aW9ucy4KICAgICAgICAg dG91Y2hBY2Nlc3NpYmlsaXR5VHJlZShheFdlYkFyZWEpOwogCi0gICAgICAgIGFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmFkZE5vdGlmaWNhdGlvbkxpc3RlbmVyKGZ1bmN0aW9uKGVsZW1lbnQsIG5v dGlmaWNhdGlvbikgeworICAgICAgICBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hZGROb3RpZmlj YXRpb25MaXN0ZW5lcihmdW5jdGlvbihlbGVtZW50LCBub3RpZmljYXRpb24sIGNoaWxkKSB7CiAg ICAgICAgICAgICBpZiAobm90aWZpY2F0aW9uID09ICJBWENoaWxkcmVuQWRkZWQiICYmIGVsZW1l bnQucm9sZSA9PSAiQVhSb2xlOiBBWEdyb3VwIikKLSAgICAgICAgICAgICAgICBkZWJ1Zyhub3Rp ZmljYXRpb24gKyAiIG9uICIgKyBlbGVtZW50LnRpdGxlKTsKKyAgICAgICAgICAgICAgICBkZWJ1 Zyhub3RpZmljYXRpb24gKyAiIG9uICIgKyBlbGVtZW50LnRpdGxlICsgIiAoIiArIChjaGlsZCA/ IGNoaWxkLnRpdGxlIDogIm51bGwiKSArICIpIik7CiAgICAgICAgIH0pOwogICAgIH0KIAo=