158129 2016-05-26 12:09:55 -0700 Use std::atomic<> rather than OSAtomicIncrement in CARingBuffer.cpp 2016-05-26 14:56:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble ap commit-queue oldest_to_newest 1196815 0 jer.noble 2016-05-26 12:09:55 -0700 Use std::atomic<> rather than OSAtomicIncrement in CARingBuffer.cpp 1196816 1 279903 jer.noble 2016-05-26 12:13:41 -0700 Created attachment 279903 Patch 1196831 2 279903 eric.carlson 2016-05-26 12:44:32 -0700 Comment on attachment 279903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279903&action=review > Source/WebCore/platform/audio/mac/CARingBuffer.h:88 > + std::atomic<int32_t> m_timeBoundsQueuePtr; Should this be unsigned? 1196865 3 279903 commit-queue 2016-05-26 14:56:48 -0700 Comment on attachment 279903 Patch Clearing flags on attachment: 279903 Committed r201432: <http://trac.webkit.org/changeset/201432> 1196866 4 commit-queue 2016-05-26 14:56:52 -0700 All reviewed patches have been landed. Closing bug. 279903 2016-05-26 12:13:41 -0700 2016-05-26 14:56:48 -0700 Patch bug-158129-20160526121451.patch text/plain 3771 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTYzZjAwOWQ3ZjY5N2I2 MWRkNWQzMTI4OTVjOWNhMGI5OTIyODJmZS4uM2Q0ZjUyMzBhZjgyZjRkZTgxMDAyMzViOTcxOWMy MTkwZmI3ODIxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTI2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBzdGQ6OmF0b21pYzw+ IHJhdGhlciB0aGFuIE9TQXRvbWljSW5jcmVtZW50IGluIENBUmluZ0J1ZmZlci5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODEyOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0ZDo6YXRvbWljIGlz IGEgbW9yZSBwb3J0YWJsZSBhdG9taWMgcHJpbWl0aXZlIHRoYW4gT1NBdG9taWNJbmNyZW1lbnQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9tYWMvQ0FSaW5nQnVmZmVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNBUmluZ0J1ZmZlcjo6c2V0Q3VycmVudEZyYW1lQm91bmRzKToKKyAgICAg ICAgKFdlYkNvcmU6OkNBUmluZ0J1ZmZlcjo6Z2V0Q3VycmVudEZyYW1lQm91bmRzKToKKyAgICAg ICAgKFdlYkNvcmU6OkNBUmluZ0J1ZmZlcjo6Y3VycmVudFN0YXJ0RnJhbWUpOgorICAgICAgICAo V2ViQ29yZTo6Q0FSaW5nQnVmZmVyOjpjdXJyZW50RW5kRnJhbWUpOgorICAgICAgICAqIHBsYXRm b3JtL2F1ZGlvL21hYy9DQVJpbmdCdWZmZXIuaDoKKwogMjAxNi0wNS0yNSAgTmFlbCBPdWVkcmFv Z28gIDxuYWVsLm91ZWRyYW9nb0BjcmYuY2Fub24uZnI+CiAKICAgICAgICAgUmVtb3ZlIHVudXNl ZCBzbG90QmFzZSBwYXJhbWV0ZXIgaW4gYmluZGluZ3MgZ2VuZXJhdG9yCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvQ0FSaW5nQnVmZmVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9DQVJpbmdCdWZmZXIuY3BwCmluZGV4IGVjOGQw NDFmZTdiMmMzNzA1ZDhmZmI2Y2JiZThmMWY1NDg1ZDY4M2IuLmFhMzJjMzgyZmI4NzY2ZTI3Yzlh YzRhODc1MGE2M2ZkYTA1MTZlZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL21hYy9DQVJpbmdCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL21hYy9DQVJpbmdCdWZmZXIuY3BwCkBAIC0yOSw3ICsyOSw2IEBACiAjaWYgRU5BQkxF KFdFQl9BVURJTykgJiYgVVNFKE1FRElBVE9PTEJPWCkKIAogI2luY2x1ZGUgPENvcmVBdWRpby9D b3JlQXVkaW9UeXBlcy5oPgotI2luY2x1ZGUgPGxpYmtlcm4vT1NBdG9taWMuaD4KICNpbmNsdWRl IDx3dGYvTWF0aEV4dHJhcy5oPgogCiBjb25zdCB1aW50MzJfdCBrR2VuZXJhbFJpbmdUaW1lQm91 bmRzUXVldWVTaXplID0gMzI7CkBAIC0yMDEsMTkgKzIwMCwxOSBAQCBDQVJpbmdCdWZmZXI6OkVy cm9yIENBUmluZ0J1ZmZlcjo6c3RvcmUoY29uc3QgQXVkaW9CdWZmZXJMaXN0KiBsaXN0LCBzaXpl X3QgZnJhbQogdm9pZCBDQVJpbmdCdWZmZXI6OnNldEN1cnJlbnRGcmFtZUJvdW5kcyh1aW50NjRf dCBzdGFydFRpbWUsIHVpbnQ2NF90IGVuZFRpbWUpCiB7CiAgICAgTG9ja0hvbGRlciBsb2NrZXIo bV9jdXJyZW50RnJhbWVCb3VuZHNMb2NrKTsKLSAgICB1aW50MzJfdCBuZXh0UHRyID0gbV90aW1l Qm91bmRzUXVldWVQdHIgKyAxOworICAgIHVpbnQzMl90IG5leHRQdHIgPSBtX3RpbWVCb3VuZHNR dWV1ZVB0ci5sb2FkKCkgKyAxOwogICAgIHVpbnQzMl90IGluZGV4ID0gbmV4dFB0ciAmIGtHZW5l cmFsUmluZ1RpbWVCb3VuZHNRdWV1ZU1hc2s7CiAKICAgICBtX3RpbWVCb3VuZHNRdWV1ZVtpbmRl eF0ubV9zdGFydEZyYW1lID0gc3RhcnRUaW1lOwogICAgIG1fdGltZUJvdW5kc1F1ZXVlW2luZGV4 XS5tX2VuZEZyYW1lID0gZW5kVGltZTsKICAgICBtX3RpbWVCb3VuZHNRdWV1ZVtpbmRleF0ubV91 cGRhdGVDb3VudGVyID0gbmV4dFB0cjsKLSAgICBPU0F0b21pY0luY3JlbWVudDMyQmFycmllcihz dGF0aWNfY2FzdDxpbnQzMl90Kj4oJm1fdGltZUJvdW5kc1F1ZXVlUHRyKSk7CisgICAgbV90aW1l Qm91bmRzUXVldWVQdHIrKzsKIH0KIAogdm9pZCBDQVJpbmdCdWZmZXI6OmdldEN1cnJlbnRGcmFt ZUJvdW5kcyh1aW50NjRfdCAmc3RhcnRUaW1lLCB1aW50NjRfdCAmZW5kVGltZSkKIHsKICAgICBM b2NrSG9sZGVyIGxvY2tlcihtX2N1cnJlbnRGcmFtZUJvdW5kc0xvY2spOwotICAgIHVpbnQzMl90 IGN1clB0ciA9IG1fdGltZUJvdW5kc1F1ZXVlUHRyOworICAgIHVpbnQzMl90IGN1clB0ciA9IG1f dGltZUJvdW5kc1F1ZXVlUHRyLmxvYWQoKTsKICAgICB1aW50MzJfdCBpbmRleCA9IGN1clB0ciAm IGtHZW5lcmFsUmluZ1RpbWVCb3VuZHNRdWV1ZU1hc2s7CiAgICAgQ0FSaW5nQnVmZmVyOjpUaW1l Qm91bmRzJiBib3VuZHMgPSBtX3RpbWVCb3VuZHNRdWV1ZVtpbmRleF07CiAKQEAgLTI0MCwxMyAr MjM5LDEzIEBAIHZvaWQgQ0FSaW5nQnVmZmVyOjpjbGlwVGltZUJvdW5kcyh1aW50NjRfdCYgc3Rh cnRSZWFkLCB1aW50NjRfdCYgZW5kUmVhZCkKIAogdWludDY0X3QgQ0FSaW5nQnVmZmVyOjpjdXJy ZW50U3RhcnRGcmFtZSgpIGNvbnN0CiB7Ci0gICAgdWludDMyX3QgaW5kZXggPSBtX3RpbWVCb3Vu ZHNRdWV1ZVB0ciAmIGtHZW5lcmFsUmluZ1RpbWVCb3VuZHNRdWV1ZU1hc2s7CisgICAgdWludDMy X3QgaW5kZXggPSBtX3RpbWVCb3VuZHNRdWV1ZVB0ci5sb2FkKCkgJiBrR2VuZXJhbFJpbmdUaW1l Qm91bmRzUXVldWVNYXNrOwogICAgIHJldHVybiBtX3RpbWVCb3VuZHNRdWV1ZVtpbmRleF0ubV9z dGFydEZyYW1lOwogfQogCiB1aW50NjRfdCBDQVJpbmdCdWZmZXI6OmN1cnJlbnRFbmRGcmFtZSgp IGNvbnN0CiB7Ci0gICAgdWludDMyX3QgaW5kZXggPSBtX3RpbWVCb3VuZHNRdWV1ZVB0ciAmIGtH ZW5lcmFsUmluZ1RpbWVCb3VuZHNRdWV1ZU1hc2s7CisgICAgdWludDMyX3QgaW5kZXggPSBtX3Rp bWVCb3VuZHNRdWV1ZVB0ci5sb2FkKCkgJiBrR2VuZXJhbFJpbmdUaW1lQm91bmRzUXVldWVNYXNr OwogICAgIHJldHVybiBtX3RpbWVCb3VuZHNRdWV1ZVtpbmRleF0ubV9lbmRGcmFtZTsKIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0NBUmluZ0J1ZmZl ci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0NBUmluZ0J1ZmZlci5oCmlu ZGV4IGIyMzBiMzUzNmU0ZTNiMWZmODcyYmRmNzRhYzVlN2FkNTEzZTViNGMuLjY0ZGM1YTZkMGNl OGJlYTQ1NWVmYTQ1ZjhmODdlZGEwM2JkNWIxYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL21hYy9DQVJpbmdCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hdWRpby9tYWMvQ0FSaW5nQnVmZmVyLmgKQEAgLTg1LDcgKzg1LDcgQEAgcHJpdmF0 ZToKICAgICAKICAgICBWZWN0b3I8VGltZUJvdW5kcz4gbV90aW1lQm91bmRzUXVldWU7CiAgICAg TG9jayBtX2N1cnJlbnRGcmFtZUJvdW5kc0xvY2s7Ci0gICAgaW50MzJfdCBtX3RpbWVCb3VuZHNR dWV1ZVB0cjsKKyAgICBzdGQ6OmF0b21pYzxpbnQzMl90PiBtX3RpbWVCb3VuZHNRdWV1ZVB0cjsK IH07CiAKIH0K