<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>158098</bug_id>
          
          <creation_ts>2016-05-25 15:48:10 -0700</creation_ts>
          <short_desc>AX: crash at AccessibilityRenderObject::remoteSVGRootElement const</short_desc>
          <delta_ts>2016-05-27 16:18:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>Other</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="chris fleizach">cfleizach</reporter>
          <assigned_to name="chris fleizach">cfleizach</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>mario</cc>
    
    <cc>samuel_white</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1196537</commentid>
    <comment_count>0</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-25 15:48:10 -0700</bug_when>
    <thetext>1 ???                            0000000000 0 + 0
&gt;  2 com.apple.WebCore              0x002c7ca0 WebCore::AccessibilityRenderObject::remoteSVGRootElement() const + 32 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.31/rendering/RenderImage.h:138)
   3 com.apple.WebCore              0x002c0936 WebCore::AccessibilityRenderObject::detach(WebCore::AccessibilityDetachmentType, WebCore::AXObjectCache*) + 22 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.31/accessibility/AccessibilityRenderObject.cpp:3000)
   4 com.apple.WebCore              0x00337c30 WebCore::AXObjectCache::~AXObjectCache() + 160 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.31/accessibility/AXObjectCache.cpp:188)
   5 com.apple.WebCore              0x004bd0e4 WebCore::Document::destroyRenderTree() + 116 (/Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.12.xctoolchain/usr/bin/../include/c++/v1/memory:2525)
   6 com.apple.WebCore              0x00084436 WebCore::Document::prepareForDestruction() + 358 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.31/dom/Document.cpp:2353)
   7 com.apple.WebCore              0x0063872e WebCore::Frame::setView(WTF::RefPtr&lt;WebCore::FrameView&gt;&amp;&amp;) + 62 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.31/page/Frame.cpp:249)
   8 com.apple.WebCore              0x001094c0 WebCore::FrameLoader::detachFromParent() + 480 (/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7602.1.31/loader/FrameLoader.cpp:2521)
   9 com.apple.WebKit               0x00036de8 WebKit::WebPage::close() + 992 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7602.1.31/WebProcess/WebPage/WebPage.cpp:1084)
  10 com.apple.WebKit               0x000d5607 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&amp;, IPC::MessageDecoder&amp;) + 129 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7602.1.31/Platform/IPC/MessageReceiverMap.cpp:102)
  11 com.apple.WebKit               0x0023e510 WebKit::WebProcess::didReceiveMessage(IPC::Connection&amp;, IPC::MessageDecoder&amp;) + 28 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7602.1.31/WebProcess/WebProcess.cpp:634)
  12 com.apple.WebKit               0x0009e243 IPC::Connection::dispatchMessage(std::__1::unique_ptr&lt;IPC::MessageDecoder, std::__1::default_delete&lt;IPC::MessageDecoder&gt; &gt;) + 127 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7602.1.31/Platform/IPC/Connection.cpp:895)
  13 com.apple.WebKit               0x000a0ff8 IPC::Connection::dispatchOneMessage() + 126 (/Library/Caches/com.apple.xbs/Sources/WebKit2/WebKit2-7602.1.31/Platform/IPC/Connection.cpp:957)
  14 com.apple.JavaScriptCore       0x009ee505 WTF::RunLoop::performWork() + 437 (/BuildRoot/Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.12.xctoolchain/usr/bin/../include/c++/v1/functional:1817)
  15 com.apple.JavaScriptCore       0x009ee8b2 WTF::RunLoop::performWork(void*) + 34 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WTF/WTF-7602.1.31/wtf/cf/RunLoopCF.cpp:38)
  16 com.apple.CoreFoundation       0x000a7fc1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 (/Library/Caches/com.apple.xbs/Sources/CF/CF-1333.16/RunLoop.subproj/CFRunLoop.c:1943)
  17 com.apple.CoreFoundation       0x0008833d __CFRunLoopDoSources0 + 557 (/Library/Caches/com.apple.xbs/Sources/CF/CF-1333.16/RunLoop.subproj/CFRunLoop.c:1989)
  18 com.apple.CoreFoundation       0x00087836 __CFRunLoopRun + 934 (/Library/Caches/com.apple.xbs/Sources/CF/CF-1333.16/RunLoop.subproj/CFRunLoop.c:2821)
  19 com.apple.CoreFoundation       0x0008722d CFRunLoopRunSpecific + 285 (/Library/Caches/com.apple.xbs/Sources/CF/CF-1333.16/RunLoop.subproj/CFRunLoop.c:3103)


&lt;rdar://problem/26324151&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1196539</commentid>
    <comment_count>1</comment_count>
      <attachid>279831</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-25 15:51:09 -0700</bug_when>
    <thetext>Created attachment 279831
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1196632</commentid>
    <comment_count>2</comment_count>
    <who name="Joanmarie Diggs">jdiggs</who>
    <bug_when>2016-05-25 20:35:32 -0700</bug_when>
    <thetext>Chris, I&apos;m about to call it a night, so I don&apos;t have time to try this myself, but could you trigger it by putting it a child iframe and then changing that iframe&apos;s content or removing the iframe entirely?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1196634</commentid>
    <comment_count>3</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-25 21:00:02 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Chris, I&apos;m about to call it a night, so I don&apos;t have time to try this
&gt; myself, but could you trigger it by putting it a child iframe and then
&gt; changing that iframe&apos;s content or removing the iframe entirely?

Exactly what I thought and I have a test that does that but I can&apos;t make it trigger the document destruction since only the top level doc maintains the object cache

So then I put in a WKTR only method to clear the cache on demand but then I couldn&apos;t trigger what I wanted which is NOT to ever create this ax object, only to retrieve it right at document destruction which presumably would cause us to access the bad object, and that&apos;s when I realized I needed the cache clearing to happen at the same time the render tree was going down and I couldn&apos;t do that in a frame (discovered that after two days of working on this test)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1196671</commentid>
    <comment_count>4</comment_count>
      <attachid>279831</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-26 00:32:32 -0700</bug_when>
    <thetext>Comment on attachment 279831
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1196676</commentid>
    <comment_count>5</comment_count>
      <attachid>279831</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-05-26 00:53:32 -0700</bug_when>
    <thetext>Comment on attachment 279831
Patch

Clearing flags on attachment: 279831

Committed r201417: &lt;http://trac.webkit.org/changeset/201417&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1196677</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-05-26 00:53:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1197082</commentid>
    <comment_count>7</comment_count>
      <attachid>279831</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-05-27 09:05:45 -0700</bug_when>
    <thetext>Comment on attachment 279831
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279831&amp;action=review

&gt; Source/WebCore/accessibility/AccessibilityRenderObject.h:249
&gt; +    AccessibilitySVGRoot* remoteSVGRootElement(CreationChoice createIfNecessary) const;

Argument name should be omitted here. The type makes its purpose clear without an argument name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1197086</commentid>
    <comment_count>8</comment_count>
      <attachid>279965</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-27 09:22:20 -0700</bug_when>
    <thetext>Created attachment 279965
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1197087</commentid>
    <comment_count>9</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-27 09:22:40 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Comment on attachment 279831 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=279831&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/accessibility/AccessibilityRenderObject.h:249
&gt; &gt; +    AccessibilitySVGRoot* remoteSVGRootElement(CreationChoice createIfNecessary) const;
&gt; 
&gt; Argument name should be omitted here. The type makes its purpose clear
&gt; without an argument name.

Thanks. Updated patch

https://bugs.webkit.org/attachment.cgi?id=279965&amp;action=review</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1197088</commentid>
    <comment_count>10</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2016-05-27 09:22:53 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Comment on attachment 279831 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=279831&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/accessibility/AccessibilityRenderObject.h:249
&gt; &gt; +    AccessibilitySVGRoot* remoteSVGRootElement(CreationChoice createIfNecessary) const;
&gt; 
&gt; Argument name should be omitted here. The type makes its purpose clear
&gt; without an argument name.

Thanks. Updated patch

https://bugs.webkit.org/attachment.cgi?id=279965&amp;action=review</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>279831</attachid>
            <date>2016-05-25 15:51:09 -0700</date>
            <delta_ts>2016-05-27 09:22:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>4506</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTQwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA1LTI1ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGNyYXNoIGF0IEFj
Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnJlbW90ZVNWR1Jvb3RFbGVtZW50IGNvbnN0CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgwOTgKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGF0IGxvb2tzIGxp
a2UgaGFwcGVucyBoZXJlIGlzIHRoYXQgd2hlbiBhIGRvY3VtZW50IGlzIHRvcm4gZG93biBhbmQg
d2UgdHJ5IHRvIGRldGFjaCwgd2UgZW5kIHVwIGNyZWF0aW5nIGFuIGFjY2Vzc2liaWxpdHkgZWxl
bWVudCBkdXJpbmcgZGV0YWNobWVudCBwaGFzZS4KKyAgICAgICAgU28gaW5zdGVhZCBvZiBqdXN0
IGNsZWFyaW5nIHRoZSBjYWxsYmFjayBwb2ludGVyIG9uIGFuIGV4aXN0aW5nIEFYT2JqZWN0LCB3
ZSBtYWtlIGEgbmV3IG9iamVjdCBhbmQgYWNjZXNzIHByb3BlcnRpZXMgb2YgYW4gb2JqZWN0IGJl
aW5nIGRlYWxsb2NhdGVkLgorCisgICAgICAgIEkgdHJpZWQgdmVyeSBoYXJkIHRvIG1ha2UgYSB0
ZXN0IGJ1dCBpdCBsb29rcyBsaWtlIHRoaXMgY2FuIHJlYWxseSBvbmx5IGJlIHRyaWdnZXJlZCBk
dXJpbmcgZG9jdW1lbnQgdGVhciBkb3duIHdoaWNoIGFsc28gdGVhcnMgZG93biB0aGUgQVhPYmpl
Y3RDYWNoZS4gSSBkaWRuJ3QKKyAgICAgICAgaGF2ZSBsdWNrIHJlcHJvZHVjaW5nIGJlY2F1c2Ug
b2YgdGhhdC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9i
amVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojpy
ZW1vdGVTVkdFbGVtZW50SGl0VGVzdCk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5
UmVuZGVyT2JqZWN0Ojppc1NWR0ltYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp
dHlSZW5kZXJPYmplY3Q6OmRldGFjaFJlbW90ZVNWR1Jvb3QpOgorICAgICAgICAoV2ViQ29yZTo6
QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6cmVtb3RlU1ZHUm9vdEVsZW1lbnQpOgorICAgICAg
ICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWRkUmVtb3RlU1ZHQ2hpbGRy
ZW4pOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5o
OgorCiAyMDE2LTA1LTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg
ICAgICAgIFtXZWJTb2NrZXRzXSBObyBpbmZyYXN0cnVjdHVyZSBmb3IgdGVzdGluZyBzZWN1cmUg
d2ViIHNvY2tldHMgKHdzcykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj
ZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Fj
Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oCShyZXZpc2lvbiAyMDEyOTMp
CisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl
Y3QuaAkod29ya2luZyBjb3B5KQpAQCAtMjQ1LDcgKzI0NSw4IEBACiAgICAgCiAgICAgYm9vbCBp
c1NWR0ltYWdlKCkgY29uc3Q7CiAgICAgdm9pZCBkZXRhY2hSZW1vdGVTVkdSb290KCk7Ci0gICAg
QWNjZXNzaWJpbGl0eVNWR1Jvb3QqIHJlbW90ZVNWR1Jvb3RFbGVtZW50KCkgY29uc3Q7CisgICAg
ZW51bSBDcmVhdGlvbkNob2ljZSB7IENyZWF0ZSwgUmV0cmlldmUgfTsKKyAgICBBY2Nlc3NpYmls
aXR5U1ZHUm9vdCogcmVtb3RlU1ZHUm9vdEVsZW1lbnQoQ3JlYXRpb25DaG9pY2UgY3JlYXRlSWZO
ZWNlc3NhcnkpIGNvbnN0OwogICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIHJlbW90ZVNWR0VsZW1l
bnRIaXRUZXN0KGNvbnN0IEludFBvaW50JikgY29uc3Q7CiAgICAgdm9pZCBvZmZzZXRCb3VuZGlu
Z0JveEZvclJlbW90ZVNWR0VsZW1lbnQoTGF5b3V0UmVjdCYpIGNvbnN0OwogICAgIGJvb2wgc3Vw
cG9ydHNQYXRoKCkgY29uc3Qgb3ZlcnJpZGU7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np
YmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJl
dmlzaW9uIDIwMTI5MykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJp
bGl0eVJlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyNTUsNyArMjI1NSw3IEBA
CiAKIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnJlbW90
ZVNWR0VsZW1lbnRIaXRUZXN0KGNvbnN0IEludFBvaW50JiBwb2ludCkgY29uc3QKIHsKLSAgICBB
Y2Nlc3NpYmlsaXR5T2JqZWN0KiByZW1vdGUgPSByZW1vdGVTVkdSb290RWxlbWVudCgpOworICAg
IEFjY2Vzc2liaWxpdHlPYmplY3QqIHJlbW90ZSA9IHJlbW90ZVNWR1Jvb3RFbGVtZW50KENyZWF0
ZSk7CiAgICAgaWYgKCFyZW1vdGUpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIApAQCAt
Mjk2OCwxNiArMjk2OCwxNiBAQAogICAgIAogYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0
Ojppc1NWR0ltYWdlKCkgY29uc3QKIHsKLSAgICByZXR1cm4gcmVtb3RlU1ZHUm9vdEVsZW1lbnQo
KTsKKyAgICByZXR1cm4gcmVtb3RlU1ZHUm9vdEVsZW1lbnQoQ3JlYXRlKTsKIH0KICAgICAKIHZv
aWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6ZGV0YWNoUmVtb3RlU1ZHUm9vdCgpCiB7Ci0g
ICAgaWYgKEFjY2Vzc2liaWxpdHlTVkdSb290KiByb290ID0gcmVtb3RlU1ZHUm9vdEVsZW1lbnQo
KSkKKyAgICBpZiAoQWNjZXNzaWJpbGl0eVNWR1Jvb3QqIHJvb3QgPSByZW1vdGVTVkdSb290RWxl
bWVudChSZXRyaWV2ZSkpCiAgICAgICAgIHJvb3QtPnNldFBhcmVudChudWxscHRyKTsKIH0KIAot
QWNjZXNzaWJpbGl0eVNWR1Jvb3QqIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnJlbW90ZVNW
R1Jvb3RFbGVtZW50KCkgY29uc3QKK0FjY2Vzc2liaWxpdHlTVkdSb290KiBBY2Nlc3NpYmlsaXR5
UmVuZGVyT2JqZWN0OjpyZW1vdGVTVkdSb290RWxlbWVudChDcmVhdGlvbkNob2ljZSBjcmVhdGVJ
Zk5lY2Vzc2FyeSkgY29uc3QKIHsKICAgICBpZiAoIWlzPFJlbmRlckltYWdlPihtX3JlbmRlcmVy
KSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CkBAIC0zMDA5LDExICszMDA5LDExIEBACiAgICAg
QVhPYmplY3RDYWNoZSogY2FjaGUgPSBmcmFtZS5kb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCk7
CiAgICAgaWYgKCFjYWNoZSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0gICAgQWNjZXNzaWJp
bGl0eU9iamVjdCogcm9vdFNWR09iamVjdCA9IGNhY2hlLT5nZXRPckNyZWF0ZShyZW5kZXJlclJv
b3QpOworICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIHJvb3RTVkdPYmplY3QgPSBjcmVhdGVJZk5l
Y2Vzc2FyeSA9PSBDcmVhdGUgPyBjYWNoZS0+Z2V0T3JDcmVhdGUocmVuZGVyZXJSb290KSA6IGNh
Y2hlLT5nZXQocmVuZGVyZXJSb290KTsKIAogICAgIC8vIEluIG9yZGVyIHRvIGNvbm5lY3QgdGhl
IEFYIGhpZXJhcmNoeSBmcm9tIHRoZSBTVkcgcm9vdCBlbGVtZW50IGZyb20gdGhlIGxvYWRlZCBy
ZXNvdXJjZQogICAgIC8vIHRoZSBwYXJlbnQgbXVzdCBiZSBzZXQsIGJlY2F1c2UgdGhlcmUncyBu
byBvdGhlciB3YXkgdG8gZ2V0IGJhY2sgdG8gd2hvIGNyZWF0ZWQgdGhlIGltYWdlLgotICAgIEFT
U0VSVChyb290U1ZHT2JqZWN0KTsKKyAgICBBU1NFUlQoIWNyZWF0ZUlmTmVjZXNzYXJ5IHx8IHJv
b3RTVkdPYmplY3QpOwogICAgIGlmICghaXM8QWNjZXNzaWJpbGl0eVNWR1Jvb3Q+KCpyb290U1ZH
T2JqZWN0KSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgCkBAIC0zMDIyLDcgKzMwMjIs
NyBAQAogICAgIAogdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphZGRSZW1vdGVTVkdD
aGlsZHJlbigpCiB7Ci0gICAgQWNjZXNzaWJpbGl0eVNWR1Jvb3QqIHJvb3QgPSByZW1vdGVTVkdS
b290RWxlbWVudCgpOworICAgIEFjY2Vzc2liaWxpdHlTVkdSb290KiByb290ID0gcmVtb3RlU1ZH
Um9vdEVsZW1lbnQoQ3JlYXRlKTsKICAgICBpZiAoIXJvb3QpCiAgICAgICAgIHJldHVybjsKICAg
ICAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>279965</attachid>
            <date>2016-05-27 09:22:20 -0700</date>
            <delta_ts>2016-05-27 16:18:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>1426</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTQxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA1LTI3ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGNyYXNoIGF0IEFj
Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnJlbW90ZVNWR1Jvb3RFbGVtZW50IGNvbnN0CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgwOTgKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uY2Vz
c2FyeSBhcmd1bWVudCBuYW1lIGluIGhlYWRlci4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv
QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oOgorCiAyMDE2LTA1LTI2ICBBbGVqYW5kcm8gRy4g
Q2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIE5hdGl2ZVRvSlNWYWx1ZSBpcyBo
YXJjb2RpbmcgdGhlICR0aGlzVmFsdWUgaW4gc29tZSBzdHJpbmdzCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl
Y3QuaAkocmV2aXNpb24gMjAxNDUyKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B
Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI0Niw3ICsyNDYs
NyBAQAogICAgIGJvb2wgaXNTVkdJbWFnZSgpIGNvbnN0OwogICAgIHZvaWQgZGV0YWNoUmVtb3Rl
U1ZHUm9vdCgpOwogICAgIGVudW0gQ3JlYXRpb25DaG9pY2UgeyBDcmVhdGUsIFJldHJpZXZlIH07
Ci0gICAgQWNjZXNzaWJpbGl0eVNWR1Jvb3QqIHJlbW90ZVNWR1Jvb3RFbGVtZW50KENyZWF0aW9u
Q2hvaWNlIGNyZWF0ZUlmTmVjZXNzYXJ5KSBjb25zdDsKKyAgICBBY2Nlc3NpYmlsaXR5U1ZHUm9v
dCogcmVtb3RlU1ZHUm9vdEVsZW1lbnQoQ3JlYXRpb25DaG9pY2UpIGNvbnN0OwogICAgIEFjY2Vz
c2liaWxpdHlPYmplY3QqIHJlbW90ZVNWR0VsZW1lbnRIaXRUZXN0KGNvbnN0IEludFBvaW50Jikg
Y29uc3Q7CiAgICAgdm9pZCBvZmZzZXRCb3VuZGluZ0JveEZvclJlbW90ZVNWR0VsZW1lbnQoTGF5
b3V0UmVjdCYpIGNvbnN0OwogICAgIGJvb2wgc3VwcG9ydHNQYXRoKCkgY29uc3Qgb3ZlcnJpZGU7
Cg==
</data>
<flag name="review"
          id="303966"
          type_id="1"
          status="+"
          setter="darin"
    />
    <flag name="commit-queue"
          id="304005"
          type_id="3"
          status="+"
          setter="cfleizach"
    />
          </attachment>
      

    </bug>

</bugzilla>