158096 2016-05-25 15:25:58 -0700 REGRESSION (r191531): Web Inspector: WebSQL databases are no longer shown when first opening Web Inspector 2016-05-25 16:17:27 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg beidson commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1196531 0 joepeck 2016-05-25 15:25:58 -0700 * SUMMARY WebSQL databases are no longer shown when first opening Web Inspector. * NOTES - r191531 added a FAST_RETURN_IF_NO_FRONTENDS, which prevents InspectorDatabaseAgent from tracking databases before inspector is open. 1196532 1 joepeck 2016-05-25 15:26:30 -0700 <rdar://problem/26454671> 1196533 2 279828 joepeck 2016-05-25 15:29:24 -0700 Created attachment 279828 [PATCH] Proposed Fix 1196540 3 279828 bburg 2016-05-25 15:51:44 -0700 Comment on attachment 279828 [PATCH] Proposed Fix r=me It is worrying that there is no test coverage in this part of the code, but not surprising either. 1196556 4 279828 commit-queue 2016-05-25 16:17:21 -0700 Comment on attachment 279828 [PATCH] Proposed Fix Clearing flags on attachment: 279828 Committed r201409: <http://trac.webkit.org/changeset/201409> 1196557 5 commit-queue 2016-05-25 16:17:27 -0700 All reviewed patches have been landed. Closing bug. 279828 2016-05-25 15:29:24 -0700 2016-05-25 16:17:21 -0700 [PATCH] Proposed Fix fix-1.patch text/plain 1746 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0Y2Y3MTczLi40ZjNkMzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMDUtMjUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OIChyMTkxNTMxKTogV2ViIEluc3BlY3RvcjogV2ViU1FMIGRhdGFi YXNlcyBhcmUgbm8gbG9uZ2VyIHNob3duIHdoZW4gZmlyc3Qgb3BlbmluZyBXZWIgSW5zcGVjdG9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgwOTYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NDU0NjcxPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvckluc3RydW1l bnRhdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpk aWRPcGVuRGF0YWJhc2UpOgorICAgICAgICBSZW1vdmUgdGhlIGZhc3QgcmV0dXJuIGVycmFudGx5 IGFkZGVkIGluIHIxOTE1MzEuIEluc3BlY3RvckRhdGFiYXNlQWdlbnQKKyAgICAgICAgd2FudHMg dG8gdHJhY2sgZGF0YWJhc2VzLCBldmVuIGJlZm9yZSBhIGZyb250ZW5kIG1heSBiZSBvcGVuLCBz byB0aGF0CisgICAgICAgIG9uIGZpcnN0IG9wZW4gaXQgY2FuIGluZm9ybSB0aGUgZnJvbnRlbmQg YWJvdXQgb3BlbiBkYXRhYmFzZXMuCisKIDIwMTYtMDUtMjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRz b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJhY2UgY29uZGl0aW9uIGNhbGxpbmcgYmFjayB0byBh biBJREJPcGVuREJSZXF1ZXN0IGR1cmluZyBXb3JrZXJUaHJlYWQgc2h1dGRvd24uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgKaW5k ZXggN2Q2NzdlYS4uMzhhMzUzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3Rvckluc3RydW1lbnRhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaApAQCAtMTA0MCw3ICsxMDQwLDYgQEAgaW5saW5l IHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp3aWxsRGVzdHJveUNhY2hlZFJlc291cmNl KENhY2hlZFJlc291cmNlJgogCiBpbmxpbmUgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246 OmRpZE9wZW5EYXRhYmFzZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBSZWZQdHI8 RGF0YWJhc2U+JiYgZGF0YWJhc2UsIGNvbnN0IFN0cmluZyYgZG9tYWluLCBjb25zdCBTdHJpbmcm IG5hbWUsIGNvbnN0IFN0cmluZyYgdmVyc2lvbikKIHsKLSAgICBGQVNUX1JFVFVSTl9JRl9OT19G Uk9OVEVORFModm9pZCgpKTsKICAgICBpZiAoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVu dGluZ0FnZW50cyA9IGluc3RydW1lbnRpbmdBZ2VudHNGb3JDb250ZXh0KGNvbnRleHQpKQogICAg ICAgICBkaWRPcGVuRGF0YWJhc2VJbXBsKCppbnN0cnVtZW50aW5nQWdlbnRzLCBXVEZNb3ZlKGRh dGFiYXNlKSwgZG9tYWluLCBuYW1lLCB2ZXJzaW9uKTsKIH0K