158069 2016-05-25 06:36:55 -0700 Web Inspector: sometimes reloading a page with main resource selected will show an empty content view 2016-07-06 13:25:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://bl.ocks.org/syntagmatic/raw/6c149c08fc9cde682635/iridium-33-debris.html InRadar P2 Normal --- 1 bburg joepeck bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1196318 0 bburg 2016-05-25 06:36:55 -0700 STEPS TO REPRODUCE: 0. Go to http://bl.ocks.org/syntagmatic/raw/6c149c08fc9cde682635/iridium-33-debris.html 1. Open Resources tab. 2. Select the main resource (iridium-33-debris.hmtl) 3. Reload with Cmd-R EXPECTED: The main resource tree element is re-selected when available and shows its HTML in editor ACTUAL: A blank content view is shown about 50% of the time. NOTES: Whether it reprouces or not seems related to resource load ordering. Try clearing caches between loads if it doesn't repro. 1196392 1 joepeck 2016-05-25 11:13:20 -0700 I've noticed this too. I think it has to do with a background tab, thinking it is visible, steals the SourceCodeTextEditor from the actual visible tab... I haven't verified this yet though. 1196393 2 joepeck 2016-05-25 11:13:54 -0700 I have that suspicious because I think switching tabs and switching back fixes the issue. 1197053 3 bburg 2016-05-27 07:18:43 -0700 Ping for import. 1197065 4 webkit-bug-importer 2016-05-27 07:22:54 -0700 <rdar://problem/26516710> 1200107 5 timothy 2016-06-07 10:28:17 -0700 *** Bug 158402 has been marked as a duplicate of this bug. *** 1208028 6 282834 joepeck 2016-07-05 18:47:54 -0700 Created attachment 282834 [PATCH] Proposed Fix This isn't an ideal fix, but it addresses this situation and didn't introduce any regressions with my testing. 1208062 7 282834 timothy 2016-07-05 20:26:50 -0700 Comment on attachment 282834 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=282834&action=review > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:213 > + if (WebInspector.navigationSidebar.selectedSidebarPanel !== this) { Do sidebar panels have a parent property? Could this be if (this.selected) or if (this.parent.selectedSidebarPanel === this)? That would avoid the layer violation. 1208280 8 282834 timothy 2016-07-06 10:53:04 -0700 Comment on attachment 282834 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=282834&action=review >> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:213 >> + if (WebInspector.navigationSidebar.selectedSidebarPanel !== this) { > > Do sidebar panels have a parent property? Could this be if (this.selected) or if (this.parent.selectedSidebarPanel === this)? That would avoid the layer violation. Now that I can look at the code, this should be written as: if (this.selected) Or if (this.parentSidebar.selectedSidebarPanel === this) 1208365 9 joepeck 2016-07-06 13:17:37 -0700 (In reply to comment #8) > Comment on attachment 282834 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282834&action=review > > >> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:213 > >> + if (WebInspector.navigationSidebar.selectedSidebarPanel !== this) { > > > > Do sidebar panels have a parent property? Could this be if (this.selected) or if (this.parent.selectedSidebarPanel === this)? That would avoid the layer violation. > > Now that I can look at the code, this should be written as: > > if (this.selected) Much better! 1208369 10 joepeck 2016-07-06 13:25:17 -0700 <https://trac.webkit.org/changeset/202876> 282834 2016-07-05 18:47:54 -0700 2016-07-06 13:17:43 -0700 [PATCH] Proposed Fix tab-1.patch text/plain 4945 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg2Mjc1M2IuLjkzYzNkMjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA3LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc29tZXRp bWVzIHJlbG9hZGluZyBhIHBhZ2Ugd2l0aCBtYWluIHJlc291cmNlIHNlbGVjdGVkIHdpbGwgc2hv dyBhbiBlbXB0eSBjb250ZW50IHZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1ODA2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY1MTY3MTA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsLnByb3RvdHlwZS5zaG93RGVmYXVsdENvbnRlbnRW aWV3KToKKyAgICAgICAgQ29udGludWUgdW50aWwgd2UgZ2V0IG9uZSB0aGF0IHdvcmtzLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLnNo b3dEZWZhdWx0Q29udGVudFZpZXdGb3JUcmVlRWxlbWVudCk6CisgICAgICAgIEF2b2lkIHNob3dp bmcgYSBjb250ZW50IHZpZXcgZm9yIGEgYmFja2dyb3VuZCB0YWIgaWYgaXQgY291bGQgc3RlYWwK KyAgICAgICAgdGhlIGNvbnRlbnQgdmlldyBmcm9tIGEgZm9yZWdyb3VuZCB0YWIuIFRoaXMgaXMg YSB0YXJnZXRlZCBmaXggZm9yCisgICAgICAgIHJlbG9hZCArIHRhYiBjb250ZW50IHZpZXcgbG9h ZGluZyBiZWhhdmlvci4gQSBtb3JlIGdlbmVyYWwgZml4IHdvdWxkCisgICAgICAgIGJlIHJlZHVj aW5nIHRoZSB3b3JrIGRvbmUgYnkgbm9uLWZvcmVncm91bmQgdGFicy4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U YWJCcm93c2VyLnByb3RvdHlwZS5fdGFiQmFySXRlbVNlbGVjdGVkKToKKyAgICAgICAgVXBkYXRl IG5hdmlnYXRpb24gc2lkZWJhciBmaXJzdCBzbyBpdCBpcyBzZXQgd2hlbiBzaG93aW5nIHRoZSBU YWJDb250ZW50Vmlldy4KKwogMjAxNi0wNy0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbGxGcmFtZSBjb25zb2xlLmFz c2VydCBzZWVuIGluIHRlc3RzIChzb3VyY2VDb2RlTG9jYXRpb24gaW5zdGFuY2VvZiBTb3VyY2VD b2RlTG9jYXRpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCmluZGV4IGU5MDFl NjkuLjk1Yzg2MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCkBAIC0yMDMs OCArMjAzLDggQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0gY2xhc3MgRGVi dWdnZXJTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgdmFyIGN1cnJlbnRU cmVlRWxlbWVudCA9IHRoaXMuX2NvbnRlbnRUcmVlT3V0bGluZS5jaGlsZHJlblswXTsKICAgICAg ICAgd2hpbGUgKGN1cnJlbnRUcmVlRWxlbWVudCAmJiAhY3VycmVudFRyZWVFbGVtZW50LnJvb3Qp IHsKICAgICAgICAgICAgIGlmIChjdXJyZW50VHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNw ZWN0b3IuUmVzb3VyY2VUcmVlRWxlbWVudCB8fCBjdXJyZW50VHJlZUVsZW1lbnQgaW5zdGFuY2Vv ZiBXZWJJbnNwZWN0b3IuU2NyaXB0VHJlZUVsZW1lbnQpIHsKLSAgICAgICAgICAgICAgICB0aGlz LnNob3dEZWZhdWx0Q29udGVudFZpZXdGb3JUcmVlRWxlbWVudChjdXJyZW50VHJlZUVsZW1lbnQp OwotICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICBpZiAodGhpcy5zaG93 RGVmYXVsdENvbnRlbnRWaWV3Rm9yVHJlZUVsZW1lbnQoY3VycmVudFRyZWVFbGVtZW50KSkKKyAg ICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBj dXJyZW50VHJlZUVsZW1lbnQgPSBjdXJyZW50VHJlZUVsZW1lbnQudHJhdmVyc2VOZXh0VHJlZUVs ZW1lbnQoZmFsc2UsIG51bGwsIHRydWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFu ZWwuanMKaW5kZXggZmEyNjYwYy4uYzNkNGY2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lk ZWJhclBhbmVsLmpzCkBAIC0yMDgsNiArMjA4LDE0IEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9u U2lkZWJhclBhbmVsID0gY2xhc3MgTmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRzIFdlYklu CiAgICAgICAgIGlmICghdHJlZUVsZW1lbnQgfHwgIXRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2Jq ZWN0KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgICAgIC8vIEZJWE1FOiA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMTUzNjM0PiBXZWIgSW5zcGVjdG9yOiBzb21lIGJhY2tncm91bmQg dGFicyB0aGluayB0aGV5IGFyZSB0aGUgZm9yZWdyb3VuZCB0YWIgYW5kIGRvIHVubmVjZXNzYXJ5 IHdvcmsKKyAgICAgICAgLy8gRG8gbm90IHN0ZWFsIGEgY29udGVudCB2aWV3IGlmIHdlIGFyZSBu b3QgdGhlIGFjdGl2ZSB0YWIvc2lkZWJhci4KKyAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5uYXZp Z2F0aW9uU2lkZWJhci5zZWxlY3RlZFNpZGViYXJQYW5lbCAhPT0gdGhpcykgeworICAgICAgICAg ICAgbGV0IGNvbnRlbnRWaWV3ID0gdGhpcy5jb250ZW50QnJvd3Nlci5jb250ZW50Vmlld0ZvclJl cHJlc2VudGVkT2JqZWN0KHRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0KTsKKyAgICAgICAg ICAgIGlmIChjb250ZW50VmlldyAmJiBjb250ZW50Vmlldy5wYXJlbnRDb250YWluZXIgIT09IHRo aXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIpCisgICAgICAgICAgICAgICAg cmV0dXJuIGZhbHNlOworICAgICAgICB9CisKICAgICAgICAgbGV0IGNvbnRlbnRWaWV3ID0gdGhp cy5jb250ZW50QnJvd3Nlci5zaG93Q29udGVudFZpZXdGb3JSZXByZXNlbnRlZE9iamVjdCh0cmVl RWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCk7CiAgICAgICAgIGlmICghY29udGVudFZpZXcpCiAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCcm93c2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5qcwppbmRleCAzNDc2YWI1Ny4uODNm N2Q0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGFiQnJvd3Nlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UYWJCcm93c2VyLmpzCkBAIC0yMDQsNiArMjA0LDggQEAgV2ViSW5zcGVjdG9yLlRh YkJyb3dzZXIgPSBjbGFzcyBUYWJCcm93c2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAg ICB7CiAgICAgICAgIHZhciB0YWJDb250ZW50VmlldyA9IHRoaXMuX3RhYkJhci5zZWxlY3RlZFRh YkJhckl0ZW0gPyB0aGlzLl90YWJCYXIuc2VsZWN0ZWRUYWJCYXJJdGVtLnJlcHJlc2VudGVkT2Jq ZWN0IDogbnVsbDsKIAorICAgICAgICB0aGlzLl9zaG93TmF2aWdhdGlvblNpZGViYXJQYW5lbEZv clRhYkNvbnRlbnRWaWV3KHRhYkNvbnRlbnRWaWV3KTsKKwogICAgICAgICBpZiAodGFiQ29udGVu dFZpZXcpIHsKICAgICAgICAgICAgIHRoaXMuX3JlY2VudFRhYkNvbnRlbnRWaWV3cy5yZW1vdmUo dGFiQ29udGVudFZpZXcpOwogICAgICAgICAgICAgdGhpcy5fcmVjZW50VGFiQ29udGVudFZpZXdz LnVuc2hpZnQodGFiQ29udGVudFZpZXcpOwpAQCAtMjE5LDcgKzIyMSw2IEBAIFdlYkluc3BlY3Rv ci5UYWJCcm93c2VyID0gY2xhc3MgVGFiQnJvd3NlciBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3 CiAgICAgICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5zZWxlY3RlZFRhYkNvbnRlbnRWaWV3 KTsKICAgICAgICAgfQogCi0gICAgICAgIHRoaXMuX3Nob3dOYXZpZ2F0aW9uU2lkZWJhclBhbmVs Rm9yVGFiQ29udGVudFZpZXcodGFiQ29udGVudFZpZXcpOwogICAgICAgICB0aGlzLl9zaG93RGV0 YWlsc1NpZGViYXJQYW5lbHNGb3JUYWJDb250ZW50Vmlldyh0YWJDb250ZW50Vmlldyk7CiAKICAg ICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlRhYkJyb3dz ZXIuRXZlbnQuU2VsZWN0ZWRUYWJDb250ZW50Vmlld0RpZENoYW5nZSk7Cg==