15806 2007-11-02 14:56:38 -0700 ASSERT(element->isRadioButton()) fires destroying form elements 2007-11-02 16:25:25 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar P2 Normal --- 1 darin darin mitz oldest_to_newest 60092 0 darin 2007-11-02 14:56:38 -0700 Mark Rowe: This is a 100% reproducible assertion failure. I hit this every day or two when casually browsing the Intarwebs. The assertion that is failing is ASSERT(element->isRadioButton());. GDB suggests that the element in question may have already been deleted. Note the value of m_deletionHasBegun. 60093 1 darin 2007-11-02 14:56:53 -0700 <rdar://problem/5561626> 60094 2 darin 2007-11-02 14:57:00 -0700 The problem here is that by the time ~HTMLGenericFormElement is called, it's too late to call removeFormElement, because HTMLInputElement part of the object has been destroyed, and the name() function no longer will return the right thing. 60102 3 17003 darin 2007-11-02 16:08:03 -0700 Created attachment 17003 patch with log and test 60104 4 mitz 2007-11-02 16:11:39 -0700 *** Bug 14769 has been marked as a duplicate of this bug. *** 60105 5 17003 mitz 2007-11-02 16:13:37 -0700 Comment on attachment 17003 patch with log and test r=me! 60108 6 darin 2007-11-02 16:25:25 -0700 Committed revision 27380. 17003 2007-11-02 16:08:03 -0700 2007-11-02 16:13:37 -0700 patch with log and test RemoveButtonCrashPatch.txt text/plain 5564 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzM3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDctMTEtMDIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODA2CisgICAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzU1NjE2MjY+IEFTU0VSVChlbGVtZW50LT5pc1JhZGlvQnV0dG9uKCkp IGZpcmVzIGRlc3Ryb3lpbmcgZm9ybSBlbGVtZW50cworCisgICAgICAgIFRlc3Q6IGZhc3QvZm9y bXMvcmVtb3ZlLXJhZGlvLWJ1dHRvbi1hc3NlcnQuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1M R2VuZXJpY0Zvcm1FbGVtZW50LmNwcDogKFdlYkNvcmU6OkhUTUxHZW5lcmljRm9ybUVsZW1lbnQ6 OnJlbW92ZUZyb21Gb3JtKToKKyAgICAgICAgQWRkZWQgcHJvdGVjdGVkIGZ1bmN0aW9uIHRvIGJl IHVzZWQgYnkgZGVyaXZlZCBjbGFzc2VzIHRoYXQgbmVlZCB0byBkbyB0aGUgc2FtZSBzb3J0Cisg ICAgICAgIG9mIHJlbW92YWwgZnJvbSBmb3JtIHRoYXQncyBhdXRvbWF0aWNhbGx5IGRvbmUgYnkg dGhlIGJhc2UgY2xhc3MgaW4gY2VydGFpbiBjaXJjdW1zdGFuY2VzLgorICAgICAgICAqIGh0bWwv SFRNTEdlbmVyaWNGb3JtRWxlbWVudC5oOiBBZGRlZCByZW1vdmVGcm9tRm9ybS4KKworICAgICAg ICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6IChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50 Ojp+SFRNTElucHV0RWxlbWVudCk6CisgICAgICAgIENhbGwgcmVtb3ZlRnJvbUZvcm0gaGVyZSBz byB0aGUgZWxlbWVudCBpcyByZW1vdmVkIGJlZm9yZSB3ZSBkZXN0cm95IHRoZSBIVE1MSW5wdXRF bGVtZW50CisgICAgICAgIHBhcnQgb2YgdGhpcyBvYmplY3QuIEJ5IHRoZSB0aW1lIHdlIGdldCB0 byB0aGUgYmFzZSBjbGFzcydzIGRlc3RydWN0b3IgaXQncyB0b28gbGF0ZS4KKyAgICAgICAgVGhl IHByb2JsZW0gaXMgc3BlY2lmaWMgdG8gcmFkaW8gYnV0dG9ucyBzbyB3ZSBkb24ndCBoYXZlIHRv IHdvcnJ5IGFib3V0IG90aGVyIGNsYXNzZXMKKyAgICAgICAgZGVyaXZlZCBmcm9tIEhUTUxHZW5l cmljRm9ybUVsZW1lbnQuCisKIDIwMDctMTEtMDEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkuCkluZGV4OiBXZWJDb3JlL2h0bWwv SFRNTEdlbmVyaWNGb3JtRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hU TUxHZW5lcmljRm9ybUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyNzM3NSkKKysrIFdlYkNvcmUvaHRt bC9IVE1MR2VuZXJpY0Zvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE2LDYgKzIx NiwxNCBAQCBIVE1MRm9ybUVsZW1lbnQqIEhUTUxHZW5lcmljRm9ybUVsZW1lbnQ6CiAgICAgcmV0 dXJuIG1fZm9ybTsKIH0KIAordm9pZCBIVE1MR2VuZXJpY0Zvcm1FbGVtZW50OjpyZW1vdmVGcm9t Rm9ybSgpCit7CisgICAgaWYgKCFtX2Zvcm0pCisgICAgICAgIHJldHVybjsKKyAgICBtX2Zvcm0t PnJlbW92ZUZvcm1FbGVtZW50KHRoaXMpOworICAgIG1fZm9ybSA9IDA7Cit9CisKIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnRXaXRoU3RhdGU6OkhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGUo Y29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRvYywgSFRNTEZvcm1FbGVt ZW50KiBmKQogICAgIDogSFRNTEdlbmVyaWNGb3JtRWxlbWVudCh0YWdOYW1lLCBkb2MsIGYpCiB7 CkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEdlbmVyaWNGb3JtRWxlbWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvaHRtbC9IVE1MR2VuZXJpY0Zvcm1FbGVtZW50LmgJKHJldmlzaW9uIDI3Mzc1 KQorKysgV2ViQ29yZS9odG1sL0hUTUxHZW5lcmljRm9ybUVsZW1lbnQuaAkod29ya2luZyBjb3B5 KQpAQCAtOTIsNiArOTIsOSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGZvcm1EZXN0cm95ZWQoKSB7 IG1fZm9ybSA9IDA7IH0KIAorcHJvdGVjdGVkOgorICAgIHZvaWQgcmVtb3ZlRnJvbUZvcm0oKTsK KwogcHJpdmF0ZToKICAgICB2aXJ0dWFsIEhUTUxGb3JtRWxlbWVudCogdmlydHVhbEZvcm0oKSBj b25zdDsKIApJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gMjczNzUp CisrKyBXZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE0NCw4ICsxNDQsMTIgQEAgSFRNTElucHV0RWxlbWVudDo6fkhUTUxJbnB1dEVsZW1lbnQoKQog ICAgICAgICBkb2N1bWVudCgpLT51bnJlZ2lzdGVyRm9yQ2FjaGVDYWxsYmFja3ModGhpcyk7CiAK ICAgICBkb2N1bWVudCgpLT5jaGVja2VkUmFkaW9CdXR0b25zKCkucmVtb3ZlQnV0dG9uKHRoaXMp OwotICAgIAorCiAgICAgZGVsZXRlIG1faW1hZ2VMb2FkZXI7CisKKyAgICAvLyBOZWVkIHRvIHJl bW92ZSB0aGlzIGZyb20gdGhlIGZvcm0gd2hpbGUgaXQgaXMgc3RpbGwgYW4gSFRNTElucHV0RWxl bWVudCwKKyAgICAvLyBzbyBjYW4ndCB3YWl0IGZvciB0aGUgYmFzZSBjbGFzcydzIGRlc3RydWN0 b3IgdG8gZG8gaXQuCisgICAgcmVtb3ZlRnJvbUZvcm0oKTsKIH0KIAogY29uc3QgQXRvbWljU3Ry aW5nJiBIVE1MSW5wdXRFbGVtZW50OjpuYW1lKCkgY29uc3QKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3 Mzc3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTMgQEAKKzIwMDctMTEtMDIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gdGVzdCBmb3IgaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MDYKKyAgICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTU2MTYyNj4gQVNTRVJUKGVsZW1lbnQtPmlzUmFkaW9CdXR0b24oKSkgZmly ZXMgZGVzdHJveWluZyBmb3JtIGVsZW1lbnRzCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3JlbW92 ZS1yYWRpby1idXR0b24tYXNzZXJ0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC9mb3Jtcy9yZW1vdmUtcmFkaW8tYnV0dG9uLWFzc2VydC5odG1sOiBBZGRlZC4KKwogMjAwNy0x MS0wMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIC0gZml4IHR5 cG8gaW4gdGVzdCBuYW1lCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JlbW92ZS1yYWRp by1idXR0b24tYXNzZXJ0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL3JlbW92ZS1yYWRpby1idXR0b24tYXNzZXJ0LWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmVtb3ZlLXJhZGlvLWJ1dHRvbi1hc3Nl cnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1RoaXMgdGVzdHMg dGhlIGNvZGUgcGF0aCBmb3IgZGVzdHJ1Y3Rpb24gb2YgYSByYWRpbyBidXR0b24gd2hlbiBpdCdz IGNoZWNrZWQsIHdoZW4gdGhlIGZvcm0gb3V0bGl2ZXMgdGhlIHJhZGlvIGJ1dHRvbiwgYnV0IHdo ZXJlIHRoZSByYWRpbyBidXR0b24gaXMgbmV2ZXIgZXhwbGljaXRseSByZW1vdmVkIGZyb20gdGhl IGZvcm0uCisKK0lmIHlvdSBjYW4gc2VlIHRoaXMgdGV4dCwgdGhlIHRlc3QgaGFzIHJ1bi4KClBy b3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmVtb3ZlLXJhZGlvLWJ1 dHRvbi1hc3NlcnQtZXhwZWN0ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOmVvbC1zdHlsZQog ICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmVtb3ZlLXJhZGlvLWJ1 dHRvbi1hc3NlcnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jl bW92ZS1yYWRpby1idXR0b24tYXNzZXJ0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3JlbW92ZS1yYWRpby1idXR0b24tYXNzZXJ0Lmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTAgQEAKKzxwPlRoaXMgdGVzdHMgdGhlIGNvZGUgcGF0aCBmb3IgZGVzdHJ1 Y3Rpb24gb2YgYSByYWRpbyBidXR0b24gd2hlbiBpdCdzIGNoZWNrZWQsIHdoZW4gdGhlIGZvcm0g b3V0bGl2ZXMgdGhlIHJhZGlvIGJ1dHRvbiwgYnV0IHdoZXJlIHRoZSByYWRpbyBidXR0b24gaXMg bmV2ZXIgZXhwbGljaXRseSByZW1vdmVkIGZyb20gdGhlIGZvcm0uPC9wPgorPGRpdiBpZD0iY29u dGFpbmVyIj48Zm9ybSBpZD0iZm9ybSI+PGlucHV0IHR5cGU9InJhZGlvIiBuYW1lPSJidXR0b24i IGNoZWNrZWQ+PC9mb3JtPjwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwordmFyIGZv cm0gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZm9ybSIpOworZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImNvbnRhaW5lciIpLnJlbW92ZUNoaWxkKGZvcm0pOworZm9ybS5pbm5lckhUTUw9IiI7 Citkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVyIikuaW5uZXJIVE1MPSJJZiB5b3Ug Y2FuIHNlZSB0aGlzIHRleHQsIHRoZSB0ZXN0IGhhcyBydW4uIjsKKzwvc2NyaXB0PgoKUHJvcGVy dHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yZW1vdmUtcmFkaW8tYnV0dG9u LWFzc2VydC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvaHRt bApOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgo=