158057 2016-05-24 21:03:12 -0700 Uncaught Exception: TypeError: undefined is not an object (evaluating 'records[endIndex].endTime') 2016-05-26 16:04:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 InRadar P2 Normal --- 1 bburg mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1196127 0 bburg 2016-05-24 21:03:12 -0700 ------- Auto-generated details: Inspected URL: http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/602.1.34+ (KHTML, like Gecko) Uncaught exceptions: - TypeError: undefined is not an object (evaluating 'records[endIndex].endTime') (at RenderingFrameTimelineView.js:174:33) ------- * STEPS TO REPRODUCE 1. Create a timeline recording 2. Switch to rendering frames view 3. Double-click the frames overview * EXPECTED It sets the selection interval to the visible interval (the overview view does this correctly) * ACTUAL Raises an exception 1196667 1 279870 mattbaker 2016-05-26 00:05:21 -0700 Created attachment 279870 [Patch] Proposed Fix 1196737 2 279870 timothy 2016-05-26 09:07:14 -0700 Comment on attachment 279870 [Patch] Proposed Fix This works, but it also seems like WebInspector.RenderingFrameTimelineView should handle internally to avoid the logic spilling out into this code. 1196822 3 mattbaker 2016-05-26 12:31:14 -0700 (In reply to comment #2) > Comment on attachment 279870 [details] > [Patch] Proposed Fix > > This works, but it also seems like WebInspector.RenderingFrameTimelineView > should handle internally to avoid the logic spilling out into this code. I agree, TimelineRecordingContentView does a lot of type checking. 1196823 4 webkit-bug-importer 2016-05-26 12:31:35 -0700 <rdar://problem/26499840> 1196889 5 279870 commit-queue 2016-05-26 16:03:59 -0700 Comment on attachment 279870 [Patch] Proposed Fix Clearing flags on attachment: 279870 Committed r201438: <http://trac.webkit.org/changeset/201438> 1196890 6 commit-queue 2016-05-26 16:04:03 -0700 All reviewed patches have been landed. Closing bug. 279870 2016-05-26 00:05:21 -0700 2016-05-26 16:03:59 -0700 [Patch] Proposed Fix bug-158057-20160526000634.patch text/plain 2818 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl ZGFmNGY3NTFjYzg2Njk3YTQ3NTk1ZDcyMGFlMmFhZmY1NzAwYThhLi4wOWY2NTMwZWRhZDYwYTRi NjQwNDQ4YThiYjI2NDJlMjljZWY3MzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wNS0yNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBu b3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdyZWNvcmRzW2VuZEluZGV4XS5lbmRUaW1lJykKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODA1NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcucHJvdG90eXBlLl91cGRhdGVU aW1lbGluZVZpZXdUaW1lcyk6CisgICAgICAgIFdoZW4gdGhlIGVudGlyZSByZWNvcmRpbmcgaXMg c2VsZWN0ZWQsIHJlbmRlcmluZyBmcmFtZXMgc2hvdWxkIHVzZSB0aGUKKyAgICAgICAgcmVjb3Jk IGNvdW50IGFzIGl0cyBlbmQgdGltZSBpbnN0ZWFkIG9mIHRoZSByZWNvcmRpbmcncyBlbmQgdGlt ZS4KKwogMjAxNi0wNS0yNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2VwdGlvbjogVHlwZUVycm9yOiB1 bmRlZmluZWQgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAnY29sbGVjdGlvbkRhdGEuYWZm ZWN0ZWRTbmFwc2hvdHMnKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcuanMKaW5kZXggN2ZjZTg2YmY1MTM3NWI5MjQyOGZhMzM1ZTFjOTQ4ZmY5ZTgzYjZmOC4u MDIwMjUzN2ZhNjhmM2Q5ZWYwYjRhOTZhZDQyZGJhMGIwY2Q0YTY1YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdD b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCkBAIC03MjcsMTIgKzcyNywxNSBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50VmlldyA9IGNsYXNzIFRpbWVs aW5lUmVjb3JkaW5nQ29udGVudFZpZXcgZQogICAgICAgICBsZXQgZW5kVGltZSA9IHRoaXMuX3Rp bWVsaW5lT3ZlcnZpZXcuc2VsZWN0aW9uU3RhcnRUaW1lICsgdGhpcy5fdGltZWxpbmVPdmVydmll dy5zZWxlY3Rpb25EdXJhdGlvbjsKIAogICAgICAgICBpZiAoZW50aXJlUmFuZ2VTZWxlY3RlZCkg ewotICAgICAgICAgICAgLy8gQ2xhbXAgc2VsZWN0aW9uIHRvIHRoZSBlbmQgb2YgdGhlIHJlY29y ZGluZyAod2l0aCBwYWRkaW5nKSwgc28gdGhhdCBPdmVydmlld1RpbWVsaW5lVmlldwotICAgICAg ICAgICAgLy8gZGlzcGxheXMgYW4gYXV0b3NpemVkIGdyYXBoIHdpdGhvdXQgYSBsb3Qgb2YgaG9y aXpvbnRhbCB3aGl0ZSBzcGFjZSBvciB0aW55IGdyYXBoIGJhcnMuCi0gICAgICAgICAgICBpZiAo aXNOYU4odGhpcy5fcmVjb3JkaW5nLmVuZFRpbWUpKQotICAgICAgICAgICAgICAgIGVuZFRpbWUg PSB0aGlzLl9jdXJyZW50VGltZTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBl bmRUaW1lID0gTWF0aC5taW4oZW5kVGltZSwgdGhpcy5fcmVjb3JkaW5nLmVuZFRpbWUgKyB0aW1l bGluZVJ1bGVyLm1pbmltdW1TZWxlY3Rpb25EdXJhdGlvbik7CisgICAgICAgICAgICBpZiAodGlt ZWxpbmVWaWV3IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVW aWV3KSB7CisgICAgICAgICAgICAgICAgZW5kVGltZSA9IHRoaXMuX3JlbmRlcmluZ0ZyYW1lVGlt ZWxpbmUucmVjb3Jkcy5sZW5ndGg7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg ICAgIC8vIENsYW1wIHNlbGVjdGlvbiB0byB0aGUgZW5kIG9mIHRoZSByZWNvcmRpbmcgKHdpdGgg cGFkZGluZyksCisgICAgICAgICAgICAgICAgLy8gc28gZ3JhcGggdmlld3Mgd2lsbCBzaG93IGFu IGF1dG8tc2l6ZWQgZ3JhcGggd2l0aG91dCBhIGxvdCBvZgorICAgICAgICAgICAgICAgIC8vIGVt cHR5IHNwYWNlIGF0IHRoZSBlbmQuCisgICAgICAgICAgICAgICAgZW5kVGltZSA9IGlzTmFOKHRo aXMuX3JlY29yZGluZy5lbmRUaW1lKSA/IHRoaXMuX3JlY29yZGluZy5jdXJyZW50VGltZSA6IHRo aXMuX3JlY29yZGluZy5lbmRUaW1lOworICAgICAgICAgICAgICAgIGVuZFRpbWUgKz0gdGltZWxp bmVSdWxlci5taW5pbXVtU2VsZWN0aW9uRHVyYXRpb247CisgICAgICAgICAgICB9CiAgICAgICAg IH0KIAogICAgICAgICB0aW1lbGluZVZpZXcuc3RhcnRUaW1lID0gdGhpcy5fdGltZWxpbmVPdmVy dmlldy5zZWxlY3Rpb25TdGFydFRpbWU7Cg==