158051 2016-05-24 20:36:30 -0700 Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'collectionData.affectedSnapshots') 2016-05-25 16:10:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 P2 Normal --- 1 bburg joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1196118 0 bburg 2016-05-24 20:36:30 -0700 ------- Auto-generated details: Inspected URL: http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/602.1.34+ (KHTML, like Gecko) Uncaught exceptions: - TypeError: undefined is not an object (evaluating 'collectionData.affectedSnapshots') (at HeapSnapshotWorker.js:61:36) ------- * STEPS TO REPRODUCE 1. Start a timeline recording, record a while. 2. Stop the timeline recording manually. 3. Reload the page 3. Uncaught Exception dialog when main frame finishes loading (approximately) * NOTES This seemed to be delayed a bit after auto-recording started. I see the initial snapshot show up in the timeline, then it throws exception soon after initial load data appears in the Timeline. 1196394 1 joepeck 2016-05-25 11:15:56 -0700 This sounds like a recent regression from my change. I'll investigate it. 1196536 2 279830 joepeck 2016-05-25 15:47:33 -0700 Created attachment 279830 [PATCH] Proposed Fix 1196538 3 279830 bburg 2016-05-25 15:49:42 -0700 Comment on attachment 279830 [PATCH] Proposed Fix r=me 1196554 4 279830 commit-queue 2016-05-25 16:10:47 -0700 Comment on attachment 279830 [PATCH] Proposed Fix Clearing flags on attachment: 279830 Committed r201408: <http://trac.webkit.org/changeset/201408> 1196555 5 commit-queue 2016-05-25 16:10:51 -0700 All reviewed patches have been landed. Closing bug. 279830 2016-05-25 15:47:33 -0700 2016-05-25 16:10:47 -0700 [PATCH] Proposed Fix fix-affected.patch text/plain 2693 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYwOTkxMTAuLmI1Njk2MmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA1LTI1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFs dWF0aW5nICdjb2xsZWN0aW9uRGF0YS5hZmZlY3RlZFNuYXBzaG90cycpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgwNTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvV29ya2Vy cy9IZWFwU25hcHNob3QvSGVhcFNuYXBzaG90LmpzOgorICAgICAgICAoSGVhcFNuYXBzaG90LnBy b3RvdHlwZS51cGRhdGVEZWFkTm9kZXNBbmRHYXRoZXJDb2xsZWN0aW9uRGF0YSk6CisgICAgICAg ICogVXNlckludGVyZmFjZS9Xb3JrZXJzL0hlYXBTbmFwc2hvdC9IZWFwU25hcHNob3RXb3JrZXIu anM6CisgICAgICAgIChIZWFwU25hcHNob3RXb3JrZXIucHJvdG90eXBlLmNyZWF0ZVNuYXBzaG90 KToKKyAgICAgICAgSWYgYnkgdGhlIHRpbWUgdGhlIHRpbWVvdXQgZmlyZXMgd2UgaGFkIGNsZWFy ZWQgb3VyIHNuYXBzaG90IGxpc3QsIHRoZW4KKyAgICAgICAgdXBkYXRlRGVhZE5vZGVzQW5kR2F0 aGVyQ29sbGVjdGlvbkRhdGEgY291bGQgYmFpbC4gSGFuZGxlIGdyYWNlZnVsbHkuCisKIDIwMTYt MDUtMjMgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogU3BsaXQgY29uc29sZSBuYXZpZ2F0aW9uIGJhciBkb2Vzbid0IHdyYXAg YXMgZXhwZWN0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1dvcmtlcnMvSGVhcFNuYXBzaG90L0hlYXBTbmFwc2hvdC5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1dvcmtlcnMvSGVhcFNuYXBzaG90L0hlYXBTbmFwc2hvdC5q cwppbmRleCAwZjRhMjZlLi5jNzg2ZGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Xb3JrZXJzL0hlYXBTbmFwc2hvdC9IZWFwU25hcHNob3QuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvV29ya2Vycy9IZWFwU25hcHNo b3QvSGVhcFNuYXBzaG90LmpzCkBAIC0zNDMsOSArMzQzLDggQEAgSGVhcFNuYXBzaG90ID0gY2xh c3MgSGVhcFNuYXBzaG90CiAgICAgewogICAgICAgICBsZXQgcHJldmlvdXNTbmFwc2hvdEluZGV4 ID0gc25hcHNob3RzLmluZGV4T2YodGhpcykgLSAxOwogICAgICAgICBsZXQgcHJldmlvdXNTbmFw c2hvdCA9IHNuYXBzaG90c1twcmV2aW91c1NuYXBzaG90SW5kZXhdOwotICAgICAgICBjb25zb2xl LmFzc2VydChwcmV2aW91c1NuYXBzaG90IGluc3RhbmNlb2YgSGVhcFNuYXBzaG90KTsKICAgICAg ICAgaWYgKCFwcmV2aW91c1NuYXBzaG90KQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgcmV0dXJuIG51bGw7CiAKICAgICAgICAgbGV0IGxhc3ROb2RlSWRlbnRpZmllciA9IHByZXZp b3VzU25hcHNob3QuX2xhc3ROb2RlSWRlbnRpZmllcjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvV29ya2Vycy9IZWFwU25hcHNob3QvSGVhcFNuYXBz aG90V29ya2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvV29ya2Vy cy9IZWFwU25hcHNob3QvSGVhcFNuYXBzaG90V29ya2VyLmpzCmluZGV4IGE0ZmM5MTUuLjgzZTAz MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1dvcmtl cnMvSGVhcFNuYXBzaG90L0hlYXBTbmFwc2hvdFdvcmtlci5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Xb3JrZXJzL0hlYXBTbmFwc2hvdC9IZWFwU25hcHNob3RX b3JrZXIuanMKQEAgLTU4LDcgKzU4LDcgQEAgSGVhcFNuYXBzaG90V29ya2VyID0gY2xhc3MgSGVh cFNuYXBzaG90V29ya2VyCiAgICAgICAgIGlmICh0aGlzLl9zbmFwc2hvdHMubGVuZ3RoID4gMSkg ewogICAgICAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7CiAgICAgICAgICAgICAgICAgbGV0IGNv bGxlY3Rpb25EYXRhID0gc25hcHNob3QudXBkYXRlRGVhZE5vZGVzQW5kR2F0aGVyQ29sbGVjdGlv bkRhdGEodGhpcy5fc25hcHNob3RzKTsKLSAgICAgICAgICAgICAgICBpZiAoIWNvbGxlY3Rpb25E YXRhLmFmZmVjdGVkU25hcHNob3RzLmxlbmd0aCkKKyAgICAgICAgICAgICAgICBpZiAoIWNvbGxl Y3Rpb25EYXRhIHx8ICFjb2xsZWN0aW9uRGF0YS5hZmZlY3RlZFNuYXBzaG90cy5sZW5ndGgpCiAg ICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB0aGlzLnNlbmRFdmVu dCgiSGVhcFNuYXBzaG90LkNvbGxlY3Rpb25FdmVudCIsIGNvbGxlY3Rpb25EYXRhKTsKICAgICAg ICAgICAgIH0sIDApOwo=