15805 2007-11-02 14:50:50 -0700 crash reports seen in isLoadingMultipartContent 2008-02-05 17:56:42 -0800 1 1 1 Unclassified WebKit Page Loading 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar P2 Normal --- 1 darin darin scott oldest_to_newest 60090 0 darin 2007-11-02 14:50:50 -0700 Apple's crash tracer has reports of crashes that look like this: >#0 com.apple.WebCore 0x95417289 WebCore::DocumentLoader::isLoadingMultipartContent() const + 9 #1 com.apple.WebCore 0x95416eea WebCore::ImageTokenizer::finish() + 138 #2 com.apple.WebCore 0x95658b44 WebCore::FrameLoader::endIfNotLoadingMainResource() + 116 #3 com.apple.WebCore 0x95260053 WebCore::Document::close() + 35 #4 com.apple.WebCore 0x953134cc WebCore::JSHTMLDocumentPrototypeFunction::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 732 I think it's just a simple missing null check. Lets do a speculative fix. 60091 1 17001 darin 2007-11-02 14:53:57 -0700 Created attachment 17001 patch 60097 2 17001 mitz 2007-11-02 15:17:01 -0700 Comment on attachment 17001 patch r=me, although I'd keep the ASSERT in hope of some day encountering the bug in a debug build and understanding it. 60107 3 darin 2007-11-02 16:22:49 -0700 Committed revision 27379. 62750 4 ddkilzer 2007-11-29 20:44:02 -0800 It would appear this isn't fixed. See Bug 16097. 62884 5 darin 2007-12-01 09:43:25 -0800 More precisely, it appears there's another crash that now happens in the same circumstance now that the first crash is fixed. 69529 6 mrowe 2008-02-05 17:56:42 -0800 *** Bug 17187 has been marked as a duplicate of this bug. *** 17001 2007-11-02 14:53:57 -0700 2007-11-02 15:17:01 -0700 patch MultipartNullCheckPatch.txt text/plain 1276 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzM3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMTEtMDIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gc3Bl Y3VsYXRpdmUgZml4IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTgwNQorICAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NTEwNzc5PiBjcmFzaGVzIGluIGlzTG9h ZGluZ011bHRpcGFydENvbnRlbnQKKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5j cHA6IChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6aXNMb2FkaW5nTXVsdGlwYXJ0Q29udGVudCk6 CisgICAgICAgIEluc3RlYWQgb2YgYXNzZXJ0aW5nIHRoZSBmcmFtZSBsb2FkZXIgaXMgbm9uLTAs IHJldHVybiBmYWxzZSBpZiBpdCBpcyAwLgorCiAyMDA3LTExLTAxICBPbGl2ZXIgSHVudCAgPG9s aXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5LgpJbmRleDogV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkocmV2aXNpb24gMjczNzUpCisrKyBXZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3Miw4ICs2NzIsNyBAQCBi b29sIERvY3VtZW50TG9hZGVyOjppc0xvYWRpbmdQbHVnSW5zKCkgCiAKIGJvb2wgRG9jdW1lbnRM b2FkZXI6OmlzTG9hZGluZ011bHRpcGFydENvbnRlbnQoKSBjb25zdAogewotICAgIEFTU0VSVCht X21haW5SZXNvdXJjZUxvYWRlcik7Ci0gICAgcmV0dXJuIG1fbWFpblJlc291cmNlTG9hZGVyLT5p c0xvYWRpbmdNdWx0aXBhcnRDb250ZW50KCk7CisgICAgcmV0dXJuIG1fbWFpblJlc291cmNlTG9h ZGVyICYmIG1fbWFpblJlc291cmNlTG9hZGVyLT5pc0xvYWRpbmdNdWx0aXBhcnRDb250ZW50KCk7 CiB9CiAKIGJvb2wgRG9jdW1lbnRMb2FkZXI6OnN0YXJ0TG9hZGluZ01haW5SZXNvdXJjZSh1bnNp Z25lZCBsb25nIGlkZW50aWZpZXIpCg==