158031 2016-05-24 11:26:10 -0700 Map should not be in JSGlobalObject's static hashtable because it's initialized eagerly via FOR_EACH_SIMPLE_BUILTIN_TYPE_WITH_CONSTRUCTOR 2016-05-24 12:03:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough benjamin ggaren keith_miller mark.lam mhahnenb msaboff oliver saam sam oldest_to_newest 1195921 0 fpizlo 2016-05-24 11:26:10 -0700 Patch forthcoming. 1195922 1 279677 fpizlo 2016-05-24 11:28:19 -0700 Created attachment 279677 the patch 1195931 2 279677 ggaren 2016-05-24 11:43:24 -0700 Comment on attachment 279677 the patch r=me 1195938 3 279677 mark.lam 2016-05-24 11:46:05 -0700 Comment on attachment 279677 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=279677&action=review > Source/JavaScriptCore/tests/stress/override-map-constructor.js:1 > +function Map() { Please add a comment above this that says "Should not crash". This gives us a clue to what was expected of this test since it is very bare. 1195943 4 fpizlo 2016-05-24 12:00:57 -0700 Landed in http://trac.webkit.org/changeset/201340 1195944 5 fpizlo 2016-05-24 12:01:24 -0700 (In reply to comment #3) > Comment on attachment 279677 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279677&action=review > > > Source/JavaScriptCore/tests/stress/override-map-constructor.js:1 > > +function Map() { > > Please add a comment above this that says "Should not crash". This gives us > a clue to what was expected of this test since it is very bare. Ooops, I landed before seeing this comment. I will fix in a follow-up. 1195950 6 fpizlo 2016-05-24 12:03:46 -0700 (In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 279677 [details] > > the patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=279677&action=review > > > > > Source/JavaScriptCore/tests/stress/override-map-constructor.js:1 > > > +function Map() { > > > > Please add a comment above this that says "Should not crash". This gives us > > a clue to what was expected of this test since it is very bare. > > Ooops, I landed before seeing this comment. I will fix in a follow-up. Addressed in http://trac.webkit.org/changeset/201342. 279677 2016-05-24 11:28:19 -0700 2016-05-24 11:43:24 -0700 the patch blah.patch text/plain 3562 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMzM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTA1LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TWFwIHNob3VsZCBub3QgYmUgaW4gSlNHbG9iYWxPYmplY3QncyBzdGF0aWMgaGFzaHRhYmxlIGJl Y2F1c2UgaXQncyBpbml0aWFsaXplZCBlYWdlcmx5IHZpYSBGT1JfRUFDSF9TSU1QTEVfQlVJTFRJ Tl9UWVBFX1dJVEhfQ09OU1RSVUNUT1IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1ODAzMQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yNjM1MzY2MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg V2Ugd2VyZSBsaXN0aW5nIE1hcCBhcyBiZWluZyBhIGxhenkgY2xhc3Mgc3RydWN0dXJlLiBJdCdz IG5vdC4gbV9tYXBTdHJ1Y3R1cmUgaXMgYSBXcml0ZUJhcnJpZXI8PgorICAgICAgICBub3QgYSBM YXp5Q2xhc3NTdHJ1Y3R1cmU8PiBhbmQgdGhlcmUgaXMgbm90aGluZyBsYXp5IGFib3V0IGl0Lgor CisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHA6IFRoZSBmaXggaXMgdG8gcmVt b3ZlIE1hcCBoZXJlLgorICAgICAgICAqIHJ1bnRpbWUvTG9va3VwLmNwcDogQWRkIHNvbWUgZHVt cGluZyBvbiB0aGUgYXNzZXJ0IHBhdGguCisgICAgICAgIChKU0M6OnNldFVwU3RhdGljRnVuY3Rp b25TbG90KToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3Mvb3ZlcnJpZGUtbWFwLWNvbnN0cnVjdG9y LmpzOiBBZGRlZC4gVGhpcyB0ZXN0IHVzZWQgdG8gY3Jhc2guCisgICAgICAgIChNYXApOgorCiAy MDE2LTA1LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgTExJ bnQ2NCBzaG91bGQgaGF2ZSB0eXBlZCBhcnJheSBmYXN0IHBhdGhzIGZvciBnZXRfYnlfdmFsCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3Qu Y3BwCShyZXZpc2lvbiAyMDEzMzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzOSw3ICsyMzksNiBAQCBjb25z dCBHbG9iYWxPYmplY3RNZXRob2RUYWJsZSBKU0dsb2JhbE9iCiAgIEZsb2F0NjRBcnJheSAgICAg ICAgICBKU0dsb2JhbE9iamVjdDo6bV90eXBlZEFycmF5RmxvYXQ2NCAgICAgICAgICBEb250RW51 bXxDbGFzc1N0cnVjdHVyZQogICBEYXRhVmlldyAgICAgICAgICAgICAgSlNHbG9iYWxPYmplY3Q6 Om1fdHlwZWRBcnJheURhdGFWaWV3ICAgICAgICAgRG9udEVudW18Q2xhc3NTdHJ1Y3R1cmUKICAg U2V0ICAgICAgICAgICAgICAgICAgIEpTR2xvYmFsT2JqZWN0OjptX3NldFN0cnVjdHVyZSAgICAg ICAgICAgICAgIERvbnRFbnVtfENsYXNzU3RydWN0dXJlCi0gIE1hcCAgICAgICAgICAgICAgICAg ICBKU0dsb2JhbE9iamVjdDo6bV9tYXBTdHJ1Y3R1cmUgICAgICAgICAgICAgICBEb250RW51bXxD bGFzc1N0cnVjdHVyZQogICBEYXRlICAgICAgICAgICAgICAgICAgSlNHbG9iYWxPYmplY3Q6Om1f ZGF0ZVN0cnVjdHVyZSAgICAgICAgICAgICAgRG9udEVudW18Q2xhc3NTdHJ1Y3R1cmUKICAgQm9v bGVhbiAgICAgICAgICAgICAgIEpTR2xvYmFsT2JqZWN0OjptX2Jvb2xlYW5PYmplY3RTdHJ1Y3R1 cmUgICAgIERvbnRFbnVtfENsYXNzU3RydWN0dXJlCiAgIE51bWJlciAgICAgICAgICAgICAgICBK U0dsb2JhbE9iamVjdDo6bV9udW1iZXJPYmplY3RTdHJ1Y3R1cmUgICAgICBEb250RW51bXxDbGFz c1N0cnVjdHVyZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Mb29rdXAuY3Bw CShyZXZpc2lvbiAyMDEzMzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Mb29r dXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NywxMSArNzcsMTYgQEAgYm9vbCBzZXRVcFN0YXRp Y0Z1bmN0aW9uU2xvdChFeGVjU3RhdGUqIAogICAgICAgICB9IGVsc2UgaWYgKGVudHJ5LT5hdHRy aWJ1dGVzKCkgJiBQcm9wZXJ0eUNhbGxiYWNrKSB7CiAgICAgICAgICAgICBKU1ZhbHVlIHJlc3Vs dCA9IGVudHJ5LT5sYXp5UHJvcGVydHlDYWxsYmFjaygpKHZtLCB0aGlzT2JqKTsKICAgICAgICAg ICAgIHRoaXNPYmotPnB1dERpcmVjdCh2bSwgcHJvcGVydHlOYW1lLCByZXN1bHQsIGF0dHJpYnV0 ZXNGb3JTdHJ1Y3R1cmUoZW50cnktPmF0dHJpYnV0ZXMoKSkpOwotICAgICAgICB9IGVsc2UKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGRhdGFMb2coIlN0YXRpYyBoYXNodGFibGUgZW50 cnkgZm9yICIsIHByb3BlcnR5TmFtZSwgIiBoYXMgd2VpcmQgYXR0cmlidXRlczogIiwgZW50cnkt PmF0dHJpYnV0ZXMoKSwgIlxuIik7CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVB Q0hFRCgpOworICAgICAgICB9CiAKICAgICAgICAgb2Zmc2V0ID0gdGhpc09iai0+Z2V0RGlyZWN0 T2Zmc2V0KHZtLCBwcm9wZXJ0eU5hbWUsIGF0dHJpYnV0ZXMpOwotICAgICAgICBSRUxFQVNFX0FT U0VSVChpc1ZhbGlkT2Zmc2V0KG9mZnNldCkpOworICAgICAgICBpZiAoIWlzVmFsaWRPZmZzZXQo b2Zmc2V0KSkgeworICAgICAgICAgICAgZGF0YUxvZygiU3RhdGljIGhhc2h0YWJsZSBpbml0aWFs aWF0aW9uIGZvciAiLCBwcm9wZXJ0eU5hbWUsICIgZGlkIG5vdCBwcm9kdWNlIGEgcHJvcGVydHku XG4iKTsKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAg IH0KICAgICB9CiAKICAgICBpZiAoaXNBY2Nlc3NvcikKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS90ZXN0cy9zdHJlc3Mvb3ZlcnJpZGUtbWFwLWNvbnN0cnVjdG9yLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb3ZlcnJpZGUtbWFwLWNvbnN0 cnVjdG9yLmpzCShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy9vdmVycmlkZS1tYXAtY29uc3RydWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSwyIEBACitmdW5jdGlvbiBNYXAoKSB7Cit9Cg==