158028 2016-05-24 11:17:51 -0700 Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page 2016-08-03 13:50:39 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1195915 0 bburg 2016-05-24 11:17:51 -0700 Note: only reproduces when a source code editor has focus. If you click on a sidebar, the URL selection shortcut seems to take priority. 1197045 1 bburg 2016-05-27 07:17:51 -0700 Ping for import. 1197056 2 webkit-bug-importer 2016-05-27 07:19:34 -0700 <rdar://problem/26516663> 1217040 3 bburg 2016-08-03 11:39:54 -0700 Matt, if we implement the ':' selector for quick open, that will obviate the need for Cmd-L, right? 1217095 4 mattbaker 2016-08-03 13:15:11 -0700 (In reply to comment #3) > Matt, if we implement the ':' selector for quick open, that will obviate the > need for Cmd-L, right? We can remove it now. Control-G also opens the line number dialog (same as Edge, Chrome, and some popular editors). 1217100 5 285261 mattbaker 2016-08-03 13:19:43 -0700 Created attachment 285261 [Patch] Proposed Fix 1217142 6 285261 commit-queue 2016-08-03 13:50:36 -0700 Comment on attachment 285261 [Patch] Proposed Fix Clearing flags on attachment: 285261 Committed r204099: <http://trac.webkit.org/changeset/204099> 1217143 7 commit-queue 2016-08-03 13:50:39 -0700 All reviewed patches have been landed. Closing bug. 285261 2016-08-03 13:19:43 -0700 2016-08-03 13:50:36 -0700 [Patch] Proposed Fix bug-158028-20160803131820.patch text/plain 1989 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 OGNjYTZiZDIxZWE4MTFkYTVmZDZmZGRjZTAxODVhZjU1ZTE1ZTBiLi42Mjg1NTNlNGNhODgzYTU4 MzEwYmE2ZDRiMDJhNjE0YTIzN2UwZWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0wOC0wMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ21kLUwgc2hvcnRjdXQgZm9yIEp1bXAgdG8gTGlu ZSBjb25mbGljdHMgd2l0aCBzZWxlY3RpbmcgVVJMIG9mIGluc3BlY3RlZCBwYWdlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTgwMjgKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI2NTE2NjYzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBDb21tYW5kLUwgc2hvcnRjdXQgZm9yIG9wZW5pbmcg dGhlIExpbmUgTnVtYmVyIGRpYWxvZywgc2luY2UKKyAgICAgICAgd2UgYWxyZWFkeSBzdXBwb3J0 IENvbnRyb2wtRy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRl eHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3Ip OiBEZWxldGVkLgorCiAyMDE2LTA4LTAxICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERvbid0IHNldCBgd2lkdGg6Y2FsYygx MDAlIC0gMHB4KTsgbGVmdDowcHhgIG9uIGNvbnNvbGUgbWVzc2FnZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRp dG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNl Q29kZVRleHRFZGl0b3IuanMKaW5kZXggOWE5Njk3MmJlZjk0N2Y0ZmViYTI3MGU5Y2I5ZjEyMjY0 NzcwMWZmNy4uMjJlMWU3Y2Q4MDRkZjRmYTA4YjQxMjkzZTVhN2Y0MDY0MDE4MDkwYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29k ZVRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTgyLDggKzgyLDYgQEAgV2ViSW5zcGVj dG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0 ZW5kcyBXZWJJbnNwZWMKIAogICAgICAgICBzb3VyY2VDb2RlLnJlcXVlc3RDb250ZW50KCkudGhl bih0aGlzLl9jb250ZW50QXZhaWxhYmxlLmJpbmQodGhpcykpOwogCi0gICAgICAgIC8vIEZJWE1F OiBDbWQrTCBzaG9ydGN1dCBkb2Vzbid0IGFjdHVhbGx5IHdvcmsuCi0gICAgICAgIG5ldyBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5N b2RpZmllci5Db21tYW5kLCAiTCIsIHRoaXMuc2hvd0dvVG9MaW5lRGlhbG9nLmJpbmQodGhpcyks IHRoaXMuZWxlbWVudCk7CiAgICAgICAgIG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db250cm9sLCAiRyIsIHRo aXMuc2hvd0dvVG9MaW5lRGlhbG9nLmJpbmQodGhpcyksIHRoaXMuZWxlbWVudCk7CiAKICAgICAg ICAgV2ViSW5zcGVjdG9yLmxvZ01hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3Iu TG9nTWFuYWdlci5FdmVudC5DbGVhcmVkLCB0aGlzLl9sb2dDbGVhcmVkLCB0aGlzKTsK