158026 2016-05-24 11:12:18 -0700 Fix null pointer dereferencing in WebViewImpl::inputContext 2016-05-24 14:11:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue oldest_to_newest 1195911 0 achristensen 2016-05-24 11:12:18 -0700 Fix null pointer dereferencing in WebViewImpl::inputContext 1195912 1 279674 achristensen 2016-05-24 11:13:01 -0700 Created attachment 279674 Patch 1196012 2 279701 achristensen 2016-05-24 13:58:44 -0700 Created attachment 279701 Patch 1196013 3 279701 thorton 2016-05-24 13:59:25 -0700 Comment on attachment 279701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279701&action=review > Source/WebKit2/ChangeLog:11 > + this was null sometimes in WebViewImpl::inputContext. Capital t. 1196018 4 achristensen 2016-05-24 14:01:35 -0700 This was not null. this was. 1196024 5 279701 commit-queue 2016-05-24 14:11:25 -0700 Comment on attachment 279701 Patch Clearing flags on attachment: 279701 Committed r201351: <http://trac.webkit.org/changeset/201351> 1196025 6 commit-queue 2016-05-24 14:11:29 -0700 All reviewed patches have been landed. Closing bug. 279674 2016-05-24 11:13:01 -0700 2016-05-24 13:58:42 -0700 Patch bug-158026-20160524111411.patch text/plain 1328 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTMzNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA1LTI0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG51bGwg cG9pbnRlciBkZXJlZmVyZW5jaW5nIGluIFdlYlZpZXdJbXBsOjppbnB1dENvbnRleHQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODAyNgorICAgICAg ICByZGFyOi8vcHJvYmxlbS8yNTk5NDA5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aW5wdXRDb250ZXh0KToKKwogMjAxNi0wNS0yNCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBhdXRvIGZvciBz b21lIG9mIG91ciBsYW1iZGEgZnVuY3Rpb24gcGFyYW1ldGVycwpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQkocmV2aXNpb24gMjAxMjkwKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0zNzMyLDcgKzM3MzIsNyBAQCBOU1RleHRJbnB1dENvbnRleHQgKldlYlZpZXdJ bXBsOjppbnB1dENvCiAgICAgfQogCiAgICAgLy8gRGlzYWJsZSB0ZXh0IGlucHV0IG1hY2hpbmVy eSB3aGVuIGluIG5vbi1lZGl0YWJsZSBjb250ZW50LiBBbiBpbnZpc2libGUgaW5saW5lIGlucHV0 IGFyZWEgYWZmZWN0cyBwZXJmb3JtYW5jZSwgYW5kIGNhbiBwcmV2ZW50IEV4cG9zZSBmcm9tIHdv cmtpbmcuCi0gICAgaWYgKCFtX3BhZ2UtPmVkaXRvclN0YXRlKCkuaXNDb250ZW50RWRpdGFibGUp CisgICAgaWYgKCFtX3BhZ2UgfHwgIW1fcGFnZS0+ZWRpdG9yU3RhdGUoKS5pc0NvbnRlbnRFZGl0 YWJsZSkKICAgICAgICAgcmV0dXJuIG5pbDsKIAogICAgIHJldHVybiBbbV92aWV3IF93ZWJfc3Vw ZXJJbnB1dENvbnRleHRdOwo= 279701 2016-05-24 13:58:44 -0700 2016-05-24 14:11:25 -0700 Patch bug-158026-20160524135954.patch text/plain 1173 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTM0NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTI0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG51bGwg cG9pbnRlciBkZXJlZmVyZW5jaW5nIGluIFdlYlZpZXdJbXBsOjppbnB1dENvbnRleHQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODAyNgorICAgICAg ICByZGFyOi8vcHJvYmxlbS8yNTk5NDA5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06Cisg ICAgICAgICgtW1dLV2ViVmlldyBpbnB1dENvbnRleHRdKToKKyAgICAgICAgdGhpcyB3YXMgbnVs bCBzb21ldGltZXMgaW4gV2ViVmlld0ltcGw6OmlucHV0Q29udGV4dC4KKwogMjAxNi0wNS0yNCAg Q2hlbHNlYSBQdWdoICA8Y3B1Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFsbG93IGNs aWVudHMgdG8gb3ZlcnJpZGUgdGhlIHR5cGUgb2YgYW4gaW5wdXQgZmllbGQKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCShyZXZpc2lv biAyMDEyOTApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjY0Nyw2ICsyNjQ3LDggQEAgLSAodm9pZClpbnNlcnRU ZXh0OihpZClzdHJpbmcgcmVwbGFjZW1lbgogCiAtIChOU1RleHRJbnB1dENvbnRleHQgKilpbnB1 dENvbnRleHQKIHsKKyAgICBpZiAoIV9pbXBsKQorICAgICAgICByZXR1cm4gbmlsOwogICAgIHJl dHVybiBfaW1wbC0+aW5wdXRDb250ZXh0KCk7CiB9CiAK